Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

2015-07-01 Thread Daniel Vetter
On Wed, Jul 01, 2015 at 05:54:06PM +0300, Ander Conselvan De Oliveira wrote: > On Tue, 2015-06-30 at 18:41 +0300, Jani Nikula wrote: > > On Tue, 30 Jun 2015, Daniel Vetter wrote: > > > On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote: > > >> On Tue, 30 Jun 2015, Ander Conselvan de Olive

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

2015-07-01 Thread Ander Conselvan De Oliveira
On Tue, 2015-06-30 at 18:41 +0300, Jani Nikula wrote: > On Tue, 30 Jun 2015, Daniel Vetter wrote: > > On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote: > >> On Tue, 30 Jun 2015, Ander Conselvan de Oliveira > >> wrote: > >> > Similarly to what is done for SKL, clear the dpll_hw_state o

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

2015-06-30 Thread Jani Nikula
On Tue, 30 Jun 2015, Daniel Vetter wrote: > On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote: >> On Tue, 30 Jun 2015, Ander Conselvan de Oliveira >> wrote: >> > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe >> > config in hsw_dp_set_ddi_pll_sel(), since it mai

Re: [Intel-gfx] [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

2015-06-30 Thread Daniel Vetter
On Tue, Jun 30, 2015 at 04:47:06PM +0300, Jani Nikula wrote: > On Tue, 30 Jun 2015, Ander Conselvan de Oliveira > wrote: > > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe > > config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values. > > That can happen if a

Re: [PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

2015-06-30 Thread Jani Nikula
On Tue, 30 Jun 2015, Ander Conselvan de Oliveira wrote: > Similarly to what is done for SKL, clear the dpll_hw_state of the pipe > config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values. > That can happen if a crtc that was previously driving an HDMI connector > switches to a DP c

[PATCH] drm/i915: Clear pipe's pll hw state in hsw_dp_set_ddi_pll_sel()

2015-06-30 Thread Ander Conselvan de Oliveira
Similarly to what is done for SKL, clear the dpll_hw_state of the pipe config in hsw_dp_set_ddi_pll_sel(), since it main contain stale values. That can happen if a crtc that was previously driving an HDMI connector switches to a DP connector. In that case, the wrpll field was left with its old valu