Re: [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable

[Jonathan Cameron]

On Fri, 26 May 2017 12:07:41 +0530
Arvind Yadav  wrote:

> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav 
Straight forward looking so I've applied this to the togreg
branch of iio.git and pushed it out as testing for the autobuilders
to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/xilinx-xadc-core.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c 
> b/drivers/iio/adc/xilinx-xadc-core.c
> index 56cf590..4a60497 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
>   ret = PTR_ERR(xadc->clk);
>   goto err_free_samplerate_trigger;
>   }
> - clk_prepare_enable(xadc->clk);
> +
> + ret = clk_prepare_enable(xadc->clk);
> + if (ret)
> + goto err_free_samplerate_trigger;
>  
>   ret = xadc->ops->setup(pdev, indio_dev, irq);
>   if (ret)

Re: [PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable

[Jonathan Cameron]

On Fri, 26 May 2017 12:07:41 +0530
Arvind Yadav  wrote:

> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav 
Straight forward looking so I've applied this to the togreg
branch of iio.git and pushed it out as testing for the autobuilders
to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/xilinx-xadc-core.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-xadc-core.c 
> b/drivers/iio/adc/xilinx-xadc-core.c
> index 56cf590..4a60497 100644
> --- a/drivers/iio/adc/xilinx-xadc-core.c
> +++ b/drivers/iio/adc/xilinx-xadc-core.c
> @@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
>   ret = PTR_ERR(xadc->clk);
>   goto err_free_samplerate_trigger;
>   }
> - clk_prepare_enable(xadc->clk);
> +
> + ret = clk_prepare_enable(xadc->clk);
> + if (ret)
> + goto err_free_samplerate_trigger;
>  
>   ret = xadc->ops->setup(pdev, indio_dev, irq);
>   if (ret)

[PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable

[Arvind Yadav]

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
 drivers/iio/adc/xilinx-xadc-core.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-xadc-core.c 
b/drivers/iio/adc/xilinx-xadc-core.c
index 56cf590..4a60497 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
ret = PTR_ERR(xadc->clk);
goto err_free_samplerate_trigger;
}
-   clk_prepare_enable(xadc->clk);
+
+   ret = clk_prepare_enable(xadc->clk);
+   if (ret)
+   goto err_free_samplerate_trigger;
 
ret = xadc->ops->setup(pdev, indio_dev, irq);
if (ret)
-- 
1.9.1

[PATCH] iio: adc: xilinx: Handle return value of clk_prepare_enable

[Arvind Yadav]

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav 
---
 drivers/iio/adc/xilinx-xadc-core.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-xadc-core.c 
b/drivers/iio/adc/xilinx-xadc-core.c
index 56cf590..4a60497 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -1204,7 +1204,10 @@ static int xadc_probe(struct platform_device *pdev)
ret = PTR_ERR(xadc->clk);
goto err_free_samplerate_trigger;
}
-   clk_prepare_enable(xadc->clk);
+
+   ret = clk_prepare_enable(xadc->clk);
+   if (ret)
+   goto err_free_samplerate_trigger;
 
ret = xadc->ops->setup(pdev, indio_dev, irq);
if (ret)
-- 
1.9.1