Re: [PATCH] power: max77693: fix simple_return.cocci warnings
Hi, On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote: > drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be > simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci Thanks, applied with Reviewed-By from Krzysztof. -- Sebastian signature.asc Description: Digital signature
Re: [PATCH] power: max77693: fix simple_return.cocci warnings
On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote: > drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be > simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Krzysztof Kozlowski > Signed-off-by: Fengguang Wu > --- > > max77693_charger.c |6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski > > --- a/drivers/power/max77693_charger.c > +++ b/drivers/power/max77693_charger.c > @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 > if (ret) > return ret; > > - ret = max77693_set_charge_input_threshold_volt(chg, > + return max77693_set_charge_input_threshold_volt(chg, > chg->charge_input_threshold_volt); > - if (ret) > - return ret; > - > - return 0; > } > > #ifdef CONFIG_OF -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] power: max77693: fix simple_return.cocci warnings
On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote: drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Fengguang Wu fengguang...@intel.com --- max77693_charger.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- a/drivers/power/max77693_charger.c +++ b/drivers/power/max77693_charger.c @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 if (ret) return ret; - ret = max77693_set_charge_input_threshold_volt(chg, + return max77693_set_charge_input_threshold_volt(chg, chg-charge_input_threshold_volt); - if (ret) - return ret; - - return 0; } #ifdef CONFIG_OF -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] power: max77693: fix simple_return.cocci warnings
Hi, On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote: drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Thanks, applied with Reviewed-By from Krzysztof. -- Sebastian signature.asc Description: Digital signature
[PATCH] power: max77693: fix simple_return.cocci warnings
drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Krzysztof Kozlowski Signed-off-by: Fengguang Wu --- max77693_charger.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/power/max77693_charger.c +++ b/drivers/power/max77693_charger.c @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 if (ret) return ret; - ret = max77693_set_charge_input_threshold_volt(chg, + return max77693_set_charge_input_threshold_volt(chg, chg->charge_input_threshold_volt); - if (ret) - return ret; - - return 0; } #ifdef CONFIG_OF -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] power: max77693: fix simple_return.cocci warnings
drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Fengguang Wu fengguang...@intel.com --- max77693_charger.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/drivers/power/max77693_charger.c +++ b/drivers/power/max77693_charger.c @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 if (ret) return ret; - ret = max77693_set_charge_input_threshold_volt(chg, + return max77693_set_charge_input_threshold_volt(chg, chg-charge_input_threshold_volt); - if (ret) - return ret; - - return 0; } #ifdef CONFIG_OF -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
