Re: [PATCH v2] block: trace completion of all bios.

2017-03-23 Thread NeilBrown
On Thu, Mar 23 2017, Ming Lei wrote: > On Thu, Mar 23, 2017 at 05:29:02PM +1100, NeilBrown wrote: >> >> /** >> + * bio_endio_notrace - end I/O on a bio without tracing >> + * @bio:bio >> + * >> + * Description: >> + * bio_endio_notrace() will end I/O on the whole bio. >> + *

Re: [PATCH v2] block: trace completion of all bios.

2017-03-23 Thread NeilBrown
On Thu, Mar 23 2017, Ming Lei wrote: > On Thu, Mar 23, 2017 at 05:29:02PM +1100, NeilBrown wrote: >> >> /** >> + * bio_endio_notrace - end I/O on a bio without tracing >> + * @bio:bio >> + * >> + * Description: >> + * bio_endio_notrace() will end I/O on the whole bio. >> + *

Re: [PATCH v2] block: trace completion of all bios.

2017-03-23 Thread Ming Lei
On Thu, Mar 23, 2017 at 05:29:02PM +1100, NeilBrown wrote: > > Currently only dm and md/raid5 bios trigger trace_block_bio_complete(). > Now that we have bio_chain(), it is not possible, in general, for a > driver to know when the bio is really complete. Only bio_endio() > knows that. > > So

Re: [PATCH v2] block: trace completion of all bios.

2017-03-23 Thread Ming Lei
On Thu, Mar 23, 2017 at 05:29:02PM +1100, NeilBrown wrote: > > Currently only dm and md/raid5 bios trigger trace_block_bio_complete(). > Now that we have bio_chain(), it is not possible, in general, for a > driver to know when the bio is really complete. Only bio_endio() > knows that. > > So

[PATCH v2] block: trace completion of all bios.

2017-03-23 Thread NeilBrown
Currently only dm and md/raid5 bios trigger trace_block_bio_complete(). Now that we have bio_chain(), it is not possible, in general, for a driver to know when the bio is really complete. Only bio_endio() knows that. So move the trace_block_bio_complete() call to bio_endio(). Now

[PATCH v2] block: trace completion of all bios.

2017-03-23 Thread NeilBrown
Currently only dm and md/raid5 bios trigger trace_block_bio_complete(). Now that we have bio_chain(), it is not possible, in general, for a driver to know when the bio is really complete. Only bio_endio() knows that. So move the trace_block_bio_complete() call to bio_endio(). Now