Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
On Mon, Oct 17, 2016 at 07:33:33AM +, David Binderman wrote:
> Hello there,
>
>
>
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style)
> Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
>
>
>
> Source code is
>
>
>
> if (cli->cl_avail_grant < 0) {
>
>
>
> Suggest code rework.
Great! Please send a patch.
thanks,
greg k-h
Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
On Mon, Oct 17, 2016 at 07:33:33AM +, David Binderman wrote:
> Hello there,
>
>
>
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style)
> Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
>
>
>
> Source code is
>
>
>
> if (cli->cl_avail_grant < 0) {
>
>
>
> Suggest code rework.
Great! Please send a patch.
thanks,
greg k-h
Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ?
Hi David,
On Mon, 2016-10-17 at 07:40 +, David Binderman wrote:
> Hello there,
>
> linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style)
> Checking if unsigned variable 'len' is less than zero.
>
> Source code is
>
> len = min((size_t)le32_to_cpu(rsp->len) << 2,
> iwl_rx_packet_payload_len(hcmd.resp_pkt) - sizeof(*rsp));
> len = min(len - delta, count);
> if (len < 0) {
> ret = -EFAULT;
> goto out;
> }
>
> Suggest improve error checking.
Thanks for reporting! A fix for this is already queued in our internal
tree and will be sent upstream soon.
--
Cheers,
Luca.
Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ?
Hi David,
On Mon, 2016-10-17 at 07:40 +, David Binderman wrote:
> Hello there,
>
> linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style)
> Checking if unsigned variable 'len' is less than zero.
>
> Source code is
>
> len = min((size_t)le32_to_cpu(rsp->len) << 2,
> iwl_rx_packet_payload_len(hcmd.resp_pkt) - sizeof(*rsp));
> len = min(len - delta, count);
> if (len < 0) {
> ret = -EFAULT;
> goto out;
> }
>
> Suggest improve error checking.
Thanks for reporting! A fix for this is already queued in our internal
tree and will be sent upstream soon.
--
Cheers,
Luca.
linux-next: stats (Was: Linux 4.9-rc1)
Hi all, As usual, the executive friendly graph is at http://neuling.org/linux-next-size.html :-) (No merge commits counted, next-20161004 was the first linux-next after the merge window opened.) Commits in v4.9-rc1 (relative to v4.8):14308 Commits in next-20161004: 13539 Commits with the same SHA1:12716 Commits with the same patch_id: 485 (1) Commits with the same subject line: 33 (1) (1) not counting those in the lines above. So commits in -rc1 that were in next-20161004: 13234 92% Some breakdown of the list of extra commits (relative to next-20161004) in -rc1: Top ten first word of commit summary: 110 pci 96 ib 75 powerpc 69 xfs 57 media 52 drm 37 net 28 perf 25 mips 22 scsi Top ten authors: 104 bhelg...@google.com 73 darrick.w...@oracle.com 42 npig...@gmail.com 40 trond.mykleb...@primarydata.com 28 ouli...@huawei.com 24 bhaktipriy...@gmail.com 22 chuck.le...@oracle.com 21 paul.bur...@imgtec.com 21 cyril...@gmail.com 19 boris.brezil...@free-electrons.com Top ten commiters: 127 dledf...@redhat.com 113 bhelg...@google.com 100 anna.schuma...@netapp.com 94 m...@ellerman.id.au 92 da...@davemloft.net 63 darrick.w...@oracle.com 57 mche...@kernel.org 40 torva...@linux-foundation.org 35 a...@redhat.com 28 r...@linux-mips.org There are also 305 commits in next-20161004 that didn't make it into v4.9-rc1. Top ten first word of commit summary: 37 drm 28 coresight 19 arm 12 powerpc 11 arm64 11 arm-soc 9 keys 8 mm 8 ima 6 bf609 Top ten authors: 17 bauer...@linux.vnet.ibm.com 17 a...@linux-foundation.org 14 paul...@linux.vnet.ibm.com 14 jani.nik...@intel.com 13 a...@arndb.de 12 mathieu.poir...@linaro.org 11 dhowe...@redhat.com 8 t...@kernel.org 8 suzuki.poul...@arm.com 8 jav...@osg.samsung.com Some of Andrew's patches are fixes for other patches in his tree (and have been merged into those). Top ten commiters: 71 s...@canb.auug.org.au 31 mathieu.poir...@linaro.org 22 paul...@linux.vnet.ibm.com 17 jani.nik...@intel.com 16 steven@ubuntu-virtualbox.(none) 16 a...@arndb.de 14 he...@sntech.de 11 dhowe...@redhat.com 8 t...@kernel.org 6 rodrigo.v...@intel.com Those commits by me are from the quilt series (mainly Andrew's mmotm tree). -- Cheers, Stephen Rothwell
linux-next: stats (Was: Linux 4.9-rc1)
Hi all, As usual, the executive friendly graph is at http://neuling.org/linux-next-size.html :-) (No merge commits counted, next-20161004 was the first linux-next after the merge window opened.) Commits in v4.9-rc1 (relative to v4.8):14308 Commits in next-20161004: 13539 Commits with the same SHA1:12716 Commits with the same patch_id: 485 (1) Commits with the same subject line: 33 (1) (1) not counting those in the lines above. So commits in -rc1 that were in next-20161004: 13234 92% Some breakdown of the list of extra commits (relative to next-20161004) in -rc1: Top ten first word of commit summary: 110 pci 96 ib 75 powerpc 69 xfs 57 media 52 drm 37 net 28 perf 25 mips 22 scsi Top ten authors: 104 bhelg...@google.com 73 darrick.w...@oracle.com 42 npig...@gmail.com 40 trond.mykleb...@primarydata.com 28 ouli...@huawei.com 24 bhaktipriy...@gmail.com 22 chuck.le...@oracle.com 21 paul.bur...@imgtec.com 21 cyril...@gmail.com 19 boris.brezil...@free-electrons.com Top ten commiters: 127 dledf...@redhat.com 113 bhelg...@google.com 100 anna.schuma...@netapp.com 94 m...@ellerman.id.au 92 da...@davemloft.net 63 darrick.w...@oracle.com 57 mche...@kernel.org 40 torva...@linux-foundation.org 35 a...@redhat.com 28 r...@linux-mips.org There are also 305 commits in next-20161004 that didn't make it into v4.9-rc1. Top ten first word of commit summary: 37 drm 28 coresight 19 arm 12 powerpc 11 arm64 11 arm-soc 9 keys 8 mm 8 ima 6 bf609 Top ten authors: 17 bauer...@linux.vnet.ibm.com 17 a...@linux-foundation.org 14 paul...@linux.vnet.ibm.com 14 jani.nik...@intel.com 13 a...@arndb.de 12 mathieu.poir...@linaro.org 11 dhowe...@redhat.com 8 t...@kernel.org 8 suzuki.poul...@arm.com 8 jav...@osg.samsung.com Some of Andrew's patches are fixes for other patches in his tree (and have been merged into those). Top ten commiters: 71 s...@canb.auug.org.au 31 mathieu.poir...@linaro.org 22 paul...@linux.vnet.ibm.com 17 jani.nik...@intel.com 16 steven@ubuntu-virtualbox.(none) 16 a...@arndb.de 14 he...@sntech.de 11 dhowe...@redhat.com 8 t...@kernel.org 6 rodrigo.v...@intel.com Those commits by me are from the quilt series (mainly Andrew's mmotm tree). -- Cheers, Stephen Rothwell
Linux 4.9-rc1
I usually do the releases on a Sunday afternoon, but occasionally cut
the merge window short by a day just to keep people on their toes, and
make sure people learn not to send in last-minute pull requests. No
gaming the merge window to the last day. This is one such release.
To be fair, the reason I did it a day early this time around is less
to stop people from trying to time their pull requests, and mostly
because this has been a pretty big merge window, and not hugely
enjoyable. I ended up stopping doing pulls twice during the merge
window just because I was chasing down some random problem. That tends
to turn my busy merge window time from "busy" to "somewhat stressful".
But hey, it's all good now, and while 4.9 looks to be a big release
and we had a couple of hiccups, on the whole things look normal. The
big new thing is the greybus addition, which Greg swears is actually
getting used. But the bulk of the changes by far is actually a lot of
small details under the hood, as usual.
My own favorite "small detail under the hood" happens to be Andy
Lutomirski's new virtually mapped kernel stack allocations. They make
it easier to find and recover from stack overflows, but the effort
also cleaned up some code, and added a kernel stack mapping cache to
avoid any performance downsides. Al has also been working on some vfs
and uaccess cleanups (particularly a goo splice model cleanup) that I
follow. But realistically, what _I_ consider cool small details is
just my own personal thing, there's things all over.
The virtual stack mapping also happens to mean that people who try to
do DMA from temporary buffers on the stack ("Don't do it!") now really
need to change their evil ways. So there is some fallout from this,
and I expect a couple of drivers to need minor fixes. But it's all for
a good cause, really (and it isn't all that common, because doing DMA
from the stack really has never been a good idea, and is generally not
even workable in most situations).
But there really is a lot of other things going on, and the shortlog
that I do for other releases is much too big during rc1. So as usual,
I'm appending my "mergelog" instead, which gives a very high-level
view of what I merged and from whom. And as usual, I want to point out
that the person I merge from is not necessarily the person who did the
work: we had 1500 people involved in this release, only the top-level
maintainers get credited in my mergelog.
Go forth and test,
Linus
---
Al Viro (7):
VFS splice updates
misc vfs updates
splice fixups
vfs xattr updates
more vfs updates
uaccess.h prepwork
more misc uaccess and vfs updates
Alex Williamson (1):
VFIO updates
Alexandre Belloni (1):
RTC updates
Andrew Morton (2):
updates
more updates
Anna Schumaker (1):
NFS client updates
Arnd Bergmann (8):
ARM SoC cleanups
ARM SoC platform updates
ARM SoC defconfig updates
ARM SoC 64-bit updates
ARM SoC driver updates
ARM DT updates
ARM 64-bit DT updates
ARM SoC late DT updates
Bjorn Andersson (2):
remoteproc updates
rpmsg updates
Bjorn Helgaas (1):
PCI updates
Bob Peterson (1):
gfs2 updates
Borislav Petkov (1):
EDAC updates
Brian Norris (1):
MTD updates
Bruce Fields (1):
nfsd updates
Chris Mason (2):
btrfs updates
btrfs fixes
Dan Williams (1):
libnvdimm updates
Darren Hart (1):
x86 platform drivers updates
Dave Airlie (1):
drm updates
Dave Chinner (2):
xfs and iomap updates
XFS support for shared data extents
David Kleikamp (1):
jfs updates
David Miller (5):
networking updates
sparc updates
networking fixups
networking fixes
networking fixes
David Teigland (1):
dlm fix
David Vrabel (1):
xen updates
Dmitry Torokhov (2):
input subsystem updates
some more input subsystem updates
Doug Ledford (5):
hdi1 rdma driver updates
more rdma updates
main rdma updates
more rdma updates
rdma qedr RoCE driver
Eric Biederman (1):
namespace updates
Geert Uytterhoeven (1):
m68k updates
Greg KH (5):
char/misc driver updates
driver core updates
tty and serial updates
usb/phy/extcon updates
staging and IIO updates
Greg Ungerer (1):
m68knommu updates
Guenter Roeck (1):
hwmon updates
Hans-Christian Noren Egtvedt (1):
avr32 update
Helge Deller (2):
parisc updates
parisc fixes
Herbert Xu (1):
crypto updates
Ilya Dryomov (1):
Ceph updates
Ingo Molnar (14):
RCU updates
core SMP updates
EFI updates
locking updates
perf updates
RAS updates
scheduler changes
x86 apic updates
low-level x86 updates
x86 boot updates
x86 cleanups
x86 platform changes
x86 timer updates
x86 vdso updates
Jacek Anaszewski (1):
LED driver updates
Jaegeuk Kim (1):
f2fs updates
James Bottomley (2):
SCSI updates
more SCSI updates
James Hogan (1):
Linux 4.9-rc1
I usually do the releases on a Sunday afternoon, but occasionally cut
the merge window short by a day just to keep people on their toes, and
make sure people learn not to send in last-minute pull requests. No
gaming the merge window to the last day. This is one such release.
To be fair, the reason I did it a day early this time around is less
to stop people from trying to time their pull requests, and mostly
because this has been a pretty big merge window, and not hugely
enjoyable. I ended up stopping doing pulls twice during the merge
window just because I was chasing down some random problem. That tends
to turn my busy merge window time from "busy" to "somewhat stressful".
But hey, it's all good now, and while 4.9 looks to be a big release
and we had a couple of hiccups, on the whole things look normal. The
big new thing is the greybus addition, which Greg swears is actually
getting used. But the bulk of the changes by far is actually a lot of
small details under the hood, as usual.
My own favorite "small detail under the hood" happens to be Andy
Lutomirski's new virtually mapped kernel stack allocations. They make
it easier to find and recover from stack overflows, but the effort
also cleaned up some code, and added a kernel stack mapping cache to
avoid any performance downsides. Al has also been working on some vfs
and uaccess cleanups (particularly a goo splice model cleanup) that I
follow. But realistically, what _I_ consider cool small details is
just my own personal thing, there's things all over.
The virtual stack mapping also happens to mean that people who try to
do DMA from temporary buffers on the stack ("Don't do it!") now really
need to change their evil ways. So there is some fallout from this,
and I expect a couple of drivers to need minor fixes. But it's all for
a good cause, really (and it isn't all that common, because doing DMA
from the stack really has never been a good idea, and is generally not
even workable in most situations).
But there really is a lot of other things going on, and the shortlog
that I do for other releases is much too big during rc1. So as usual,
I'm appending my "mergelog" instead, which gives a very high-level
view of what I merged and from whom. And as usual, I want to point out
that the person I merge from is not necessarily the person who did the
work: we had 1500 people involved in this release, only the top-level
maintainers get credited in my mergelog.
Go forth and test,
Linus
---
Al Viro (7):
VFS splice updates
misc vfs updates
splice fixups
vfs xattr updates
more vfs updates
uaccess.h prepwork
more misc uaccess and vfs updates
Alex Williamson (1):
VFIO updates
Alexandre Belloni (1):
RTC updates
Andrew Morton (2):
updates
more updates
Anna Schumaker (1):
NFS client updates
Arnd Bergmann (8):
ARM SoC cleanups
ARM SoC platform updates
ARM SoC defconfig updates
ARM SoC 64-bit updates
ARM SoC driver updates
ARM DT updates
ARM 64-bit DT updates
ARM SoC late DT updates
Bjorn Andersson (2):
remoteproc updates
rpmsg updates
Bjorn Helgaas (1):
PCI updates
Bob Peterson (1):
gfs2 updates
Borislav Petkov (1):
EDAC updates
Brian Norris (1):
MTD updates
Bruce Fields (1):
nfsd updates
Chris Mason (2):
btrfs updates
btrfs fixes
Dan Williams (1):
libnvdimm updates
Darren Hart (1):
x86 platform drivers updates
Dave Airlie (1):
drm updates
Dave Chinner (2):
xfs and iomap updates
XFS support for shared data extents
David Kleikamp (1):
jfs updates
David Miller (5):
networking updates
sparc updates
networking fixups
networking fixes
networking fixes
David Teigland (1):
dlm fix
David Vrabel (1):
xen updates
Dmitry Torokhov (2):
input subsystem updates
some more input subsystem updates
Doug Ledford (5):
hdi1 rdma driver updates
more rdma updates
main rdma updates
more rdma updates
rdma qedr RoCE driver
Eric Biederman (1):
namespace updates
Geert Uytterhoeven (1):
m68k updates
Greg KH (5):
char/misc driver updates
driver core updates
tty and serial updates
usb/phy/extcon updates
staging and IIO updates
Greg Ungerer (1):
m68knommu updates
Guenter Roeck (1):
hwmon updates
Hans-Christian Noren Egtvedt (1):
avr32 update
Helge Deller (2):
parisc updates
parisc fixes
Herbert Xu (1):
crypto updates
Ilya Dryomov (1):
Ceph updates
Ingo Molnar (14):
RCU updates
core SMP updates
EFI updates
locking updates
perf updates
RAS updates
scheduler changes
x86 apic updates
low-level x86 updates
x86 boot updates
x86 cleanups
x86 platform changes
x86 timer updates
x86 vdso updates
Jacek Anaszewski (1):
LED driver updates
Jaegeuk Kim (1):
f2fs updates
James Bottomley (2):
SCSI updates
more SCSI updates
James Hogan (1):
