Re: [PATCH] kasan: make function get_wild_bug_type static

2017-06-22 Thread Dmitry Vyukov
On Thu, Jun 22, 2017 at 11:00 AM, Colin King  wrote:
> From: Colin Ian King 
>
> The helper function get_wild_bug_type does not need to be in global scope,
> so make it static.
>
> Cleans up sparse warning:
> "symbol 'get_wild_bug_type' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King 

Acked-by: Dmitry Vyukov 

> ---
>  mm/kasan/report.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index beee0e980e2d..04bb1d3eb9ec 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -107,7 +107,7 @@ static const char *get_shadow_bug_type(struct 
> kasan_access_info *info)
> return bug_type;
>  }
>
> -const char *get_wild_bug_type(struct kasan_access_info *info)
> +static const char *get_wild_bug_type(struct kasan_access_info *info)
>  {
> const char *bug_type = "unknown-crash";
>
> --
> 2.11.0
>


Re: [PATCH] kasan: make function get_wild_bug_type static

2017-06-22 Thread Dmitry Vyukov
On Thu, Jun 22, 2017 at 11:00 AM, Colin King  wrote:
> From: Colin Ian King 
>
> The helper function get_wild_bug_type does not need to be in global scope,
> so make it static.
>
> Cleans up sparse warning:
> "symbol 'get_wild_bug_type' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King 

Acked-by: Dmitry Vyukov 

> ---
>  mm/kasan/report.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index beee0e980e2d..04bb1d3eb9ec 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -107,7 +107,7 @@ static const char *get_shadow_bug_type(struct 
> kasan_access_info *info)
> return bug_type;
>  }
>
> -const char *get_wild_bug_type(struct kasan_access_info *info)
> +static const char *get_wild_bug_type(struct kasan_access_info *info)
>  {
> const char *bug_type = "unknown-crash";
>
> --
> 2.11.0
>