Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-23 Thread NeilBrown
On Sat, Apr 22 2017, Javier González wrote: >> On 20 Apr 2017, at 07.38, NeilBrown wrote: >> >> blk_queue_split() is always called with the last arg being q->bio_split, >> where 'q' is the first arg. >> >> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-23 Thread NeilBrown
On Sat, Apr 22 2017, Javier González wrote: >> On 20 Apr 2017, at 07.38, NeilBrown wrote: >> >> blk_queue_split() is always called with the last arg being q->bio_split, >> where 'q' is the first arg. >> >> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses >>

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-22 Thread Javier González
> On 20 Apr 2017, at 07.38, NeilBrown wrote: > > blk_queue_split() is always called with the last arg being q->bio_split, > where 'q' is the first arg. > > Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses > q->bio_split. > > This is inconsistent and

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-22 Thread Javier González
> On 20 Apr 2017, at 07.38, NeilBrown wrote: > > blk_queue_split() is always called with the last arg being q->bio_split, > where 'q' is the first arg. > > Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses > q->bio_split. > > This is inconsistent and unnecessary.

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-21 Thread Ming Lei
On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown wrote: > blk_queue_split() is always called with the last arg being q->bio_split, > where 'q' is the first arg. > > Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses > q->bio_split. > > This is inconsistent and

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-21 Thread Ming Lei
On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown wrote: > blk_queue_split() is always called with the last arg being q->bio_split, > where 'q' is the first arg. > > Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses > q->bio_split. > > This is inconsistent and unnecessary.

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-21 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

2017-04-21 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig