Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[NeilBrown]

On Sat, Apr 22 2017, Javier González wrote:

>> On 20 Apr 2017, at 07.38, NeilBrown  wrote:
>> 
>> blk_queue_split() is always called with the last arg being q->bio_split,
>> where 'q' is the first arg.
>> 
>> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
>> q->bio_split.
>> 
>> This is inconsistent and unnecessary.  Remove the last arg and always use
>> q->bio_split inside blk_queue_split()
>> 
>> Signed-off-by: NeilBrown 
>> ---
>> block/blk-core.c  |2 +-
>> block/blk-merge.c |9 -
>> block/blk-mq.c|2 +-
>> drivers/block/drbd/drbd_req.c |2 +-
>> drivers/block/pktcdvd.c   |2 +-
>> drivers/block/ps3vram.c   |2 +-
>> drivers/block/rsxx/dev.c  |2 +-
>> drivers/block/umem.c  |2 +-
>> drivers/block/zram/zram_drv.c |2 +-
>> drivers/lightnvm/rrpc.c   |2 +-
>> drivers/md/md.c   |2 +-
>> drivers/s390/block/dcssblk.c  |2 +-
>> drivers/s390/block/xpram.c|2 +-
>> include/linux/blkdev.h|3 +--
>> 14 files changed, 17 insertions(+), 19 deletions(-)
>> 
>
> It most probably made it to Jens' tree after you made these changes, but
> in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a
> couple of places inside pblk_rw_io().

Ahh, yes - thanks.  That will need to same small change.

Jens, do you prefer a resend, or and update patch, or to just add this
change manually?

Thanks,
NeilBrown


signature.asc
Description: PGP signature

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[NeilBrown]

On Sat, Apr 22 2017, Javier González wrote:

>> On 20 Apr 2017, at 07.38, NeilBrown  wrote:
>> 
>> blk_queue_split() is always called with the last arg being q->bio_split,
>> where 'q' is the first arg.
>> 
>> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
>> q->bio_split.
>> 
>> This is inconsistent and unnecessary.  Remove the last arg and always use
>> q->bio_split inside blk_queue_split()
>> 
>> Signed-off-by: NeilBrown 
>> ---
>> block/blk-core.c  |2 +-
>> block/blk-merge.c |9 -
>> block/blk-mq.c|2 +-
>> drivers/block/drbd/drbd_req.c |2 +-
>> drivers/block/pktcdvd.c   |2 +-
>> drivers/block/ps3vram.c   |2 +-
>> drivers/block/rsxx/dev.c  |2 +-
>> drivers/block/umem.c  |2 +-
>> drivers/block/zram/zram_drv.c |2 +-
>> drivers/lightnvm/rrpc.c   |2 +-
>> drivers/md/md.c   |2 +-
>> drivers/s390/block/dcssblk.c  |2 +-
>> drivers/s390/block/xpram.c|2 +-
>> include/linux/blkdev.h|3 +--
>> 14 files changed, 17 insertions(+), 19 deletions(-)
>> 
>
> It most probably made it to Jens' tree after you made these changes, but
> in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a
> couple of places inside pblk_rw_io().

Ahh, yes - thanks.  That will need to same small change.

Jens, do you prefer a resend, or and update patch, or to just add this
change manually?

Thanks,
NeilBrown


signature.asc
Description: PGP signature

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[Javier González]

> On 20 Apr 2017, at 07.38, NeilBrown  wrote:
> 
> blk_queue_split() is always called with the last arg being q->bio_split,
> where 'q' is the first arg.
> 
> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
> q->bio_split.
> 
> This is inconsistent and unnecessary.  Remove the last arg and always use
> q->bio_split inside blk_queue_split()
> 
> Signed-off-by: NeilBrown 
> ---
> block/blk-core.c  |2 +-
> block/blk-merge.c |9 -
> block/blk-mq.c|2 +-
> drivers/block/drbd/drbd_req.c |2 +-
> drivers/block/pktcdvd.c   |2 +-
> drivers/block/ps3vram.c   |2 +-
> drivers/block/rsxx/dev.c  |2 +-
> drivers/block/umem.c  |2 +-
> drivers/block/zram/zram_drv.c |2 +-
> drivers/lightnvm/rrpc.c   |2 +-
> drivers/md/md.c   |2 +-
> drivers/s390/block/dcssblk.c  |2 +-
> drivers/s390/block/xpram.c|2 +-
> include/linux/blkdev.h|3 +--
> 14 files changed, 17 insertions(+), 19 deletions(-)
> 

It most probably made it to Jens' tree after you made these changes, but
in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a
couple of places inside pblk_rw_io().

Thanks,
Javier.


signature.asc
Description: Message signed with OpenPGP

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[Javier González]

> On 20 Apr 2017, at 07.38, NeilBrown  wrote:
> 
> blk_queue_split() is always called with the last arg being q->bio_split,
> where 'q' is the first arg.
> 
> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
> q->bio_split.
> 
> This is inconsistent and unnecessary.  Remove the last arg and always use
> q->bio_split inside blk_queue_split()
> 
> Signed-off-by: NeilBrown 
> ---
> block/blk-core.c  |2 +-
> block/blk-merge.c |9 -
> block/blk-mq.c|2 +-
> drivers/block/drbd/drbd_req.c |2 +-
> drivers/block/pktcdvd.c   |2 +-
> drivers/block/ps3vram.c   |2 +-
> drivers/block/rsxx/dev.c  |2 +-
> drivers/block/umem.c  |2 +-
> drivers/block/zram/zram_drv.c |2 +-
> drivers/lightnvm/rrpc.c   |2 +-
> drivers/md/md.c   |2 +-
> drivers/s390/block/dcssblk.c  |2 +-
> drivers/s390/block/xpram.c|2 +-
> include/linux/blkdev.h|3 +--
> 14 files changed, 17 insertions(+), 19 deletions(-)
> 

It most probably made it to Jens' tree after you made these changes, but
in drivers/lightnvm/pblk-init.c we also use blk_queue_split() in a
couple of places inside pblk_rw_io().

Thanks,
Javier.


signature.asc
Description: Message signed with OpenPGP

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[Ming Lei]

On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown  wrote:
> blk_queue_split() is always called with the last arg being q->bio_split,
> where 'q' is the first arg.
>
> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
> q->bio_split.
>
> This is inconsistent and unnecessary.  Remove the last arg and always use
> q->bio_split inside blk_queue_split()
>
> Signed-off-by: NeilBrown 

Reviewed-by: Ming Lei 

Thanks,

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[Ming Lei]

On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown  wrote:
> blk_queue_split() is always called with the last arg being q->bio_split,
> where 'q' is the first arg.
>
> Also blk_queue_split() sometimes uses the passed-in 'bs' and sometimes uses
> q->bio_split.
>
> This is inconsistent and unnecessary.  Remove the last arg and always use
> q->bio_split inside blk_queue_split()
>
> Signed-off-by: NeilBrown 

Reviewed-by: Ming Lei 

Thanks,

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig 

Re: [PATCH 01/11] blk: remove bio_set arg from blk_queue_split()

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig