Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

Mike Kravetz writes: > On 07/26/2017 06:34 AM, Punit Agrawal wrote: >> Michal Hocko writes: >> >>> On Wed 26-07-17 14:33:57, Michal Hocko wrote: On Wed 26-07-17 13:11:46, Punit Agrawal wrote: >>> [...] > I've been running tests from mce-test

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

Mike Kravetz writes: > On 07/26/2017 06:34 AM, Punit Agrawal wrote: >> Michal Hocko writes: >> >>> On Wed 26-07-17 14:33:57, Michal Hocko wrote: On Wed 26-07-17 13:11:46, Punit Agrawal wrote: >>> [...] > I've been running tests from mce-test suite and libhugetlbfs for similar >

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On 07/26/2017 06:34 AM, Punit Agrawal wrote: > Michal Hocko writes: > >> On Wed 26-07-17 14:33:57, Michal Hocko wrote: >>> On Wed 26-07-17 13:11:46, Punit Agrawal wrote: >> [...] I've been running tests from mce-test suite and libhugetlbfs for similar changes we did

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On 07/26/2017 06:34 AM, Punit Agrawal wrote: > Michal Hocko writes: > >> On Wed 26-07-17 14:33:57, Michal Hocko wrote: >>> On Wed 26-07-17 13:11:46, Punit Agrawal wrote: >> [...] I've been running tests from mce-test suite and libhugetlbfs for similar changes we did on arm64. There

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

Michal Hocko writes: > On Wed 26-07-17 14:33:57, Michal Hocko wrote: >> On Wed 26-07-17 13:11:46, Punit Agrawal wrote: > [...] >> > I've been running tests from mce-test suite and libhugetlbfs for similar >> > changes we did on arm64. There could be assumptions that were not

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

Michal Hocko writes: > On Wed 26-07-17 14:33:57, Michal Hocko wrote: >> On Wed 26-07-17 13:11:46, Punit Agrawal wrote: > [...] >> > I've been running tests from mce-test suite and libhugetlbfs for similar >> > changes we did on arm64. There could be assumptions that were not >> > exercised but

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Wed 26-07-17 14:33:57, Michal Hocko wrote: > On Wed 26-07-17 13:11:46, Punit Agrawal wrote: [...] > > I've been running tests from mce-test suite and libhugetlbfs for similar > > changes we did on arm64. There could be assumptions that were not > > exercised but I'm not sure how to check for

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Wed 26-07-17 14:33:57, Michal Hocko wrote: > On Wed 26-07-17 13:11:46, Punit Agrawal wrote: [...] > > I've been running tests from mce-test suite and libhugetlbfs for similar > > changes we did on arm64. There could be assumptions that were not > > exercised but I'm not sure how to check for

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Wed 26-07-17 13:11:46, Punit Agrawal wrote: > Hi Michal, > > Michal Hocko writes: > > > On Wed 26-07-17 10:50:38, Michal Hocko wrote: > >> On Tue 25-07-17 16:41:14, Punit Agrawal wrote: > >> > When walking the page tables to resolve an address that points to > >> >

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Wed 26-07-17 13:11:46, Punit Agrawal wrote: > Hi Michal, > > Michal Hocko writes: > > > On Wed 26-07-17 10:50:38, Michal Hocko wrote: > >> On Tue 25-07-17 16:41:14, Punit Agrawal wrote: > >> > When walking the page tables to resolve an address that points to > >> > !p*d_present() entry,

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

Hi Michal, Michal Hocko writes: > On Wed 26-07-17 10:50:38, Michal Hocko wrote: >> On Tue 25-07-17 16:41:14, Punit Agrawal wrote: >> > When walking the page tables to resolve an address that points to >> > !p*d_present() entry, huge_pte_offset() returns inconsistent values >>

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

Hi Michal, Michal Hocko writes: > On Wed 26-07-17 10:50:38, Michal Hocko wrote: >> On Tue 25-07-17 16:41:14, Punit Agrawal wrote: >> > When walking the page tables to resolve an address that points to >> > !p*d_present() entry, huge_pte_offset() returns inconsistent values >> > depending on the

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Wed 26-07-17 10:50:38, Michal Hocko wrote: > On Tue 25-07-17 16:41:14, Punit Agrawal wrote: > > When walking the page tables to resolve an address that points to > > !p*d_present() entry, huge_pte_offset() returns inconsistent values > > depending on the level of page table (PUD or PMD). > > >

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Wed 26-07-17 10:50:38, Michal Hocko wrote: > On Tue 25-07-17 16:41:14, Punit Agrawal wrote: > > When walking the page tables to resolve an address that points to > > !p*d_present() entry, huge_pte_offset() returns inconsistent values > > depending on the level of page table (PUD or PMD). > > >

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Tue 25-07-17 16:41:14, Punit Agrawal wrote: > When walking the page tables to resolve an address that points to > !p*d_present() entry, huge_pte_offset() returns inconsistent values > depending on the level of page table (PUD or PMD). > > It returns NULL in the case of a PUD entry while in the

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Tue 25-07-17 16:41:14, Punit Agrawal wrote: > When walking the page tables to resolve an address that points to > !p*d_present() entry, huge_pte_offset() returns inconsistent values > depending on the level of page table (PUD or PMD). > > It returns NULL in the case of a PUD entry while in the

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Tue, Jul 25, 2017 at 04:41:14PM +0100, Punit Agrawal wrote: > When walking the page tables to resolve an address that points to > !p*d_present() entry, huge_pte_offset() returns inconsistent values > depending on the level of page table (PUD or PMD). > > It returns NULL in the case of a PUD

Re: [PATCH 1/1] mm/hugetlb: Make huge_pte_offset() consistent and document behaviour

On Tue, Jul 25, 2017 at 04:41:14PM +0100, Punit Agrawal wrote: > When walking the page tables to resolve an address that points to > !p*d_present() entry, huge_pte_offset() returns inconsistent values > depending on the level of page table (PUD or PMD). > > It returns NULL in the case of a PUD