Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Masahiro Yamada]

Hi Viresh,


2017-08-16 14:37 GMT+09:00 Viresh Kumar :
> Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> use "operating-points-v2" property from their DT. They should continue
> to work after this patch.
>
> Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 061b468512a2..45f2ec3b7f7a 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "allwinner,sun6i-a31s", },
> { .compatible = "allwinner,sun7i-a20", },
> { .compatible = "allwinner,sun8i-a23", },
> -   { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> { .compatible = "allwinner,sun8i-h3", },
>
> @@ -37,7 +36,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "arm,integrator-cp", },
>
> { .compatible = "hisilicon,hi3660", },
> -   { .compatible = "hisilicon,hi6220", },
>
> { .compatible = "fsl,imx27", },
> { .compatible = "fsl,imx51", },
> @@ -51,11 +49,8 @@ static const struct of_device_id whitelist[] __initconst = 
> {
> { .compatible = "samsung,exynos3250", },
> { .compatible = "samsung,exynos4210", },
> { .compatible = "samsung,exynos4212", },
> -   { .compatible = "samsung,exynos4412", },
> { .compatible = "samsung,exynos5250", },
>  #ifndef CONFIG_BL_SWITCHER
> -   { .compatible = "samsung,exynos5420", },
> -   { .compatible = "samsung,exynos5433", },
> { .compatible = "samsung,exynos5800", },
>  #endif
>
> @@ -87,11 +82,7 @@ static const struct of_device_id whitelist[] __initconst = 
> {
> { .compatible = "rockchip,rk3368", },
> { .compatible = "rockchip,rk3399", },
>
> -   { .compatible = "socionext,uniphier-pro5", },
> -   { .compatible = "socionext,uniphier-pxs2", },
> { .compatible = "socionext,uniphier-ld6b", },
> -   { .compatible = "socionext,uniphier-ld11", },
> -   { .compatible = "socionext,uniphier-ld20", },


Please remove "socionext,uniphier-ld6b" as well.

It includes the same silicon die
of "socionext,uniphier-pxs2".



-- 
Best Regards
Masahiro Yamada

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Masahiro Yamada]

Hi Viresh,


2017-08-16 14:37 GMT+09:00 Viresh Kumar :
> Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> use "operating-points-v2" property from their DT. They should continue
> to work after this patch.
>
> Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 061b468512a2..45f2ec3b7f7a 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "allwinner,sun6i-a31s", },
> { .compatible = "allwinner,sun7i-a20", },
> { .compatible = "allwinner,sun8i-a23", },
> -   { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> { .compatible = "allwinner,sun8i-h3", },
>
> @@ -37,7 +36,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "arm,integrator-cp", },
>
> { .compatible = "hisilicon,hi3660", },
> -   { .compatible = "hisilicon,hi6220", },
>
> { .compatible = "fsl,imx27", },
> { .compatible = "fsl,imx51", },
> @@ -51,11 +49,8 @@ static const struct of_device_id whitelist[] __initconst = 
> {
> { .compatible = "samsung,exynos3250", },
> { .compatible = "samsung,exynos4210", },
> { .compatible = "samsung,exynos4212", },
> -   { .compatible = "samsung,exynos4412", },
> { .compatible = "samsung,exynos5250", },
>  #ifndef CONFIG_BL_SWITCHER
> -   { .compatible = "samsung,exynos5420", },
> -   { .compatible = "samsung,exynos5433", },
> { .compatible = "samsung,exynos5800", },
>  #endif
>
> @@ -87,11 +82,7 @@ static const struct of_device_id whitelist[] __initconst = 
> {
> { .compatible = "rockchip,rk3368", },
> { .compatible = "rockchip,rk3399", },
>
> -   { .compatible = "socionext,uniphier-pro5", },
> -   { .compatible = "socionext,uniphier-pxs2", },
> { .compatible = "socionext,uniphier-ld6b", },
> -   { .compatible = "socionext,uniphier-ld11", },
> -   { .compatible = "socionext,uniphier-ld20", },


Please remove "socionext,uniphier-ld6b" as well.

It includes the same silicon die
of "socionext,uniphier-pxs2".



-- 
Best Regards
Masahiro Yamada

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Simon Horman]

On Thu, Aug 17, 2017 at 09:53:01AM +0200, Simon Horman wrote:
> On Wed, Aug 16, 2017 at 08:51:04AM +0200, Geert Uytterhoeven wrote:
> > Hi Viresh,
> > 
> > On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  
> > wrote:
> > > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > > use "operating-points-v2" property from their DT. They should continue
> > > to work after this patch.
> > >
> > > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> > >
> > > Signed-off-by: Viresh Kumar 
> > > ---
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> > >  1 file changed, 11 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 061b468512a2..45f2ec3b7f7a 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] 
> > > __initconst = {
> > > { .compatible = "allwinner,sun6i-a31s", },
> > > { .compatible = "allwinner,sun7i-a20", },
> > > { .compatible = "allwinner,sun8i-a23", },
> > > -   { .compatible = "allwinner,sun8i-a33", },
> > > { .compatible = "allwinner,sun8i-a83t", },
> > > { .compatible = "allwinner,sun8i-h3", },
> > 
> > I think "renesas,r8a7795" can be removed again, too.
> > Simon?
> 
> I assume you are referring to "[PATCH 1/2] cpufreq: dt-platdev:
> Automatically create cpufreq device with OPP v2" (which you kindly
> forwarded me). If so, yes, that seems likely. I'll do some testing to
> confirm this.

I have now done some testing. With "[PATCH 1/2]" applied the following can
be removed:

"renesas,r8a7795"
"renesas,r8a7796"

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Simon Horman]

On Thu, Aug 17, 2017 at 09:53:01AM +0200, Simon Horman wrote:
> On Wed, Aug 16, 2017 at 08:51:04AM +0200, Geert Uytterhoeven wrote:
> > Hi Viresh,
> > 
> > On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  
> > wrote:
> > > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > > use "operating-points-v2" property from their DT. They should continue
> > > to work after this patch.
> > >
> > > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> > >
> > > Signed-off-by: Viresh Kumar 
> > > ---
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> > >  1 file changed, 11 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 061b468512a2..45f2ec3b7f7a 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] 
> > > __initconst = {
> > > { .compatible = "allwinner,sun6i-a31s", },
> > > { .compatible = "allwinner,sun7i-a20", },
> > > { .compatible = "allwinner,sun8i-a23", },
> > > -   { .compatible = "allwinner,sun8i-a33", },
> > > { .compatible = "allwinner,sun8i-a83t", },
> > > { .compatible = "allwinner,sun8i-h3", },
> > 
> > I think "renesas,r8a7795" can be removed again, too.
> > Simon?
> 
> I assume you are referring to "[PATCH 1/2] cpufreq: dt-platdev:
> Automatically create cpufreq device with OPP v2" (which you kindly
> forwarded me). If so, yes, that seems likely. I'll do some testing to
> confirm this.

I have now done some testing. With "[PATCH 1/2]" applied the following can
be removed:

"renesas,r8a7795"
"renesas,r8a7796"

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Chen-Yu Tsai]

On Wed, Aug 16, 2017 at 7:24 PM, Viresh Kumar  wrote:
> On 16-08-17, 16:53, Chen-Yu Tsai wrote:
>> On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar  
>> wrote:
>> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
>> > use "operating-points-v2" property from their DT. They should continue
>> > to work after this patch.
>> >
>> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>> >
>> > Signed-off-by: Viresh Kumar 
>> > ---
>> >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>> >  1 file changed, 11 deletions(-)
>> >
>> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
>> > b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > index 061b468512a2..45f2ec3b7f7a 100644
>> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst 
>> > = {
>> > { .compatible = "allwinner,sun6i-a31s", },
>> > { .compatible = "allwinner,sun7i-a20", },
>> > { .compatible = "allwinner,sun8i-a23", },
>> > -   { .compatible = "allwinner,sun8i-a33", },
>> > { .compatible = "allwinner,sun8i-a83t", },
>> > { .compatible = "allwinner,sun8i-h3", },
>> >
>>
>> Acked-by: Chen-Yu Tsai 
>>
>> In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
>> cpufreq implemented. All the other ones are missing thermal sensor support,
>> and no OPP tables have been added yet.
>
> Then, why did you guys add all those SoCs there ? :)

The idea was to add all the SoCs to the cpufreq driver first, and sort out
the thermal sensor and device tree parts later. Obviously this progressed
very slowly.

ChenYu

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Chen-Yu Tsai]

On Wed, Aug 16, 2017 at 7:24 PM, Viresh Kumar  wrote:
> On 16-08-17, 16:53, Chen-Yu Tsai wrote:
>> On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar  
>> wrote:
>> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
>> > use "operating-points-v2" property from their DT. They should continue
>> > to work after this patch.
>> >
>> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>> >
>> > Signed-off-by: Viresh Kumar 
>> > ---
>> >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>> >  1 file changed, 11 deletions(-)
>> >
>> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
>> > b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > index 061b468512a2..45f2ec3b7f7a 100644
>> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst 
>> > = {
>> > { .compatible = "allwinner,sun6i-a31s", },
>> > { .compatible = "allwinner,sun7i-a20", },
>> > { .compatible = "allwinner,sun8i-a23", },
>> > -   { .compatible = "allwinner,sun8i-a33", },
>> > { .compatible = "allwinner,sun8i-a83t", },
>> > { .compatible = "allwinner,sun8i-h3", },
>> >
>>
>> Acked-by: Chen-Yu Tsai 
>>
>> In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
>> cpufreq implemented. All the other ones are missing thermal sensor support,
>> and no OPP tables have been added yet.
>
> Then, why did you guys add all those SoCs there ? :)

The idea was to add all the SoCs to the cpufreq driver first, and sort out
the thermal sensor and device tree parts later. Obviously this progressed
very slowly.

ChenYu

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Viresh Kumar]

On 17-08-17, 09:53, Simon Horman wrote:
> On Wed, Aug 16, 2017 at 08:51:04AM +0200, Geert Uytterhoeven wrote:
> > Hi Viresh,
> > 
> > On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  
> > wrote:
> > > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > > use "operating-points-v2" property from their DT. They should continue
> > > to work after this patch.
> > >
> > > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> > >
> > > Signed-off-by: Viresh Kumar 
> > > ---
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> > >  1 file changed, 11 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 061b468512a2..45f2ec3b7f7a 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] 
> > > __initconst = {
> > > { .compatible = "allwinner,sun6i-a31s", },
> > > { .compatible = "allwinner,sun7i-a20", },
> > > { .compatible = "allwinner,sun8i-a23", },
> > > -   { .compatible = "allwinner,sun8i-a33", },
> > > { .compatible = "allwinner,sun8i-a83t", },
> > > { .compatible = "allwinner,sun8i-h3", },
> > 
> > I think "renesas,r8a7795" can be removed again, too.
> > Simon?
> 
> I assume you are referring to "[PATCH 1/2] cpufreq: dt-platdev:
> Automatically create cpufreq device with OPP v2" (which you kindly
> forwarded me). If so, yes, that seems likely. I'll do some testing to
> confirm this.

Yeah, and he probably meant that renesas bits can be removed and
included in this patch 2/2 only.

-- 
viresh

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Viresh Kumar]

On 17-08-17, 09:53, Simon Horman wrote:
> On Wed, Aug 16, 2017 at 08:51:04AM +0200, Geert Uytterhoeven wrote:
> > Hi Viresh,
> > 
> > On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  
> > wrote:
> > > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > > use "operating-points-v2" property from their DT. They should continue
> > > to work after this patch.
> > >
> > > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> > >
> > > Signed-off-by: Viresh Kumar 
> > > ---
> > >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> > >  1 file changed, 11 deletions(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > index 061b468512a2..45f2ec3b7f7a 100644
> > > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] 
> > > __initconst = {
> > > { .compatible = "allwinner,sun6i-a31s", },
> > > { .compatible = "allwinner,sun7i-a20", },
> > > { .compatible = "allwinner,sun8i-a23", },
> > > -   { .compatible = "allwinner,sun8i-a33", },
> > > { .compatible = "allwinner,sun8i-a83t", },
> > > { .compatible = "allwinner,sun8i-h3", },
> > 
> > I think "renesas,r8a7795" can be removed again, too.
> > Simon?
> 
> I assume you are referring to "[PATCH 1/2] cpufreq: dt-platdev:
> Automatically create cpufreq device with OPP v2" (which you kindly
> forwarded me). If so, yes, that seems likely. I'll do some testing to
> confirm this.

Yeah, and he probably meant that renesas bits can be removed and
included in this patch 2/2 only.

-- 
viresh

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Simon Horman]

On Wed, Aug 16, 2017 at 08:51:04AM +0200, Geert Uytterhoeven wrote:
> Hi Viresh,
> 
> On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  wrote:
> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > use "operating-points-v2" property from their DT. They should continue
> > to work after this patch.
> >
> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> >
> > Signed-off-by: Viresh Kumar 
> > ---
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index 061b468512a2..45f2ec3b7f7a 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst 
> > = {
> > { .compatible = "allwinner,sun6i-a31s", },
> > { .compatible = "allwinner,sun7i-a20", },
> > { .compatible = "allwinner,sun8i-a23", },
> > -   { .compatible = "allwinner,sun8i-a33", },
> > { .compatible = "allwinner,sun8i-a83t", },
> > { .compatible = "allwinner,sun8i-h3", },
> 
> I think "renesas,r8a7795" can be removed again, too.
> Simon?

I assume you are referring to "[PATCH 1/2] cpufreq: dt-platdev:
Automatically create cpufreq device with OPP v2" (which you kindly
forwarded me). If so, yes, that seems likely. I'll do some testing to
confirm this.

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Simon Horman]

On Wed, Aug 16, 2017 at 08:51:04AM +0200, Geert Uytterhoeven wrote:
> Hi Viresh,
> 
> On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  wrote:
> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > use "operating-points-v2" property from their DT. They should continue
> > to work after this patch.
> >
> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> >
> > Signed-off-by: Viresh Kumar 
> > ---
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index 061b468512a2..45f2ec3b7f7a 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst 
> > = {
> > { .compatible = "allwinner,sun6i-a31s", },
> > { .compatible = "allwinner,sun7i-a20", },
> > { .compatible = "allwinner,sun8i-a23", },
> > -   { .compatible = "allwinner,sun8i-a33", },
> > { .compatible = "allwinner,sun8i-a83t", },
> > { .compatible = "allwinner,sun8i-h3", },
> 
> I think "renesas,r8a7795" can be removed again, too.
> Simon?

I assume you are referring to "[PATCH 1/2] cpufreq: dt-platdev:
Automatically create cpufreq device with OPP v2" (which you kindly
forwarded me). If so, yes, that seems likely. I'll do some testing to
confirm this.

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Viresh Kumar]

On 16-08-17, 16:53, Chen-Yu Tsai wrote:
> On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar  wrote:
> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > use "operating-points-v2" property from their DT. They should continue
> > to work after this patch.
> >
> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> >
> > Signed-off-by: Viresh Kumar 
> > ---
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index 061b468512a2..45f2ec3b7f7a 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst 
> > = {
> > { .compatible = "allwinner,sun6i-a31s", },
> > { .compatible = "allwinner,sun7i-a20", },
> > { .compatible = "allwinner,sun8i-a23", },
> > -   { .compatible = "allwinner,sun8i-a33", },
> > { .compatible = "allwinner,sun8i-a83t", },
> > { .compatible = "allwinner,sun8i-h3", },
> >
> 
> Acked-by: Chen-Yu Tsai 
> 
> In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
> cpufreq implemented. All the other ones are missing thermal sensor support,
> and no OPP tables have been added yet.

Then, why did you guys add all those SoCs there ? :)

-- 
viresh

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Viresh Kumar]

On 16-08-17, 16:53, Chen-Yu Tsai wrote:
> On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar  wrote:
> > Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> > use "operating-points-v2" property from their DT. They should continue
> > to work after this patch.
> >
> > Tested on Hikey platform (only the "hisilicon,hi6220" entry).
> >
> > Signed-off-by: Viresh Kumar 
> > ---
> >  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> > b/drivers/cpufreq/cpufreq-dt-platdev.c
> > index 061b468512a2..45f2ec3b7f7a 100644
> > --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> > +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> > @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst 
> > = {
> > { .compatible = "allwinner,sun6i-a31s", },
> > { .compatible = "allwinner,sun7i-a20", },
> > { .compatible = "allwinner,sun8i-a23", },
> > -   { .compatible = "allwinner,sun8i-a33", },
> > { .compatible = "allwinner,sun8i-a83t", },
> > { .compatible = "allwinner,sun8i-h3", },
> >
> 
> Acked-by: Chen-Yu Tsai 
> 
> In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
> cpufreq implemented. All the other ones are missing thermal sensor support,
> and no OPP tables have been added yet.

Then, why did you guys add all those SoCs there ? :)

-- 
viresh

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Chen-Yu Tsai]

On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar  wrote:
> Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> use "operating-points-v2" property from their DT. They should continue
> to work after this patch.
>
> Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 061b468512a2..45f2ec3b7f7a 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "allwinner,sun6i-a31s", },
> { .compatible = "allwinner,sun7i-a20", },
> { .compatible = "allwinner,sun8i-a23", },
> -   { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> { .compatible = "allwinner,sun8i-h3", },
>

Acked-by: Chen-Yu Tsai 

In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
cpufreq implemented. All the other ones are missing thermal sensor support,
and no OPP tables have been added yet.

ChenYu

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Chen-Yu Tsai]

On Wed, Aug 16, 2017 at 1:37 PM, Viresh Kumar  wrote:
> Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> use "operating-points-v2" property from their DT. They should continue
> to work after this patch.
>
> Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 061b468512a2..45f2ec3b7f7a 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "allwinner,sun6i-a31s", },
> { .compatible = "allwinner,sun7i-a20", },
> { .compatible = "allwinner,sun8i-a23", },
> -   { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> { .compatible = "allwinner,sun8i-h3", },
>

Acked-by: Chen-Yu Tsai 

In fact, we can drop all the sun8i entries. Of them, only sun8i-a33 has
cpufreq implemented. All the other ones are missing thermal sensor support,
and no OPP tables have been added yet.

ChenYu

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Geert Uytterhoeven]

Hi Viresh,

On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  wrote:
> Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> use "operating-points-v2" property from their DT. They should continue
> to work after this patch.
>
> Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 061b468512a2..45f2ec3b7f7a 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "allwinner,sun6i-a31s", },
> { .compatible = "allwinner,sun7i-a20", },
> { .compatible = "allwinner,sun8i-a23", },
> -   { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> { .compatible = "allwinner,sun8i-h3", },

I think "renesas,r8a7795" can be removed again, too.
Simon?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 2/2] cpufreq: dt-platdev: Drop few entries from whitelist

[Geert Uytterhoeven]

Hi Viresh,

On Wed, Aug 16, 2017 at 7:37 AM, Viresh Kumar  wrote:
> Drop few ARM (32 and 64 bit) platforms from the whitelist which always
> use "operating-points-v2" property from their DT. They should continue
> to work after this patch.
>
> Tested on Hikey platform (only the "hisilicon,hi6220" entry).
>
> Signed-off-by: Viresh Kumar 
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c 
> b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 061b468512a2..45f2ec3b7f7a 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -27,7 +27,6 @@ static const struct of_device_id whitelist[] __initconst = {
> { .compatible = "allwinner,sun6i-a31s", },
> { .compatible = "allwinner,sun7i-a20", },
> { .compatible = "allwinner,sun8i-a23", },
> -   { .compatible = "allwinner,sun8i-a33", },
> { .compatible = "allwinner,sun8i-a83t", },
> { .compatible = "allwinner,sun8i-h3", },

I think "renesas,r8a7795" can be removed again, too.
Simon?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds