Re: [PATCH 2/3] xen: split up xen_hvm_init_shared_info()

2017-07-25 Thread Juergen Gross 
On 25/07/17 16:19, Boris Ostrovsky wrote:
> On 07/25/2017 05:50 AM, Juergen Gross wrote:
>>  
>> -void __ref xen_hvm_init_shared_info(void)
>> +void xen_hvm_init_shared_info(void)
> 
> Why are you dropping __ref?

The function no longer calls any __init function.


Juergen

Re: [PATCH 2/3] xen: split up xen_hvm_init_shared_info()

2017-07-25 Thread Juergen Gross 
On 25/07/17 16:19, Boris Ostrovsky wrote:
> On 07/25/2017 05:50 AM, Juergen Gross wrote:
>>  
>> -void __ref xen_hvm_init_shared_info(void)
>> +void xen_hvm_init_shared_info(void)
> 
> Why are you dropping __ref?

The function no longer calls any __init function.


Juergen

Re: [PATCH 2/3] xen: split up xen_hvm_init_shared_info()

2017-07-25 Thread Boris Ostrovsky 
On 07/25/2017 05:50 AM, Juergen Gross wrote:
>  
> -void __ref xen_hvm_init_shared_info(void)
> +void xen_hvm_init_shared_info(void)

Why are you dropping __ref?

-boris

Re: [PATCH 2/3] xen: split up xen_hvm_init_shared_info()

2017-07-25 Thread Boris Ostrovsky 
On 07/25/2017 05:50 AM, Juergen Gross wrote:
>  
> -void __ref xen_hvm_init_shared_info(void)
> +void xen_hvm_init_shared_info(void)

Why are you dropping __ref?

-boris