Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-23 Thread Palmer Dabbelt
On Wed, 07 Jun 2017 00:35:04 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 10:53 PM, Palmer Dabbelt wrote: >> On Tue, 06 Jun 2017 02:31:02 PDT (-0700), Arnd Bergmann wrote: >>> On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: On Fri,

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-23 Thread Palmer Dabbelt
On Wed, 07 Jun 2017 00:35:04 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 10:53 PM, Palmer Dabbelt wrote: >> On Tue, 06 Jun 2017 02:31:02 PDT (-0700), Arnd Bergmann wrote: >>> On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-07 Thread Arnd Bergmann
On Tue, Jun 6, 2017 at 10:53 PM, Palmer Dabbelt wrote: > On Tue, 06 Jun 2017 02:31:02 PDT (-0700), Arnd Bergmann wrote: >> On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >>> On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: On Thu,

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-07 Thread Arnd Bergmann
On Tue, Jun 6, 2017 at 10:53 PM, Palmer Dabbelt wrote: > On Tue, 06 Jun 2017 02:31:02 PDT (-0700), Arnd Bergmann wrote: >> On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >>> On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-06 Thread Palmer Dabbelt
On Tue, 06 Jun 2017 02:31:02 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >> On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: >>> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: On Tue,

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-06 Thread Palmer Dabbelt
On Tue, 06 Jun 2017 02:31:02 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >> On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: >>> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-06 Thread Arnd Bergmann
On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: > On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: >> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >>> On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: On Tue,

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-06 Thread Arnd Bergmann
On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: > On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: >> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >>> On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-05 Thread Palmer Dabbelt
On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: > On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >> On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: >>> On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: > >>> Also,

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-06-05 Thread Palmer Dabbelt
On Fri, 26 May 2017 02:06:58 PDT (-0700), Arnd Bergmann wrote: > On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >> On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: >>> On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: > >>> Also, it would be good to replace the

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-26 Thread Arnd Bergmann
On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: > On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: >> On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> Also, it would be good to replace the multiply+div64 >> with a single

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-26 Thread Arnd Bergmann
On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: > On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: >> On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> Also, it would be good to replace the multiply+div64 >> with a single multiplication here, see how x86 and arm do

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-24 Thread Palmer Dabbelt
On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: > On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile >> new file mode 100644 >> index ..f644e582f4b8 >> --- /dev/null >> +++

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-24 Thread Palmer Dabbelt
On Tue, 23 May 2017 04:19:42 PDT (-0700), Arnd Bergmann wrote: > On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile >> new file mode 100644 >> index ..f644e582f4b8 >> --- /dev/null >> +++ b/arch/riscv/lib/Makefile >

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-23 Thread Palmer Dabbelt
On Tue, 23 May 2017 03:47:34 PDT (-0700), ge...@linux-m68k.org wrote: > Hi Palmer, > > On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> arch/riscv/lib/Makefile | 5 ++ >> arch/riscv/lib/ashldi3.c | 42 > > At least this one has already two

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-23 Thread Palmer Dabbelt
On Tue, 23 May 2017 03:47:34 PDT (-0700), ge...@linux-m68k.org wrote: > Hi Palmer, > > On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: >> arch/riscv/lib/Makefile | 5 ++ >> arch/riscv/lib/ashldi3.c | 42 > > At least this one has already two identical copies in

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-23 Thread Arnd Bergmann
On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: > diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile > new file mode 100644 > index ..f644e582f4b8 > --- /dev/null > +++ b/arch/riscv/lib/Makefile > + > +void __delay(unsigned long cycles) > +{ > +

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-23 Thread Arnd Bergmann
On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: > diff --git a/arch/riscv/lib/Makefile b/arch/riscv/lib/Makefile > new file mode 100644 > index ..f644e582f4b8 > --- /dev/null > +++ b/arch/riscv/lib/Makefile > + > +void __delay(unsigned long cycles) > +{ > + u64 t0 =

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-23 Thread Geert Uytterhoeven
Hi Palmer, On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: > arch/riscv/lib/Makefile | 5 ++ > arch/riscv/lib/ashldi3.c | 42 At least this one has already two identical copies in arch/score/lib/ashldi3.c and arch/sh/lib/ashldi3.c. Probably these

Re: [PATCH 5/7] RISC-V: arch/riscv/lib

2017-05-23 Thread Geert Uytterhoeven
Hi Palmer, On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt wrote: > arch/riscv/lib/Makefile | 5 ++ > arch/riscv/lib/ashldi3.c | 42 At least this one has already two identical copies in arch/score/lib/ashldi3.c and arch/sh/lib/ashldi3.c. Probably these should be moved to