Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Palmer Dabbelt
On Tue, 06 Jun 2017 02:03:51 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >> On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >>> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: On Mon,

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Palmer Dabbelt
On Tue, 06 Jun 2017 02:03:51 PDT (-0700), Arnd Bergmann wrote: > On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: >> On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >>> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: On Mon, 22 May 2017 19:11:35 PDT (-0700),

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Palmer Dabbelt
On Tue, 06 Jun 2017 02:01:23 PDT (-0700), Arnd Bergmann wrote: > On Sat, Jun 3, 2017 at 1:56 AM, Palmer Dabbelt wrote: >> On Tue, 23 May 2017 06:35:23 PDT (-0700), Arnd Bergmann wrote: +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); >>> If you don't care about

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Palmer Dabbelt
On Tue, 06 Jun 2017 02:01:23 PDT (-0700), Arnd Bergmann wrote: > On Sat, Jun 3, 2017 at 1:56 AM, Palmer Dabbelt wrote: >> On Tue, 23 May 2017 06:35:23 PDT (-0700), Arnd Bergmann wrote: +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); >>> If you don't care about LPC/ISA devices,

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Arnd Bergmann
On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: > On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >>> On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: >> >>> *

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Arnd Bergmann
On Tue, Jun 6, 2017 at 6:56 AM, Palmer Dabbelt wrote: > On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: >> On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >>> On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: >> >>> * Definitions like

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Arnd Bergmann
On Sat, Jun 3, 2017 at 1:56 AM, Palmer Dabbelt wrote: > On Tue, 23 May 2017 06:35:23 PDT (-0700), Arnd Bergmann wrote: >>> +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); >> If you don't care about LPC/ISA devices, then your PCI_MIN_IO >> should also be zero

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-06 Thread Arnd Bergmann
On Sat, Jun 3, 2017 at 1:56 AM, Palmer Dabbelt wrote: > On Tue, 23 May 2017 06:35:23 PDT (-0700), Arnd Bergmann wrote: >>> +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); >> If you don't care about LPC/ISA devices, then your PCI_MIN_IO >> should also be zero instead of 0x1000 > >

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-05 Thread Palmer Dabbelt
On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: > On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >> On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: > >> * Parens around single-statement __asm__ macros. For these I also get a >>

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-05 Thread Palmer Dabbelt
On Thu, 25 May 2017 12:51:54 PDT (-0700), Arnd Bergmann wrote: > On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: >> On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: > >> * Parens around single-statement __asm__ macros. For these I also get a >>message when they're

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-02 Thread Palmer Dabbelt
On Thu, 25 May 2017 10:05:05 PDT (-0700), pa...@ucw.cz wrote: >> +static void ci_leaf_init(struct cacheinfo *this_leaf, >> + struct device_node *node, >> + enum cache_type type, unsigned int level) >> +{ >> +this_leaf->of_node = node; >> +

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-02 Thread Palmer Dabbelt
On Thu, 25 May 2017 10:05:05 PDT (-0700), pa...@ucw.cz wrote: >> +static void ci_leaf_init(struct cacheinfo *this_leaf, >> + struct device_node *node, >> + enum cache_type type, unsigned int level) >> +{ >> +this_leaf->of_node = node; >> +

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-02 Thread Palmer Dabbelt
On Tue, 23 May 2017 06:35:23 PDT (-0700), Arnd Bergmann wrote: >> +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); > > Please move the majority of this file into drivers/irqchip as a > standalone driver. OK.

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-06-02 Thread Palmer Dabbelt
On Tue, 23 May 2017 06:35:23 PDT (-0700), Arnd Bergmann wrote: >> +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); > > Please move the majority of this file into drivers/irqchip as a > standalone driver. OK.

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-25 Thread Arnd Bergmann
On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: > On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: > * Parens around single-statement __asm__ macros. For these I also get a >message when they're wrapped in "do {} while (0)", so I'm not sure what >

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-25 Thread Arnd Bergmann
On Thu, May 25, 2017 at 3:59 AM, Palmer Dabbelt wrote: > On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: > * Parens around single-statement __asm__ macros. For these I also get a >message when they're wrapped in "do {} while (0)", so I'm not sure what > else >to do. I

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-25 Thread Pavel Machek
Hi! > +static void ci_leaf_init(struct cacheinfo *this_leaf, > + struct device_node *node, > + enum cache_type type, unsigned int level) > +{ > +this_leaf->of_node = node; > +this_leaf->level = level; > +this_leaf->type =

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-25 Thread Pavel Machek
Hi! > +static void ci_leaf_init(struct cacheinfo *this_leaf, > + struct device_node *node, > + enum cache_type type, unsigned int level) > +{ > +this_leaf->of_node = node; > +this_leaf->level = level; > +this_leaf->type =

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-24 Thread Palmer Dabbelt
On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: > On Mon, May 22, 2017 at 5:41 PM, Palmer Dabbelt wrote: > What's missing from this patchset (ideally) is a good writeup under > DOcumentation/ on expectations of system state (and/or configuration) > upon entry

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-24 Thread Palmer Dabbelt
On Mon, 22 May 2017 19:11:35 PDT (-0700), o...@lixom.net wrote: > On Mon, May 22, 2017 at 5:41 PM, Palmer Dabbelt wrote: > What's missing from this patchset (ideally) is a good writeup under > DOcumentation/ on expectations of system state (and/or configuration) > upon entry of the kernel. For

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-23 Thread Arnd Bergmann
> +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); Please move the majority of this file into drivers/irqchip as a standalone driver. > diff --git a/arch/riscv/kernel/pci.c b/arch/riscv/kernel/pci.c > new file mode 100644 > index ..4191a5ffdd67 > --- /dev/null > +++

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-23 Thread Arnd Bergmann
> +IRQCHIP_DECLARE(riscv, "riscv,cpu-intc", riscv_intc_init); Please move the majority of this file into drivers/irqchip as a standalone driver. > diff --git a/arch/riscv/kernel/pci.c b/arch/riscv/kernel/pci.c > new file mode 100644 > index ..4191a5ffdd67 > --- /dev/null > +++

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-22 Thread Olof Johansson
On Mon, May 22, 2017 at 5:41 PM, Palmer Dabbelt wrote: > --- > arch/riscv/kernel/Makefile | 19 ++ > arch/riscv/kernel/asm-offsets.c| 113 ++ > arch/riscv/kernel/cacheinfo.c | 82 > arch/riscv/kernel/cpu.c| 81 >

Re: [PATCH 6/7] RISC-V: arch/riscv/kernel

2017-05-22 Thread Olof Johansson
On Mon, May 22, 2017 at 5:41 PM, Palmer Dabbelt wrote: > --- > arch/riscv/kernel/Makefile | 19 ++ > arch/riscv/kernel/asm-offsets.c| 113 ++ > arch/riscv/kernel/cacheinfo.c | 82 > arch/riscv/kernel/cpu.c| 81 > arch/riscv/kernel/entry.S