Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-08-29 Thread Keerthy
On Thursday 08 June 2017 07:41 PM, Javier Martinez Canillas wrote: > On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra > wrote: >> Hi Keerthy: >> >> 2017-06-08 12:46 GMT+02:00 Keerthy : >>> Currently the driver boots only via device tree hence add a >>>

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-08-29 Thread Keerthy
On Thursday 08 June 2017 07:41 PM, Javier Martinez Canillas wrote: > On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra > wrote: >> Hi Keerthy: >> >> 2017-06-08 12:46 GMT+02:00 Keerthy : >>> Currently the driver boots only via device tree hence add a >>> dependency on CONFIG_OF. This leaves

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-11 Thread Javier Martinez Canillas
Hello Keerthy, On Sun, Jun 11, 2017 at 8:12 PM, Keerthy wrote: > > > On Sunday 11 June 2017 10:50 AM, Keerthy wrote: >> >> >> On Friday 09 June 2017 05:18 AM, Javier Martinez Canillas wrote: >>> On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: >>> >>> [snip]

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-11 Thread Javier Martinez Canillas
Hello Keerthy, On Sun, Jun 11, 2017 at 8:12 PM, Keerthy wrote: > > > On Sunday 11 June 2017 10:50 AM, Keerthy wrote: >> >> >> On Friday 09 June 2017 05:18 AM, Javier Martinez Canillas wrote: >>> On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: >>> >>> [snip] >>> > >>> >>> -static

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-11 Thread Keerthy
On Sunday 11 June 2017 10:50 AM, Keerthy wrote: > > > On Friday 09 June 2017 05:18 AM, Javier Martinez Canillas wrote: >> On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: >> >> [snip] >> >> >> -static const struct i2c_device_id tps65217_id_table[] = { >> -

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-11 Thread Keerthy
On Sunday 11 June 2017 10:50 AM, Keerthy wrote: > > > On Friday 09 June 2017 05:18 AM, Javier Martinez Canillas wrote: >> On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: >> >> [snip] >> >> >> -static const struct i2c_device_id tps65217_id_table[] = { >> - {"tps65217",

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-10 Thread Keerthy
On Friday 09 June 2017 05:18 AM, Javier Martinez Canillas wrote: > On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: > > [snip] > >>> > > -static const struct i2c_device_id tps65217_id_table[] = { > - {"tps65217", TPS65217}, > - { /* sentinel */ }

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-10 Thread Keerthy
On Friday 09 June 2017 05:18 AM, Javier Martinez Canillas wrote: > On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: > > [snip] > >>> > > -static const struct i2c_device_id tps65217_id_table[] = { > - {"tps65217", TPS65217}, > - { /* sentinel */ } > -}; >

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Javier Martinez Canillas
On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: [snip] >> -static const struct i2c_device_id tps65217_id_table[] = { - {"tps65217", TPS65217}, - { /* sentinel */ } -}; -MODULE_DEVICE_TABLE(i2c, tps65217_id_table); >> >> Unfortunately

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Javier Martinez Canillas
On Fri, Jun 9, 2017 at 1:18 AM, Keerthy wrote: [snip] >> -static const struct i2c_device_id tps65217_id_table[] = { - {"tps65217", TPS65217}, - { /* sentinel */ } -}; -MODULE_DEVICE_TABLE(i2c, tps65217_id_table); >> >> Unfortunately you can't get rid of

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Keerthy
On Thursday 08 June 2017 07:41 PM, Javier Martinez Canillas wrote: > On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra > wrote: >> Hi Keerthy: >> >> 2017-06-08 12:46 GMT+02:00 Keerthy : >>> Currently the driver boots only via device tree hence add a >>>

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Keerthy
On Thursday 08 June 2017 07:41 PM, Javier Martinez Canillas wrote: > On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra > wrote: >> Hi Keerthy: >> >> 2017-06-08 12:46 GMT+02:00 Keerthy : >>> Currently the driver boots only via device tree hence add a >>> dependency on CONFIG_OF. This leaves

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Javier Martinez Canillas
On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra wrote: > Hi Keerthy: > > 2017-06-08 12:46 GMT+02:00 Keerthy : >> Currently the driver boots only via device tree hence add a >> dependency on CONFIG_OF. This leaves with a bunch of unused code >> so clean

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Javier Martinez Canillas
On Thu, Jun 8, 2017 at 3:32 PM, Enric Balletbo Serra wrote: > Hi Keerthy: > > 2017-06-08 12:46 GMT+02:00 Keerthy : >> Currently the driver boots only via device tree hence add a >> dependency on CONFIG_OF. This leaves with a bunch of unused code >> so clean that up. >> >> Signed-off-by: Keerthy

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Enric Balletbo Serra
Hi Keerthy: 2017-06-08 12:46 GMT+02:00 Keerthy : > Currently the driver boots only via device tree hence add a > dependency on CONFIG_OF. This leaves with a bunch of unused code > so clean that up. > > Signed-off-by: Keerthy nit: I think will be good if you

Re: [PATCH v2] mfd: tps65217: Introduce dependency on CONFIG_OF

2017-06-08 Thread Enric Balletbo Serra
Hi Keerthy: 2017-06-08 12:46 GMT+02:00 Keerthy : > Currently the driver boots only via device tree hence add a > dependency on CONFIG_OF. This leaves with a bunch of unused code > so clean that up. > > Signed-off-by: Keerthy nit: I think will be good if you can also mention the change to the