Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Andy Shevchenko]

On Sat, Jul 22, 2017 at 2:02 AM, Darren Hart <dvh...@infradead.org> wrote:
> On Fri, Jul 21, 2017 at 03:29:39AM +, Chakravarty, Souvik K wrote:
>> Just missed the email from Darren.
>
> :-)
>
>> Reviewed-by: Souvik K Chakravarty <souvik.k.chakrava...@intel.com>
>
> Thank you Souvik.
>
> While these one liners are OK for trivial changes like this, please note that
> Andy and I depend on individual driver maintainers to provide thorough 
> reviews,
> and it helps to document that review to help us understand what sorts of 
> things
> you considered before approving the patch. Please keep this in mind in the
> future for more complex changes.
>
> This set is on Andy's queue, so the final review/follow-up will come from him.
>

Pushed both to testing, thanks!

> Thanks,
>
>>
>> > -Original Message-
>> > From: Chakravarty, Souvik K
>> > Sent: Friday, July 21, 2017 8:45 AM
>> > To: 'Rajneesh Bhardwaj' <rajneesh.bhard...@intel.com>; platform-driver-
>> > x...@vger.kernel.org
>> > Cc: dvh...@infradead.org; a...@infradead.org; linux-
>> > ker...@vger.kernel.org; Murthy, Shanth <shanth.mur...@intel.com>;
>> > Bhardwaj, Rajneesh <rajneesh.bhard...@intel.com>
>> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> >
>> > Both set of two looks good. +1.
>> >
>> > > -Original Message-
>> > > From: platform-driver-x86-ow...@vger.kernel.org
>> > > [mailto:platform-driver- x86-ow...@vger.kernel.org] On Behalf Of
>> > > Rajneesh Bhardwaj
>> > > Sent: Thursday, July 20, 2017 7:51 PM
>> > > To: platform-driver-...@vger.kernel.org
>> > > Cc: dvh...@infradead.org; a...@infradead.org; linux-
>> > > ker...@vger.kernel.org; Murthy, Shanth <shanth.mur...@intel.com>;
>> > > Chakravarty, Souvik K <souvik.k.chakrava...@intel.com>; Bhardwaj,
>> > > Rajneesh <rajneesh.bhard...@intel.com>
>> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> > >
>> > > Telemetry driver includes intel_telemetry.h which defines
>> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
>> > >
>> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhard...@intel.com>
>> > > ---
>> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>> > >  1 file changed, 1 deletion(-)
>> > >
>> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > index 6393b3b1d5a6..e0424d5a795a 100644
>> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > @@ -46,7 +46,6 @@
>> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD0xD
>> > >
>> > >  #define TELEM_MAX_EVENTS_SRAM28
>> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS20
>> > >  #define TELEM_SSRAM_STARTTIME_OFFSET 8
>> > >  #define TELEM_SSRAM_EVTLOG_OFFSET16
>> > >
>> > > --
>> > > 2.7.4
>>
>>
>
> --
> Darren Hart
> VMware Open Source Technology Center



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Andy Shevchenko]

On Sat, Jul 22, 2017 at 2:02 AM, Darren Hart  wrote:
> On Fri, Jul 21, 2017 at 03:29:39AM +, Chakravarty, Souvik K wrote:
>> Just missed the email from Darren.
>
> :-)
>
>> Reviewed-by: Souvik K Chakravarty 
>
> Thank you Souvik.
>
> While these one liners are OK for trivial changes like this, please note that
> Andy and I depend on individual driver maintainers to provide thorough 
> reviews,
> and it helps to document that review to help us understand what sorts of 
> things
> you considered before approving the patch. Please keep this in mind in the
> future for more complex changes.
>
> This set is on Andy's queue, so the final review/follow-up will come from him.
>

Pushed both to testing, thanks!

> Thanks,
>
>>
>> > -Original Message-
>> > From: Chakravarty, Souvik K
>> > Sent: Friday, July 21, 2017 8:45 AM
>> > To: 'Rajneesh Bhardwaj' ; platform-driver-
>> > x...@vger.kernel.org
>> > Cc: dvh...@infradead.org; a...@infradead.org; linux-
>> > ker...@vger.kernel.org; Murthy, Shanth ;
>> > Bhardwaj, Rajneesh 
>> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> >
>> > Both set of two looks good. +1.
>> >
>> > > -Original Message-
>> > > From: platform-driver-x86-ow...@vger.kernel.org
>> > > [mailto:platform-driver- x86-ow...@vger.kernel.org] On Behalf Of
>> > > Rajneesh Bhardwaj
>> > > Sent: Thursday, July 20, 2017 7:51 PM
>> > > To: platform-driver-...@vger.kernel.org
>> > > Cc: dvh...@infradead.org; a...@infradead.org; linux-
>> > > ker...@vger.kernel.org; Murthy, Shanth ;
>> > > Chakravarty, Souvik K ; Bhardwaj,
>> > > Rajneesh 
>> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
>> > >
>> > > Telemetry driver includes intel_telemetry.h which defines
>> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
>> > >
>> > > Signed-off-by: Rajneesh Bhardwaj 
>> > > ---
>> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>> > >  1 file changed, 1 deletion(-)
>> > >
>> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > index 6393b3b1d5a6..e0424d5a795a 100644
>> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
>> > > @@ -46,7 +46,6 @@
>> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD0xD
>> > >
>> > >  #define TELEM_MAX_EVENTS_SRAM28
>> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS20
>> > >  #define TELEM_SSRAM_STARTTIME_OFFSET 8
>> > >  #define TELEM_SSRAM_EVTLOG_OFFSET16
>> > >
>> > > --
>> > > 2.7.4
>>
>>
>
> --
> Darren Hart
> VMware Open Source Technology Center



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Darren Hart]

On Fri, Jul 21, 2017 at 03:29:39AM +, Chakravarty, Souvik K wrote:
> Just missed the email from Darren.

:-)

> Reviewed-by: Souvik K Chakravarty <souvik.k.chakrava...@intel.com>

Thank you Souvik.

While these one liners are OK for trivial changes like this, please note that
Andy and I depend on individual driver maintainers to provide thorough reviews,
and it helps to document that review to help us understand what sorts of things
you considered before approving the patch. Please keep this in mind in the
future for more complex changes.

This set is on Andy's queue, so the final review/follow-up will come from him.

Thanks,

> 
> > -Original Message-
> > From: Chakravarty, Souvik K
> > Sent: Friday, July 21, 2017 8:45 AM
> > To: 'Rajneesh Bhardwaj' <rajneesh.bhard...@intel.com>; platform-driver-
> > x...@vger.kernel.org
> > Cc: dvh...@infradead.org; a...@infradead.org; linux-
> > ker...@vger.kernel.org; Murthy, Shanth <shanth.mur...@intel.com>;
> > Bhardwaj, Rajneesh <rajneesh.bhard...@intel.com>
> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > 
> > Both set of two looks good. +1.
> > 
> > > -Original Message-
> > > From: platform-driver-x86-ow...@vger.kernel.org
> > > [mailto:platform-driver- x86-ow...@vger.kernel.org] On Behalf Of
> > > Rajneesh Bhardwaj
> > > Sent: Thursday, July 20, 2017 7:51 PM
> > > To: platform-driver-...@vger.kernel.org
> > > Cc: dvh...@infradead.org; a...@infradead.org; linux-
> > > ker...@vger.kernel.org; Murthy, Shanth <shanth.mur...@intel.com>;
> > > Chakravarty, Souvik K <souvik.k.chakrava...@intel.com>; Bhardwaj,
> > > Rajneesh <rajneesh.bhard...@intel.com>
> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > >
> > > Telemetry driver includes intel_telemetry.h which defines
> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> > >
> > > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhard...@intel.com>
> > > ---
> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > index 6393b3b1d5a6..e0424d5a795a 100644
> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > @@ -46,7 +46,6 @@
> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD0xD
> > >
> > >  #define TELEM_MAX_EVENTS_SRAM28
> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS20
> > >  #define TELEM_SSRAM_STARTTIME_OFFSET 8
> > >  #define TELEM_SSRAM_EVTLOG_OFFSET16
> > >
> > > --
> > > 2.7.4
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Darren Hart]

On Fri, Jul 21, 2017 at 03:29:39AM +, Chakravarty, Souvik K wrote:
> Just missed the email from Darren.

:-)

> Reviewed-by: Souvik K Chakravarty 

Thank you Souvik.

While these one liners are OK for trivial changes like this, please note that
Andy and I depend on individual driver maintainers to provide thorough reviews,
and it helps to document that review to help us understand what sorts of things
you considered before approving the patch. Please keep this in mind in the
future for more complex changes.

This set is on Andy's queue, so the final review/follow-up will come from him.

Thanks,

> 
> > -Original Message-
> > From: Chakravarty, Souvik K
> > Sent: Friday, July 21, 2017 8:45 AM
> > To: 'Rajneesh Bhardwaj' ; platform-driver-
> > x...@vger.kernel.org
> > Cc: dvh...@infradead.org; a...@infradead.org; linux-
> > ker...@vger.kernel.org; Murthy, Shanth ;
> > Bhardwaj, Rajneesh 
> > Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > 
> > Both set of two looks good. +1.
> > 
> > > -Original Message-
> > > From: platform-driver-x86-ow...@vger.kernel.org
> > > [mailto:platform-driver- x86-ow...@vger.kernel.org] On Behalf Of
> > > Rajneesh Bhardwaj
> > > Sent: Thursday, July 20, 2017 7:51 PM
> > > To: platform-driver-...@vger.kernel.org
> > > Cc: dvh...@infradead.org; a...@infradead.org; linux-
> > > ker...@vger.kernel.org; Murthy, Shanth ;
> > > Chakravarty, Souvik K ; Bhardwaj,
> > > Rajneesh 
> > > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> > >
> > > Telemetry driver includes intel_telemetry.h which defines
> > > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> > >
> > > Signed-off-by: Rajneesh Bhardwaj 
> > > ---
> > >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > index 6393b3b1d5a6..e0424d5a795a 100644
> > > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > > @@ -46,7 +46,6 @@
> > >  #define TELEM_SAMPLING_DEFAULT_PERIOD0xD
> > >
> > >  #define TELEM_MAX_EVENTS_SRAM28
> > > -#define TELEM_MAX_OS_ALLOCATED_EVENTS20
> > >  #define TELEM_SSRAM_STARTTIME_OFFSET 8
> > >  #define TELEM_SSRAM_EVTLOG_OFFSET16
> > >
> > > --
> > > 2.7.4
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center

RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Chakravarty, Souvik K]

Just missed the email from Darren.

Reviewed-by: Souvik K Chakravarty <souvik.k.chakrava...@intel.com>

> -Original Message-
> From: Chakravarty, Souvik K
> Sent: Friday, July 21, 2017 8:45 AM
> To: 'Rajneesh Bhardwaj' <rajneesh.bhard...@intel.com>; platform-driver-
> x...@vger.kernel.org
> Cc: dvh...@infradead.org; a...@infradead.org; linux-
> ker...@vger.kernel.org; Murthy, Shanth <shanth.mur...@intel.com>;
> Bhardwaj, Rajneesh <rajneesh.bhard...@intel.com>
> Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Both set of two looks good. +1.
> 
> > -Original Message-
> > From: platform-driver-x86-ow...@vger.kernel.org
> > [mailto:platform-driver- x86-ow...@vger.kernel.org] On Behalf Of
> > Rajneesh Bhardwaj
> > Sent: Thursday, July 20, 2017 7:51 PM
> > To: platform-driver-...@vger.kernel.org
> > Cc: dvh...@infradead.org; a...@infradead.org; linux-
> > ker...@vger.kernel.org; Murthy, Shanth <shanth.mur...@intel.com>;
> > Chakravarty, Souvik K <souvik.k.chakrava...@intel.com>; Bhardwaj,
> > Rajneesh <rajneesh.bhard...@intel.com>
> > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> >
> > Telemetry driver includes intel_telemetry.h which defines
> > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> >
> > Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhard...@intel.com>
> > ---
> >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > index 6393b3b1d5a6..e0424d5a795a 100644
> > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > @@ -46,7 +46,6 @@
> >  #define TELEM_SAMPLING_DEFAULT_PERIOD  0xD
> >
> >  #define TELEM_MAX_EVENTS_SRAM  28
> > -#define TELEM_MAX_OS_ALLOCATED_EVENTS  20
> >  #define TELEM_SSRAM_STARTTIME_OFFSET   8
> >  #define TELEM_SSRAM_EVTLOG_OFFSET  16
> >
> > --
> > 2.7.4

RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Chakravarty, Souvik K]

Just missed the email from Darren.

Reviewed-by: Souvik K Chakravarty 

> -Original Message-
> From: Chakravarty, Souvik K
> Sent: Friday, July 21, 2017 8:45 AM
> To: 'Rajneesh Bhardwaj' ; platform-driver-
> x...@vger.kernel.org
> Cc: dvh...@infradead.org; a...@infradead.org; linux-
> ker...@vger.kernel.org; Murthy, Shanth ;
> Bhardwaj, Rajneesh 
> Subject: RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Both set of two looks good. +1.
> 
> > -Original Message-
> > From: platform-driver-x86-ow...@vger.kernel.org
> > [mailto:platform-driver- x86-ow...@vger.kernel.org] On Behalf Of
> > Rajneesh Bhardwaj
> > Sent: Thursday, July 20, 2017 7:51 PM
> > To: platform-driver-...@vger.kernel.org
> > Cc: dvh...@infradead.org; a...@infradead.org; linux-
> > ker...@vger.kernel.org; Murthy, Shanth ;
> > Chakravarty, Souvik K ; Bhardwaj,
> > Rajneesh 
> > Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> >
> > Telemetry driver includes intel_telemetry.h which defines
> > TELEM_MAX_OS_ALLOCATED_EVENTS already.
> >
> > Signed-off-by: Rajneesh Bhardwaj 
> > ---
> >  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > index 6393b3b1d5a6..e0424d5a795a 100644
> > --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> > +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> > @@ -46,7 +46,6 @@
> >  #define TELEM_SAMPLING_DEFAULT_PERIOD  0xD
> >
> >  #define TELEM_MAX_EVENTS_SRAM  28
> > -#define TELEM_MAX_OS_ALLOCATED_EVENTS  20
> >  #define TELEM_SSRAM_STARTTIME_OFFSET   8
> >  #define TELEM_SSRAM_EVTLOG_OFFSET  16
> >
> > --
> > 2.7.4

RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Chakravarty, Souvik K]

Both set of two looks good. +1.

> -Original Message-
> From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-
> x86-ow...@vger.kernel.org] On Behalf Of Rajneesh Bhardwaj
> Sent: Thursday, July 20, 2017 7:51 PM
> To: platform-driver-...@vger.kernel.org
> Cc: dvh...@infradead.org; a...@infradead.org; linux-
> ker...@vger.kernel.org; Murthy, Shanth ;
> Chakravarty, Souvik K ; Bhardwaj,
> Rajneesh 
> Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Telemetry driver includes intel_telemetry.h which defines
> TELEM_MAX_OS_ALLOCATED_EVENTS already.
> 
> Signed-off-by: Rajneesh Bhardwaj 
> ---
>  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 6393b3b1d5a6..e0424d5a795a 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -46,7 +46,6 @@
>  #define TELEM_SAMPLING_DEFAULT_PERIOD0xD
> 
>  #define TELEM_MAX_EVENTS_SRAM28
> -#define TELEM_MAX_OS_ALLOCATED_EVENTS20
>  #define TELEM_SSRAM_STARTTIME_OFFSET 8
>  #define TELEM_SSRAM_EVTLOG_OFFSET16
> 
> --
> 2.7.4

RE: [PATCH v2 2/2] Telemetry: remove redundant macro definition

[Chakravarty, Souvik K]

Both set of two looks good. +1.

> -Original Message-
> From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-
> x86-ow...@vger.kernel.org] On Behalf Of Rajneesh Bhardwaj
> Sent: Thursday, July 20, 2017 7:51 PM
> To: platform-driver-...@vger.kernel.org
> Cc: dvh...@infradead.org; a...@infradead.org; linux-
> ker...@vger.kernel.org; Murthy, Shanth ;
> Chakravarty, Souvik K ; Bhardwaj,
> Rajneesh 
> Subject: [PATCH v2 2/2] Telemetry: remove redundant macro definition
> 
> Telemetry driver includes intel_telemetry.h which defines
> TELEM_MAX_OS_ALLOCATED_EVENTS already.
> 
> Signed-off-by: Rajneesh Bhardwaj 
> ---
>  drivers/platform/x86/intel_telemetry_pltdrv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 6393b3b1d5a6..e0424d5a795a 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -46,7 +46,6 @@
>  #define TELEM_SAMPLING_DEFAULT_PERIOD0xD
> 
>  #define TELEM_MAX_EVENTS_SRAM28
> -#define TELEM_MAX_OS_ALLOCATED_EVENTS20
>  #define TELEM_SSRAM_STARTTIME_OFFSET 8
>  #define TELEM_SSRAM_EVTLOG_OFFSET16
> 
> --
> 2.7.4