Re: [PATCH] Correcting the spelling mistake in selftests drivers/net testing

2024-02-27 Thread Jiri Pirko
Please fix the patch subject to include appropriate prefixes and rephrase a bit like this: Subject: [PATCH net-next] selftests: net: Correct couple of spelling mistakes pw-bot: cr Tue, Feb 27, 2024 at 06:55:13PM CET, pvkumar5749...@gmail.com wrote: >Changes : > - "excercise" is corrected

kselftest/next kselftest-lkdtm: 2 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f)

2024-02-27 Thread kernelci.org bot
kselftest/next kselftest-lkdtm: 2 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions

kselftest/next kselftest-livepatch: 1 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f)

2024-02-27 Thread kernelci.org bot
kselftest/next kselftest-livepatch: 1 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f) Regressions Summary --- platform| arch | lab | compiler | defconfig | regressions

kselftest/next build: 5 builds: 2 failed, 3 passed, 2 errors, 5 warnings (v6.8-rc1-56-g539cd3f4da3f)

2024-02-27 Thread kernelci.org bot
kselftest/next build: 5 builds: 2 failed, 3 passed, 2 errors, 5 warnings (v6.8-rc1-56-g539cd3f4da3f) Full Build Summary: https://kernelci.org/build/kselftest/branch/next/kernel/v6.8-rc1-56-g539cd3f4da3f/ Tree: kselftest Branch: next Git Describe: v6.8-rc1-56-g539cd3f4da3f Git Commit:

[PATCH v2] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-27 Thread David Gow
The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable is logged by some KUNIT_ASSERT_EQ_MSG() using the '%d' or '%llu' format specifiers, the former of which

Re: [PATCH RFC bpf-next v3 08/16] bpf/verifier: do_misc_fixups for is_bpf_timer_set_sleepable_cb_kfunc

2024-02-27 Thread Alexei Starovoitov
On Tue, Feb 27, 2024 at 8:51 AM Benjamin Tissoires wrote: > > On Tue, Feb 27, 2024 at 5:36 PM Eduard Zingerman wrote: > > > > On Tue, 2024-02-27 at 17:18 +0100, Benjamin Tissoires wrote: > > [...] > > > > > Hmm, I must still be missing a piece of the puzzle: > > > if I declare

Re: [PATCH v2 0/4] Improvements to livepatch kselftests on top of kselftest-next

2024-02-27 Thread Shuah Khan
On 2/21/24 10:17, Marcos Paulo de Souza wrote: The changes on lib.mk are both for simplification and also clarification, like in the case of not handling TEST_GEN_MODS_DIR directly. There is a new patch to solve one issue reported by build bot. These changes apply on top of the current

Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest

2024-02-27 Thread Shuah Khan
On 2/26/24 02:28, Maciej Wieczor-Retman wrote: Hi Shuah, On 2024-02-23 at 15:37:11 -0700, Shuah Khan wrote: Hi Reinette, Okay ran a quick test. Why does this test leave "/sys/fs/resctrl" mounted when it exits. Can we fix this to unmount before the test exits? I also wasn't able to

Re: [PATCH v4] kselftest: Add basic test for probing the rust sample modules

2024-02-27 Thread Shuah Khan
Hi Laura, On 2/26/24 03:16, Laura Nao wrote: Add new basic kselftest that checks if the available rust sample modules can be added and removed correctly. Signed-off-by: Laura Nao Reviewed-by: Sergio Gonzalez Collado Reviewed-by: Muhammad Usama Anjum --- Depends on: -

Re: [PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

2024-02-27 Thread Shuah Khan
On 2/21/24 02:27, David Gow wrote: KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and

Re: [PATCH 7/9] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-27 Thread Shuah Khan
On 2/21/24 14:29, Justin Stitt wrote: Hi, On Wed, Feb 21, 2024 at 05:27:20PM +0800, David Gow wrote: The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Alexandre Belloni
On 27/02/2024 14:23:29-0700, Shuah Khan wrote: > On 2/27/24 13:32, Alexandre Belloni wrote: > > Hello, > > > > On 21/02/2024 17:27:18+0800, David Gow wrote: > > > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > > > > > This was found by extending KUnit's assertion macros

Re: [BUG] selftests: cgroup: KMEMLEAK in cgroup/test_cpuset_prs.sh

2024-02-27 Thread Waiman Long
On 2/27/24 14:50, Mirsad Todorovac wrote: Hi, everybody, In the latest vanilla torvalds tree kernel v6.8-rc6-11-g45ec2f5f6ed3 on an Ubuntu 23.10 system, there KMEMLEAK detected a couple of memory leaks: Visually it appears like the same leak repeated six times, but I reckoned it might be of

Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

2024-02-27 Thread Shuah Khan
On 2/27/24 14:20, Andrei Vagin wrote: On Tue, Feb 27, 2024 at 8:41 AM Shuah Khan wrote: On 2/27/24 00:42, Meng Li wrote: make -C tools/testing/selftests, compiling dev_in_maps fail. In file included from dev_in_maps.c:10: /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Shuah Khan
On 2/27/24 13:32, Alexandre Belloni wrote: Hello, On 21/02/2024 17:27:18+0800, David Gow wrote: 'days' is a s64 (from div_s64), and so should use a %lld specifier. This was found by extending KUnit's assertion macros to use gcc's __printf attribute. Fixes: 1d1bb12a8b18 ("rtc: Improve

Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

2024-02-27 Thread Andrei Vagin
On Tue, Feb 27, 2024 at 8:41 AM Shuah Khan wrote: > > On 2/27/24 00:42, Meng Li wrote: > > make -C tools/testing/selftests, compiling dev_in_maps fail. > > In file included from dev_in_maps.c:10: > > /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier > > before numeric

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Alexandre Belloni
Hello, On 21/02/2024 17:27:18+0800, David Gow wrote: > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > This was found by extending KUnit's assertion macros to use gcc's > __printf attribute. > > Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add >

[BUG] selftests: cgroup: KMEMLEAK in cgroup/test_cpuset_prs.sh

2024-02-27 Thread Mirsad Todorovac
Hi, everybody, In the latest vanilla torvalds tree kernel v6.8-rc6-11-g45ec2f5f6ed3 on an Ubuntu 23.10 system, there KMEMLEAK detected a couple of memory leaks: Visually it appears like the same leak repeated six times, but I reckoned it might be of importance to review them all. It happened

Re: [PATCH] kunit: tool: add parsing of all files in directory

2024-02-27 Thread Rae Moar
On Thu, Feb 22, 2024 at 6:37 PM Daniel Latypov wrote: > > On Thu, Feb 22, 2024 at 2:18 PM Rae Moar wrote: > > > > Add ability to parse all files within a directory. Additionally add the > > ability to parse all results in the KUnit debugfs repository. > > Nice, I'd been hoping for this. > It's

Re: [PATCH v8 33/38] kselftest/arm64: Add a GCS test program built with the system libc

2024-02-27 Thread Thiago Jung Bauermann
Mark Brown writes: > [[PGP Signed Part:Undecided]] > On Thu, Feb 22, 2024 at 11:24:59PM -0300, Thiago Jung Bauermann wrote: >> Mark Brown writes: > >> My rootfs is Ubuntu 22.04.3. In case it's useful, my kernel config is >> here: > >>

[PATCH] Correcting the spelling mistake in selftests drivers/net testing

2024-02-27 Thread Prabhav Kumar Vaish
Changes : - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh Signed-off-by: Prabhav Kumar Vaish ---

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-27 Thread Mark Rutland
On Fri, Feb 23, 2024 at 11:17:02AM -0700, Rob Herring wrote: > On Fri, Feb 23, 2024 at 3:23 AM Will Deacon wrote: > > > > On Thu, Feb 22, 2024 at 05:03:17PM -0700, Rob Herring wrote: > > > On Fri, Feb 16, 2024 at 05:05:54PM -0800, Stephen Boyd wrote: > > > > Call this function unconditionally so

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-02-27 Thread Oreoluwa Babatunde
On 2/16/2024 5:05 PM, Stephen Boyd wrote: > Call this function unconditionally so that we can populate an empty DTB > on platforms that don't boot with a firmware provided or builtin DTB. > When ACPI is in use, unflatten_device_tree() ignores the > 'initial_boot_params' pointer so the live DT on

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-27 Thread T.J. Mercier
On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum wrote: > > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v1: > - Update some more error

[PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names

2024-02-27 Thread Ido Schimmel
Rename some test cases to avoid overlapping test names which is problematic for the kernel test robot. No changes in the test's logic. Suggested-by: Yujie Liu Signed-off-by: Ido Schimmel --- Yujie Liu, please verify this works for you. --- tools/testing/selftests/net/test_vxlan_mdb.sh | 36

Re: [PATCH RFC bpf-next v3 08/16] bpf/verifier: do_misc_fixups for is_bpf_timer_set_sleepable_cb_kfunc

2024-02-27 Thread Benjamin Tissoires
On Tue, Feb 27, 2024 at 5:36 PM Eduard Zingerman wrote: > > On Tue, 2024-02-27 at 17:18 +0100, Benjamin Tissoires wrote: > [...] > > > Hmm, I must still be missing a piece of the puzzle: > > if I declare bpf_timer_set_sleepable_cb() to take a third "aux" > > argument, given that it is declared as

Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

2024-02-27 Thread Shuah Khan
On 2/27/24 00:42, Meng Li wrote: make -C tools/testing/selftests, compiling dev_in_maps fail. In file included from dev_in_maps.c:10: /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant 35 | MS_RDONLY = 1,/* Mount read-only.

Re: [PATCH v5 0/3] selftests/resctrl: Simplify test cleanup functions

2024-02-27 Thread Reinette Chatre
Hi Shuah, Could you please consider this series for inclusion? I do admit that there has been a lot of resctrl selftest work recently. This should be it for a while as new work is still being worked on. Thank you very much. Reinette On 2/26/2024 11:21 PM, Maciej Wieczor-Retman wrote: >

Re: [PATCH RFC bpf-next v3 08/16] bpf/verifier: do_misc_fixups for is_bpf_timer_set_sleepable_cb_kfunc

2024-02-27 Thread Eduard Zingerman
On Tue, 2024-02-27 at 17:18 +0100, Benjamin Tissoires wrote: [...] > Hmm, I must still be missing a piece of the puzzle: > if I declare bpf_timer_set_sleepable_cb() to take a third "aux" > argument, given that it is declared as kfunc, I also must declare it in > my bpf program, or I get the

Re: [PATCH RFC bpf-next v3 08/16] bpf/verifier: do_misc_fixups for is_bpf_timer_set_sleepable_cb_kfunc

2024-02-27 Thread Benjamin Tissoires
On Feb 23 2024, Eduard Zingerman wrote: > On Wed, 2024-02-21 at 17:25 +0100, Benjamin Tissoires wrote: > > This is still a WIP, but I think this can be dropped as we never > > get to this instruction. So what should we do here? > > As Alexei replied in a separate sub-thread you probably want this

Re: [PATCH v8 33/38] kselftest/arm64: Add a GCS test program built with the system libc

2024-02-27 Thread Mark Brown
On Thu, Feb 22, 2024 at 11:24:59PM -0300, Thiago Jung Bauermann wrote: > Mark Brown writes: > My rootfs is Ubuntu 22.04.3. In case it's useful, my kernel config is > here: > https://people.linaro.org/~thiago.bauermann/gcs/config-v6.8.0-rc2 Does using defconfig make a difference for you? >

Re: [PATCH] cpufreq: amd-pstate: adjust min/max limit perf

2024-02-27 Thread Mario Limonciello
On 2/27/2024 01:39, Meng Li wrote: The min/max limit perf values calculated based on frequency may exceed the reasonable range of perf(highest perf, lowest perf). Signed-off-by: Meng Li Reviewed-by: Mario Limonciello --- drivers/cpufreq/amd-pstate.c | 15 ++- 1 file changed,

Re: [PATCH RFC bpf-next v3 04/16] bpf/helpers: introduce sleepable bpf_timers

2024-02-27 Thread Benjamin Tissoires
On Feb 23 2024, Eduard Zingerman wrote: > On Wed, 2024-02-21 at 17:25 +0100, Benjamin Tissoires wrote: > > [...] > > > @@ -1282,7 +1333,7 @@ BPF_CALL_3(bpf_timer_start, struct bpf_timer_kern *, > > timer, u64, nsecs, u64, fla > > > > if (in_nmi()) > > return -EOPNOTSUPP; > > -

Re: [PATCH v5 0/3] selftests/resctrl: Simplify test cleanup functions

2024-02-27 Thread Ilpo Järvinen
On Tue, 27 Feb 2024, Maciej Wieczor-Retman wrote: > Cleaning up after tests is implemented separately for individual tests > and called at the end of each test execution. Since these functions are > very similar and a more generalized test framework was introduced a > function pointer in the

Re: [RFC PATCH] selftest/powerpc: Add rule file to address sub-folder test fail

2024-02-27 Thread Sachin Sant
> On 25-Feb-2024, at 10:09 PM, Madhavan Srinivasan wrote: > > When running `make -C powerpc/pmu run_tests` from top level selftests > directory, currently this error is being reported > > make: Entering directory > '/home/maddy/linux/tools/testing/selftests/powerpc/pmu' > Makefile:40:

[PATCH v2 2/2] selftests: dmabuf-heap: add config file for the test

2024-02-27 Thread Muhammad Usama Anjum
The config fragment enlists all the config options needed for the test. This config is merged into the kernel's config on which this test is run. Reviewed-by: T.J. Mercier Signed-off-by: Muhammad Usama Anjum --- Changes since v1: - Add reviewed-by tag ---

[PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-27 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- Changes since v1: - Update some more error handling code --- .../selftests/dmabuf-heaps/dmabuf-heap.c | 217

Re: [PATCH 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-27 Thread Muhammad Usama Anjum
On 2/27/24 6:52 AM, T.J. Mercier wrote: > On Sun, Feb 25, 2024 at 11:59 PM Muhammad Usama Anjum > wrote: >> >> Conform the layout, informational and status messages to TAP. No >> functional change is intended other than the layout of output messages. >> >> Signed-off-by: Muhammad Usama Anjum >>