Re: [PATCH bpf-next v2 11/16] bpf: wq: add bpf_wq_init

2024-04-25 Thread Benjamin Tissoires
On Apr 24 2024, Alexei Starovoitov wrote: > On Wed, Apr 24, 2024 at 8:06 AM Alexei Starovoitov > wrote: > > > > On Tue, Apr 23, 2024 at 7:55 PM Alexei Starovoitov > > wrote: > > > > > > On Sat, Apr 20, 2024 at 2:10 AM Benjamin Tissoires > > > wrote: > > > > > > > > We need to teach the

Re: [PATCH bpf-next v2 11/16] bpf: wq: add bpf_wq_init

2024-04-24 Thread Alexei Starovoitov
On Wed, Apr 24, 2024 at 8:06 AM Alexei Starovoitov wrote: > > On Tue, Apr 23, 2024 at 7:55 PM Alexei Starovoitov > wrote: > > > > On Sat, Apr 20, 2024 at 2:10 AM Benjamin Tissoires > > wrote: > > > > > > We need to teach the verifier about the second argument which is declared > > > as void *

Re: [PATCH bpf-next v2 11/16] bpf: wq: add bpf_wq_init

2024-04-24 Thread Alexei Starovoitov
On Tue, Apr 23, 2024 at 7:55 PM Alexei Starovoitov wrote: > > On Sat, Apr 20, 2024 at 2:10 AM Benjamin Tissoires wrote: > > > > We need to teach the verifier about the second argument which is declared > > as void * but which is of type KF_ARG_PTR_TO_MAP. We could have dropped > > this extra

Re: [PATCH bpf-next v2 11/16] bpf: wq: add bpf_wq_init

2024-04-23 Thread Alexei Starovoitov
On Sat, Apr 20, 2024 at 2:10 AM Benjamin Tissoires wrote: > > We need to teach the verifier about the second argument which is declared > as void * but which is of type KF_ARG_PTR_TO_MAP. We could have dropped > this extra case if we declared the second argument as struct bpf_map *, > but that

[PATCH bpf-next v2 11/16] bpf: wq: add bpf_wq_init

2024-04-20 Thread Benjamin Tissoires
We need to teach the verifier about the second argument which is declared as void * but which is of type KF_ARG_PTR_TO_MAP. We could have dropped this extra case if we declared the second argument as struct bpf_map *, but that means users will have to do extra casting to have their program