Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Alexei Starovoitov
On Thu, Dec 14, 2023 at 12:24 PM Daniel Xu wrote: > > > Looks like only x86 supports exceptions (looking at > bpf_jit_supports_exceptions()). > > This causes selftests in this patchset to fail on !x86, which is > unfortunate. We probably want to be running these tests on all the major > archs, so

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Daniel Xu
On Thu, Dec 14, 2023 at 11:23:02AM -0700, Daniel Xu wrote: > On Thu, Dec 14, 2023 at 05:16:08PM +0100, Kumar Kartikeya Dwivedi wrote: > > On Thu, 14 Dec 2023 at 17:08, Kumar Kartikeya Dwivedi > > wrote: > > > > > > On Thu, 14 Dec 2023 at 00:49, Eyal Birger wrote: > > > > > > > > On Wed, Dec 13,

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Daniel Xu
On Thu, Dec 14, 2023 at 05:16:08PM +0100, Kumar Kartikeya Dwivedi wrote: > On Thu, 14 Dec 2023 at 17:08, Kumar Kartikeya Dwivedi > wrote: > > > > On Thu, 14 Dec 2023 at 00:49, Eyal Birger wrote: > > > > > > On Wed, Dec 13, 2023 at 3:15 PM Daniel Xu wrote: > > > > > > [...] > > > > > > > > > >

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Kumar Kartikeya Dwivedi
On Thu, 14 Dec 2023 at 17:08, Kumar Kartikeya Dwivedi wrote: > > On Thu, 14 Dec 2023 at 00:49, Eyal Birger wrote: > > > > On Wed, Dec 13, 2023 at 3:15 PM Daniel Xu wrote: > > > > > [...] > > > > > > > > > > diff --git a/tools/testing/selftests/bpf/progs/test_tunnel_kern.c > > > > >

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Kumar Kartikeya Dwivedi
On Thu, 14 Dec 2023 at 00:49, Eyal Birger wrote: > > On Wed, Dec 13, 2023 at 3:15 PM Daniel Xu wrote: > > > > [...] > > > > > > > > diff --git a/tools/testing/selftests/bpf/progs/test_tunnel_kern.c > > > > b/tools/testing/selftests/bpf/progs/test_tunnel_kern.c > > > > index

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-13 Thread Eyal Birger
On Wed, Dec 13, 2023 at 3:15 PM Daniel Xu wrote: > > On Wed, Dec 13, 2023 at 12:13:51AM +0100, Kumar Kartikeya Dwivedi wrote: > > On Tue, 12 Dec 2023 at 20:52, Daniel Xu wrote: > > > > > > cc Kumar > > > > > > On Tue, Dec 12, 2023 at 09:17:02AM -0700, Daniel Xu wrote: > > > > On Mon, Dec 11,

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-13 Thread Daniel Xu
On Wed, Dec 13, 2023 at 12:13:51AM +0100, Kumar Kartikeya Dwivedi wrote: > On Tue, 12 Dec 2023 at 20:52, Daniel Xu wrote: > > > > cc Kumar > > > > On Tue, Dec 12, 2023 at 09:17:02AM -0700, Daniel Xu wrote: > > > On Mon, Dec 11, 2023 at 04:25:06PM -0800, Eyal Birger wrote: > > > > On Mon, Dec 11,

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-12 Thread Kumar Kartikeya Dwivedi
On Tue, 12 Dec 2023 at 20:52, Daniel Xu wrote: > > cc Kumar > > On Tue, Dec 12, 2023 at 09:17:02AM -0700, Daniel Xu wrote: > > On Mon, Dec 11, 2023 at 04:25:06PM -0800, Eyal Birger wrote: > > > On Mon, Dec 11, 2023 at 3:49 PM Daniel Xu wrote: > > > > > > > > On Mon, Dec 11, 2023 at 03:13:07PM

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-12 Thread Daniel Xu
cc Kumar On Tue, Dec 12, 2023 at 09:17:02AM -0700, Daniel Xu wrote: > On Mon, Dec 11, 2023 at 04:25:06PM -0800, Eyal Birger wrote: > > On Mon, Dec 11, 2023 at 3:49 PM Daniel Xu wrote: > > > > > > On Mon, Dec 11, 2023 at 03:13:07PM -0800, Eyal Birger wrote: > > > > On Mon, Dec 11, 2023 at 2:31 PM

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-12 Thread Daniel Xu
On Tue, Dec 12, 2023 at 08:44:42AM -0800, Alexei Starovoitov wrote: > On Tue, Dec 12, 2023 at 8:17 AM Daniel Xu wrote: > > > > > > If you don't mind (and there no more comments), I would prefer to send a > > follow up fixing the nits in this revision. So that I stop blasting the > > list (as well

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-12 Thread Alexei Starovoitov
On Tue, Dec 12, 2023 at 8:17 AM Daniel Xu wrote: > > > If you don't mind (and there no more comments), I would prefer to send a > follow up fixing the nits in this revision. So that I stop blasting the > list (as well as people who may not be as concerned with these details). Resending patches

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-12 Thread Daniel Xu
On Mon, Dec 11, 2023 at 04:25:06PM -0800, Eyal Birger wrote: > On Mon, Dec 11, 2023 at 3:49 PM Daniel Xu wrote: > > > > On Mon, Dec 11, 2023 at 03:13:07PM -0800, Eyal Birger wrote: > > > On Mon, Dec 11, 2023 at 2:31 PM Daniel Xu wrote: > > > > > > > > On Mon, Dec 11, 2023 at 01:39:25PM -0800,

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-11 Thread Eyal Birger
On Mon, Dec 11, 2023 at 3:49 PM Daniel Xu wrote: > > On Mon, Dec 11, 2023 at 03:13:07PM -0800, Eyal Birger wrote: > > On Mon, Dec 11, 2023 at 2:31 PM Daniel Xu wrote: > > > > > > On Mon, Dec 11, 2023 at 01:39:25PM -0800, Eyal Birger wrote: > > > > Hi Daniel, > > > > > > > > Tiny nits below in

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-11 Thread Daniel Xu
On Mon, Dec 11, 2023 at 03:13:07PM -0800, Eyal Birger wrote: > On Mon, Dec 11, 2023 at 2:31 PM Daniel Xu wrote: > > > > On Mon, Dec 11, 2023 at 01:39:25PM -0800, Eyal Birger wrote: > > > Hi Daniel, > > > > > > Tiny nits below in case you respin this for other reasons: > > > > > > On Mon, Dec 11,

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-11 Thread Eyal Birger
On Mon, Dec 11, 2023 at 2:31 PM Daniel Xu wrote: > > On Mon, Dec 11, 2023 at 01:39:25PM -0800, Eyal Birger wrote: > > Hi Daniel, > > > > Tiny nits below in case you respin this for other reasons: > > > > On Mon, Dec 11, 2023 at 12:20 PM Daniel Xu wrote: > > > > > > This commit extends

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-11 Thread Daniel Xu
On Mon, Dec 11, 2023 at 01:39:25PM -0800, Eyal Birger wrote: > Hi Daniel, > > Tiny nits below in case you respin this for other reasons: > > On Mon, Dec 11, 2023 at 12:20 PM Daniel Xu wrote: > > > > This commit extends test_tunnel selftest to test the new XDP xfrm state > > lookup kfunc. > > >

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-11 Thread Eyal Birger
Hi Daniel, Tiny nits below in case you respin this for other reasons: On Mon, Dec 11, 2023 at 12:20 PM Daniel Xu wrote: > > This commit extends test_tunnel selftest to test the new XDP xfrm state > lookup kfunc. > > Co-developed-by: Antony Antony > Signed-off-by: Antony Antony >

[PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-11 Thread Daniel Xu
This commit extends test_tunnel selftest to test the new XDP xfrm state lookup kfunc. Co-developed-by: Antony Antony Signed-off-by: Antony Antony Signed-off-by: Daniel Xu --- .../selftests/bpf/prog_tests/test_tunnel.c| 20 ++-- .../selftests/bpf/progs/test_tunnel_kern.c| 51