[PATCH 0/1 v2] media/video: vpif: fixing function name start to vpif_config_params

2012-08-09 Thread Dror Cohen
This patch address the issue that a function named config_vpif_params should be vpif_config_params. However this name is shared with two structures defined already. So I changed the structures to config_vpif_params (origin was vpif_config_params) v2 changes: softer wording in description and the

[PATCH 1/1 v2] media/video: vpif: fixing function name start to vpif_config_params

2012-08-09 Thread Dror Cohen
diff --git a/drivers/media/video/davinci/vpif.c b/drivers/media/video/davinci/vpif.c index af96802..04dd8fa 100644 --- a/drivers/media/video/davinci/vpif.c +++ b/drivers/media/video/davinci/vpif.c @@ -301,12 +301,12 @@ static void vpif_set_mode_info(const struct vpif_channel_config_params

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Gregor Jasny
Hello Konke, On 8/7/12 5:11 PM, Konke Radlow wrote: diff --git a/configure.ac b/configure.ac index 8ddcc9d..1109c4d 100644 --- a/configure.ac +++ b/configure.ac @@ -146,9 +148,12 @@ AC_ARG_WITH(libv4l2subdir, AS_HELP_STRING(--with-libv4l2subdir=DIR,set libv4l2 l

Re: build docs fails: parser error : Failure to process entity sub-enum-freq-bands

2012-08-09 Thread Hans Verkuil
It works for me. make DOCBOOKS=media_api.xml htmldocs Perhaps you need to do a make cleandocs first? Regards, Hans On Thu August 9 2012 01:17:57 Antti Palosaari wrote: That is from current staging/for_v3.7 [crope@localhost linux]$ make htmldocs HTML

Re: build docs fails: parser error : Failure to process entity sub-enum-freq-bands

2012-08-09 Thread Antti Palosaari
On 08/09/2012 10:29 AM, Hans Verkuil wrote: It works for me. make DOCBOOKS=media_api.xml htmldocs Perhaps you need to do a make cleandocs first? make cleandocs resolves the problems. Sorry for the noise. regards Antti Regards, Hans On Thu August 9 2012 01:17:57 Antti Palosaari

[PATCH v2 1/2] dma-buf: add reference counting for exporter module

2012-08-09 Thread Tomasz Stanislawski
This patch adds reference counting on a module that exported dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Sumit Semwal sumit.sem...@linaro.org Acked-by: Daniel

[PATCH v2 2/2] drm: set owner field to for all DMABUF exporters

2012-08-09 Thread Tomasz Stanislawski
This patch sets owner field in DMABUF operations for all DMABUF exporters in DRM subsystem. This prevents an exporting module from being unloaded while exported DMABUF descriptor is in use. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Sumit Semwal sumit.sem...@linaro.org

[PATCH v2 0/2] Enhance DMABUF with reference counting for exporter module

2012-08-09 Thread Tomasz Stanislawski
Hello, This patchset adds reference counting for an exporter module to DMABUF framework. Moreover, it adds setup of an owner field for exporters in DRM subsystem. v1: Original v2: - split patch into DMABUF and DRM part - allow owner to be NULL Regards, Tomasz Stanislawski Tomasz

Re: [PATCH 1/3] dma-fence: dma-buf synchronization (v7)

2012-08-09 Thread Maarten Lankhorst
Hey Sumit, Op 08-08-12 08:35, Sumit Semwal schreef: Hi Maarten, On 8 August 2012 00:17, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 07-08-12 19:53, Maarten Lankhorst schreef: A dma-fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace

[PATCH v4 0/4] Update MFC v4l2 driver to support MFC6.x

2012-08-09 Thread Arun Kumar K
The patchset adds support for MFCv6 firmware in s5p-mfc driver. The first two patches will update the existing MFCv5 driver framework for making it suitable for supporting co-existence with a newer hardware version. The last two patches add support for MFCv6 firmware. This patchset have to be

[PATCH v4 2/4] [media] s5p-mfc: Add MFC variant data to device context

2012-08-09 Thread Arun Kumar K
From: Jeongtae Park jtp.p...@samsung.com MFC variant data replaces various macros used in the driver which will change in a different version of MFC hardware. Also does a cleanup of MFC context structure and common files. Signed-off-by: Jeongtae Park jtp.p...@samsung.com Signed-off-by: Janghyuck

[PATCH v4 3/4] [media] s5p-mfc: MFCv6 register definitions

2012-08-09 Thread Arun Kumar K
From: Jeongtae Park jtp.p...@samsung.com Adds register definitions for MFC v6.x firmware Signed-off-by: Jeongtae Park jtp.p...@samsung.com Signed-off-by: Janghyuck Kim janghyuck@samsung.com Signed-off-by: Jaeryul Oh jaeryul...@samsung.com Signed-off-by: Naveen Krishna Chatradhi

[GIT PULL FOR v3.6] DocBook fixes for 3.6

2012-08-09 Thread Hans Verkuil
The first patch fixes a long standing invalid doc chunk first fixed by Sylwester here: http://patchwork.linuxtv.org/patch/11271/ I've taken that patch as is and only rebased it so it applies cleanly. It is in state 'Changes requested' but nobody ever actually requested any changes, and it is an

Re: [PATCH] pwc: Use vb2 queue mutex through a single name

2012-08-09 Thread Hans de Goede
Hi, Thanks for the patch, I've added it to my tree for 3.7: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.7-wip Regards, Hans On 07/15/2012 08:00 AM, Ezequiel Garcia wrote: This lock was being taken using two different names (pointers) in the same function. Both

Re: [PATCH] [media] gspca: dubious one-bit signed bitfield

2012-08-09 Thread Hans de Goede
Hi, Thanks for the patch, I've added it to my tree for 3.7: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.7-wip Regards, Hans On 08/05/2012 02:34 PM, Emil Goode wrote: This patch changes some signed integers to unsigned because they are not intended for negative

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Mauro Carvalho Chehab
Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote: [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver This one gives me a build warning if CONFIG_LEDS_CLASS is disabled: ERROR: led_classdev_register

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans de Goede
Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all those fixed, this one is could to go. So hopefully the next version can be added to git master! On

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Hans de Goede
Hi, My bad, sorry about this. Mauro's patch looks good. An alternative fix would be to #ifdefify the led code in the drivers themselves. Regards, Hans On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote: Em 08-08-2012 19:28, David Rientjes escreveu: On Tue, 31 Jul 2012, Mauro Carvalho

Re: [RFC PATCH 2/2] Add rds-ctl tool (with changes proposed in RFC)

2012-08-09 Thread Hans de Goede
Hi, Comments inline. On 08/07/2012 05:11 PM, Konke Radlow wrote: --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp | 959 + 4 files changed, 967

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans Verkuil
On Thu August 9 2012 13:58:07 Hans de Goede wrote: Hi Konke, As Gregor already mentioned there is no need to define libv4l2rdssubdir in configure.ac , so please drop that. Other then that I've some minor remarks (comments inline), with all those fixed, this one is could to go. So

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Hans Verkuil
On Tue August 7 2012 17:11:54 Konke Radlow wrote: --- Makefile.am |3 +- configure.ac|7 +- lib/include/libv4l2rds.h| 228 ++ lib/libv4l2rds/Makefile.am | 11 + lib/libv4l2rds/libv4l2rds.c | 953

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

2012-08-09 Thread Ezequiel Garcia
Hi Mauro, On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org) for me to work on stk1160. That way I could simply send git pull requests instead of patches. I'm not sure if this is a

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

2012-08-09 Thread Mauro Carvalho Chehab
Em 09-08-2012 09:24, Ezequiel Garcia escreveu: Hi Mauro, On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On a second thought, perhaps it makes sense to have a git repo (on linuxtv.org) for me to work on stk1160. That way I could simply send git pull requests

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread Mauro Carvalho Chehab
Em 09-08-2012 09:00, Hans de Goede escreveu: Hi, My bad, sorry about this. Mauro's patch looks good. Hmm... menuconfig NEW_LEDS bool LED Support help Say Y to enable Linux LED support. This allows control of supported LEDs from both userspace and

[PATCH 0/2] Add Nokia N900 (RX51) IR diode support

2012-08-09 Thread Timo Kokkonen
These patches add the support for sending IR remote controller codes on the Nokia N900 phone. The code is taken from the public N900 kernel release and modified to work with today's kernel. The code has been tested with a real Nokia N900 device and confirmed to work. I can identify only one known

[PATCH 1/2] media: rc: Introduce RX51 IR transmitter driver

2012-08-09 Thread Timo Kokkonen
This is the driver for the IR transmitter diode found on the Nokia N900 (also known as RX51) device. The driver is mostly the same as found in the original 2.6.28 based kernel that comes with the device. The following modifications have been made compared to the original driver version: - Adopt

[PATCH 2/2] ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data

2012-08-09 Thread Timo Kokkonen
The IR diode on the RX51 is connected to the GPT9. This data is needed for the IR driver to function. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff

__video_register_device: warning cannot be reached if warn_if_nr_in_use

2012-08-09 Thread Richard Zhao
In file drivers/media/video/v4l2-dev.c int __video_register_device(struct video_device *vdev, int type, int nr, int warn_if_nr_in_use, struct module *owner) { [...] vdev-minor = i + minor_offset; 878:vdev-num = nr; vdev-num is set to nr here. [...] if (nr !=

Re: __video_register_device: warning cannot be reached if warn_if_nr_in_use

2012-08-09 Thread Hans Verkuil
On Thu August 9 2012 14:55:02 Richard Zhao wrote: In file drivers/media/video/v4l2-dev.c int __video_register_device(struct video_device *vdev, int type, int nr, int warn_if_nr_in_use, struct module *owner) { [...] vdev-minor = i + minor_offset; 878: vdev-num = nr;

Re: [PATCH 2/2] ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data

2012-08-09 Thread Igor Grinberg
Hi Timo, On 08/09/12 15:41, Timo Kokkonen wrote: The IR diode on the RX51 is connected to the GPT9. This data is needed for the IR driver to function. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi --- arch/arm/mach-omap2/board-rx51-peripherals.c | 30 ++

Re: [PATCH 1/2] media: rc: Introduce RX51 IR transmitter driver

2012-08-09 Thread Igor Grinberg
On 08/09/12 15:41, Timo Kokkonen wrote: This is the driver for the IR transmitter diode found on the Nokia N900 (also known as RX51) device. The driver is mostly the same as found in the original 2.6.28 based kernel that comes with the device. The following modifications have been made

Re: __video_register_device: warning cannot be reached if warn_if_nr_in_use

2012-08-09 Thread Richard Zhao
Hans Verkuil hverk...@xs4all.nl wrote: On Thu August 9 2012 14:55:02 Richard Zhao wrote: In file drivers/media/video/v4l2-dev.c int __video_register_device(struct video_device *vdev, int type, int nr, int warn_if_nr_in_use, struct module *owner) { [...] vdev-minor = i

Re: __video_register_device: warning cannot be reached if warn_if_nr_in_use

2012-08-09 Thread Sylwester Nawrocki
On 08/09/2012 03:19 PM, Hans Verkuil wrote: On Thu August 9 2012 14:55:02 Richard Zhao wrote: In file drivers/media/video/v4l2-dev.c int __video_register_device(struct video_device *vdev, int type, int nr, int warn_if_nr_in_use, struct module *owner) { [...] vdev-minor =

Re: [alsa-devel] [PATCH v8] media: Add stk1160 new driver

2012-08-09 Thread Ezequiel Garcia
On Thu, Aug 9, 2012 at 9:33 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 09-08-2012 09:24, Ezequiel Garcia escreveu: Hi Mauro, On Mon, Aug 6, 2012 at 4:13 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On a second thought, perhaps it makes sense to have a git repo (on

Re: [PATCH 2/2] ARM: mach-omap2: board-rx51-peripherals: Add lirc-rx51 data

2012-08-09 Thread Timo Kokkonen
On 08/09/12 16:19, Igor Grinberg wrote: Hi Timo, On 08/09/12 15:41, Timo Kokkonen wrote: The IR diode on the RX51 is connected to the GPT9. This data is needed for the IR driver to function. Signed-off-by: Timo Kokkonen timo.t.kokko...@iki.fi ---

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
they are gone. And btw: I'm sorry for fiddling with your build environment in such a way. I have to admit that the additions I made were based more on copying from existing libraries than really understanding the effects of each command. Regards, Konke On Thu, Aug 9, 2012 at 7:22 AM, Gregor

Re: [PATCH v2 1/2] dma-buf: add reference counting for exporter module

2012-08-09 Thread Greg KH
On Thu, Aug 09, 2012 at 11:36:21AM +0200, Tomasz Stanislawski wrote: This patch adds reference counting on a module that exported dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use. Why force all of the modules to be changed by hand,

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
On Thu, Aug 9, 2012 at 11:58 AM, Hans de Goede hdego...@redhat.com wrote: Other then that I've some minor remarks (comments inline), with all those fixed, this one is could to go. So hopefully the next version can be added to git master! I'm very happy to hear that :) On 08/07/2012 05:11

Re: [RFC PATCH 2/2] Add rds-ctl tool (with changes proposed in RFC)

2012-08-09 Thread Konke Radlow
On Thu, Aug 9, 2012 at 12:05 PM, Hans de Goede hdego...@redhat.com wrote: Hi, Comments inline. On 08/07/2012 05:11 PM, Konke Radlow wrote: --- Makefile.am |3 +- configure.ac |1 + utils/rds-ctl/Makefile.am |5 + utils/rds-ctl/rds-ctl.cpp |

Re: [PATCH v2 1/2] dma-buf: add reference counting for exporter module

2012-08-09 Thread Tomasz Stanislawski
Hi Greg, On 08/09/2012 04:23 PM, Greg KH wrote: On Thu, Aug 09, 2012 at 11:36:21AM +0200, Tomasz Stanislawski wrote: This patch adds reference counting on a module that exported dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use.

[PATCH] mantis: fix silly crash case

2012-08-09 Thread Alan Cox
From: Alan Cox a...@linux.intel.com If we set mantis-fe to NULL on an error its not a good idea to then try passing NULL to the unregister paths and oopsing really. Signed-off-by: Alan Cox a...@linux.intel.com Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=16473 ---

Re: support for Elgato eyetv one

2012-08-09 Thread Dutchdude
Thanks for the reply! I had no idea that it would be that complex. From the moment I joined this mailing board in order to add the information above, I received no less than 193 e-mails! It's great to see that are that many people working on linux drivers! Good luck and keep up the good work!

Re: support for Elgato eyetv one

2012-08-09 Thread Antti Palosaari
On 08/09/2012 07:13 PM, Dutchdude wrote: Thanks for the reply! I had no idea that it would be that complex. From the moment I joined this mailing board in order to add the information above, I received no less than 193 e-mails! It's great to see that are that many people working on linux

Re: [GIT PULL for 3.6-rc1] media updates part 2

2012-08-09 Thread David Rientjes
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote: Yeah, that would work as well, although the code would look uglier. IMHO, using select/depend is better. Agreed, I think it should be depends on LEDS_CLASS rather than select it if there is a hard dependency that cannot be fixed with

Re: [PATCH v8] media: Add stk1160 new driver

2012-08-09 Thread Mauro Carvalho Chehab
Patch looks ok. Just a few comments: Em 06-08-2012 10:38, Ezequiel Garcia escreveu: This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of staging/media/easycap driver and it's expected as a replacement. --- Please don't

Re: [PATCH v8] media: Add stk1160 new driver

2012-08-09 Thread Ezequiel Garcia
On Thu, Aug 9, 2012 at 5:25 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Patch looks ok. Just a few comments: Em 06-08-2012 10:38, Ezequiel Garcia escreveu: This driver adds support for stk1160 usb bridge as used in some video/audio usb capture devices. It is a complete rewrite of

cron job: media_tree daily build: WARNINGS

2012-08-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Thu Aug 9 19:00:28 CEST 2012 git hash:c3707357c6c651652a87a05eabd7582f90a4 gcc version: i686-linux-gcc

Re: [GIT PULL FOR v3.6] Add adv7604/ad9389b drivers

2012-08-09 Thread Mauro Carvalho Chehab
Hi Hans, It follows a few notes about what I've seen at the two initial patches. I didn't review the other ones, as they should follow whatever agreed at the API/spec changes. It should be noticed that I'm not a monitor-set expert (while I have some past experiences playing with monitor's EDID

[PATCH RFC 3/3] dvb_frontend: do not allow statistic IOCTLs when sleeping

2012-08-09 Thread Antti Palosaari
Demodulator cannot perform statistic IOCTLs when it is not tuned. Return -EPERM in such case. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-core/dvb_frontend.c | 34 +++ 1 file changed, 25 insertions(+), 9 deletions(-) diff --git

[PATCH RFC 2/3] dvb_frontend: return -ENOTTY for unimplement IOCTL

2012-08-09 Thread Antti Palosaari
Earlier it was returning -EOPNOTSUPP. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-core/dvb_frontend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index

[PATCH RFC 1/3] dvb_frontend: use Kernel dev_* logging

2012-08-09 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/dvb-core/dvb_frontend.c | 226 +++--- 1 file changed, 116 insertions(+), 110 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c b/drivers/media/dvb/dvb-core/dvb_frontend.c index

[PATCH RFC 0/3] dvb-frontend statistic IOCTL validation

2012-08-09 Thread Antti Palosaari
I added some logic to prevent statistic queries in case demodulator is clearly in state statistic query is invalid. Currently there could be checks in device driver but usually not. Garbage is usually returned and in some cases even I/O errors are generated as demod is put sleep and cannot

Re: [PATCH RFC] add LNA support for DVB API

2012-08-09 Thread Antti Palosaari
On 07/12/2012 04:04 AM, Antti Palosaari wrote: Any comment about that? Should I store value to cache? Should I offer get too? Should I offer way to query possible values? I think that implementation is quite simply and safe to add. Lets extend later if really needed... regards Antti

Re: [PATCH 17/24] au0828: fix possible race condition in usage of dev-ctrlmsg

2012-08-09 Thread Mauro Carvalho Chehab
Em 06-08-2012 23:47, Devin Heitmueller escreveu: The register read function is referencing the dev-ctrlmsg structure outside of the dev-mutex lock, which can cause corruption of the value if multiple callers are invoking au0828_readreg() simultaneously. Use a stack variable to hold the

[PATCH 1/3] tda18212: silence compiler warning

2012-08-09 Thread Antti Palosaari
Trivial fix. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/common/tuners/tda18212.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/tuners/tda18212.c b/drivers/media/common/tuners/tda18212.c index 602c2e3..a14e8b6 100644 ---

[PATCH 2/3] tda18212: use Kernel dev_* logging

2012-08-09 Thread Antti Palosaari
Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/common/tuners/tda18212.c | 35 ++ 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/media/common/tuners/tda18212.c b/drivers/media/common/tuners/tda18212.c index a14e8b6..5d9f028

[PATCH 3/3] tda18218: silence compiler warning

2012-08-09 Thread Antti Palosaari
Trivial fix. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/common/tuners/tda18218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/tuners/tda18218.c b/drivers/media/common/tuners/tda18218.c index dfb3a83..8a6f9ca 100644 ---

Re: [PATCH 17/24] au0828: fix possible race condition in usage of dev-ctrlmsg

2012-08-09 Thread Devin Heitmueller
On Thu, Aug 9, 2012 at 7:48 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 06-08-2012 23:47, Devin Heitmueller escreveu: The register read function is referencing the dev-ctrlmsg structure outside of the dev-mutex lock, which can cause corruption of the value if multiple callers are