Re: [RFC/PATCH 09/13] media: s5k6aa: Add support for device tree based instantiation

2012-08-19 Thread Sakari Ailus
Hi Laurent and Sylwester, My apologies for the late answer. On Fri, Jul 27, 2012 at 12:50:13AM +0200, Laurent Pinchart wrote: Hi Sylwester, On Thursday 26 July 2012 22:39:31 Sylwester Nawrocki wrote: On 07/26/2012 05:21 PM, Laurent Pinchart wrote: On Friday 25 May 2012 21:52:48

Re: [PATCH] [media] winbond-cir: Fix initialization

2012-08-19 Thread Alan Cox
+#ifdef CONFIG_SERIAL_8250 Coule be modular + if (!io) { + struct uart_port port = { .iobase = data-sbase }; + int line = serial8250_find_port(port); + if (line = 0) { + serial8250_unregister_port(line); Hmm... Not sure if it makes

[PATCH 0/6] HID: picoLCD additional fixes + CIR support

2012-08-19 Thread Bruno Prémont
Hi, This series fixes some race conditions in picoLCD driver during remove() and adds support for IR functionality. Repeatedly binding/unbinding device at hid-picolcd driver level or at usbhid level now works properly (except in rare occasions which trigger a paging error in interrupt context

[PATCH 3/6] HID: picoLCD: Add support for CIR

2012-08-19 Thread Bruno Prémont
Implement support for picoLCD's CIR header using RC_CORE for decoding the IR event stream. Signed-off-by: Bruno Prémont bonb...@linux-vserver.org --- drivers/hid/hid-picolcd.h |5 ++- drivers/hid/hid-picolcd_cir.c | 95 +++-

Re: [patch] [media] rc: divide by zero bugs in s_tx_carrier()

2012-08-19 Thread Ben Hutchings
On Sat, 2012-08-18 at 18:58 +0300, Dan Carpenter wrote: carrier comes from a get_user() in ir_lirc_ioctl(). We need to test that it's not zero before using it as a divisor. Other RC drivers seem to have the same problem, only more deeply buried. I think it's better to put this check in

cron job: media_tree daily build: ERRORS

2012-08-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Aug 19 19:00:23 CEST 2012 git hash:9b78c5a3007e10a172d4e83bea18509fdff2e8e3 gcc version: i686-linux-gcc

Re: cron job: media_tree daily build: ERRORS

2012-08-19 Thread Anca Emanuel
On Sun, Aug 19, 2012 at 10:54 PM, Hans Verkuil hverk...@xs4all.nl wrote: This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:Sun Aug 19 19:00:23 CEST 2012 git hash:

Re: cron job: media_tree daily build: ERRORS

2012-08-19 Thread Antti Palosaari
On 08/19/2012 11:09 PM, Anca Emanuel wrote: On Sun, Aug 19, 2012 at 10:54 PM, Hans Verkuil hverk...@xs4all.nl wrote: This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date:

[PATCH] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

2012-08-19 Thread Ben Hutchings
ite_dev::rdev is currently initialised in ite_probe() after rc_register_device() returns. If a newly registered device is opened quickly enough, we may enable interrupts and try to use ite_dev::rdev before it has been initialised. Move it up to the earliest point we can, right after calling

Re: [PATH v3 0/2] Add v4l2 subdev driver for S5K4ECGX sensor with embedded SoC ISP

2012-08-19 Thread Sylwester Nawrocki
Hi Sangwook, On 08/03/2012 04:24 PM, Sangwook Lee wrote: I was thinking about this, but this seems to be is a bit time-consuming because I have to do this just due to lack of s5k4ecgx hardware information. let me try it later once this patch is accepted. I've converted this driver to use

Re: TV Tuner dmesg errors

2012-08-19 Thread Rohit Sharma
Latest error log is http://pastebin.com/rP5GMB6d -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

2012-08-19 Thread Ben Hutchings
ite_dev::rdev is currently initialised in ite_probe() after rc_register_device() returns. If a newly registered device is opened quickly enough, we may enable interrupts and try to use ite_dev::rdev before it has been initialised. Move it up to the earliest point we can, right after calling

[PATCH 1/4] stk1160: Make kill/free urb debug message more verbose

2012-08-19 Thread Ezequiel Garcia
This is just a cleaning patch to produce more useful debug messages. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-video.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/usb/stk1160/stk1160-video.c

[PATCH 2/4] stk1160: Handle urb allocation failure condition properly

2012-08-19 Thread Ezequiel Garcia
When an urb buffer can't be allocated, the currently allocated buffer count must be saved so they can properly released. Moreover, it's sufficient to call stk1160_free_isoc to have all urb buffers released. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com ---

[PATCH 3/4] stk1160: Fix s_fmt and try_fmt implementation

2012-08-19 Thread Ezequiel Garcia
The driver was expecting to get a valid pixelformat on s_fmt and try_fmt. This is wrong, since the user may pass a bitmask and expect the driver to change it, returning a valid (fourcc) pixelformat. This problem was spotted by v4l2-compliance. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com

[PATCH 4/4] stk1160: Stop device and unqueue buffers when start_streaming() fails

2012-08-19 Thread Ezequiel Garcia
If start_streaming() fails (e.g. out of memory) the driver needs to rewind the start procedure. This implies possibly stopping the device and clearing the buffer queue. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-v4l.c | 16 1

Re: [v7] media: coda: Add driver for Coda video codec.

2012-08-19 Thread Richard Zhao
Hi Javier, Did the patch get picked? I didn't see it on git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git Still, how did you test this v4l2 device? Thanks Richard On Fri, Aug 03, 2012 at 01:21:02PM +0200, javier Martin wrote: Hi Richard, thank you for your review.