Am 26.02.2014 12:01, schrieb Arnd Bergmann:
It's been a while since the first submission of these patches,
but a lot of them have made it into linux-next already, so here
is the stuff that is not merged yet, hopefully addressing all
the comments.
Geert and Michael: the I was expecting the
On 28/02/14 01:28, Rob Herring wrote:
On Thu, Feb 27, 2014 at 4:52 PM, James Hogan james.ho...@imgtec.com wrote:
v3:
- Rename compatible string to img,ir-rev1 (Rob Herring).
- Specify ordering of clocks explicitly (Rob Herring).
I'd appreciate if somebody could give this another glance after
Hi Laurent,
On 02/26/2014 04:40 PM, Laurent Pinchart wrote:
Hi Mark,
[ ... ]
With the information I've given you, could you try to log more information in
the driver to try and find what goes wrong ? You could for instance log the
content of each header at the beginning of the
use the correct name in the comment describing function
omap3isp_module_sync_is_stopping()
isp_isr() never returned IRQ_NONE, remove the comment saying so
Signed-off-by: Peter Meerwald pme...@pmeerw.net
---
drivers/media/platform/omap3isp/isp.c | 5 +
1 file changed, 1 insertion(+), 4
This is an automatic generated email to let you know that the following patch
were queued at the
http://git.linuxtv.org/media_tree.git tree:
Subject: [media] omap_vout: avoid sleep_on race
Author: Arnd Bergmann a...@arndb.de
Date:Thu Jan 2 09:07:29 2014 -0300
sleep_on and its variants are
From: Ricardo Ribalda Delgado ricardo.riba...@gmail.com
This patch adds a test preventing streamon() if there is no buffer
ready.
Without this patch, a user could call streamon() before
preparing any buffer. This leads to a situation where if he calls
close() before calling streamoff() the
Fix an incorrect test in vb2_internal_qbuf() where only DEQUEUED buffers
are allowed. But PREPARED buffers are also OK.
Introduced by commit 4138111a27859dcc56a5592c804dd16bb12a23d1
(vb2: simplify qbuf/prepare_buf by removing callback).
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
From: Hans Verkuil hans.verk...@cisco.com
When a vb2_queue is freed check if all the mem_ops and queue ops were balanced.
So the number of calls to e.g. buf_finish has to match the number of calls to
buf_prepare, etc.
This code is only enabled if CONFIG_VIDEO_ADV_DEBUG is set.
Signed-off-by:
From: Hans Verkuil hans.verk...@cisco.com
If a queue was canceled, then the buf_finish op was never called for the
pending buffers. So add this call to queue_cancel. Before calling buf_finish
set the buffer state to PREPARED, which is the correct state. That way the
states DONE and ERROR will
From: Hans Verkuil hans.verk...@cisco.com
If start_streaming fails then any queued buffers must be given back
to the vb2 core.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/vivi.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
__vb2_queue_free() would init the queued_list at all times, even if
q-num_buffers 0. This should only happen if num_buffers == 0.
This situation can happen if a CREATE_BUFFERS call couldn't allocate
enough buffers and had to free those it did manage to
From: Hans Verkuil hans.verk...@cisco.com
If __reqbufs was called then existing buffers are freed. However, if that
happens without ever having started STREAMON, but if buffers have been queued,
then the buf_finish op is never called.
Add a call to __vb2_queue_cancel in __reqbufs so that these
This third version incorporates the comments I received, and I also made
some additional changes.
Changes since REVIEWv2:
- the patches regarding the buf_finish changes were reorganized. Laurent
pointed out a bug in patch 07/15 that is fixed here by adding the
buf_finish call to
From: Hans Verkuil hans.verk...@cisco.com
In commit 02f142ecd24aaf891324ffba8527284c1731b561 support was added to
start_streaming to return -ENOBUFS if insufficient buffers were queued
for the DMA engine to start. The vb2 core would attempt calling
start_streaming again if another buffer would be
From: Hans Verkuil hans.verk...@cisco.com
This function never checked if width and height are correct. Add such
a check so the v4l2-compliance tool returns OK again for vivi.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/vivi.c | 6 +-
1 file changed, 5
From: Hans Verkuil hans.verk...@cisco.com
Ensure that these ops are properly balanced.
There are two scenarios:
1) for MMAP buf_init is called when the buffers are created and buf_cleanup
must be called when the queue is finally freed. This scenario was always
working.
2) for USERPTR and
From: Hans Verkuil hans.verk...@cisco.com
Sometimes sentences in comments ended with a period, and sometimes they
didn't. Add periods. No other changes.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
include/media/videobuf2-core.h | 40
1 file
From: Hans Verkuil hans.verk...@cisco.com
'queued_count' is a bit vague since it is not clear to which queue it
refers to: the vb2 internal list of buffers or the driver-owned list
of buffers.
Rename to make it explicit.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Pawel Osciak
From: Hans Verkuil hans.verk...@cisco.com
Commit 88e268702bfba78448abd20a31129458707383aa (vb2: Improve file I/O
emulation to handle buffers in any order) broke read/write support if
the size of the buffer being read/written is less than the size of the
image.
When the commit was tested
From: Hans Verkuil hans.verk...@cisco.com
No need to oops for this, WARN_ON is good enough.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/videobuf2-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: Hans Verkuil hans.verk...@cisco.com
The buf_finish op should always work, so change the return type to void.
Update the few drivers that use it.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Pawel Osciak pa...@osciak.com
Reviewed-by: Pawel Osciak pa...@osciak.com
---
From: Hans Verkuil hans.verk...@cisco.com
If you request buffers, then queue buffers and then call STREAMOFF
those buffers are not returned to their dequeued state because streamoff
will just return if q-streaming was 0.
This means that afterwards you can never QBUF that same buffer again unless
On 02/27/2014 06:35 PM, Philipp Zabel wrote:
If of_graph_get_next_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.
Signed-off-by: Philipp Zabelp.za...@pengutronix.de
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On 02/27/2014 06:35 PM, Philipp Zabel wrote:
This patch adds a new struct of_endpoint which is then embedded in struct
v4l2_of_endpoint and contains the endpoint properties that are not V4L2
(or even media) specific: the port number, endpoint id, local device tree
node and remote endpoint
Hi Philipp,
Just couple minor comments...
On 02/27/2014 06:35 PM, Philipp Zabel wrote:
The device tree graph bindings as used by V4L2 and documented in
Documentation/device-tree/bindings/media/video-interfaces.txt contain
generic parts that are not media specific but could be useful for any
This patch series fixes null pointer dereference boot failure as well as
compile errors.
Shuah Khan (3):
media/drx39xyj: fix pr_dbg undefined compile errors when DJH_DEBUG is
defined
media/drx39xyj: remove return that prevents DJH_DEBUG code to run
media/drx39xyj: fix boot failure due
DJH_DEBUG only code path in drxbsp_i2c_write_read() dereferences
w_dev_addr and subsequently w_dev_addr-user_data-i2c which results
in failure during boot. This patch fixes the null pointer derefence
bug as well as the following compile errors:
LD arch/x86/built-in.o
CC
drxbsp_i2c_write_read() has return that prevents DJH_DEBUG code to run.
Remove it.
Signed-off-by: Shuah Khan shuah...@samsung.com
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c
drxj.c fails to compile with the following errors when DJH_DEBUG
is defined.
drivers/media/dvb-frontends/drx39xyj/drxj.c:1567:2: error: implicit declaration
of function ‘pr_dbg’ [-Werror=implicit-function-declaration]
pr_dbg(drx3933 i2c operation addr=%x i2c=%p, wc=%x rc=%x\n,
^
Hi Dean,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: a06b429df49bb50ec1e671123a45147a1d1a6186
commit: 47d8c881c304642a68d398b87d9e8846e643c81a [476/499] [media] s2255drv:
dynamic memory allocation efficiency fix
Critical bug fix. Fixes memory leak introduced by
commit 47d8c881c304642a68d398b87d9e8846e643c81a.
Signed-off-by: Dean Anderson linux-...@sensoray.com
---
drivers/media/usb/s2255/s2255drv.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c
Add generic scancode filtering of RC input events, and fall back to
permitting any RC_FILTER_NORMAL scancode filter to be set if no s_filter
callback exists. This allows raw IR decoder events to be filtered, and
potentially allows hardware decoders to set looser filters and rely on
generic code to
Only a single allowed and enabled protocol mask currently exists in
struct rc_dev, however to support a separate wakeup filter protocol two
of each are needed, ideally as an array.
Therefore make both rc_dev::allowed_protos and rc_dev::enabled_protocols
arrays, update all users to reference the
When either of the normal or wakeup filter protocols are changed,
refresh the corresponding scancode filter, i.e. try and set the same
scancode filter with the new protocol. If that fails clear the filter
instead.
If no protocol was selected the filter is just cleared, and if no
s_filter callback
Add a wakeup_protocols sysfs file which controls the new
rc_dev::enabled_protocols[RC_FILTER_WAKEUP], which is the mask of
protocols that are used for the wakeup filter.
A new RC driver callback change_wakeup_protocol() is called to change
the wakeup protocol mask.
Signed-off-by: James Hogan
The allowed and enabled protocol masks need to be expanded to be per
filter type in order to support wakeup filter protocol selection. To
ease that process abstract access to the rc_dev::allowed_protos and
rc_dev::enabled_protocols members with inline functions.
Signed-off-by: James Hogan
These patches make some improvements relating to the recently added RC
scancode filtering interface:
- Patch 1 adds generic scancode filtering. This allows filtering to also
work for raw rc drivers and scancode drivers without filtering
capabilities.
- Patches 2-4 future proof the sysfs API to
Add a driver for the ImgTec Infrared decoder block. Two separate rc
input devices are exposed depending on kernel configuration. One uses
the hardware decoder which is set up with timings for a specific
protocol and supports mask/value filtering and wake events. The other
uses raw edge interrupts
Add device tree binding for ImgTec Consumer Infrared block, specifically
major revision 1 of the hardware.
Signed-off-by: James Hogan james.ho...@imgtec.com
Acked-by: Rob Herring r...@kernel.org
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
Cc: Pawel Moll
Add base driver for the ImgTec Infrared decoder block. The driver is
split into separate components for raw (software) decode and hardware
decoder which are in following commits.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc:
Add ImgTec IR decoder driver to the build system.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/Kconfig | 2 ++
drivers/media/rc/Makefile| 1 +
Add an img-ir module for decoding the JVC infrared protocol.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic
Add an img-ir module for decoding the Sony infrared protocol.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic
Add an img-ir module for decoding the Sharp infrared protocol.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic
Add raw IR remote control input driver for the ImgTec Infrared decoder
block's raw edge interrupts. Generic software protocol decoders are used
to allow multiple protocols to be supported at a time, including those
not supported by the hardware decoder.
Signed-off-by: James Hogan
Add an img-ir module for decoding the NEC and extended NEC infrared
protocols.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
---
v2:
- Update scancode and filter callbacks to handle 32-bit NEC as used by
Apple
Add an img-ir module for decoding the Sanyo infrared protocol.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic
Add remote control input driver for the ImgTec Infrared block hardware
decoder, which is set up with timings for a specific protocol and
supports mask/value filtering and wake events.
The hardware decoder timing values, raw data to scan code conversion
function and scan code filter to raw data
Attention: Please, Kindly contact KENYA COMMERCIAL BANK immediately for your
compensation payment of (3MILLION UNITED STATE DOLLARS) via email:
Email:(servic...@kenya.ncommercialbnk.com) quote your payment Ref
No:KCB/00Y/2014 For purposes of immediate payment.
--
To unsubscribe from this
On Fri, Feb 28, 2014 at 4:22 PM, Shuah Khan shuah...@samsung.com wrote:
This patch series fixes null pointer dereference boot failure as well as
compile errors.
Seems kind of strange that I wasn't on the CC for this, since I was
the original author of all that code (in fact, DJH are my
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 86c7654f4a0afcbbd2fedefec01082f292b14cb4
commit: 103fe2fb2314f09d9b923c5919e70cbe66830d6d [media] r820t: Invert bits for
read ops
date: 11 months ago
config: x86_64-randconfig-wa0-03010518 (attached as
Moikka!
These patches are based top of:
http://git.linuxtv.org/media-tree.git/shortlog/refs/heads/sdr
I am not able to make development during next week, so if there is any
issues, please wait to week 12 I could fix, or do what ever is best
required by situation.
Both SDR drivers are in
On 02/28/2014 05:13 PM, Devin Heitmueller wrote:
Seems kind of strange that I wasn't on the CC for this, since I was the
original author of all that code (in fact, DJH are my initials).
Mauro, did you strip off my authorship when you pulled the patches from
my tree?
The patches themselves look
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Mar 1 04:00:26 CET 2014
git branch: test
git hash: a06b429df49bb50ec1e671123a45147a1d1a6186
gcc
54 matches
Mail list logo
