Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver

2014-05-19 Thread Maxime Ripard
Hi, I missed a few things in my first review. On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: This patch adds driver for sunxi IR controller. It is based on Alexsey Shestacov's work based on the original driver supplied by Allwinner. Signed-off-by: Alexander Bersenev

Re: [PATCH 1/2] v4l: s5p-mfc: Fix default pixel format selection for decoder

2014-05-19 Thread Sylwester Nawrocki
On 16/05/14 14:03, Kamil Debski wrote: The patch adding the v6 version of MFC changed the default format for the CAPTURE queue, but this also affects the v5 version. This patch solves this problem by checking the MFC version before assigning the default format. Signed-off-by: Kamil Debski

Re: [PATCH 2/2] v4l: s5p-mfc: Limit enum_fmt to output formats of current version

2014-05-19 Thread Sylwester Nawrocki
Hi Kamil, On 16/05/14 14:03, Kamil Debski wrote: MFC versions support a different set of formats, this specially applies to the raw YUV formats. This patch changes enum_fmt, so that it only reports formats that are supported by the used MFC version. Signed-off-by: Kamil Debski

Re: [PATCH 2/2] v4l: s5p-mfc: Limit enum_fmt to output formats of current version

2014-05-19 Thread Arun Kumar K
Hi Kamil, Only a small correction. On Fri, May 16, 2014 at 5:33 PM, Kamil Debski k.deb...@samsung.com wrote: MFC versions support a different set of formats, this specially applies to the raw YUV formats. This patch changes enum_fmt, so that it only reports formats that are supported by the

[PATCH 06/10] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org Currently, for formats that are not H264, MFC driver will check the consumed stream size returned by the firmware and, based on that, will try to decide whether the bitstream buffer contained more than one frame. If the size of the buffer is larger than the

[PATCH 01/10] [media] s5p-mfc: Copy timestamps only when a frame is produced.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org Timestamps for destination buffers are assigned by copying them from corresponding source buffers when the decode operation results in a frame being outputted to a destination buffer. But the decision when to do this, i.e. whether the decode operation on

[PATCH 02/10] [media] s5p-mfc: Fixes for decode REQBUFS.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org - Honor return values from vb2_reqbufs on REQBUFS(0). - Do not set the number of allocated buffers to 0 if userspace tries to request buffers again without freeing them. - There is no need to verify correct instance state on reqbufs, as we will verify

[PATCH 04/10] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org Currently, we allocate private codec buffers on STREAMON, which may fail if we are out of memory. We don't check for failure though, which will make us crash with the codec accessing random memory. We shouldn't be failing STREAMON with out of memory errors

[PATCH 08/10] [media] s5p-mfc: Move INIT_BUFFER_OPTIONS from v7 to v6

2014-05-19 Thread Arun Kumar K
The register S5P_FIMV_D_INIT_BUFFER_OPTIONS holds good for v6 firmware too. So moving the definition from v7 regs to v6. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h|1 + drivers/media/platform/s5p-mfc/regs-mfc-v7.h|2 --

[PATCH 03/10] [media] s5p-mfc: Extract open/close MFC instance commands.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak posc...@chromium.org This is in preparation for a new flow to fix issues with streamon, which should not be allocating buffer memory. Signed-off-by: Pawel Osciak posc...@chromium.org Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH 10/10] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-05-19 Thread Arun Kumar K
Renaming the IS_MFCV7 macro to IS_MFCV7_PLUS for the addition of MFCv8 support which reuses the v7 code. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +-

[PATCH 1/2] [media] s5p-mfc: Core support to add v8 decoder

2014-05-19 Thread Arun Kumar K
From: Kiran AVND avnd.ki...@samsung.com This patch adds variant data and core support for V8 decoder. This patch also adds the register definition file for new firmware version v8 for MFC. Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Pawel Osciak posc...@chromium.org

[PATCH 0/2] Re-send MFCv8 support patches

2014-05-19 Thread Arun Kumar K
These 2 patches for MFCv8 support are rebased onto [1] with the dependencies as mentioned below. Changes include adding the MFC_V8 version to formats. - Re-send MFC patches https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31051.html - Adding version information to formats by

[PATCH 2/2] [media] s5p-mfc: Core support for v8 encoder

2014-05-19 Thread Arun Kumar K
From: Kiran AVND avnd.ki...@samsung.com This patch adds core support for v8 encoder. This patch also adds register definitions and buffer size requirements for H264 VP8 encoding, needed for new firmware version v8 for MFC Signed-off-by: Kiran AVND avnd.ki...@samsung.com Signed-off-by: Pawel

Re: [RFC PATCH 2/2 with seqcount v3] reservation: add suppport for read-only access using rcu

2014-05-19 Thread Thomas Hellstrom
Hi, Maarten! Some nitpicks, and that krealloc within rcu lock still worries me. Otherwise looks good. /Thomas On 04/23/2014 12:15 PM, Maarten Lankhorst wrote: This adds 4 more functions to deal with rcu. reservation_object_get_fences_rcu() will obtain the list of shared and exclusive

Re: [RFC PATCH 2/2 with seqcount v3] reservation: add suppport for read-only access using rcu

2014-05-19 Thread Maarten Lankhorst
op 19-05-14 15:42, Thomas Hellstrom schreef: Hi, Maarten! Some nitpicks, and that krealloc within rcu lock still worries me. Otherwise looks good. /Thomas On 04/23/2014 12:15 PM, Maarten Lankhorst wrote: @@ -55,8 +60,8 @@ int reservation_object_reserve_shared(struct reservation_object

Re: [PATCH 4/6] android: convert sync to fence api, v5

2014-05-19 Thread John Stultz
On Mon, Feb 24, 2014 at 8:29 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Just to show it's easy. Android syncpoints can be mapped to a timeline. This removes the need to maintain a separate api for synchronization. I've left the android trace events in place, but the core

Re: [PATCH v7 2/3] [media] rc: add sunxi-ir driver

2014-05-19 Thread David Härdeman
On Thu, May 15, 2014 at 03:56:41AM +0600, Alexander Bersenev wrote: This patch adds driver for sunxi IR controller. It is based on Alexsey Shestacov's work based on the original driver supplied by Allwinner. ... +static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) +{ + unsigned long

Re: [PATCH] Full DVB driver package for Earthsoft PT3 (ISDB-S/T) cards

2014-05-19 Thread ほち
Thanks for the review. Inlined questions before going further. Best Regards -Bud 2014-05-18 4:03 GMT+09:00 Antti Palosaari cr...@iki.fi: Overall tc90522 driver looks very complex and there was multiple issues. One reason of complexiness is that HW algo used. I cannot see any reason why it is

Re: [PATCH] Full DVB driver package for Earthsoft PT3 (ISDB-S/T) cards

2014-05-19 Thread Antti Palosaari
Moikka! On 05/20/2014 01:19 AM, ほち wrote: Thanks for the review. Inlined questions before going further. Lets see, I will answer my best. But one thing, that is very big driver/patch, containing one PCI driver, one (or two?) demod drivers and two tuner drivers. So it could take a some time

Re: [PATCH 2/2] v4l: s5p-mfc: Limit enum_fmt to output formats of current version

2014-05-19 Thread Pawel Osciak
Hi Kamil, I like the solution as well. Two suggestions to consider below. On Fri, May 16, 2014 at 9:03 PM, Kamil Debski k.deb...@samsung.com wrote: MFC versions support a different set of formats, this specially applies to the raw YUV formats. This patch changes enum_fmt, so that it only

cron job: media_tree daily build: OK

2014-05-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 20 04:00:16 CEST 2014 git branch: test git hash: ba0d342ecc21fbbe2f6c178f4479944d1fb34f3b gcc

Re: [PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-19 Thread Arun Kumar K
Hi Kamil, On 05/15/14 20:47, Kamil Debski wrote: Hi Arun, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Arun Kumar K Sent: Wednesday, May 14, 2014 10:10 AM Hi Hans, On 05/14/14 12:39, Hans Verkuil wrote: On 05/14/2014 08:29 AM, Arun