Hello
Philipp Zabel p.za...@pengutronix.de writes:
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 8e9c26c..3fe7e28 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -35,6 +35,8 @@ source
On 06/24/14 01:54, Laurent Pinchart wrote:
videobuf2 stores the driver streaming state internally in the queue in
the start_streaming_called variable. The state is set right after the
driver start_stream operation returns, and checked in the
vb2_buffer_done() function, typically called from
On Tue, 2014-06-24 at 09:27 +1000, Julian Calaby wrote:
- x = (T)pci_alloc_consistent(E1,E2,E3);
+ x = pci_zalloc_consistent(E1,E2,E3);
if ((x==NULL) || ...) S
- memset((T2)x,0,E2);
I don't know much about SmPL, but wouldn't having that if statement
there reduce your matches?
Code
Hello.
On 06/24/2014 03:54 AM, Laurent Pinchart wrote:
videobuf2 expects no buffer to be owned by the driver when the
stop_stream queue operation returns. As the vsp1 driver fails to do so,
a warning is generated at stream top time.
Fix this by mark releasing all buffers queued on the IRQ
Tuner ID set into EEPROM is wrong in some cases, which causes driver
to select wrong tuner profile. That leads device non-working. Fix
issue by overriding known bad tuner IDs with suitable default value.
Cc: sta...@vger.kernel.org # v3.15+
Signed-off-by: Antti Palosaari cr...@iki.fi
---
On Thu, 19 Jun 2014 16:27:59 +0200
Hans de Goede hdego...@redhat.com wrote:
Hi Antonio,
Thanks for working on this.
On 06/04/2014 10:24 PM, Antonio Ospite wrote:
Add a xfer_ep_index field to struct gspca_dev, and change alt_xfer() so
that it accepts a parameter which represents a
Hello again
Philipp Zabel p.za...@pengutronix.de writes:
+struct media_device *ipu_find_media_device(void)
+{
+ return ipu_media-mdev;
+}
+EXPORT_SYMBOL_GPL(ipu_find_media_device);
Where is ipu_find_media_device() being called?
+int ipu_media_device_register(struct device *dev)
+{
Hi,
On 06/24/2014 03:35 PM, Antonio Ospite wrote:
On Thu, 19 Jun 2014 16:27:59 +0200
Hans de Goede hdego...@redhat.com wrote:
Hi Antonio,
Thanks for working on this.
On 06/04/2014 10:24 PM, Antonio Ospite wrote:
Add a xfer_ep_index field to struct gspca_dev, and change alt_xfer() so
The h.264 decoder produces capture frames that are a multiple of the macroblock
size (16 pixels). To inform userspace about invalid pixel data at the edges,
use the active and padded composing rectangles on the capture queue.
The cropping information is obtained from the h.264 sequence parameter
From: Michael Olbrich m.olbr...@pengutronix.de
In case no further buffers are queued after the stop command, restart
job scheduling explicitly.
Signed-off-by: Michael Olbrich m.olbr...@pengutronix.de
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 2 ++
1
OVL and BTP IRAM buffers are never used, setup the bits for
for DBK/BIT/IP usage depending on CODA version in one place.
Also, use a simple allocator function and group IRAM addresses
and size in a coda_aux_buf structure.
This is done in preparation for CODA960 support.
Signed-off-by: Philipp
This patch allows to use the runtime pm and generic pm domain frameworks
to completely gate power to the VPU if it is unused. This functionality
is available on i.MX6.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
Changes since v1:
- Use pm_runtime_enabled()
---
Currently the rotator unit is used to copy decoded frames out into buffers
provided by videobuf2. Since the CODA reports the I/P/B frame type of the
last decoded frame, and this frame will be copied out in a later device_run,
depending on display order, we have to store the frame type until such
Even though the CODA h.264 decoder always decodes complete macroblocks, we can
set the stride to the corresponding multiple of 16 and use a value smaller than
that as real width. Unfortunately the same doesn't work for height, as there
is no vertical linesperframe stride for discontiguous planar
bytesperline is calculated in multiple places, store it in the coda_q_data
structure. This will be more useful later when adding JPEG support.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 27 ---
1 file changed, 16 insertions(+),
CODA7541 only supports encoding h.264 frames with width and height that are
multiples of the macroblock size.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git
This allows us to get rid of the now superfluous v4l2_m2m_get_vq check
in G_FMT. Also, we can use this to check the buffer type in G_SELECTION
later.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 12 +---
1 file changed, 5 insertions(+), 7
The coda h.264 decoder also counts PIC_RUNs where no frame was decoded but
a frame was rotated out / marked as ready to be displayed. This causes an
offset between the incoming encoded frame's sequence number and the decode
sequence number returned by the coda. This patch introduces a sequence
This error was introduced by 5677e3b04d3b3961200aa2bb9cc715e709eafeb9
[media] coda: update CODA7541 to firmware 1.4.50.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The coda driver advertises timestamp_type V4L2_BUF_FLAG_TIMESTAMP_COPY on
both queues, so we have to copy timestamps from input v4l2 buffers to the
corresponding destination v4l2 buffers. Since the h.264 decoder can reorder
frames, a timestamp queue is needed to keep track of and assign the
If bitrate is not set, the encoder is running in VBR mode, with the
I- and P-frame quantization parameters configured from userspace.
For the quantization parameters, 0 is a valid value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 4 ++--
1 file
This variable should be renamed to hold instead (temporarily stopping streaming
until new data is fed into the bitstream buffer).
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
This patch exports all auxiliary buffers, including SRAM, as debugfs binary
blobs for debugging purposes. It shows, for example, that psbuf currently
doesn't seem to be used at all on CODA7541, and that slicebuf and workbuf
usage is far from the maximum. It can also be used to validate SRAM size
When encoding into h.264, the input frame stride needs to be a multiple of 16.
During allocation of the input buffers, it may not be known yet whether the
encoder should create h.264 or not. Assume the worst and always use a frame
stride that is a multiple of 16.
Signed-off-by: Philipp Zabel
If the CODA reports macroblock errors, also set the VB2_BUF_STATE_ERROR flag
to alert userspace.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/coda.c
On i.MX53 and i.MX6, the CODA VPU can be reset by the System Reset Controller.
We can use this to get out of dire situations, for example after a PIC_RUN
timeout.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 51
Allow userspace to enable cyclic intra refresh by setting the number of
intra macroblocks per frame to a non-zero value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
Using the coda_mutex lock to serialize hardware access would cause
INFO: possible circular locking dependency detected lockdep warnings.
Since the possible locking paths are hard to follow, serialize hardware
access with a single workqueue thread. Ultimately the workqueue could
be converted to
v4l2_fh already contains a mem2mem context pointer. Use it.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 66 +--
1 file changed, 32 insertions(+), 34 deletions(-)
diff --git a/drivers/media/platform/coda.c
From: Michael Olbrich m.olbr...@pengutronix.de
Some drivers might allow to decode remaining frames from an internal ringbuffer
after a decoder stop command. Allow those to call v4l2_m2m_try_schedule
directly.
Signed-off-by: Michael Olbrich m.olbr...@pengutronix.de
Signed-off-by: Philipp Zabel
If the bitrate control is set, the encoder works in CBR mode, dynamically
changing the quantization parameters to achieve a constant bitrate.
With the min/max QP controls the quantization parameters can be limited
to a given range.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
The driver uses the genalloc API, which doesn't have stubs in
case GENERIC_ALLOCATOR is disabled.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/Kconfig
On Mon, Jun 16, 2014 at 12:11:20PM +0200, Denis Carikli wrote:
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to drm_display_mode.
Signed-off-by: Denis Carikli de...@eukrea.com
This patch needs an
Previously we'd add one to this value, allocating one additional, superfluous
internal buffer.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda.c
This patch adds support for the CODA960 VPU in Freescale i.MX6 SoCs.
It enables h.264 and MPEG4 encoding and decoding support. Besides the usual
register shifting, the CODA960 gains frame memory control and GDI registers
that are set up for linear mapping right now, needs ENC_PIC_SRC_INDEX to be
This adds controls for the h.264 deblocking loop filter.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda.c
Use the mem2mem helpers introduced to get rid of some duplicated code.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 113 ++
1 file changed, 14 insertions(+), 99 deletions(-)
diff --git
Hi,
this is a second shot at adding support for the CODA960 Video
Processing Unit on i.MX6Q/D/DL/S SoCs to the coda driver.
Changes since v1:
- Dropped force IDR patch.
- Dropped enum_framesizes for now.
- Clear B frame flag for decoder I/P/B frame detection.
- Rewrote g_selection to only
This adds a new function coda_check_firmware that does the firmware
version checks so that this can be done only once from coda_probe
instead of every time the runtime pm framework resumes the coda.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/media/platform/coda.c | 42
On Mon, Jun 16, 2014 at 12:11:19PM +0200, Denis Carikli wrote:
The imx-drm driver can't use the de-active and
pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock
polarity are hardcoded in the imx-drm driver.
So theses properties are now set to
Denis,
This patch creates binding documentation. Any patch which does so
should be copied to the DT people so they can review the bindings
and give appropriate acks. It would be better if you separate the
binding documentation updates from the other functional changes too.
I've added them on
Hi Hans,
Am Montag, den 16.06.2014, 10:35 +0200 schrieb Hans Verkuil:
Hi Philipp,
I went through this patch series and replied with some comments.
thank you for the comments. I have dropped the force IDR patch in
v2 and will send a separate RFC for the VFU / forced keyframe
support.
I have
Am Montag, den 16.06.2014, 10:08 +0200 schrieb Hans Verkuil:
On 06/13/2014 06:08 PM, Philipp Zabel wrote:
This patch adds support for the VIDIOC_ENUM_FRAMESIZES ioctl.
When decoding H.264, the output frame size is rounded up to the
next multiple of the macroblock size (16 pixels).
Why do
On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
Signed-off-by: Denis Carikli de...@eukrea.com
It would be nice to have a little more explanation in the commit messages
for these patches. If you'd like to send me better commit messages for
these patches, I'll add them to what I
Am Montag, den 16.06.2014, 10:24 +0200 schrieb Hans Verkuil:
On 06/13/2014 06:08 PM, Philipp Zabel wrote:
This disables forcing IDR frames at GOP size intervals on CODA7541 and
CODA960,
which is only needed to work around a firmware bug on CodaDx6.
Instead, the V4L2_BUF_FLAG_KEYFRAME
On Tue, May 27, 2014 at 10:38 AM, Enrico ebut...@users.berlios.de wrote:
On Mon, May 26, 2014 at 9:50 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hello,
This patch sets implements support for BT.656 and interlaced formats in the
OMAP3 ISP driver. Better late than never I
Le mardi 24 juin 2014 à 16:55 +0200, Philipp Zabel a écrit :
This patch adds support for the CODA960 VPU in Freescale i.MX6 SoCs.
It enables h.264 and MPEG4 encoding and decoding support. Besides the usual
register shifting, the CODA960 gains frame memory control and GDI registers
that are
On 06/24/2014 05:13 PM, Russell King - ARM Linux wrote:
[...]
If you'd like to send me better commit messages for
these patches, I'll add them to what I already have:
imx-drm: use defines for clock polarity settings
The comment of the clk_pol field of the ipu_di_signal_cfg struct was
On Tue, Jun 24, 2014 at 06:25:19PM +0200, Denis Carikli wrote:
On 06/24/2014 05:13 PM, Russell King - ARM Linux wrote:
[...]
If you'd like to send me better commit messages for
these patches, I'll add them to what I already have:
imx-drm: use defines for clock polarity settings
The
Le vendredi 13 juin 2014 à 18:08 +0200, Philipp Zabel a écrit :
This patch adds support for the CODA960 VPU in Freescale i.MX6 SoCs.
I might be confused, but is this driver sharing the same device node for
the encoder and the decoder ? If so why ? I know the spec might not be
preventing it, but
Am 24.06.2014 17:19, schrieb Enrico:
On Tue, May 27, 2014 at 10:38 AM, Enrico ebut...@users.berlios.de wrote:
On Mon, May 26, 2014 at 9:50 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hello,
This patch sets implements support for BT.656 and interlaced formats in the
OMAP3 ISP
On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Denis,
This patch creates binding documentation. Any patch which does so
should be copied to the DT people so they can review the bindings
and give appropriate acks. It would be better if you separate
These are quite common and off the shelf, universal
Ku band LBNFs. They started been used in Europe
after the lunch of the Astra 1E and can be found
pretty much everywhere.
Signed-off-by: Reynaldo H. Verdejo Pinochet r.verd...@sisa.samsung.com
---
lib/libdvbv5/dvb-sat.c | 10 ++
1 file
This removes checks of struct member addresses since they likely result
in the condition always being true. Also in the stb6100_get_bandwidth
and tda8261_get_bandwidth functions the pointers frontend_ops and
tuner_ops are assigned the same addresses twice.
Signed-off-by: Emil Goode
This cleans up some line over 80 character violations.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/media/dvb-frontends/stb6100_cfg.h | 12
drivers/media/dvb-frontends/tda8261_cfg.h |9 ++---
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git
On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote:
[...]
diff --git
a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt
b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt
[...]
@@ -0,0 +1,7 @@
+Eukrea DVI-SVGA (800x600 pixels) DVI output.
Hi Thierry,
Le Tue, 24 Jun 2014 23:49:37 +0200,
Thierry Reding thierry.red...@gmail.com a écrit :
On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote:
[...]
diff --git
a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt
On Tue, Jun 24, 2014 at 02:52:11PM -0500, Rob Herring wrote:
On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
[...]
On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote:
[...]
diff --git
On Tue, Jun 24, 2014 at 11:56:39PM +0200, Eric Bénard wrote:
Hi Thierry,
Le Tue, 24 Jun 2014 23:49:37 +0200,
Thierry Reding thierry.red...@gmail.com a écrit :
On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote:
[...]
diff --git
On Tue, Jun 24, 2014 at 03:57:46PM +0100, Russell King - ARM Linux wrote:
On Mon, Jun 16, 2014 at 12:11:20PM +0200, Denis Carikli wrote:
We need a way to pass signal polarity informations
between DRM panels, and the display drivers.
To do that, a pol_flags field was added to
Add a managed token resource that can be created at device level
which can be used as a large grain lock by diverse group of drivers
such as the media drivers that share a resource.
Token resource manages a unique named string resource which is
derived from common bus_name, and hardware address
Add a managed token resource that can be created at device level
which can be used as a large grain lock by diverse group of drivers
such as the media drivers that share a resource.
Media devices often have hardware resources that are shared
across several functions. These devices appear as a
Add a new field tuner_tkn to struct dvb_frontend. Drivers can
create tuner token using devm_token_create() and initialize
the tuner_tkn when frontend is registered with the dvb-core.
This change enables drivers to provide a token devres for tuner
access control.
Change dvb_frontend to lock tuner
Add a new field tuner_tkn to struct video_device. Drivers can
create tuner token using devm_token_create() and initialize
the tuner_tkn when frontend is registered with the dvb-core.
This change enables drivers to provide a token devres for tuner
access control.
Change v4l2-core to lock tuner
au0828 is changed to use token devres as a large locking
for exclusive access to tuner function. A new tuner_tkn
field is added to struct au0828_dev. Tuner token is created
from au0828 probe() and destroyed from disconnect().
Two new routines au0828_create_token_resources() and
On Tue, Jun 24, 2014 at 04:01:58PM +0100, Russell King - ARM Linux wrote:
On Mon, Jun 16, 2014 at 12:11:19PM +0200, Denis Carikli wrote:
The imx-drm driver can't use the de-active and
pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Jun 25 04:00:27 CEST 2014
git branch: test
git hash: 1fe3a8fe494463cfe2556a25ae41a1499725c178
gcc
On Mon, Jun 16, 2014 at 12:11:18PM +0200, Denis Carikli wrote:
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v13-v14:
- Rebased
ChangeLog 12-v13:
- No changes
ChangeLog 11-v12:
- Improved the define names to match the hardware:
ENABLE_POL is not a clock signal but instead
68 matches
Mail list logo
