Re: [PATCH] media: davinci: vpif: fix array out of bound warnings

2014-08-03 Thread Sakari Ailus
Hi Prabhakar, On Fri, Jul 18, 2014 at 05:31:51PM +0100, Lad, Prabhakar wrote: This patch fixes following array out of bound warnings, drivers/media/platform/davinci/vpif_display.c: In function 'vpif_remove': drivers/media/platform/davinci/vpif_display.c:1389:36: warning: iteration 1u

[PATCH] staging: media: as102: replace custom dprintk() with dev_dbg()

2014-08-03 Thread Martin Kepplinger
remove dprintk() and replace it with dev_dbg() in order to use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de --- I don't have the device but this builds. I think this is ok when it gets reviewed. applies to -next20140801

cron job: media_tree daily build: WARNINGS

2014-08-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Aug 4 04:00:14 CEST 2014 git branch: test git hash: 0f3bf3dc1ca394a8385079a5653088672b65c5c4 gcc

[PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nicholas Krause
This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Dave Airlie
On 4 August 2014 13:25, Nicholas Krause xerofo...@gmail.com wrote: This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Please go back and read every mail sent to you in the last few weeks.

[PATCH 2/9] ddbridge: I2C client for tda18212

2014-08-03 Thread Antti Palosaari
Used tda18212 tuner is implemented as a I2C driver. Implement I2C client to ddbridge and use it for tda18212. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/pci/ddbridge/ddbridge-core.c | 70 +- drivers/media/pci/ddbridge/ddbridge.h | 1 + 2 files

[PATCH 4/9] em28xx: convert tda18212 tuner to I2C client

2014-08-03 Thread Antti Palosaari
Used tda18212 tuner is implemented as a I2C driver. Use em28xx tuner I2C client for tda18212 driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/em28xx/em28xx-dvb.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git

[PATCH 8/9] tda18212: convert to RegMap API

2014-08-03 Thread Antti Palosaari
Use RegMap API to handle all the boring I2C register access boilerplate stuff. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/Kconfig| 1 + drivers/media/tuners/tda18212.c | 131 ++-- 2 files changed, 18 insertions(+), 114

[PATCH 1/9] tda18212: prepare for I2C client conversion

2014-08-03 Thread Antti Palosaari
We need carry pointer to frontend via config struct (I2C platform_data ptr) when I2C model is used. Add that pointer first in order to keep build unbreakable during conversion. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/tda18212.h | 5 + 1 file changed, 5

[PATCH 9/9] ddbridge: fix I2C adapter capabilities

2014-08-03 Thread Antti Palosaari
It is I2C adapter, not SMBUS, which could do some simple SMBUS operations. Report is as a I2C capable too. Wrong reported type causes RegMap to fail write multiple registers using I2C register address auto-increment. Signed-off-by: Antti Palosaari cr...@iki.fi ---

[PATCH 7/9] tda18212: rename state from 'priv' to 's'

2014-08-03 Thread Antti Palosaari
Rename driver state pointer to 's' through whole driver, just because I like use shortest possible name for such common struct used everywhere in the driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/tda18212.c | 104 1 file

[PATCH 5/9] tda18212: convert driver to I2C binding

2014-08-03 Thread Antti Palosaari
Convert driver from DVB proprietary model to common I2C model. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/tda18212.c | 129 drivers/media/tuners/tda18212.h | 14 - 2 files changed, 79 insertions(+), 64 deletions(-) diff

[PATCH 6/9] tda18212: clean logging

2014-08-03 Thread Antti Palosaari
There is no need to print module name nor function name as those are done by kernel logging system when dev_xxx logging is used and driver is proper I2C driver. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/tuners/tda18212.c | 35 ++- 1 file

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Hans Verkuil
On 08/04/2014 05:25 AM, Nicholas Krause wrote: This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by: Nicholas Krause xerofo...@gmail.com Dunno what's going on here after

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nick Krause
On Mon, Aug 4, 2014 at 1:03 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 08/04/2014 05:25 AM, Nicholas Krause wrote: This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by:

[PATCH for v3.17] videobuf2-core: add comments before the WARN_ON

2014-08-03 Thread Hans Verkuil
Recently WARN_ON() calls have been added to warn if the driver is not properly returning buffers to vb2 in start_streaming (if it fails) or stop_streaming(). Add comments before those WARN_ON calls that refer to the videobuf2-core.h header that explains what drivers are supposed to do in these

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Dave Airlie
On 4 August 2014 15:03, Hans Verkuil hverk...@xs4all.nl wrote: On 08/04/2014 05:25 AM, Nicholas Krause wrote: This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR. Signed-off-by: Nicholas

[GIT PULL FOR v3.17] vb2: one fix and adding comments

2014-08-03 Thread Hans Verkuil
I'd like to get this in for 3.17: the first patch fixes a BUG_ON due to a wrong gfp_flags value, the second adds comments before two WARN_ONs that are triggered fairly often due to buggy drivers and that point the driver developer into the right direction on how to solve it. Regards,

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nick Krause
On Mon, Aug 4, 2014 at 1:38 AM, Dave Airlie airl...@gmail.com wrote: On 4 August 2014 15:03, Hans Verkuil hverk...@xs4all.nl wrote: On 08/04/2014 05:25 AM, Nicholas Krause wrote: This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE inside the for instead of not

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Nick Krause
On Mon, Aug 4, 2014 at 1:43 AM, Nick Krause xerofo...@gmail.com wrote: On Mon, Aug 4, 2014 at 1:38 AM, Dave Airlie airl...@gmail.com wrote: On 4 August 2014 15:03, Hans Verkuil hverk...@xs4all.nl wrote: On 08/04/2014 05:25 AM, Nicholas Krause wrote: This patch changes the call of

Re: [PATCH] v4l2: Change call of function in videobuf2-core.c

2014-08-03 Thread Dave Airlie
Dave, I understand your issues with my programming. I need to try and understand the kernel first before programming for it. Why do you insist on sending more patches then, every day you try and send another one or two, despite been told multiple times to a) understand what you are writing,

Re: [PATCH for v3.17] videobuf2-core: add comments before the WARN_ON

2014-08-03 Thread Pawel Osciak
On Mon, Aug 4, 2014 at 2:36 PM, Hans Verkuil hverk...@xs4all.nl wrote: Recently WARN_ON() calls have been added to warn if the driver is not properly returning buffers to vb2 in start_streaming (if it fails) or stop_streaming(). Add comments before those WARN_ON calls that refer to the