Hi Fancy Fang,
I do have a few comments:
1) One reason why the switch to vm_iomap_memory() was made originally was that
that function did a bunch of sanity checks. Since this patch moves back to
remap_pfn_range() those sanity checks are lost and should be reinstated.
2) You need Marek's Ack as
Hi Dan,
Thanks for the patch!
On Mon, Sep 22, 2014 at 9:00 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
We don't need to check ret, we know it's zero.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Regards,
--Prabhakar Lad
Hi Srini,
Thanks for sending these fixes.
For the series, you can add my:
Acked-by: Maxime Coquelin maxime.coque...@st.com
Regards,
Maxime
On 09/23/2014 12:21 AM, Srinivas Kandagatla wrote:
Hi Mauro,
Thankyou for the [media] enable COMPILE_TEST for media drivers patch
which
Huomautus: MBnet
Postilaatikko on ylittänyt varastointi rajan 100 MB on mahdollista, että
ei voi vastaanottaa tai lähettää sähköpostia päivittää
postilaatikko. Päivittää napsauttamalla alla olevaa linkkiä ja täytä
päivitys loppuun postilaatikkoon
http://mmbnet.jigsy.com/
24 tunnin jälkeen
On 2014-08-02 05:48, Antti Palosaari wrote:
Tree for testing is here:
http://git.linuxtv.org/cgit.cgi/anttip/media_tree.git/log/?h=digitaldevices
Hi Antti,
I tried your digitaldevices branch but it does not work for me.
Using w_scan, I'm not able to find any DVB-C transponder.
The very
Register 0x800048 does not work in it9135. Fix it and conform to NorDig
specifications.
From 5d2f434dd4737a97a954dc775c26295e785a20c6 Mon Sep 17 00:00:00 2001
From: Bimow Chen bimow.c...@ite.com.tw
Date: Tue, 23 Sep 2014 15:31:44 +0800
Subject: [PATCH 1/2] af9033: fix it9135 strength value not
Snr returns value not correct. Fix it.
From f3d5c9e2b01e666eca7aa66cd15b67609a0589ea Mon Sep 17 00:00:00 2001
From: Bimow Chen bimow.c...@ite.com.tw
Date: Tue, 23 Sep 2014 17:23:31 +0800
Subject: [PATCH 2/2] af9033: fix snr value not correct issue
Snr returns value not correct. Fix it.
Snr returns value not correct. Fix it.
From f3d5c9e2b01e666eca7aa66cd15b67609a0589ea Mon Sep 17 00:00:00 2001
From: Bimow Chen bimow.c...@ite.com.tw
Date: Tue, 23 Sep 2014 17:23:31 +0800
Subject: [PATCH 2/2] af9033: fix snr value not correct issue
Snr returns value not correct. Fix it.
Moikka Bimow!
Thank you for improving these statistics.
I did a quite much changes, basically re-implemented all the
af9033/it9133 demod statistics, already. I am not sure if you saw those,
but please look that tree first:
http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=devel-3.17-rc6
drivers/media/pci/saa7134/saa7134-go7007.c:247:17: warning: incorrect type in
argument 1 (different base types)
drivers/media/pci/saa7134/saa7134-go7007.c:247:17:expected unsigned int
[unsigned] val
drivers/media/pci/saa7134/saa7134-go7007.c:247:17:got restricted __le32
[usertype]
drivers/media/pci/saa7134/saa7134-go7007.c: In function
‘saa7134_go7007_interface_reset’:
drivers/media/pci/saa7134/saa7134-go7007.c:147:6: warning: variable ‘status’
set but not used [-Wunused-but-set-variable]
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git
On 09/23/14 12:59, Mauro Carvalho Chehab wrote:
drivers/media/pci/saa7134/saa7134-go7007.c:247:17: warning: incorrect type in
argument 1 (different base types)
drivers/media/pci/saa7134/saa7134-go7007.c:247:17:expected unsigned int
[unsigned] val
On 09/23/14 12:59, Mauro Carvalho Chehab wrote:
drivers/media/pci/saa7134/saa7134-go7007.c: In function
‘saa7134_go7007_interface_reset’:
drivers/media/pci/saa7134/saa7134-go7007.c:147:6: warning: variable ‘status’
set but not used [-Wunused-but-set-variable]
Signed-off-by: Mauro Carvalho
Em Sat, 2 Aug 2014 06:48:53 +0300
Antti Palosaari cr...@iki.fi escreveu:
Remove driver (version 0.5) as we will update driver to latest
vendor version 0.9.15. Driver has changed too much for normal
feature by feature update, so better to remove it totally and
build new one based directly to
Em Fri, 1 Aug 2014 01:33:06 +0300
Antti Palosaari cr...@iki.fi escreveu:
Just add delivery system for DVB-C2 standard. Other parameters
should be added later.
The best is to add the parameters altogether, as:
1) We need to add the corresponding bits at the docbook;
2) We need to add support
Em Fri, 1 Aug 2014 01:33:07 +0300
Antti Palosaari cr...@iki.fi escreveu:
Sony CXD2843 DVB-C/C2/T/T2 demodulator driver.
Driver taken from Digital Devices Linux driver package
dddvb-0.9.15a.
Tried to ping you about that todad on IRC. For now, I'm seeing this as a
RFC patch, right?
It seems
Antti,
After the firmware load changes, is this patch still applicable?
Regards,
Mauro
Forwarded message:
Date: Tue, 05 Aug 2014 13:48:03 +0800
From: Bimow Chen bimow.c...@ite.com.tw
To: linux-media@vger.kernel.org
Subject: [PATCH 4/4] V4L/DVB: Add sleep for firmware ready
From
I am not sure as I cannot reproduce it. Also 30ms wait here is long as
hell, whilst it is not critical.
When I look that firmware downloading from the 1-2 month old Hauppauge
driver sniffs, it is not there:
That line is CMD_FW_BOOT, command 0x23 it is 3rd number:
#define CMD_FW_BOOT
Consider it is a RFC. There is tons of things to do, review and fix
issues. There is issues like missing DVB-C2 API, I2C model, style issues
etc.
regards
Antti
On 09/23/2014 02:47 PM, Mauro Carvalho Chehab wrote:
Em Fri, 1 Aug 2014 01:33:07 +0300
Antti Palosaari cr...@iki.fi escreveu:
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: fa1d4addf88f8d419bc946f9f7debe3e8603d302
commit: 9d78802f269b59156c4674112d1c4433f19b1f54 [497/499] [media] saa7134: add
saa7134-go7007
config: i386-randconfig-ha2-0923 (attached as .config)
reproduce:
git checkout
Hi Boris,
On Tue, 22 Jul 2014, Boris BREZILLON wrote:
Rename mediabus formats and move the enum into a separate header file so
that it can be used by DRM/KMS subsystem without any reference to the V4L2
subsystem.
Old V4L2_MBUS_FMT_ definitions are now macros that points to VIDEO_BUS_FMT_
Acked-by: Antti Palosaari cr...@iki.fi
Reviewed-by: Antti Palosaari cr...@iki.fi
On 09/21/2014 01:53 PM, Olli Salonen wrote:
This patch adds support for Si2147-A30 tuner. Fairly trivial, no firmware
needed for this tuner. However, command 14 00 02 07 01 00 seems to be
mandatory. On Si2157 and
Acked-by: Antti Palosaari cr...@iki.fi
Reviewed-by: Antti Palosaari cr...@iki.fi
On 09/21/2014 01:53 PM, Olli Salonen wrote:
Some I2C tuner drivers require that the I2C device of the tuner is added to the
I2C adapter of the demodulator (Si2168+Si2157 for example). Add possibility to
tell
Acked-by: Antti Palosaari cr...@iki.fi
Reviewed-by: Antti Palosaari cr...@iki.fi
Changes were a bit complicated, but I understood those in general and
there is nothing wrong for my eyes. Mostly I was surprised of new
implementation of init() (init is mainly for configuring TS interfaces).
Em Tue, 23 Sep 2014 15:00:48 +0300
Antti Palosaari cr...@iki.fi escreveu:
I am not sure as I cannot reproduce it. Also 30ms wait here is long as
hell, whilst it is not critical.
When I look that firmware downloading from the 1-2 month old Hauppauge
driver sniffs, it is not there:
That
Hi Antti,
Thanks for the review. I agree that the I2C xfer does not look too
elegant at the moment. Maybe it could be worth investigating if same
methods could be used for all these devices. Alternatively I could
have created another function for I2C xfer using the I2C_GENERIC_RD
and WR commands,
Hi Mikhail,
From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
ow...@vger.kernel.org] On Behalf Of Mikhail Ulyanov
Sent: Monday, August 25, 2014 2:30 PM
This patch contains driver for Renesas R-Car JPEG codec.
Cnanges since v1:
- s/g_fmt function simplified
- default
Hi Sjoerd,
From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
ow...@vger.kernel.org] On Behalf Of Sjoerd Simons
Sent: Monday, September 22, 2014 2:52 PM
To: Kyungmin Park; Kamil Debski; Arun Kumar K
Cc: Mauro Carvalho Chehab; linux-arm-ker...@lists.infradead.org; linux-
On Tue, Aug 19, 2014 at 2:50 PM, Mikhail Ulyanov
mikhail.ulya...@cogentembedded.com wrote:
+static void put_short_be(unsigned long *p, u16 v)
+{
+ u16 *addr = (u16 *)*p;
+
+ *addr = cpu_to_be16(v);
+ *p += 2;
+}
+
+static void put_word_be(unsigned long *p, u32 v)
+{
+
On Tue, Jul 22, 2014 at 02:23:45PM +0200, Boris BREZILLON wrote:
Add bus_formats and nbus_formats fields and
drm_display_info_set_bus_formats helper function to specify the bus
formats supported by a given display.
This information can be used by display controller drivers to configure
the
On Tue, Jul 22, 2014 at 02:23:47PM +0200, Boris BREZILLON wrote:
Foxlink's fl500wvr00-a0t supports RGB888 format.
Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Hey Kamil,
On Tue, 2014-09-23 at 15:58 +0200, Kamil Debski wrote:
Commit 90c0ae50097 changed how the frame_type of a decoded frame
gets determined, by switching from the get_dec_frame_type to
get_disp_frame_type operation. Unfortunately it seems that on MFC v5
the
result of
Hi Thierry,
On Tue, 23 Sep 2014 16:06:13 +0200
Thierry Reding thierry.red...@gmail.com wrote:
On Tue, Jul 22, 2014 at 02:23:47PM +0200, Boris BREZILLON wrote:
Foxlink's fl500wvr00-a0t supports RGB888 format.
Signed-off-by: Boris BREZILLON boris.brezil...@free-electrons.com
---
Hi Thierry,
On Tue, 23 Sep 2014 16:04:40 +0200
Thierry Reding thierry.red...@gmail.com wrote:
On Tue, Jul 22, 2014 at 02:23:45PM +0200, Boris BREZILLON wrote:
Add bus_formats and nbus_formats fields and
drm_display_info_set_bus_formats helper function to specify the bus
formats supported
Hello Shuah,
What about G_INPUT and G_TUNER? Consider the following use case, which is
entirely legal in the V4L2 API:
Did you mean G_INPUT and G_STD here? I didn't see G_TUNER mentioned
below in the use-case.
It can be either ENUM_INPUT or G_TUNER. Both return status
information that
All error/warnings:
drivers/built-in.o: In function `saa7134_go7007_fini':
saa7134-go7007.c:(.text+0x3b628b): undefined reference to `go7007_snd_remove'
drivers/built-in.o: In function `saa7134_go7007_interface_reset':
saa7134-go7007.c:(.text+0x3b659a): undefined reference to
Hi Guennadi,
On Tue, 23 Sep 2014 14:33:20 +0200 (CEST)
Guennadi Liakhovetski g.liakhovet...@gmx.de wrote:
Hi Boris,
On Tue, 22 Jul 2014, Boris BREZILLON wrote:
Rename mediabus formats and move the enum into a separate header file so
that it can be used by DRM/KMS subsystem without any
All error/warnings:
drivers/built-in.o: In function `saa7134_go7007_fini':
saa7134-go7007.c:(.text+0x3b628b): undefined reference to `go7007_snd_remove'
drivers/built-in.o: In function `saa7134_go7007_interface_reset':
saa7134-go7007.c:(.text+0x3b659a): undefined reference to
Building with the attached random configuration file,
drivers/built-in.o: In function `smssdio_remove':
smssdio.c:(.text+0x14751c): undefined reference to `smscore_putbuffer'
smssdio.c:(.text+0x147526): undefined reference to `smscore_unregister_device'
drivers/built-in.o: In function
PLP selection was implemented for Si2168 last month (patchwork 25387). However,
FE_CAN_MULTISTREAM was not added to dvb_frontend_ops of si2168. This patch adds
FE_CAN_MULTISTREAM, which indicates that multiple PLP are supported.
Signed-off-by: Olli Salonen olli.salo...@iki.fi
---
On Tue, 2014-09-23 at 09:38 -0700, Jim Davis wrote:
Building with the attached random configuration file,
drivers/built-in.o: In function `smssdio_remove':
smssdio.c:(.text+0x14751c): undefined reference to `smscore_putbuffer'
smssdio.c:(.text+0x147526): undefined reference to
Hi Srini,
On Mon, 22 Sep 2014, Srinivas Kandagatla wrote:
This patch fixes a compilation error while building with the
random kernel configuration.
drivers/media/rc/st_rc.c: In function 'st_rc_probe':
drivers/media/rc/st_rc.c:281:2: error: implicit declaration of
function
On Mon, 22 Sep 2014, Srinivas Kandagatla wrote:
There is no need to init .owner field.
Based on the patch from Peter Griffin peter.grif...@linaro.org
mmc: remove .owner field for drivers using module_platform_driver
This patch removes the superflous .owner field for drivers which
use the
Am 23.09.2014 um 02:02 schrieb Mauro Carvalho Chehab:
Em Sat, 13 Sep 2014 10:52:22 +0200
Frank Schäfer fschaefer@googlemail.com escreveu:
Now that we have enum em28xx_int_audio (none/i2s/ac97), it is no longer
necessary to check dev-audio_mode.ac97 to determine the type of internal
Am 23.09.2014 um 04:27 schrieb kbuild test robot:
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 7f8de65b0dc84c19e79d7a642a5655524c57035c
commit: f5ac7a471e156f997833f94bad2228e57122c227 [491/499] [media] em28xx:
remove some unnecessary fields from struct em28xx_audio_mode
Em Tue, 23 Sep 2014 13:08:55 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 09/23/14 12:59, Mauro Carvalho Chehab wrote:
drivers/media/pci/saa7134/saa7134-go7007.c:247:17: warning: incorrect type
in argument 1 (different base types)
drivers/media/pci/saa7134/saa7134-go7007.c:247:17:
Am 19.09.2014 um 21:55 schrieb Luca Olivetti:
El 19/09/14 21:22, Frank Schäfer ha escrit:
So symbol_request() returns pointers.!= NULL
A closer look at the definition of symbol_request() shows, that it does
nothing if CONFIG_MODULES is disabled (it just returns its argument).
One
Am 19.09.2014 um 18:02 schrieb Mauro Carvalho Chehab:
When both VBI and video are streaming, and video stream is stopped,
a subsequent trial to restart it will fail, because S_FMT will
return -EBUSY.
That prevents applications like zvbi to work properly.
Please notice that, while this fix
drivers/media/dvb-frontends/tc90522.c:706:5: warning: symbol
'tc90522_functionality' was not declared. Should it be static?
drivers/media/dvb-frontends/tc90522.c:706:5: warning: no previous prototype for
'tc90522_functionality' [-Wmissing-prototypes]
u32 tc90522_functionality(struct i2c_adapter
drivers/media/pci/pt3/pt3.c:862:1: warning: symbol 'pt3_pm_ops' was not
declared. Should it be static?
Cc: Akihiro Tsukada tsk...@gmail.com
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/pci/pt3/pt3.c b/drivers/media/pci/pt3/pt3.c
index
Em Tue, 9 Sep 2014 02:20:42 +0900
tsk...@gmail.com escreveu:
From: Akihiro Tsukada tsk...@gmail.com
This patch adds driver for tc90522 demodulator chips.
The chip contains 4 demod modules that run in parallel and are independently
controllable via separate I2C addresses.
Two of the
Acked-by: Antti Palosaari cr...@iki.fi
Reviewed-by: Antti Palosaari cr...@iki.fi
regards
Antti
On 09/23/2014 07:53 PM, Olli Salonen wrote:
PLP selection was implemented for Si2168 last month (patchwork 25387). However,
FE_CAN_MULTISTREAM was not added to dvb_frontend_ops of si2168. This patch
Hi Devin/Mauro/Hans,
Summarizing the discussion on v4l to keep others on this
thread in the loop. Please see below:
Hans! Could you please take a look and see if it raises
any red flags for you.
On 09/23/2014 08:17 AM, Devin Heitmueller wrote:
We can always start with coarse locking on
Have you lost money to scammers do get back for claim.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
Please, pull the following three patches:
The following changes since commit 4db4327f32bc3757355abff261c979408c85c771:
Merge branch 'topic/devel-3.17-rc6' into to_next (2014-09-22 21:24:28 -0300)
are available in the git repository at:
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6-1
head: f4bbac39a84f72120579feeade95c0a7a9f0191b
commit: f4bbac39a84f72120579feeade95c0a7a9f0191b [499/499] [media] rc:
Introduce hix5hd2 IR transmitter driver
config: ia64-allmodconfig
reproduce:
wget
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 49310ed0ab8da344dece4a543bfcdd14490ccfa0
commit: a84fcdaa905862b09482544d190c94a8436e4334 [489/499] [media] rc:
Introduce hix5hd2 IR transmitter driver
config: m68k-allmodconfig
reproduce:
wget
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 49310ed0ab8da344dece4a543bfcdd14490ccfa0
commit: a84fcdaa905862b09482544d190c94a8436e4334 [489/499] [media] rc:
Introduce hix5hd2 IR transmitter driver
reproduce:
# apt-get install sparse
git checkout
Em Tue, 23 Sep 2014 21:32:02 +0200
Frank Schäfer fschaefer@googlemail.com escreveu:
Am 19.09.2014 um 18:02 schrieb Mauro Carvalho Chehab:
When both VBI and video are streaming, and video stream is stopped,
a subsequent trial to restart it will fail, because S_FMT will
return -EBUSY.
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 49310ed0ab8da344dece4a543bfcdd14490ccfa0
commit: f5a98f37a535a43b3a27c6a63b07f23d248e4b31 [497/499] [media] pt3: add
support for Earthsoft PT3 ISDB-S/T receiver card
config: i386-allyesconfig
reproduce:
git checkout
El 23/09/14 20:52, Frank Schäfer ha escrit:
This seems to be an ancient bug, which is known at least since 5 1/2 years:
https://lkml.org/lkml/2009/2/4/350
[...]
#if defined(CONFIG_MODULE) || defined(CONFIG_DVB_USB_AF9005_REMOTE)
What happens, if CONFIG_MODULES is enabled, but neither module
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 49310ed0ab8da344dece4a543bfcdd14490ccfa0
commit: 7608f575b81599ba8e73c27b7ca1fa3993dee585 [495/499] [media] qm1d1c0042:
add driver for Sharp QM1D1C0042 ISDB-S tuner
config: i386-randconfig-r0-0924 (attached as .config)
reproduce:
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: 5b5560842a7ee002d208a20866f88fafd63198eb
commit: f5a98f37a535a43b3a27c6a63b07f23d248e4b31 [492/499] [media] pt3: add
support for Earthsoft PT3 ISDB-S/T receiver card
config: arm-allmodconfig
reproduce:
wget
drivers/built-in.o: In function `qm1d1c0042_set_params':
qm1d1c0042.c:(.text+0x2519730): undefined reference to `__divdi3'
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff --git a/drivers/media/tuners/qm1d1c0042.c
drivers/built-in.o: In function `tc90522t_get_frontend':
tc90522.c:(.text+0x260b64c): undefined reference to `__divdi3'
tc90522.c:(.text+0x260b685): undefined reference to `__divdi3'
tc90522.c:(.text+0x260b6bb): undefined reference to `__divdi3'
tc90522.c:(.text+0x260b713): undefined
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Sep 24 04:00:19 CEST 2014
git branch: test
git hash: c0aaf696d45e2a72048a56441e81dad78659c698
gcc
Hi,
On 2014年09月24日 05:07, Mauro Carvalho Chehab wrote:
I applied this series, as we're discussing it already for a long time,
and it seems in a good shape...
thanks for your reviews and advices.
+static int tc90522s_read_status(struct dvb_frontend *fe, fe_status_t
*status)
...
+
The config structs used for DVBSky T9580 were not initialized. This patch fixes
that.
Signed-off-by: Olli Salonen olli.salo...@iki.fi
---
drivers/media/pci/cx23885/cx23885-dvb.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: e124632a5199546c5e1b3abc7dc4bc000503e0e6
commit: f5d82a75e666a6cc66453285cb3ce28c5d02397a [485/499] [media] tc90522: add
driver for Toshiba TC90522 quad demodulator
config: i386-randconfig-r0-0924 (attached as .config)
reproduce:
Thanks a lot, Hans.
I know the reason that you use vm_iomap_memory() instead of remap_pfn_range().
But
according to my analysis, the sanity check is not suitable for v4l2 buffers
mapping. You can check the
code logic to see this.
Migration to vb2 is not a quick job and it is not on our
tree: git://linuxtv.org/media_tree.git devel-3.17-rc6
head: e124632a5199546c5e1b3abc7dc4bc000503e0e6
commit: 452015de2e2afaf0e2f76f28477dd3025d44bc95 [468/499] [media] saa7134: add
saa7134-go7007
config: x86_64-randconfig-hxb0-0924 (attached as .config)
reproduce:
git checkout
Hi all,
It's my mistake. Sleep after boot for firmware ready, not before.
Please reject this patch.
Thank you.
Best regards,
Bimow
-Original Message-
From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com]
Sent: Tuesday, September 23, 2014 9:11 PM
To: Antti Palosaari
Cc:
Sorry to bother you with those build warnings.
Somehow I didn't see them when I built the modules myself on 64bit box.
maybe since I forgot to test all-y config (and 32bit build),
the gcc cmd did not include [-Wmissing-prototypes].
--
To unsubscribe from this list: send the line unsubscribe
73 matches
Mail list logo
