Hi Laurent-san,
Thanks for your comment.
2014-12-21 3:35 GMT+09:00 Laurent Pinchart laurent.pinch...@ideasonboard.com:
Hello Kaneko-san,
Thank you for the patch.
On Saturday 20 December 2014 23:16:03 Yoshihiro Kaneko wrote:
From: Hiroki Negishi hiroki.negishi...@hitachi-solutions.com
The following changes since commit 654a731be1a0b6f606f3f3d12b50db08f2ae3c34:
[media] media: s5p-mfc: use vb2_ops_wait_prepare/finish helper
(2014-12-22 14:36:21 -0200)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git WinTV-HVR5525
for you to fetch changes
Hi Philipp,
On 12/22/2014 04:11 PM, Philipp Zabel wrote:
This patch adds a function to get a port device tree node by port id,
or reg property value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
drivers/of/base.c
Hi Andrzej,
On Tue, Dec 23, 2014 at 12:10:00PM +0100, Andrzej Hajda wrote:
[...]
/**
+ * of_graph_get_port_by_id() - get the port matching a given id
+ * @parent: pointer to the parent device node
Here you have 'parent' and 'node' in the code.
[...]
Maybe I miss something but it does
On Mon, Dec 22, 2014 at 02:09:46PM -0700, Mathieu Poirier wrote:
On 22 December 2014 at 08:11, Philipp Zabel p.za...@pengutronix.de wrote:
Decrementing the reference count of the previous endpoint node allows to
use the of_graph_get_next_endpoint function in a for_each_... style macro.
All
As promised, let's remove these for 3.20.
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Hans Verkuil hans.verk...@cisco.com
Remove obsolete text files for drivers that have been removed.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/video4linux/CQcam.txt | 205 ---
Documentation/video4linux/README.tlg2300 | 47 ---
From: Hans Verkuil hans.verk...@cisco.com
These drivers haven't been tested in a long, long time. The hardware is
ancient and hopelessly obsolete. These drivers also need to be converted
to newer media frameworks but due to the lack of hardware that's going
to be impossible. In addition, cheaper
From: Hans Verkuil hans.verk...@cisco.com
This driver hasn't been tested in a long, long time. The company that made
this chip has gone bust many years ago and hardware using this chip is next
to impossible to find.
This driver needs to be converted to newer media frameworks but due to the
lack
The videobuf_dma_init* and videobuf_dma_map() functions are no longer
used except in videobuf-dma-sg.c itself. Make them static.
These functions were abused in various drivers. All those drivers
have now been fixed, so by no longer exporting these functions
future abuse is now prevented.
Hi,
I addressed Andrzej's comments on of_graph_get_port_by_id() and added
Mathieu's ack to the first patch. Also I missed the omap2-dss init code
last time around. For the first patch, I'd like to get an ack for the rcar-du
and omap2-dss changes so this can go in through Grant's tree.
This
Decrementing the reference count of the previous endpoint node allows to
use the of_graph_get_next_endpoint function in a for_each_... style macro.
All current users of this function that pass a non-NULL prev parameter
(coresight, rcar-du, imx-drm, soc_camera, and omap2-dss) are changed to
not
Note that while of_graph_get_next_endpoint decrements the reference count
of the child node passed to it, of_node_put(child) still has to be called
manually when breaking out of the loop.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart
This patch adds a function to get a port device tree node by port id,
or reg property value.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
---
Changes since v6:
- Fixed of_graph_get_port_by_id to handle the optional 'ports' node
As shown at the code, upd_demod_gain_period is used to write
to two 16-bit registers:
dib8000_write_word(state, 1946, upd_demod_gain_period 0x);
dib8000_write_word(state, 1947, reg | (114) | ((upd_demod_gain_period
16) 0xFF));
So, it should be declared as u32.
This fixes the
Hi,
The work on a common CEC framework was started over three years ago by Hans
Verkuil. Unfortunately the work has stalled. As I have received the task of
creating a driver for the CEC interface module present on the Exynos range of
SoCs, I got in touch with Hans. He repied that the work stalled
From: Hans Verkuil hansv...@cisco.com
Add the CEC framework.
Signed-off-by: Hans Verkuil hansv...@cisco.com
[k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil]
[k.deb...@samsung.com: Merged Update author commit by Hans Verkuil]
[k.deb...@samsung.com: change kthread handling when
From: Hans Verkuil hansv...@cisco.com
Add CEC support to the adv7511 driver.
Signed-off-by: Hans Verkuil hansv...@cisco.com
[k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil]
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
drivers/media/i2c/adv7511.c | 325
Add CEC interface driver present in the Samsung Exynos range of
SoCs.
The following files were based on work by SangPil Moon:
- exynos_hdmi_cec.h
- exynos_hdmi_cecctl.c
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
.../devicetree/bindings/video/exynos_cec.txt | 26 ++
From: Hans Verkuil hansv...@cisco.com
Add callbacks to the v4l2_subdev_video_ops.
Signed-off-by: Hans Verkuil hansv...@cisco.com
[k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil]
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
include/media/v4l2-subdev.h |8
From: Hans Verkuil hansv...@cisco.com
Add CEC support ot the adv7604 driver.
Signed-off-by: Hans Verkuil hansv...@cisco.com
[k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil]
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
drivers/media/i2c/adv7604.c | 182
Add s5p-cec driver bindings to the board file of the Exynos 4412 Odroid U3.
Signed-off-by: Kamil Debski k.deb...@samsung.com
---
arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts
As reported by smatch:
drivers/media/pci/cx23885/cx23885-dvb.c:2080 dvb_register() Function
too hairy. Giving up.
This is indeed a too complex function, with lots of stuff inside.
Breaking this into two functions makes it a little bit less hairy.
Signed-off-by: Mauro Carvalho Chehab
--
guten Tag
Ich bin mit diesem Medium, um Sie über die Transaktion zur
Abgabe von $ 2150 (Einundzwanzig Millionen fünfhunderttausend Euro)
in meiner Bank in China, Sie als Empfänger zu informieren. Es wird zu
100% sicher, dass der Finanzvorstand des verstorbenen Kunden.
Fix the following smatch warning:
drivers/media/pci/cx88//cx88-dvb.c:1508 dvb_register() warn: if
statement not indented
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
---
drivers/media/pci/cx88/cx88-dvb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Em Mon, 22 Dec 2014 13:25:45 -0700
Jim Davis jim.ep...@gmail.com escreveu:
This driver doesn't build with the current kernel, as reported in
linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day
build system
Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to
preserve the existing dependency.
Fixes: ea2e813e8cc3 ([media] tlg2300: move to staging in preparation for
removal)
Cc: Hans Verkuil hverk...@xs4all.nl
Cc: Jim Davis jim.ep...@gmail.com
Signed-off-by: Mauro Carvalho Chehab
Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to
preserve the existing dependency.
fixes: c1d9e03d4ef4 ([media] vino/saa7191: move to staging in preparation for
removal)
Cc: Hans Verkuil hverk...@xs4all.nl
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
diff
Acked-by: Hans Verkuil hans.verk...@cisco.com
On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote:
Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to
preserve the existing dependency.
fixes: c1d9e03d4ef4 ([media] vino/saa7191: move to staging in preparation
for removal)
Acked-by: Hans Verkuil hans.verk...@cisco.com
On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote:
Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to
preserve the existing dependency.
Fixes: ea2e813e8cc3 ([media] tlg2300: move to staging in preparation for
removal)
Cc:
Em Wed, 3 Dec 2014 22:46:41 +0100
Pavel Machek pa...@ucw.cz escreveu:
We are moving to device tree support on OMAP3, but that currently
breaks ADP1653 driver. This adds device tree support, plus required
documentation.
Signed-off-by: Pavel Machek pa...@ucw.cz
Please be sure to check your
On Tue 2014-12-23 15:23:25, Mauro Carvalho Chehab wrote:
Em Wed, 3 Dec 2014 22:46:41 +0100
Pavel Machek pa...@ucw.cz escreveu:
We are moving to device tree support on OMAP3, but that currently
breaks ADP1653 driver. This adds device tree support, plus required
documentation.
Convert that driver to I2C driver model.
Legacy DVB binding is left also for later removal...
Tested-by: Benjamin Larsson benja...@southpole.se
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 113 +
As rtl2832 driver support now I2C binding we will switch to that one.
Tested-by: Benjamin Larsson benja...@southpole.se
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 29 ++---
drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 1 +
2
RTL2832 demod integrated into RTL2832U has PID filter. PID filtering
is provided by rtl2832 demod driver. Add support for it.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 33 +
1 file changed, 29 insertions(+), 4
Tuners are connected to demod I2C adapter. Use that muxed adapter
for each tuner. That allows us to get rid of hackish FE gate control
solution.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 13 -
1 file changed, 8 insertions(+), 5
As a I2C driver struct i2c_client is top level structure representing
the driver. Use it as parameter to carry all needed information for
each function in order to simplify things.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 97
Pass correct device, platform device, for logging system in order
to format printouts correctly.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832_sdr.c | 151 +-
1 file changed, 86 insertions(+), 65 deletions(-)
diff --git
Implement PID filter. This demod has PID filter size of 32 PIDs.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 69 ++
drivers/media/dvb-frontends/rtl2832.h | 2 +
drivers/media/dvb-frontends/rtl2832_priv.h | 1 +
3
Estimate signal strength from IF digital AGC.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
b/drivers/media/dvb-frontends/rtl2832.c
index
Change legacy DVBv3 read BER to return values calculated by DVBv5
statistics.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 15 ++-
drivers/media/dvb-frontends/rtl2830_priv.h | 1 +
2 files changed, 3 insertions(+), 13 deletions(-)
Change legacy DVBv3 read BER to return values calculated by DVBv5
statistics.
---
drivers/media/dvb-frontends/rtl2832.c | 13 ++---
drivers/media/dvb-frontends/rtl2832_priv.h | 1 +
2 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
Move all needed configuration values to platform data structure
and remove old configuration code where possible.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 48 +++---
drivers/media/dvb-frontends/rtl2832.h | 20
Use regmap to cover register access routines.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/Kconfig| 1 +
drivers/media/dvb-frontends/rtl2832.c | 329 +++--
drivers/media/dvb-frontends/rtl2832_priv.h | 4 +-
3 files changed,
Change legacy DVBv3 read SNR to return values calculated by DVBv5
statistics.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 42 +++---
drivers/media/dvb-frontends/rtl2832_priv.h | 1 +
2 files changed, 5 insertions(+), 38
Small cleanups. Remove unneeded variables. Some checkpatch issues.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832_sdr.c | 46 +++
drivers/media/dvb-frontends/rtl2832_sdr.h | 17
2 files changed, 23 insertions(+), 40
DVBv5 CNR.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 73 +-
drivers/media/dvb-frontends/rtl2832_priv.h | 3 +-
2 files changed, 73 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
DVBv5 BER.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 25 +
drivers/media/dvb-frontends/rtl2830_priv.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2830.c
Both mn88472 and mn88473 slave demods are connected to master I2C
bus, not the bus behind master demod I2C gate like tuners. Use
correct bus.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Chips uses 8-bit register addresses with 5 pages. Extend register
address by using register page as a first byte of address, defining
virtual register addresses. That is common method of handling
register pages and regmap also uses it. Remove page + address
conversion glue which was there for
Switch demod resource use from exported symbols to callbacks its
provides.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 39 +
drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 5 -
2 files changed, 24 insertions(+), 20
Use platform data configuration for rtl2832 demod driver. Old
configuration are still left as it is used for rtl2832_sdr driver.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 38 +++--
1 file changed, 32 insertions(+), 6
There is no need to do software reset on init() as it is done a bit
later on end of set_frontend(). Software reset usually means
restarting (resetting to starting point) chip internal state machine
(FSM). Naturally it is done after all parameters are programmed.
Signed-off-by: Antti Palosaari
Rename it device state variable to dev. Both priv and dev are very
common terms for such variable in kernel, but I like use dev in
order to keep drivers consistent.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 272 ++---
'dev' sounds better than 's' for such variable.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832_sdr.c | 858 +++---
1 file changed, 429 insertions(+), 429 deletions(-)
diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c
Add callback for all of those functions which are currently
exported using EXPORT_SYMBOL. That allows us convert every user to
callbacks and eventually all exported symbols could be removed.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 90
Use regmap to cover register access routines.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/Kconfig| 1 +
drivers/media/dvb-frontends/rtl2830.c | 415 +
drivers/media/dvb-frontends/rtl2830_priv.h | 4 +-
3 files changed,
DVBv5 BER.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 25 +
drivers/media/dvb-frontends/rtl2832_priv.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
Demod lock flags are derived from demod state machine states. States
are running from 1 to 11, where highest state 11 means demod is
fully locked and streaming. Naturally smaller state numbers means
there is some partial locks.
Define now state 10 as missing synch and lock.
Signed-off-by: Antti
We don't need it anymore as all users are using muxed I2C adapter.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 33 --
drivers/media/dvb-frontends/rtl2832_priv.h | 1 -
2 files changed, 34 deletions(-)
diff --git
Exported resources are not needed anymore as all users are using
callbacks carried via platform data. Due to that we will remove
those.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 138 --
Pass correct device pointer to dev_* logging functions in order
print logs correctly.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 102 +++---
1 file changed, 57 insertions(+), 45 deletions(-)
diff --git
RTL2832 SDR module implements kernel platform driver. Change old
binding to that one.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 126
drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 3 +
2 files changed, 50
Enable regmap register cache in order to reduce IO.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
b/drivers/media/dvb-frontends/rtl2832.c
index
Provide register read and write callbacks for SDR module.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 3 +++
drivers/media/dvb-frontends/rtl2832.h | 4
2 files changed, 7 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
Estimate signal strength from IF AGC.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2830.c
b/drivers/media/dvb-frontends/rtl2830.c
index
That SDR driver module was abusing DVB frontend SEC (satellite
equipment controller) device and due to that it was also using
legacy DVB binding. Platform bus is pseudo-bus provided by kernel
driver model and it fits cases like that, where any other busses
are not suitable.
Signed-off-by: Antti
Change legacy DVBv3 signal strength to return values calculated by
DVBv5 statistics.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 27 ---
1 file changed, 4 insertions(+), 23 deletions(-)
diff --git
Own I2C locking is needed due to two special reasons:
1) Chips uses multiple register pages/banks on single I2C slave.
Page is changed via I2C register access.
2) Chip offers muxed/gated I2C adapter for tuner. Gate/mux is
controlled by I2C register access.
Due to these reasons, I2C locking did
Implement PID filter.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 67 ++
drivers/media/dvb-frontends/rtl2830.h | 2 +
drivers/media/dvb-frontends/rtl2830_priv.h | 1 +
3 files changed, 70 insertions(+)
diff
DVBv5 CNR.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 74 ++
drivers/media/dvb-frontends/rtl2830_priv.h | 3 ++
2 files changed, 77 insertions(+)
diff --git a/drivers/media/dvb-frontends/rtl2830.c
Remove internal config and use configuration values directly from
the platform data.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 43 --
drivers/media/dvb-frontends/rtl2830_priv.h | 15 +--
2 files changed, 18
Trivial changes proposed by checkpatch.pl and some more.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 125 ++---
drivers/media/dvb-frontends/rtl2830.h | 4 -
drivers/media/dvb-frontends/rtl2830_priv.h | 3 -
3 files
We must unregister frontend first and after that driver itself. That
order went wrong after demod drivers were switched to kernel I2C
drivers, causing crashes.
Tested-by: Benjamin Larsson benja...@southpole.se
Signed-off-by: Antti Palosaari cr...@iki.fi
---
RTL2830 demod integrated to RTL2831U has PID filter. PID filtering
is provided by rtl2830 demod driver. Add support for it.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 25 +
1 file changed, 25 insertions(+)
diff --git
Remove legacy DVB binding as all users are using I2C binding.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 101 -
drivers/media/dvb-frontends/rtl2830.h | 63 --
Pass correct device for dev_foo() logging in order to print logs
correctly.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 43 +--
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git
Change legacy DVBv3 read SNR to return values calculated by DVBv5
statistics.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 44 ++
drivers/media/dvb-frontends/rtl2830_priv.h | 1 +
2 files changed, 4 insertions(+), 41
Use name 'dev' for device state instance as it is more common and
also one letter shorter.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2830.c | 212 ++---
drivers/media/dvb-frontends/rtl2830_priv.h | 2 +-
2 files changed, 107
rtl2830 driver supports now I2C model too. Start using it.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 80 +++--
drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 17 +++
2 files changed, 54 insertions(+), 43 deletions(-)
Convert driver to kernel I2C model. Old DVB proprietary model is
still left there also.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/Kconfig| 2 +-
drivers/media/dvb-frontends/rtl2830.c | 167 +
Top level pointer on USB probe is struct usb_interface *. Add that
pointer to struct dvb_usb_device that drivers could use it, for
dev_* logging and more.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/dvb_usb.h | 2 ++
Remove all the stuff that is not needed anymore. Rename variable.
Remove extra new lines.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 72 --
drivers/media/dvb-frontends/rtl2832.h | 32 +
I prefer dev over priv and I want keep all my drivers in line with
that.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 238
drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 2 +-
2 files changed, 120 insertions(+), 120
As all the callbacks are already same we could merge device
properties struct too and save space.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 93 +++--
1 file changed, 31 insertions(+), 62 deletions(-)
diff --git
Put demod to soft reset in order to save power when sleep. That drops
power usage ~30mA @5V on USB dongle I tested. In real life it does
not matter much as USB IF powers off demod too, but now it is done
twice - demod and USB IF.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
We are consumer of DVB frontend provided by rtl28xxu module. Due to
that we must use refcount to ensure none could remove rtl28xxu when
we are alive (or when we are streaming, if more fine-grained
refcounting is wanted).
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Use rtl28xxu_ prefix for all register access routine names.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 100
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
Pass correct device pointer to dev_* logging in order to print
module name and bus id correctly.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 90 +++--
1 file changed, 42 insertions(+), 48 deletions(-)
diff --git
I have implemented tons of things for that driver, more than anyone
else, so lets claim copyright and module authorship.
Cc: Thomas Mair thomas.mai...@gmail.com
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/dvb-frontends/rtl2832.c | 2 ++
Merge all chip type specific prefixed (rtl2831u_ and rtl2832u_)
callback to top level callback prefixed as rtl28xxu_.
rtl2831u_foo() = rtl28xxu_foo()
rtl2832u_foo() = rtl28xxu_foo()
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 140
Detect automatically whether chip is old RTL2831U or newer
RTL2832U/RTL2832P. Detection is based I2C command that is found only
from newer RTL2832U models.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 31 +++
1 file
Buffer needed for USB control message is small so move it to state
and get rid of alloc/free used for each control message.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 31 +--
drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 1 +
This driver, rtl28xxu, offers frontend service for rtl2832_sdr
module, thus we are producer and rtl2832_sdr module is consumer.
Due to that, reference counting should be done in way rtl2832_sdr
takes refrence to rtl28xxu. Remove wrong refcount.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
Logic is so simple that there is no idea to separate tuner selection to
own function, instead do it in a callback and get rid of one function.
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 27 +--
1 file changed, 9
Introduce own lock to silence lockdep warning. lockdep validator
makes wrong decision when two similar (map-mutex) locks were taken
recursively, even those are different mutexes in a two different
drivers. After that patch, functionality remains same, but mutex names
are different. That is a
There was 2 muxed I2C adapters, one for demod tuner bus and one for
internal use. Idea of internal I2C adapter was to force I2C repeater
close when demod access its registers. Driver has also delayed work
queue based method to close I2C repeater.
After regmap conversion internal I2C adapter based
DVB FE callback functionality went broken after I moved tuners to
demod muxed I2C adapter. That happens because driver state was
carried by I2C adapter and when mux is used there is one adapter
more in a chain.
USB adapter - I2C adapter - muxed I2C adapter
Signed-off-by: Antti Palosaari
On 12/23/2014 09:49 PM, Antti Palosaari wrote:
Both mn88472 and mn88473 slave demods are connected to master I2C
bus, not the bus behind master demod I2C gate like tuners. Use
correct bus.
Hello Antti, in my work tree I am still getting i2c errors even with the
ir poll workaround (it takes
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Dec 24 04:00:12 CET 2014
git branch: test
git hash: cb9564e133f4f790920d715714790512085bb2e3
gcc
100 matches
Mail list logo
