Re: [PATCH v1 01/11] leds: Add support for max77693 mfd flash cell

2015-03-23 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 03/21/2015 11:44 PM, Sakari Ailus wrote: Hi Jacek, On Fri, Mar 20, 2015 at 04:03:21PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface.

Re: [PATCH] Add device tree support to adp1653 flash driver

2015-03-23 Thread Pavel Machek
Hi! Nokia N900 is switching to device tree, make sure we can use flash there, too. Signed-off-by: Pavel Machek pa...@ucw.cz Sakari, you are marked as a matinainer for this driver. Can you take the patch so that it makes it into 4.1? Thanks,

Re: [PATCH/RFC v13 03/13] leds: Add support for max77693 mfd flash cell

2015-03-23 Thread Lee Jones
This patch requires a DT Ack. Whoops, not this one. Patch 4. This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Lee Jones
This patch requires a DT Ack. This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com Acked-by: Kyungmin Park

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Lee Jones
On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 12:07:43, Lee Jones wrote: This patch requires a DT Ack. No, it requires DT people to be notified -- and they were, few times by now. They clearly don't care. Well fortunately for the Kernel community, I do care. And as this

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

2015-03-23 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 03/22/2015 01:22 AM, Sakari Ailus wrote: Hi Jacek, Thanks for the updated set. Some comments below. On Fri, Mar 20, 2015 at 04:03:27PM +0100, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices

Re: [RFC] Extend struct v4l2_fmtdesc to give more format info

2015-03-23 Thread Hans Verkuil
On 03/22/2015 08:56 AM, Sakari Ailus wrote: Hi Hans, On Fri, Mar 20, 2015 at 02:25:57PM +0100, Hans Verkuil wrote: This is a proposal to extend the information returned by v4l2_fmtdesc (VIDIOC_ENUM_FMT). Especially in combination with my previous RFC PATCH

Re: [RFC PATCH] v4l2-ioctl: fill in the description for VIDIOC_ENUM_FMT

2015-03-23 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Friday 20 March 2015 13:17:19 Hans Verkuil wrote: The descriptions used in drivers for the formats returned with ENUM_FMT are all over the place. So instead allow the core to fill in the description and flags. This allows drivers to drop the description

Re: [media-workshop] [ANN] Media Mini-Summit Draft Agenda for March 26th

2015-03-23 Thread Shuah Khan
On Sun, Mar 22, 2015 at 10:02 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Em Mon, 16 Mar 2015 12:25:28 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: This is the draft agenda for the media mini-summit in San Jose on March 26th. Time: 9 AM to 5 PM (approximately) Room: TBC

Re: [RFC PATCH] v4l2-ioctl: fill in the description for VIDIOC_ENUM_FMT

2015-03-23 Thread Hans Verkuil
On 03/22/2015 01:38 PM, Laurent Pinchart wrote: Hi Hans, Thank you for the patch. On Friday 20 March 2015 13:17:19 Hans Verkuil wrote: The descriptions used in drivers for the formats returned with ENUM_FMT are all over the place. So instead allow the core to fill in the description and

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Pavel Machek
On Mon 2015-03-23 12:07:43, Lee Jones wrote: This patch requires a DT Ack. No, it requires DT people to be notified -- and they were, few times by now. They clearly don't care. This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional

Re: [PATCH v1 06/11] exynos4-is: Add support for v4l2-flash subdevs

2015-03-23 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 03/22/2015 02:21 AM, Sakari Ailus wrote: Hi Jacek, Some comments below. Please also get an ack from Sylwester! :-) No doubt about that :) On Fri, Mar 20, 2015 at 04:03:26PM +0100, Jacek Anaszewski wrote: This patch adds support for external v4l2-flash

[v4l-utils] dvbv5-scan stores incorrect channel data for DVB-S

2015-03-23 Thread Olli Salonen
Hi, I noticed that when doing a channel scan using dvbv5-scan the scan results in a bogus dvb_channel.conf file. During the scan the correct frequency is printed out: Scanning frequency #1 11265000 Service Viasat History HD, provider (null): reserved Service TV6 HD Sweden, provider (null):

Re: [sur40] Debugging a race condition?

2015-03-23 Thread Florian Echtler
Additional note: this happens almost never with the original code using dma-contig, which is why I didn't catch it during testing. I've now switched back and forth between the two versions multiple times, and it's definitely a lot less stable with dma-sg and usb_sg_init/_wait. Maybe that can help

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Pavel Machek
On Mon 2015-03-23 15:02:13, Lee Jones wrote: On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 12:07:43, Lee Jones wrote: This patch requires a DT Ack. No, it requires DT people to be notified -- and they were, few times by now. They clearly don't care. Well

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Lee Jones
On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 15:02:13, Lee Jones wrote: On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 12:07:43, Lee Jones wrote: This patch requires a DT Ack. No, it requires DT people to be notified -- and they were, few times by

[sur40] Debugging a race condition?

2015-03-23 Thread Florian Echtler
Hello everyone, now that I'm using the newly merged sur40 video driver in a development environment, I've noticed that a custom V4L2 application we've been using in our lab will sometimes trigger a hard lockup of the machine (_nothing_ works anymore, no VT switching, no network, not even Magic

Re: [PATCH/RFC v13 03/13] leds: Add support for max77693 mfd flash cell

2015-03-23 Thread Lee Jones
This patch requires a DT Ack. This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software.

Re: [PATCH v1.1 14/15] omap3isp: Add support for the Device Tree

2015-03-23 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. This looks good to me, except that there's one last bug I've spotted. Please see below. On Saturday 21 March 2015 00:05:04 Sakari Ailus wrote: Add the ISP device to omap3 DT include file and add support to the driver to use it. Also obtain information on

Re: [PATCH V3] [media] mantis: fix error handling

2015-03-23 Thread Dan Carpenter
On Mon, Mar 23, 2015 at 05:25:53PM +0100, Silvan Jegen wrote: Remove dead code, make goto label names more expressive and add a label in order to call mantis_dvb_exit if mantis_uart_init fails. Also make sure that mantis_pci_exit is called if we fail the mantis_stream_control call and that

[PATCH v2 RESEND 3/4] v4l: of: Parse variable length properties --- link-frequencies

2015-03-23 Thread Sakari Ailus
The link-frequencies property is a variable length array of link frequencies in an endpoint. The array is needed by an increasing number of drivers, so it makes sense to add it to struct v4l2_of_endpoint. However, the length of the array is variable and the size of struct v4l2_of_endpoint is

[PATCH v2 RESEND 4/4] smiapp: Use v4l2_of_alloc_parse_endpoint()

2015-03-23 Thread Sakari Ailus
Instead of parsing the link-frequencies property in the driver, let v4l2_of_alloc_parse_endpoint() do it. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/i2c/smiapp/smiapp-core.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff

Re: [PATCH v1 02/11] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Jacek Anaszewski
Hi Sakari, On 03/21/2015 11:49 PM, Sakari Ailus wrote: Hi Jacek, On Fri, Mar 20, 2015 at 04:03:22PM +0100, Jacek Anaszewski wrote: +Optional properties of the LED child node: +- label : see Documentation/devicetree/bindings/leds/common.txt I'm still not comfortable using the label field

[PATCH v2 RESEND 2/4] v4l: of: Instead of zeroing bus_type and bus field separately, unify this

2015-03-23 Thread Sakari Ailus
Clean the entire struct starting from bus_type. As more fields are added, no changes will be needed in the function to reset their value explicitly. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/v4l2-core/v4l2-of.c |5 +++-- include/media/v4l2-of.h |1 + 2

[PATCH v2 RESEND 0/4] Add link-frequencies to struct v4l2_of_endpoint

2015-03-23 Thread Sakari Ailus
(Resending; fixed Sylwester's e-mail address.) Hi, I've split off the third and obviously somewhat problematic patch in the set, and sent a pull req containing the first two patches and another dependent patch: URL:http://www.spinics.net/lists/linux-media/msg88033.html The changes intend to

[PATCH v2 RESEND 1/4] v4l: of: Remove the head field in struct v4l2_of_endpoint

2015-03-23 Thread Sakari Ailus
The field is unused. Remove it. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi --- include/media/v4l2-of.h |2 -- 1 file changed, 2 deletions(-) diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h index 70fa7b7..dc468de 100644 --- a/include/media/v4l2-of.h +++

Re: [RFC PATCH] v4l2-ioctl: fill in the description for VIDIOC_ENUM_FMT

2015-03-23 Thread Philipp Zabel
Hi Hans, Am Freitag, den 20.03.2015, 13:17 +0100 schrieb Hans Verkuil: The descriptions used in drivers for the formats returned with ENUM_FMT are all over the place. So instead allow the core to fill in the description and flags. This allows drivers to drop the description and flags. If

Re: cx23885: DVBSky S952 dvb_register failed err = -22

2015-03-23 Thread Ole Ernst
Very much appreciated, thanks Antti! Let me know, if you need someone to test your patches. Am 23.03.2015 um 19:08 schrieb Antti Palosaari: On 03/18/2015 11:06 AM, Ole Ernst wrote: Hi Max, I'm afraid I'm not experienced enough to adapt the ts2020 driver to interwork with the current kernel

[PATCH V3] [media] mantis: fix error handling

2015-03-23 Thread Silvan Jegen
Remove dead code, make goto label names more expressive and add a label in order to call mantis_dvb_exit if mantis_uart_init fails. Also make sure that mantis_pci_exit is called if we fail the mantis_stream_control call and that we call mantis_i2c_exit if mantis_get_mac fails. Signed-off-by:

Re: cx23885: DVBSky S952 dvb_register failed err = -22

2015-03-23 Thread Antti Palosaari
On 03/18/2015 11:06 AM, Ole Ernst wrote: Hi Max, I'm afraid I'm not experienced enough to adapt the ts2020 driver to interwork with the current kernel driver for the S952. I'd be more than happy to test patches though! I will migrate M88TS2022 to TS2020 and it will start working after that.

Re: [PATCH/RFC v13 04/13] DT: Add documentation for the mfd Maxim max77693

2015-03-23 Thread Sylwester Nawrocki
On 23/03/15 16:59, Lee Jones wrote: On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 15:02:13, Lee Jones wrote: On Mon, 23 Mar 2015, Pavel Machek wrote: On Mon 2015-03-23 12:07:43, Lee Jones wrote: This patch requires a DT Ack. No, it requires DT people to be

Re: cx23885: DVBSky S952 dvb_register failed err = -22

2015-03-23 Thread Antti Palosaari
On 03/23/2015 11:12 PM, Ole Ernst wrote: Very much appreciated, thanks Antti! Let me know, if you need someone to test your patches. Could you test that tree? http://git.linuxtv.org/cgit.cgi/anttip/media_tree.git/log/?h=ts2020 git clone -b ts2020 git://linuxtv.org/anttip/media_tree.git then

Re: [PATCH v1 06/11] exynos4-is: Add support for v4l2-flash subdevs

2015-03-23 Thread Sakari Ailus
Hi Jacek, On Mon, Mar 23, 2015 at 04:32:12PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 03/22/2015 02:21 AM, Sakari Ailus wrote: Hi Jacek, Some comments below. Please also get an ack from Sylwester! :-) No doubt about that :) On Fri, Mar 20, 2015 at

Re: [PATCH v1 07/11] media: Add registration helpers for V4L2 flash sub-devices

2015-03-23 Thread Sakari Ailus
Hi Jacek, On Mon, Mar 23, 2015 at 04:08:10PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. On 03/22/2015 01:22 AM, Sakari Ailus wrote: Hi Jacek, Thanks for the updated set. Some comments below. On Fri, Mar 20, 2015 at 04:03:27PM +0100, Jacek Anaszewski wrote:

cron job: media_tree daily build: ABI WARNING

2015-03-23 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 24 04:00:19 CET 2015 git branch: test git hash: 8a56b6b5fd6ff92b7e27d870b803b11b751660c2 gcc