Re: [PATCH v4 1/1] V4L2: platform: Add Renesas R-Car JPEG codec driver.

2015-07-16 Thread Hans Verkuil
On 07/16/2015 01:17 AM, Mikhail Ulyanov wrote: Hello, If you have any comments or suggestion, please let me know :) Asking because it seems stuck for nearly a 3 weeks... I was hoping to review this last Monday but I ran out of time. It's on the top of my TODO list so you should have a review

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Laurent Pinchart
Hi Hans, On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: On 07/15/15 23:05, Laurent Pinchart wrote: On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not use the controller framework. Signed-off-by:

[PATCHv2 1/9] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR

2015-07-16 Thread Antti Palosaari
SDR receiver has ADC (Analog-to-Digital Converter) and SDR transmitter has DAC (Digital-to-Analog Converter) . Originally I though it could be good idea to have own type for receiver and transmitter, but now I feel one common type for SDR is enough. So lets rename it. Cc: Hans Verkuil

[PATCHv2 9/9] hackrf: do not set human readable name for formats

2015-07-16 Thread Antti Palosaari
Format names are set by core nowadays. Remove name from driver. Signed-off-by: Antti Palosaari cr...@iki.fi Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/usb/hackrf/hackrf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/usb/hackrf/hackrf.c

[PATCHv2 7/9] hackrf: switch to single function which configures everything

2015-07-16 Thread Antti Palosaari
Implement single funtion, hackrf_set_params(), which handles all needed settings. Controls and other IOCTLs are just wrappers to that function. That way we can get easily better control what we could do on different device states - sleeping, receiving, transmitting. Signed-off-by: Antti Palosaari

[PATCHv2 6/9] hackrf: add control for RF amplifier

2015-07-16 Thread Antti Palosaari
There is Avago MGA-81563 amplifier just right after antenna connector. It could be turned on/off and its gain is around 12dB. Signed-off-by: Antti Palosaari cr...@iki.fi --- drivers/media/usb/hackrf/hackrf.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff

[PATCHv2 8/9] hackrf: add support for transmitter

2015-07-16 Thread Antti Palosaari
HackRF SDR device has both receiver and transmitter. There is limitation that receiver and transmitter cannot be used at the same time (half-duplex operation). That patch implements transmitter support to existing receiver only driver. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti

[PATCHv2 4/9] v4l2: add support for SDR transmitter

2015-07-16 Thread Antti Palosaari
New IOCTL ops: vidioc_enum_fmt_sdr_out vidioc_g_fmt_sdr_out vidioc_s_fmt_sdr_out vidioc_try_fmt_sdr_out New vb2 buffertype: V4L2_BUF_TYPE_SDR_OUTPUT New v4l2 capability: V4L2_CAP_SDR_OUTPUT Signed-off-by: Antti Palosaari cr...@iki.fi Acked-by: Hans Verkuil hans.verk...@cisco.com ---

[PATCHv2 3/9] DocBook: document tuner RF gain control

2015-07-16 Thread Antti Palosaari
Add brief description for tuner RF gain control. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi --- Documentation/DocBook/media/v4l/compat.xml | 4 Documentation/DocBook/media/v4l/controls.xml | 14 ++ Documentation/DocBook/media/v4l/v4l2.xml

[PATCHv2 5/9] DocBook: document SDR transmitter

2015-07-16 Thread Antti Palosaari
Add documentation for V4L SDR transmitter (output) devices. Signed-off-by: Antti Palosaari cr...@iki.fi Acked-by: Hans Verkuil hans.verk...@cisco.com --- Documentation/DocBook/media/v4l/compat.xml | 4 +++ Documentation/DocBook/media/v4l/dev-sdr.xml| 30 +++---

[PATCHv2 0/9] SDR transmitter API

2015-07-16 Thread Antti Palosaari
v2: * Allow device open even another device node is active. This means you could use transmitter device even receiver is active and other way around, just streaming is blocked to single node. * Removed V4L2_CID_RF_TUNER_RF_GAIN_AUTO control as it was not used. * Changed RF gain documentation.

[PATCHv2 2/9] v4l2: add RF gain control

2015-07-16 Thread Antti Palosaari
Add new RF tuner gain control named RF Gain. That is aimed for first amplifier chip right after antenna connector. There is existing LNA Gain control, which is quite same, but it is aimed for cases amplifier is integrated to tuner chip. Some designs have both, as almost all recent tuner silicons

[RFC v4 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Ricardo Ribalda Delgado
Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not use the controller framework. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- Changelog v4: Comments by Laurent Pinchart laurent.pinch...@ideasonboard.com Remove unneeded uvc_ctrl_begin()

Re: [PATCH 8/9] hackrf: add support for transmitter

2015-07-16 Thread Antti Palosaari
Moikka! On 06/08/2015 12:26 PM, Hans Verkuil wrote: Hi Antti, I've got one comment: On 06/06/2015 02:03 PM, Antti Palosaari wrote: HackRF SDR device has both receiver and transmitter. There is limitation that receiver and transmitter cannot be used at the same time (half-duplex operation).

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Hans Verkuil
On 07/16/15 10:11, Laurent Pinchart wrote: Hi Hans, On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: On 07/15/15 23:05, Laurent Pinchart wrote: On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not use

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Hans Verkuil
On 07/16/15 10:27, Laurent Pinchart wrote: On Thursday 16 July 2015 10:23:03 Hans Verkuil wrote: On 07/16/15 10:11, Laurent Pinchart wrote: On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: On 07/15/15 23:05, Laurent Pinchart wrote: On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado

[GIT PULL FOR v4.3] Xilinx video driver fix

2015-07-16 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 8783b9c50400c6279d7c3b716637b98e83d3c933: [media] SMI PCIe IR driver for DVBSky cards (2015-07-06 08:26:16 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git xilinx/next for you to fetch changes up to

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Laurent Pinchart
On Thursday 16 July 2015 10:23:03 Hans Verkuil wrote: On 07/16/15 10:11, Laurent Pinchart wrote: On Thursday 16 July 2015 09:38:11 Hans Verkuil wrote: On 07/15/15 23:05, Laurent Pinchart wrote: On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: Callback needed by ioctl

Re: [PATCH 1/1] omap3isp: Fix async notifier registration order

2015-07-16 Thread Laurent Pinchart
Hi Timur, On Wednesday 15 July 2015 16:04:01 Timur Tabi wrote: On Tue, May 19, 2015 at 6:08 PM, Sakari Ailus sakari.ai...@iki.fi wrote: @@ -2557,18 +2553,27 @@ static int isp_probe(struct platform_device *pdev) if (ret 0) goto error_iommu; -

[GIT PULL FOR v4.3] VSP1 fixes

2015-07-16 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 8783b9c50400c6279d7c3b716637b98e83d3c933: [media] SMI PCIe IR driver for DVBSky cards (2015-07-06 08:26:16 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git vsp1/next for you to fetch changes up to

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Ricardo Ribalda Delgado
Hello Laurent On Thu, Jul 16, 2015 at 10:27 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: I'd argue that even just two drivers would be enough :-) Especially given that the proposed implementation for uvcvideo is wrong. This is why we have the review process :P. I do my best,

Re: [RFC v3 04/19] media/usb/uvc: Implement vivioc_g_def_ext_ctrls

2015-07-16 Thread Hans Verkuil
On 07/15/15 23:05, Laurent Pinchart wrote: Hi Ricardo, Thank you for the patch. On Friday 12 June 2015 18:46:23 Ricardo Ribalda Delgado wrote: Callback needed by ioctl VIDIOC_G_DEF_EXT_CTRLS as this driver does not use the controller framework. Signed-off-by: Ricardo Ribalda Delgado

Re: [PATCH 2/9] v4l2: add RF gain control

2015-07-16 Thread Antti Palosaari
On 06/08/2015 12:03 PM, Hans Verkuil wrote: On 06/06/2015 02:03 PM, Antti Palosaari wrote: Add new RF tuner gain control named RF gain. That is aimed for external LNA (amplifier) chip just right after antenna connector. I don't follow. Do you mean: This feeds into the external LNA... But if

Re: www.kernellabs.com Contact: Hauppauge hvr1275 TV Tuner card linux problem

2015-07-16 Thread Steven Toth
Dear : Steven Toth Thanks for your professional answer Thanks a lot Best Regards You are welcome! It looks like Hauppauge have released an updated HVR-1275 card, as indicated by the updated PCI-SubDevice ID 2A38. The hardware has changed and the driver needs to be modified to support

[PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Laurent Pinchart
The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c | 53 --- arch/arm/mach-omap2/devices.h | 19 2 files

[PATCH 2/2] v4l: omap3isp: Drop platform data support

2015-07-16 Thread Laurent Pinchart
Platforms using the OMAP3 ISP have all switched to DT, drop platform data support. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/platform/Kconfig | 2 +- drivers/media/platform/omap3isp/isp.c | 133 ---

[PATCH 0/2] omap3isp: Remove legacy platform data support

2015-07-16 Thread Laurent Pinchart
Hello, Now that all users of the OMAP3 ISP have switched to DT, this patch series removes support for legacy platform data support in the omap3isp driver. It also drops the OMAP3 ISP device instantiation board code that is now unused. Patch 2/2 depends on 1/2. From a conflict resolution point of

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Tony Lindgren
* Laurent Pinchart laurent.pinch...@ideasonboard.com [150716 05:57]: The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Please feel to queue this along with the second patch in this series, this should not cause any merge conflicts: Acked-by: Tony Lindgren

Re: [PATCHv7 14/15] cec: s5p-cec: Add s5p-cec driver

2015-07-16 Thread Hans Verkuil
Marek, Kamil, On 06/29/15 12:14, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil

Re: [PATCH 1/1] omap3isp: Fix async notifier registration order

2015-07-16 Thread Timur Tabi
Laurent Pinchart wrote: IS_ENABLED(CONFIG_OF) can be evaluated at compile time, so it will allow the compiler to remove the code block completely when OF support is disabled. pdev-dev.of_node is a runtime-only check which would allow the same optimization. Ok, thanks. I was thinking that

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Sakari Ailus
Hi Laurent, Laurent Pinchart wrote: The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c | 53 ---

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Laurent Pinchart
Hi Sakari, On Thursday 16 July 2015 18:45:22 Sakari Ailus wrote: Laurent Pinchart wrote: The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c | 53

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Sakari Ailus
Laurent Pinchart wrote: Hi Sakari, On Thursday 16 July 2015 18:45:22 Sakari Ailus wrote: Laurent Pinchart wrote: The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

[PATCH v2] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder

2015-07-16 Thread Philipp Zabel
The encoder needs to know the nominal framerate for the constant bitrate control mechanism to work. Currently the only way to set the framerate is by using VIDIOC_S_PARM on the output queue. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Fixed typo in coda_g_parm ---

Re: [PATCH 0/2] omap3isp: Remove legacy platform data support

2015-07-16 Thread Sakari Ailus
Laurent Pinchart wrote: Hello, Now that all users of the OMAP3 ISP have switched to DT, this patch series removes support for legacy platform data support in the omap3isp driver. It also drops the OMAP3 ISP device instantiation board code that is now unused. Patch 2/2 depends on 1/2. From

[PATCH 1/3] [media] coda: move cache setup into coda9_set_frame_cache, also use it in start_encoding

2015-07-16 Thread Philipp Zabel
The frame cache should be set up correctly to encode NV12 source frames. This was not done before, so move the cache setup out of start_decoding into its own function and call it from both start_encoding and start_decoding. Signed-off-by: Philipp Zabel p.za...@pengutronix.de ---

[PATCH 2/3] [media] coda: add macroblock tiling support

2015-07-16 Thread Philipp Zabel
From: Philipp Zabel philipp.za...@gmail.com Storing internal frames in macroblock tiled order improves memory access patterns by allowing increased burst sizes when transferring the uncompressed macroblocks to or from main memory. The translation logic only supports a single chroma base address,

[PATCH 3/3] [media] coda: make NV12 format default

2015-07-16 Thread Philipp Zabel
The chroma interleaved NV12 format has higher memory bandwidth efficiency because the chroma planes can be read/written with longer burst lengths. Use NV12 as default format if available and consistently sort it first. This patch also shortens the NV12 format name to fit into the fixed length

[PATCH v3 0/5] i.MX5/6 mem2mem scaler

2015-07-16 Thread Philipp Zabel
Hi, this series uses the IPU IC post-processing task to implement a mem2mem device for scaling and colorspace conversion. This version addresses a few review commends, and includes some further cleanup. Changes since v2: - Limit downscaling to 4:1 - Disabled USERPTR memory - Set icc pointer

[PATCH v3 3/5] gpu: ipu-v3: Register scaler platform device

2015-07-16 Thread Philipp Zabel
This patch registers the scaler device using the IC post-processing task, to be handled by a mem2mem scaler driver. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/gpu/ipu-v3/ipu-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-common.c

[PATCH v3 2/5] gpu: ipu-v3: Add mem2mem image conversion support to IC

2015-07-16 Thread Philipp Zabel
This patch adds support for mem2mem scaling and colorspace conversion using the IC module's post-processing task. Scaling images larger than 1024x1024 is supported by tiling over multiple IC scaling runs. Since the IDMAC and IC units have interesting and different alignment limitations for buffer

[PATCH v3 5/5] [media] imx-ipu: Add i.MX IPUv3 scaler driver

2015-07-16 Thread Philipp Zabel
From: Sascha Hauer s.ha...@pengutronix.de This patch adds support for hardware accelerated scaling and color space conversion between memory buffers using the IPUv3 IC. Since the maximum output size of the IC unit is 1024x1024 pixels, multiple IC tasks with overlapping tiles are used internally

[PATCH v3 4/5] [media] imx-ipu: Add ipu media common code

2015-07-16 Thread Philipp Zabel
From: Sascha Hauer s.ha...@pengutronix.de Add video4linux API routines common to drivers for units that accept or provide video data via the i.MX IPU IDMAC channels, such as scaler or deinterlacer drivers. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Lucas Stach

[PATCH v3 1/5] gpu: ipu-v3: Add missing IDMAC channel names

2015-07-16 Thread Philipp Zabel
This patch adds the remaining missing IDMAC channel names: all VDIC channels for deinterlacing and combining, the separate alpha channels for the MEM-IC and MEM-DC ASYNC channels, and the DC read, command, and output mask channels. Signed-off-by: Philipp Zabel p.za...@pengutronix.de ---

cron job: media_tree daily build: OK

2015-07-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jul 17 04:00:19 CEST 2015 git branch: test git hash: 8783b9c50400c6279d7c3b716637b98e83d3c933 gcc

Re: [PATCH] [media]: Fix compilation when CONFIG_VIDEO_V4L2_SUBDEV_API is not set

2015-07-16 Thread Adam Majer
On Thu, Jul 16, 2015 at 06:20:55PM -0500, Adam Majer wrote: When CONFIG_VIDEO_V4L2_SUBDEV_API is unset, some drivers fail to compile as they use unavailable API. drivers/media/i2c/adv7511.c:968:3: error: implicit declaration of function ‘v4l2_subdev_get_try_format’

[PATCH] [media]: Fix compilation when CONFIG_VIDEO_V4L2_SUBDEV_API is not set

2015-07-16 Thread Adam Majer
When CONFIG_VIDEO_V4L2_SUBDEV_API is unset, some drivers fail to compile as they use unavailable API. drivers/media/i2c/adv7511.c:968:3: error: implicit declaration of function ‘v4l2_subdev_get_try_format’ [-Werror=implicit-function-declaration] --- drivers/media/i2c/adv7511.c | 8