Re: Media Controller patches

2015-12-13 Thread Mauro Carvalho Chehab
Em Fri, 11 Dec 2015 19:05:22 -0200 Mauro Carvalho Chehab escreveu: > Em Thu, 10 Dec 2015 18:34:11 -0200 > Mauro Carvalho Chehab escreveu: > > > Hi, > > > > I've been working during this week to address the issues pointed during > > the Media

[PATCH 3/4] [media] media-devnode: move kernel-doc documentation to the header

2015-12-13 Thread Mauro Carvalho Chehab
As we're using the headers file only for documentation, move the two kernel-doc macros to the header, and fix it to avoid warnings. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-devnode.c | 24 include/media/media-devnode.h | 27

[PATCH 1/4] [media] media-entity.h: Document some ancillary functions

2015-12-13 Thread Mauro Carvalho Chehab
Add a basic documentation for most ancillary functions. Signed-off-by: Mauro Carvalho Chehab --- include/media/media-entity.h | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/include/media/media-entity.h

[PATCH 4/4] [media] media-devnode.h: document the remaining struct/functions

2015-12-13 Thread Mauro Carvalho Chehab
There is one struct and two functions that were not documented. Add the corresponding kernel-doc documentation for them. Signed-off-by: Mauro Carvalho Chehab --- include/media/media-devnode.h | 27 ++- 1 file changed, 26 insertions(+), 1

[PATCH 2/4] [media] media-device.h: document the last functions

2015-12-13 Thread Mauro Carvalho Chehab
Add kernel-doc documentation for media_device_get_devres and media_device_find_devres. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-device.c | 7 --- include/media/media-device.h | 22 ++ 2 files changed, 22 insertions(+), 7

Re: [PATCH v2 00/32] VSP: Add R-Car Gen3 support

2015-12-13 Thread Khiem Nguyen
On 12/14/2015 1:53 AM, Laurent Pinchart wrote: Hello Khiem, On Friday 11 December 2015 15:43:27 Khiem Nguyen wrote: On 12/6/2015 5:54 AM, Laurent Pinchart wrote: On Saturday 05 December 2015 11:57:49 Geert Uytterhoeven wrote: On Sat, Dec 5, 2015 at 3:12 AM, Laurent Pinchart wrote: This

af9015 not supported anymore ???

2015-12-13 Thread oddebian
Hello, I have investigated a little further and it looks like the af9015 is not working correctly with any linux kernels (32 or 64 bits) >= 3, although it seems to be recognised (firmware uploaded). Any idea about how to debug the thing ? OD Message transféré > De: oddebian

[PATCH] media: soc_camera: rcar_vin: Add R-Car Gen3 support

2015-12-13 Thread Yoshihiro Kaneko
From: Yoshihiko Mori Add chip identification for R-Car Gen3. Signed-off-by: Yoshihiko Mori Signed-off-by: Yoshihiro Kaneko --- This patch is against master branch of linuxtv.org/media_tree.git.

Re: [PATCH] media: soc_camera: rcar_vin: Add R-Car Gen3 support

2015-12-13 Thread Sergei Shtylyov
On 12/13/2015 06:27 PM, Yoshihiro Kaneko wrote: From: Yoshihiko Mori Add chip identification for R-Car Gen3. Signed-off-by: Yoshihiko Mori Signed-off-by: Yoshihiro Kaneko [...] diff --git

Re: [PATCH] adv7604: add direct interrupt handling

2015-12-13 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Friday 11 December 2015 17:04:28 Ulrich Hecht wrote: > When probed from device tree, the i2c client driver can handle the > interrupt on its own. > > Signed-off-by: Ulrich Hecht > --- > drivers/media/i2c/adv7604.c | 24

Re: [PATCH v2 0/7] Exynos: MFC driver: reserved memory cleanup and IOMMU support

2015-12-13 Thread Laurent Pinchart
Hi Marek, Thank you for the patches. On Wednesday 09 December 2015 14:58:15 Marek Szyprowski wrote: > Hello, > > This patchset finally perform cleanup of custom code in s5p-mfc codec > driver. The first part is removal of custom, driver specific code for > intializing and handling of reserved

Re: [PATCH] libmediactl.c: add poor man's udev support

2015-12-13 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thursday 10 December 2015 11:44:43 Hans Verkuil wrote: > If libudev is not available (android!), It's time for Android to grow up and get rid of their LGPL hatred... That might actually happen as a result of the Chrome/Android merge that seems to be

Re: [PATCH v2 03/22] media: Add an API to manage entity enumerations

2015-12-13 Thread Sakari Ailus
Hi Mauro, Thanks for the comments! Mauro Carvalho Chehab wrote: > Hi Sakari, > > Em Sun, 29 Nov 2015 21:20:04 +0200 > Sakari Ailus escreveu: > >> From: Sakari Ailus >> >> This is useful in e.g. knowing whether certain operations have already

Re: [PATCH v2 03/22] media: Add an API to manage entity enumerations

2015-12-13 Thread Mauro Carvalho Chehab
Em Mon, 14 Dec 2015 00:12:08 +0200 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the comments! > > Mauro Carvalho Chehab wrote: > > Hi Sakari, > > > > Em Sun, 29 Nov 2015 21:20:04 +0200 > > Sakari Ailus escreveu: > > > >> From: Sakari Ailus

Re: [PATCH 3/3] media: adv7604: update timings on change of input signal

2015-12-13 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Friday 11 December 2015 17:04:53 Ulrich Hecht wrote: > Without this, g_crop will always return the boot-time state. > > Signed-off-by: Ulrich Hecht > --- > drivers/media/i2c/adv7604.c | 9 + > 1 file changed, 9

Re: [PATCH v2 00/32] VSP: Add R-Car Gen3 support

2015-12-13 Thread Laurent Pinchart
Hello Khiem, On Friday 11 December 2015 15:43:27 Khiem Nguyen wrote: > On 12/6/2015 5:54 AM, Laurent Pinchart wrote: > > On Saturday 05 December 2015 11:57:49 Geert Uytterhoeven wrote: > >> On Sat, Dec 5, 2015 at 3:12 AM, Laurent Pinchart wrote: > >>> This patch set adds support for the Renesas

Re: [PATCH 1/3] media: adv7604: implement g_crop

2015-12-13 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Friday 11 December 2015 17:04:51 Ulrich Hecht wrote: > The rcar_vin driver relies on this. > > Signed-off-by: Ulrich Hecht > --- > drivers/media/i2c/adv7604.c | 12 > 1 file changed, 12 insertions(+) > > diff

Re: [PATCH 2/3] media: adv7604: implement cropcap

2015-12-13 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Friday 11 December 2015 17:04:52 Ulrich Hecht wrote: > Used by the rcar_vin driver. > > Signed-off-by: Ulrich Hecht > --- > drivers/media/i2c/adv7604.c | 17 + > 1 file changed, 17 insertions(+) > > diff

Re: [PATCH 0/3] adv7604: .g_crop and .cropcap support

2015-12-13 Thread Laurent Pinchart
Hi Hans, On Friday 11 December 2015 17:25:40 Hans Verkuil wrote: > On 12/11/2015 05:04 PM, Ulrich Hecht wrote: > > Hi! > > > > The rcar_vin driver relies on these methods. The third patch makes sure > > that they return up-to-date data if the input signal has changed since > > initialization. >

Re: [PATCH] v4l: Fix dma buf single plane compat handling

2015-12-13 Thread Laurent Pinchart
Hi Sakari, On Wednesday 09 December 2015 13:07:40 Sakari Ailus wrote: > On Wed, Dec 09, 2015 at 01:11:12AM +0200, Laurent Pinchart wrote: > > On Tuesday 08 December 2015 17:29:16 Sakari Ailus wrote: > > > On Mon, Dec 07, 2015 at 10:45:39AM +0200, Laurent Pinchart wrote: > > > > From: Gjorgji

Re: [v4l-utils PATCH 1/1] v4l: libv4l2subdev: Precisely convert media bus string to code

2015-12-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Wednesday 09 December 2015 17:14:47 Sakari Ailus wrote: > The length of the string was ignored, making it possible for the > conversion to fail due to extra characters in the string. I'm not sure to follow you there. Is the issue that passing a string such

Re: [v4l-utils PATCH v2 1/3] libv4l2subdev: Use generated format definitions in libv4l2subdev

2015-12-13 Thread Laurent Pinchart
Hi Sakari, On Tuesday 08 December 2015 17:15:14 Sakari Ailus wrote: > Instead of manually adding each and every new media bus pixel code to > libv4l2subdev, generate the list automatically. The pre-existing formats > that do not match the list are not modified so that existing users are >

Re: [PATCH v2 4/7] media: vb2-dma-contig: add helper for setting dma max seg size

2015-12-13 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Wednesday 09 December 2015 14:58:19 Marek Szyprowski wrote: > Add a helper function for device drivers to set DMA's max_seg_size. > Setting it to largest possible value lets DMA-mapping API always create > contiguous mappings in DMA address space. This is

Re: [v4l-utils PATCH v2 2/3] libv4l2subdev: Add a function to list library supported pixel codes

2015-12-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tuesday 08 December 2015 17:15:15 Sakari Ailus wrote: > Also mark which format definitions are compat definitions for the > pre-existing codes. This way we don't end up listing the same formats > twice. Wouldn't it be easier to add a function to return the

cron job: media_tree daily build: WARNINGS

2015-12-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Dec 14 04:00:22 CET 2015 git branch: test git hash: 52d60eb7e6d6429a766ea1b8f67e01c3b2dcd3c5 gcc

[yavta PATCH v2] Return proper error code if STREAMON fails

2015-12-13 Thread Tuukka Toivonen
Return the error code if video_enable() and VIDIOC_STREAMON fails. Signed-off-by: Tuukka Toivonen --- yavta.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/yavta.c b/yavta.c index b627725..3d80d3c 100644 --- a/yavta.c +++ b/yavta.c @@ -1708,7

Re: [yavta PATCH] Return proper error code if STREAMON fails

2015-12-13 Thread Tuukka Toivonen
Hi, Thanks for your feedback. On Saturday, December 12, 2015 17:40:07 Laurent Pinchart wrote: > I wonder if there's really a point calling video_free_buffers() in the > error case. The function will return an error causing the caller to > close the device, which will free the buffers. There are