Re: [PATCH] cx231xx: correctly handling failed allocation

2015-12-29 Thread Devin Heitmueller
On Tue, Dec 29, 2015 at 1:53 PM, Insu Yun wrote: > Since kmalloc can be failed in memory pressure, > if not properly handled, NULL dereference can be happend > > Signed-off-by: Insu Yun > --- > drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ > 1 file

[PATCH] cx231xx: correctly handling failed allocation

2015-12-29 Thread Insu Yun
Since kmalloc can be failed in memory pressure, if not properly handled, NULL dereference can be happend Signed-off-by: Insu Yun --- drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c

[PATCH] [media] cx88-dvb: Changed tuner associated with board Hauppauge HVR-4000 from TUNER_PHILIPS_FMD1216ME_MK3 to TUNER_PHILIPS_FMD1216MEX_MK3

2015-12-29 Thread José David Moreno Juárez
The correct tuner for the board Hauppauge HVR-4000 seems to be FMD1216MEX MK3 instead of FMD1216ME MK3. The tuner is identified as such by tveeprom: Dec 28 23:01:15 [kernel] tveeprom 8-0050: tuner model is Philips FMD1216MEX (idx 133, type 78) This patch fixes a longstanding warning

[PATCH] usbtv: correctly handling failed allocation

2015-12-29 Thread Insu Yun
Since kzalloc can be failed, if not properly handled, NULL dereference could be happened. Signed-off-by: Insu Yun --- drivers/media/usb/usbtv/usbtv-video.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/usbtv/usbtv-video.c

Re: [PATCH 1/5] staging: media: lirc: replace NULL comparisons with !var

2015-12-29 Thread Sudip Mukherjee
On Fri, Dec 18, 2015 at 06:35:25PM +0530, Sudip Mukherjee wrote: > A NULL comparison can be written as if (var) or if (!var). > Reported by checkpatch. > > Signed-off-by: Sudip Mukherjee > --- Hi Mauro, A gentle ping. Can this series be considered for 4.5? regards

cron job: media_tree daily build: OK

2015-12-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Dec 30 04:00:14 CET 2015 git branch: test git hash: 768acf46e1320d6c41ed1b7c4952bab41c1cde79 gcc

[media] anysee: Checking failure reporting

2015-12-29 Thread SF Markus Elfring
Hello, I have looked at the implementation of the function "anysee_del_i2c_dev" once more. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/media/usb/dvb-usb-v2/anysee.c?id=80c75a0f1d81922bf322c0634d1e1a15825a89e6#n685 Is it really appropriate to end this one with

Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Andrey Utkin
On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab wrote: > IMHO, there are two problems by letting indent breaking long > lines: > > 1) indent would break strings on printks. This is something that we don't > want to break strings on multiple lines in the Kernel;

Re: [PATCH v2 3/3] [media] mt9v032: Add V4L2 controls for AEC and AGC

2015-12-29 Thread Laurent Pinchart
Hi Markus, On Wednesday 16 December 2015 11:14:28 Markus Pargmann wrote: > On Wednesday 16 December 2015 09:47:58 Laurent Pinchart wrote: > > On Monday 14 December 2015 15:41:53 Markus Pargmann wrote: > >> This patch adds V4L2 controls for Auto Exposure Control and Auto Gain > >> Control

[PATCH] [media] uvcvideo: Fix build if !MEDIA_CONTROLLER

2015-12-29 Thread Thierry Reding
From: Thierry Reding Accesses to the UVC device's mdev field need to be protected by a preprocessor conditional to avoid build errors, since the field is only included if the MEDIA_CONTROLLER option is selected. Fixes: 1590ad7b5271 ("[media] media-device: split media

[PATCH] [media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc()

2015-12-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Dec 2015 12:32:41 +0100 This issue was detected by using the Coccinelle software. Return the value from a call of the msi2500_ctrl_msg() function without using an extra check for the variable "ret" at the end. Signed-off-by:

Re: [PATCH] [media] uvcvideo: Fix build if !MEDIA_CONTROLLER

2015-12-29 Thread Javier Martinez Canillas
Hello Thierry, On 12/29/2015 07:30 AM, Thierry Reding wrote: > From: Thierry Reding > > Accesses to the UVC device's mdev field need to be protected by a > preprocessor conditional to avoid build errors, since the field is only > included if the MEDIA_CONTROLLER option is

[PATCH] v4l: omap3isp: Fix data lane shift configuration

2015-12-29 Thread Laurent Pinchart
The data-shift DT property speficies the number of bits to be shifted, but the driver still interprets the value as a multiple of two bits as used by now removed platform data support. Fix it. Signed-off-by: Laurent Pinchart ---

[PATCH] [media] hdpvr: Refactoring for hdpvr_read()

2015-12-29 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 29 Dec 2015 11:02:43 +0100 Let us return directly if the element "status" of the variable "buf" indicates "BUFSTAT_READY". A check repetition can be excluded for the variable "ret" at the end then. Signed-off-by: Markus Elfring

Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Julia Lawall
On Tue, 29 Dec 2015, Andrey Utkin wrote: > On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab > wrote: > > IMHO, there are two problems by letting indent breaking long > > lines: > > > > 1) indent would break strings on printks. This is something that we don't > >

[GIT PULL FOR v4.5] omap3isp fixes

2015-12-29 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 768acf46e1320d6c41ed1b7c4952bab41c1cde79: [media] rc: sunxi-cir: Initialize the spinlock properly (2015-12-23 15:51:40 -0200) are available in the git repository at: git://linuxtv.org/pinchartl/media.git omap3isp/next for you to fetch changes

Re: [PATCH] v4l: omap3isp: Fix data lane shift configuration

2015-12-29 Thread Sakari Ailus
On Tue, Dec 29, 2015 at 04:11:51PM +0200, Laurent Pinchart wrote: > The data-shift DT property speficies the number of bits to be shifted, > but the driver still interprets the value as a multiple of two bits as > used by now removed platform data support. Fix it. > > Signed-off-by: Laurent