Re: [PATCH 24/29] drivers: convert iblock_req.pending from atomic_t to refcount_t

Hi Elena, On Mon, 2017-03-06 at 16:21 +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [bug report] [media] atmel-isc: add the isc pipeline function

Hi Dan, I understand now, thank you very much. On 3/8/2017 12:38, Dan Carpenter wrote: No. Imagine the v4l2_subdev_call() loop exits with "fmt" set to NULL. It will cause a crash. Please re-read my original email because I think you may have meant to reset fmt after that loop. regards, dan

Re: [bug report] [media] atmel-isc: add the isc pipeline function

No. Imagine the v4l2_subdev_call() loop exits with "fmt" set to NULL. It will cause a crash. Please re-read my original email because I think you may have meant to reset fmt after that loop. regards, dan carpenter

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 8 05:00:17 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build

Re: [PATCH v3 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Wed, 2017-03-08 at 11:40 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > Acked-by: Tiffany Lin >

[PATCH v3 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

From: Wu-Cheng Li VPU firmware has a bug and may return invalid buffer index for some vp9 videos. Check the buffer indexes before accessing the buffer. Signed-off-by: Wu-Cheng Li --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 33

[PATCH v3 0/1] mtk-vcodec: check the vp9 decoder buffer index from VPU

From: Wu-Cheng Li v2: also check the result of vdec_if_decode in mtk_vdec_worker. v3: set buffer status to VB2_BUF_STATE_ERROR. Move printk out of lock. Wu-Cheng Li (1): mtk-vcodec: check the vp9 decoder buffer index from VPU.

Re: [PATCH v2 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Tue, 2017-03-07 at 22:42 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > > Signed-off-by: Wu-Cheng Li >

Re: [bug report] [media] atmel-isc: add the isc pipeline function

Hi Dan, Thank you very much for your bug report. Then I have question about 'error: we previously assumed 'fmt' could be null (see line 1480)' Do you mean that the code should be written like 'if (fmt == NULL)'? On 3/7/2017 08:17, Dan Carpenter wrote: 1476 while

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

Hi Colin, Thank you for your comment. It is a bug, will be fixed in the next patch. On 3/7/2017 22:30, Colin King wrote: From: Colin Ian King The are only HIST_ENTRIES worth of entries in hist_entry however the for-loop is iterating one too many times leasing to a

[PATCH 01/13] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

From: Daniel Scheller There can be use cases (bridges, namely ddbridge) which will care about gate control in a way that involves mutex_locks and remapped i2c_gatectrl FE ops. If the demod driver (additionally) performs it's own gate control and there's something else that

[PATCH 11/13] [media] dvb-frontends/stv0367: add Digital Devices compatibility

From: Daniel Scheller This - in conjunction with the previous changes - makes it possible to use the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having this demodulator soldered on them (namely CineCTv6 bridges and some earlier DuoFlex CT addon modules).

[PATCH v3 3/6] documentation: media: Add documentation for new RGB and YUV bus formats

Add documentation for added Bus Formats to describe RGB and YUS formats used as input to the Synopsys DesignWare HDMI TX Controller. Signed-off-by: Neil Armstrong --- Documentation/media/uapi/v4l/subdev-formats.rst | 4992 ++- 1 file changed, 3963

[PATCH v3 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

The HDMI TX controller support HPD and RXSENSE signaling from the PHY via it's STAT0 PHY interface, but some vendor PHYs can manage these signals independently from the controller, thus these STAT0 handling should be moved to PHY specific operations and become optional. The existing STAT0 HPD and

[PATCH 12/13] [media] tuners/tda18212: add flag for retrying tuner init on failure

From: Daniel Scheller Taken from tda18212dd, first read after cold reset sometimes fails on some cards, trying twice shall do the trick. This is the case with the STV0367 demods soldered on the CineCTv6 bridge boards and older DuoFlex CT modules. All other users (configs) of

[PATCH 10/13] [media] dvb-frontends/stv0367: add defaults for use w/DD-branded devices

From: Daniel Scheller Digital Devices uses defaults tables in their stv0367dd demod driver variant which differ in a few registers, at least enough that no stable operation can be provided with the tables already present in the driver (init succeeds and DVB reception works

[PATCH v4] media: platform: Renesas IMR driver

From: Konstantin Kozhevnikov The image renderer, or the distortion correction engine, is a drawing processor with a simple instruction system capable of referencing video capture data or data in an external memory as the 2D texture data and performing

[PATCH 09/13] [media] dvb-frontends/stv0367: fix symbol rate conditions in cab_SetQamSize()

From: Daniel Scheller The values used for comparing symbol rates and the resulting conditional reg writes seem wrong (rates multiplied by ten), so fix those values. While this doesn't seem to influence operation, it should be fixed anyway. Signed-off-by: Daniel Scheller

[PATCH 03/13] [media] dvb-frontends/stv0367: refactor defaults table handling

From: Daniel Scheller Change defaults table writing so tables can be of dynamic length without having to keep track of their lengths by adding and evaluating an end marker (reg 0x), also move table writing to a dedicated function to remove code duplication. Additionally

[PATCH 13/13] [media] ddbridge: support STV0367-based cards and modules

From: Daniel Scheller This adds detection and activation for STV0367-based tuner hardware (namely CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the extended stv0367 demod driver, and needs the init_retry when attaching the TDA18212 tuner. TDA18212

[PATCH v3 2/6] media: uapi: Add RGB and YUV bus formats for Synopsys HDMI TX Controller

In order to describe the RGB and YUB bus formats used to feed the Synopsys DesignWare HDMI TX Controller, add missing formats to the list of Bus Formats. Documentation for these formats is added in a separate patch. Signed-off-by: Neil Armstrong ---

[PATCH 05/13] [media] dvb-frontends/stv0367: make PLLSETUP a function, add 58MHz IC speed

From: Daniel Scheller This moves the PLL SETUP code from stv0367ter_init() into a dedicated function, and also make it possible to configure 58Mhz IC speed at 27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode). Signed-off-by: Daniel Scheller

[PATCH 06/13] [media] dvb-frontends/stv0367: make full reinit on set_frontend() optional

From: Daniel Scheller Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit of the demodulator will be performed. While this might cause a slight delay when switching channels due to all involved tables being rewritten, it can even be dangerous in

[PATCH 07/13] [media] dvb-frontends/stv0367: support reading if_khz from tuner config

From: Daniel Scheller Currently, if_khz is set and provided using the configuration var in struct stv0367_config. However, in some constellations, the value might be different for differing channel bandwidths or even -T and -C operation. When e.g. used in conjunction with

[PATCH 08/13] [media] dvb-frontends/stv0367: selectable QAM FEC Lock status register

From: Daniel Scheller In some configurations (due to different PIN config, wiring or so), the QAM FECLock might be signalled using a different register than F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw), so make that register selectable.

[PATCH 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

From: Daniel Scheller These patches enhance the functionality of dvb-frontends/stv0367 to work with Digital Devices hardware driven by the ST STV0367 demodulator chip and adds probe & attach bits to ddbridge to make use of them, effectively enabling full support for CineCTv6

[PATCH 04/13] [media] dvb-frontends/stv0367: move out tables, support multiple tab variants

From: Daniel Scheller Move the *ter and *cab st_register tables into a separate header file and additionally organize them via a multidimensional array, allowing to add more tables with differing init values, and also prepare for a base init table which should contain general

Re: [PATCH 10/29] drivers, md: convert stripe_head.count from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:20:57PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations.

[PATCH 02/13] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled

From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when

[PATCH v3 0/6] drm: bridge: dw-hdmi: Add support for Custom PHYs

The Amlogic GX SoCs implements a Synopsys DesignWare HDMI TX Controller in combination with a very custom PHY. Thanks to Laurent Pinchart's changes, the HW report the following : Detected HDMI TX controller v2.01a with HDCP (Vendor PHY) The following differs from common PHY integration as

Re: [PATCH v3 6/6] drm: bridge: dw-hdmi: Move HPD handling to PHY operations

Hi Neil, On 07-03-2017 16:42, Neil Armstrong wrote: > The HDMI TX controller support HPD and RXSENSE signaling from the PHY > via it's STAT0 PHY interface, but some vendor PHYs can manage these > signals independently from the controller, thus these STAT0 handling > should be moved to PHY

[PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

Some display pipelines can only provide non-RBG input pixels to the HDMI TX Controller, this patch takes the pixel format from the plat_data if provided. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 322 +-

[PATCH] [media] mceusb: fix NULL-deref at probe

Make sure to check for the required out endpoint to avoid dereferencing a NULL-pointer in mce_request_packet should a malicious device lack such an endpoint. Note that this path it hit during probe. Fixes: 66e89522aff7 ("V4L/DVB: IR: add mceusb IR receiver driver") Cc: stable

Re: [PATCH v3 4/6] drm: bridge: dw-hdmi: Switch to V4L bus format and encodings

Hi Neil, On 07-03-2017 16:42, Neil Armstrong wrote: > Some display pipelines can only provide non-RBG input pixels to the HDMI TX > Controller, this patch takes the pixel format from the plat_data if provided. > > Signed-off-by: Neil Armstrong > --- >

[PATCH v3 5/6] drm: bridge: dw-hdmi: Add Documentation on supported input formats

This patch adds a new DRM documentation entry and links to the input format table added in the dw_hdmi header. Signed-off-by: Neil Armstrong --- Documentation/gpu/dw-hdmi.rst | 15 +++ Documentation/gpu/index.rst | 1 + 2 files changed, 16 insertions(+)

Re: [PATCH] media: vpif: use a configurable i2c_adapter_id for vpif display

Hi Bartosz, Thanks for the patch. On Thu, Feb 16, 2017 at 6:08 PM, Bartosz Golaszewski wrote: > > The vpif display driver uses a static i2c adapter ID of 1 but on the > da850-evm board in DT boot mode the i2c adapter ID is actually 0. > > Make the adapter ID

Re: [PATCH v3 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

Hi Neil, On 07-03-2017 16:42, Neil Armstrong wrote: > From: Laurent Pinchart > > In preparation for adding PHY operations to handle RX SENSE and HPD, > group all the PHY interrupt setup code in a single location and extract > it to a separate function.

[PATCH v3 1/6] drm: bridge: dw-hdmi: Extract PHY interrupt setup to a function

From: Laurent Pinchart In preparation for adding PHY operations to handle RX SENSE and HPD, group all the PHY interrupt setup code in a single location and extract it to a separate function. Signed-off-by: Laurent Pinchart

[PATCH] [media] v4l2-dv-timings: Introduce v4l2_calc_fps()

HDMI Receivers receive video modes which, according to CEA specification, can have different frames per second (fps) values. This patch introduces a helper function in the media core which can calculate the expected video mode fps given the pixel clock value and the horizontal/vertical values.

Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

Hi Ramiro, On Mon, Mar 06, 2017 at 11:16:34AM +, Ramiro Oliveira wrote: ... > +static int __sensor_init(struct v4l2_subdev *sd) > +{ > + int ret; > + u8 resetval, rdval; > + struct i2c_client *client = v4l2_get_subdevdata(sd); > + > + dev_dbg(>dev, "sensor init\n"); This

[PATCH v2 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

From: Wu-Cheng Li VPU firmware has a bug and may return invalid buffer index for some vp9 videos. Check the buffer indexes before accessing the buffer. Signed-off-by: Wu-Cheng Li --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 23

[PATCH v2 0/1] mtk-vcodec: check the vp9 decoder buffer index from VPU

From: Wu-Cheng Li This patch guards against the invalid buffer index from VPU firmware. v2: also check the result of vdec_if_decode in mtk_vdec_worker. Wu-Cheng Li (1): mtk-vcodec: check the vp9 decoder buffer index from VPU.

[PATCH 2/4] media: platform: dwc: Support for DW CSI-2 Host

Add support for the Synopsys DesignWare CSI-2 Host Signed-off-by: Ramiro Oliveira --- MAINTAINERS | 7 + drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 2 + drivers/media/platform/dwc/Kconfig

[PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

From: Colin Ian King The are only HIST_ENTRIES worth of entries in hist_entry however the for-loop is iterating one too many times leasing to a read access off the end off the array ctrls->hist_entry. Fix this by iterating by the correct number of times. Detected by

RE: [PATCH 13/29] drivers, media: convert vb2_vmarea_handler.refcount from atomic_t to refcount_t

> Hi Elena, > > On Mon, Mar 06, 2017 at 04:21:00PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to

[PATCH 4/4] media: platform: dwc: Support for CSI-2 Host video platform

Add support for the CSI-2 Host video platform. This platform exists only to support the Synopsys DW CSI-2 Host bring-up and debug efforts. Signed-off-by: Ramiro Oliveira --- drivers/media/platform/dwc/Kconfig| 40 ++ drivers/media/platform/dwc/Makefile

Status of CEC?

Hi Hans, I'm writing to you in order to get more details about current CEC implementation status. I've seen the code and it appears you have already support for CEC 2.0, right? I've also seen the implementation in adv7511 of CEC and I've extracted the following sequence: 1) Call

RE: [PATCH 12/29] drivers, media: convert s2255_dev.num_channels from atomic_t to refcount_t

> Hi Elena, > > On Mon, Mar 06, 2017 at 04:20:59PM +0200, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to

[PATCH 3/4] Documentation: dt: Add bindings documentation for CSI-2 Host Video Platform

Create device tree bindings documentation for the CSI-2 Host Video platform. Signed-off-by: Ramiro Oliveira --- .../devicetree/bindings/media/snps,plat-csi2.txt | 77 ++ 1 file changed, 77 insertions(+) create mode 100644

[PATCH 0/4] Support for Synopsys DW CSI-2 Host

This patchset adds support for the DW CSI-2 Host and also for a video device associated with it. The first 2 patches are only for the DW CSI-2 Host and the last 2 are for the video device. Although this patchset is named as v1 there were already two patchsets previous to this one, but with a

[PATCH 1/4] Documentation: dt: Add bindings documentation for DW MIPI CSI-2 Host

Create device tree bindings documentation for the Synopsys DW MIPI CSI-2 Host. Signed-off-by: Ramiro Oliveira --- .../devicetree/bindings/media/snps,dw-mipi-csi.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644

Re: [PATCH 1/1] media: entity: Swap pads if route is checked from source to sink

Hi Sakari, Thanks for the patch. On 2016-11-08 12:11:15 +0200, Sakari Ailus wrote: > This way the pads are always passed to the has_route() op sink pad first. > Makes sense. > > Signed-off-by: Sakari Ailus > --- > Hi Niklas, > > This should make it easier to

[PATCH] [media] platform: Order the Makefile alphabetically

The Makefile was a free for all without a clear order defined. Sort all the options based on the Kconfig symbol. Signed-off-by: Maxime Ripard --- drivers/media/platform/Makefile | 89 ++--- 1 file changed, 31 insertions(+),

Re: [PATCH 1/1] media: entity: Swap pads if route is checked from source to sink

Hi Niklas, On 03/07/17 13:15, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for the patch. > > On 2016-11-08 12:11:15 +0200, Sakari Ailus wrote: >> This way the pads are always passed to the has_route() op sink pad first. >> Makes sense. >> >> Signed-off-by: Sakari Ailus

Re: [PATCH] media: vpif: use a configurable i2c_adapter_id for vpif display

2017-02-16 19:08 GMT+01:00 Bartosz Golaszewski : > The vpif display driver uses a static i2c adapter ID of 1 but on the > da850-evm board in DT boot mode the i2c adapter ID is actually 0. > > Make the adapter ID configurable like it already is for vpif capture. > >

Re: [Patch v2 11/11] Documention: v4l: Documentation for HEVC CIDs

On 03.03.2017 10:07, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder It should be rather "Document controls for HEVC encoder" or sth similar. In general most of comments are in previous patch. Few additional comments: - please be careful about control names - they are exported to

Re: Status of CEC?

On 03/07/2017 12:44 PM, Jose Abreu wrote: Hi Hans, I'm writing to you in order to get more details about current CEC implementation status. I've seen the code and it appears you have already support for CEC 2.0, right? I've also seen the implementation in adv7511 of CEC and I've extracted the

Re: [Patch v2 10/11] s5p-mfc: Add support for HEVC encoder

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add HEVC encoder support and necessary registers, V4L2 CIDs, > and hevc encoder parameters > > Signed-off-by: Smitha T Murthy > --- > drivers/media/platform/s5p-mfc/regs-mfc-v10.h | 28 +- >

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

RE: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

> On 03/06/2017 03:21 PM, Elena Reshetova wrote: > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter overflows that might lead to use-after-free > > situations. > >

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

On 7-3-2017 10:44, Kalle Valo wrote: > Arnd Bergmann writes: > >> On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo wrote: >>> Arend Van Spriel writes: >>> On 2-3-2017 17:38, Arnd Bergmann wrote: > With KASAN and a couple of

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

Arnd Bergmann writes: > On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo wrote: >> Arend Van Spriel writes: >> >>> On 2-3-2017 17:38, Arnd Bergmann wrote: With KASAN and a couple of other patches applied, this driver is one

Re: [PATCH 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Tue, Mar 7, 2017 at 3:59 PM, Tiffany Lin wrote: > On Tue, 2017-03-07 at 14:03 +0800, Wu-Cheng Li wrote: >> From: Wu-Cheng Li >> >> VPU firmware has a bug and may return invalid buffer index for >> some vp9 videos. Check the buffer indexes before

Re: [Patch v2 07/11] Documentation: v4l: Documentation for HEVC v4l2 definition

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy Reviewed-by: Andrzej Hajda > --- > Documentation/media/uapi/v4l/pixfmt-013.rst |5 + > 1 files changed, 5

Re: [PATCH 13/29] drivers, media: convert vb2_vmarea_handler.refcount from atomic_t to refcount_t

Hi Elena, On Mon, Mar 06, 2017 at 04:21:00PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [Patch v2 09/11] v4l2: Add v4l2 control IDs for HEVC encoder

On 03.03.2017 10:07, Smitha T Murthy wrote: > Add v4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 51 + > include/uapi/linux/v4l2-controls.h | 129 > ++ > 2

Re: [PATCH 12/29] drivers, media: convert s2255_dev.num_channels from atomic_t to refcount_t

Hi Elena, On Mon, Mar 06, 2017 at 04:20:59PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free >

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

On Mon, Mar 06, 2017 at 04:20:58PM +0200, Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. >

Re: [PATCH 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

On Tue, 2017-03-07 at 14:03 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > > Signed-off-by: Wu-Cheng Li >