cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri May 19 05:00:25 CEST 2017 media-tree git hash:f2c61f98e0b5f8b53b8fb860e5dcdd661bde7d0b media_build

Re: [PATCH v5 2/3] platform: add video-multiplexer subdevice driver

On Wed 2017-05-17 17:15:06, Philipp Zabel wrote: > This driver can handle SoC internal and external video bus multiplexers, > controlled by mux controllers provided by the mux controller framework, > such as MMIO register bitfields or GPIOs. The subdevice passes through > the mbus configuration of

Re: [PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Laurent, On Fri, May 19, 2017 at 12:59:12AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 19 May 2017 00:05:17 Sakari Ailus wrote: > > On Thu, May 18, 2017 at 11:54:46PM +0300, Laurent Pinchart wrote: > > > On Thursday 18 May 2017 23:50:34 Sakari Ailus wrote: > > >> On Thu, May

[media-pci-cx25821] question about value overwrite

Hello everybody, While looking into Coverity ID 1226903 I ran into the following piece of code at drivers/media/pci/cx25821/cx25821-medusa-video.c:393: 393int medusa_set_videostandard(struct cx25821_dev *dev) 394{ 395int status = 0; 396u32 value = 0, tmp = 0; 397 398

Re: [PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Sakari, On Friday 19 May 2017 00:05:17 Sakari Ailus wrote: > On Thu, May 18, 2017 at 11:54:46PM +0300, Laurent Pinchart wrote: > > On Thursday 18 May 2017 23:50:34 Sakari Ailus wrote: > >> On Thu, May 18, 2017 at 07:08:00PM +0300, Laurent Pinchart wrote: > >>> On Wednesday 17 May 2017 22:20:57

Re: [PATCH v5 2/3] platform: add video-multiplexer subdevice driver

Hi Philipp, Thanks a lot for the update! Just a few really minor comments below. After fixing them you can add: Acked-by: Sakari Ailus On Wed, May 17, 2017 at 05:15:06PM +0200, Philipp Zabel wrote: > This driver can handle SoC internal and external video bus

Re: [PATCH v3 2/2] media: i2c: adv748x: add adv748x driver

Hi Kieran, Thank you for the patch. On Wednesday 17 May 2017 15:13:18 Kieran Bingham wrote: > From: Kieran Bingham > > Provide basic support for the ADV7481 and ADV7482. > > The driver is modelled with 2 subdevices to allow simultaneous streaming >

Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

On Thu, 18 May 2017 11:06:43 -0300 Mauro Carvalho Chehab wrote: > diff --git a/drivers/media/tuners/fc0011.c b/drivers/media/tuners/fc0011.c > index 192b1c7740df..145407dee3db 100644 > --- a/drivers/media/tuners/fc0011.c > +++ b/drivers/media/tuners/fc0011.c > @@ -342,6

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Kieran, On Thu, May 18, 2017 at 01:04:55PM +0100, Kieran Bingham wrote: > Hi Sakari, > > >>> In omap3isp/isp.c: isp_fwnodes_parse() the async notifier is registered > >>> looking > >>> at the endpoints parent fwnode: > >>> > >>> isd->asd.match.fwnode.fwnode = > >>>

Re: [PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Laurent, On Thu, May 18, 2017 at 11:54:46PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 18 May 2017 23:50:34 Sakari Ailus wrote: > > On Thu, May 18, 2017 at 07:08:00PM +0300, Laurent Pinchart wrote: > > > On Wednesday 17 May 2017 22:20:57 Sakari Ailus wrote: > > >> On Wed, May

Re: [PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Sakari, On Thursday 18 May 2017 23:50:34 Sakari Ailus wrote: > On Thu, May 18, 2017 at 07:08:00PM +0300, Laurent Pinchart wrote: > > On Wednesday 17 May 2017 22:20:57 Sakari Ailus wrote: > >> On Wed, May 17, 2017 at 04:38:14PM +0100, Kieran Bingham wrote: > >>> From: Kieran Bingham

Re: [PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Laurent, On Thu, May 18, 2017 at 07:08:00PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Wednesday 17 May 2017 22:20:57 Sakari Ailus wrote: > > On Wed, May 17, 2017 at 04:38:14PM +0100, Kieran Bingham wrote: > > > From: Kieran Bingham > > > > >

Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c

On Thu, May 18, 2017 at 05:31:20PM +0100, Alan Cox wrote: > On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote: > > This is a patch to the atomisp_tpg.c file that fixes up a missing > > blank line warning found by the checkpatch.pl tool > > > > Signed-off-by: Manny Vindiola

Re: [media-dvb-usb-v2] question about value overwrite

Hi Malcolm, Quoting Malcolm Priestley : Hi On 18/05/17 20:09, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1226934 I ran into the following piece of code at drivers/media/usb/dvb-usb-v2/lmedm04.c:205 205static int

Re: [media-dvb-usb-v2] question about value overwrite

Hi On 18/05/17 20:09, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1226934 I ran into the following piece of code at drivers/media/usb/dvb-usb-v2/lmedm04.c:205 205static int lme2510_stream_restart(struct dvb_usb_device *d) 206{ 207struct lme2510_state

[media-dvb-usb-v2] question about value overwrite

Hello everybody, While looking into Coverity ID 1226934 I ran into the following piece of code at drivers/media/usb/dvb-usb-v2/lmedm04.c:205 205static int lme2510_stream_restart(struct dvb_usb_device *d) 206{ 207struct lme2510_state *st = d->priv; 208u8 all_pids[] =

Re: [PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

On Thu, May 18, 2017 at 11:06:43AM -0300, Mauro Carvalho Chehab wrote: > As such macro will check if the expression is true, it may fall through, as > warned: > On both cases, it means an error, so, let's return an error > code, to make gcc happy. > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 00/13] staging: media: atomisp queued up patches

On Thu, 2017-05-18 at 11:10 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 18 May 2017 15:50:09 +0200 > Greg Kroah-Hartman escreveu: > > > > > Hi Mauro, > > > > Here's the set of accumulated atomisp staging patches that I had in > > my > > to-review mailbox.  After

Re: [PATCH] Staging: media: fix missing blank line coding style issue in atomisp_tpg.c

On Wed, 2017-05-17 at 21:48 -0400, Manny Vindiola wrote: > This is a patch to the atomisp_tpg.c file that fixes up a missing > blank line warning found by the checkpatch.pl tool > > Signed-off-by: Manny Vindiola > --- >  drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c

Re: [PATCH v3.1 1/2] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

Hi Sakari, On Wednesday 17 May 2017 22:20:57 Sakari Ailus wrote: > On Wed, May 17, 2017 at 04:38:14PM +0100, Kieran Bingham wrote: > > From: Kieran Bingham > > > > Return NULL, if a null entity is parsed for it's v4l2_subdev > > > > Signed-off-by:

Re: [PATCH v1 2/3] device property: Add fwnode_graph_get_port_parent

Hi Kieran, On Wed, May 17, 2017 at 04:03:38PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > V4L2 async notifiers can pass the endpoint fwnode rather than the device > fwnode. > > Provide a helper to obtain the parent device fwnode without

Re: [PATCH 2/4] [media] imon: better code the pad_mouse toggling

On Thu, May 18, 2017 at 11:06:44AM -0300, Mauro Carvalho Chehab wrote: > The logic with toggles the pad_mouse is confusing. Now, gcc 7.1 > complains about it: > > drivers/media/rc/imon.c: In function 'imon_incoming_scancode': > drivers/media/rc/imon.c:1725:23: warning: '~' on a boolean expression

Re: [PATCH 00/13] staging: media: atomisp queued up patches

Em Thu, 18 May 2017 15:50:09 +0200 Greg Kroah-Hartman escreveu: > Hi Mauro, > > Here's the set of accumulated atomisp staging patches that I had in my > to-review mailbox. After this, my queue is empty, the driver is all > yours! Thanks! Alan, please let me know

[PATCH 4/4] [media] mtk_vcodec_dec: return error at mtk_vdec_pic_info_update()

Gcc 7.1 complains that: drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c: In function 'mtk_vdec_pic_info_update': drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c:284:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] int ret; ^~~

[PATCH 1/4] [media] tw5864, fc0011: better handle WARN_ON()

As such macro will check if the expression is true, it may fall through, as warned: In file included from ./include/uapi/linux/stddef.h:1:0, from ./include/linux/stddef.h:4, from ./include/uapi/linux/posix_types.h:4, from

[PATCH 2/4] [media] imon: better code the pad_mouse toggling

The logic with toggles the pad_mouse is confusing. Now, gcc 7.1 complains about it: drivers/media/rc/imon.c: In function 'imon_incoming_scancode': drivers/media/rc/imon.c:1725:23: warning: '~' on a boolean expression [-Wbool-operation] ictx->pad_mouse = (~ictx->pad_mouse) & 0x1;

[PATCH 3/4] [media] s5p-jpeg: don't return a random width/height

Gcc 7.1 complains about: drivers/media/platform/s5p-jpeg/jpeg-core.c: In function 's5p_jpeg_parse_hdr.isra.9': drivers/media/platform/s5p-jpeg/jpeg-core.c:1207:12: warning: 'width' may be used uninitialized in this function [-Wmaybe-uninitialized] result->w = width; ~~^~~

Re: [PATCH v1 3/3] v4l: async: Match parent devices

Hi Kieran, Thank you for the patch. On Wednesday 17 May 2017 16:03:39 Kieran Bingham wrote: > From: Kieran Bingham > > Devices supporting multiple endpoints on a single device node must set > their subdevice fwnode to the endpoint to allow distinct

Re: [PATCH v4 4/4] drm: rcar-du: Register a completion callback with VSP1

Em Fri, 5 May 2017 16:21:10 +0100 Kieran Bingham escreveu: > Currently we process page flip events on every display interrupt, > however this does not take into consideration the processing time needed > by the VSP1 utilised in the pipeline. > >

[PATCH 08/13] staging: media: atomisp: Make undeclared symbols static

From: Guru Das Srinagesh Fix sparse warnings: "symbol not declared; should it be static?" Signed-off-by: Guru Das Srinagesh Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c |

[PATCH 10/13] staging: media: atomisp: one char read beyond end of string

From: Dan Carpenter We should verify that "ix < max_len" before we test whether we have reached the NUL terminator. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Reported-by: David Binderman Signed-off-by: Dan Carpenter

[PATCH 13/13] staging: media: atomisp: don't treat warnings as errors

From: Mauro Carvalho Chehab Several atomisp files use: ccflags-y += -Werror As, on media, our usual procedure is to use W=1, and atomisp has *a lot* of warnings with such flag enabled,like:

[PATCH 11/13] staging: media: atomisp: putting NULs in the wrong place

From: Dan Carpenter We're putting the NUL terminators one space beyond where they belong. This doesn't show up in testing because all but the callers put a NUL in the correct place themselves. LOL. It causes a static checker warning about buffer overflows. Fixes:

[PATCH 12/13] staging: media: atomisp: fix missing blank line coding style issue in atomisp_tpg.c

From: Manny Vindiola This is a patch to the atomisp_tpg.c file that fixes up a missing blank line warning found by the checkpatch.pl tool Signed-off-by: Manny Vindiola Signed-off-by: Greg Kroah-Hartman ---

[PATCH 09/13] staging: media: atomisp: Fix -Werror=int-in-bool-context compile errors

From: Hans de Goede With gcc-7.1.1 I was getting the following compile error: error: ‘*’ in boolean context, suggest ‘&&’ instead The problem is the definition of CEIL_DIV: #define CEIL_DIV(a, b) ((b) ? ((a) + (b) - 1) / (b) : 0) Which when called as: CEIL_DIV(x, y

[PATCH 02/13] staging: media: atomisp: use logical AND, not bitwise

From: Guru Das Srinagesh Fixes sparse warning "dubious: x & !y" in logical expression. Signed-off-by: Guru Das Srinagesh Signed-off-by: Greg Kroah-Hartman ---

[PATCH 06/13] staging: media: atomisp: fixed coding style errors

From: Avraham Shukron Fix for error (not warnings) reported by checkpatch.pl Specifically: - missing whitespace around "=" and after "," - indentation with spaces instead of tabs - lines starting with a whitespace This patch does not affect the compiled code in any

[PATCH 07/13] staging: media: atomisp: fix coding style warnings

From: Avraham Shukron Fix for warnings reported by checkpatch.pl: - Multiline comment style - Bare "unsigned" - Missing blank line after declarations - Un-needed braces around single-statement branch Signed-off-by: Avraham Shukron

[PATCH 01/13] staging: media: atomisp: Add __printf validation and fix fallout

From: Joe Perches __printf validation adds format and argument validation. Fix the various broken format/argument mismatches. Signed-off-by: Joe Perches Signed-off-by: Greg Kroah-Hartman ---

[PATCH 00/13] staging: media: atomisp queued up patches

Hi Mauro, Here's the set of accumulated atomisp staging patches that I had in my to-review mailbox. After this, my queue is empty, the driver is all yours! Good Luck! :) thanks, greg k-h Avraham Shukron (3): staging: media: atomisp: fixed sparse warnings staging: media: atomisp: fixed

[PATCH 04/13] staging: media: atomisp: fixed sparse warnings

From: Avraham Shukron Added "static" storage class to 4 not-declared functions Signed-off-by: Avraham Shukron Signed-off-by: Greg Kroah-Hartman --- .../media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

[PATCH 05/13] staging: media: atomisp: drop unused qos variable

From: Valentin Vidic Fixes a sparse warning: drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c:35:5: warning: symbol 'qos' was not declared. Should it be static? Signed-off-by: Valentin Vidic Signed-off-by: Greg

[PATCH 03/13] staging: media: atomisp: Fix unnecessary initialization of static

From: Fabrizio Perria Fix checkpatch warning: removed unnecessary initialization of static variable "skip_fwload" to 0 in source atomisp_v4l2.c Signed-off-by: Fabrizio Perria Signed-off-by: Greg Kroah-Hartman

Re: [PATCH] ATOMISP: Tidies up code warnings and errors in file

On Mon, May 08, 2017 at 11:25:55PM +0100, Mark Railton wrote: > Cleared up some errors and warnings in > drivers/staging/media/atomisp/i2c/ap1302.c > > Signed-off-by: Mark Railton > --- > drivers/staging/media/atomisp/i2c/ap1302.c | 83 > ++ >

Re: [PATCH v1 2/3] device property: Add fwnode_graph_get_port_parent

Hi Kieran, Thank you for the patch. On Wednesday 17 May 2017 16:03:38 Kieran Bingham wrote: > From: Kieran Bingham > > V4L2 async notifiers can pass the endpoint fwnode rather than the device > fwnode. I'm not sure I would mention V4L2 in the commit

Re: [PATCH v1 1/3] of: base: Provide of_graph_get_port_parent()

Hi Kieran, On Wednesday 17 May 2017 21:02:42 Kieran Bingham wrote: > On 17/05/17 17:36, Rob Herring wrote: > > On Wed, May 17, 2017 at 10:03 AM, Kieran Bingham wrote: > >> From: Kieran Bingham > >> > >> When handling endpoints, the v4l2 async framework

[PATCH 3/5] [media] bt8xx: add missing break

The logic that handles CA_SET_PID is clearly missing a break: it prints that the command succeeded, but, due to the missing break, it would be returning -EOPNOTSUPP, as if the driver weren't supporting such ioctl. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 1/5] [media] bcm3510: fix handling of VSB16 modulation

There's a missing break for VSB16 modulation logic, with would cause it to return -EINVAL, instead of handling it. Fix it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/bcm3510.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/5] [media] saa7164: better handle error codes

Right now, the driver is doing the right thing for PVC_ERRORCODE_UNKNOWN and PVC_ERRORCODE_INVALID_CONTROL: for both, it returns an error code (SAA_ERR_NOT_SUPPORTED). However, it is printing two error messages instead of one on those cases. Fix the logic. Signed-off-by: Mauro Carvalho Chehab

[PATCH 4/5] [media] dvb-usb-remote: don't write bogus debug messages

When a REMOTE_KEY_PRESSED event happens, it does the right thing. However, if debug is enabled, it will print a bogus message warning that "key repeated". Fix it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/dvb-usb/dvb-usb-remote.c | 5 + 1 file

Re: [RFC PATCH v2 1/4] media: i2c: adv748x: add adv748x driver

Hi Sakari, >>> In omap3isp/isp.c: isp_fwnodes_parse() the async notifier is registered >>> looking >>> at the endpoints parent fwnode: >>> >>> isd->asd.match.fwnode.fwnode = >>> fwnode_graph_get_remote_port_parent(fwnode); >>> >>> This would therefore not support

[GIT PULL FOR v4.13] V4L2 fwnode support

Hi Mauro, This pull request introduces the V4L2 fwnode framework which has equivalent functionality to V4L2 OF framework. The V4L2 OF framework users are converted to use the V4L2 fwnode framework and the redundant V4L2 OF framework is removed. Please pull. The following changes since commit

Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes

Hi Laurent, On 01/19/2017 12:43 PM, Todor Tomov wrote: > Hi Laurent, > > Thank you for the detailed review. > > On 12/05/2016 05:22 PM, Laurent Pinchart wrote: >> Hi Todor, >> >> Thank you for the patch. >> >> On Friday 25 Nov 2016 16:57:20 Todor Tomov wrote: >>> These files handle the video

Re: [PATCH] [media] atomisp: don't treat warnings as errors

Em Thu, 18 May 2017 11:05:24 +0200 Arnd Bergmann escreveu: > On Thu, May 18, 2017 at 10:45 AM, Mauro Carvalho Chehab > wrote: > > Several atomisp files use: > > ccflags-y += -Werror > > > > As, on media, our usual procedure is to use W=1, and

Re: [PATCH] rc-core: cleanup rc_register_device (v2)

On Thu, May 18, 2017 at 09:55:14AM +0200, David Härdeman wrote: > On Wed, May 17, 2017 at 09:09:57PM +0100, Sean Young wrote: > >Hi David, > > > >On Wed, May 03, 2017 at 12:04:00PM +0200, David Härdeman wrote: > >> The device core infrastructure is based on the presumption that > >> once a driver

Re: [PATCH] [media] atomisp: don't treat warnings as errors

On Thu, May 18, 2017 at 10:45 AM, Mauro Carvalho Chehab wrote: > Several atomisp files use: > ccflags-y += -Werror > > As, on media, our usual procedure is to use W=1, and atomisp > has *a lot* of warnings with such flag enabled,like: > >

[PATCH] [media] atomisp: don't treat warnings as errors

Several atomisp files use: ccflags-y += -Werror As, on media, our usual procedure is to use W=1, and atomisp has *a lot* of warnings with such flag enabled,like: ./drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/system_local.h:62:26: warning: 'DDR_BASE'

[PATCH] cec: stih: fix typos in comments

Minor fixes in comments Signed-off-by: Benjamin Gaignard --- drivers/media/platform/sti/cec/stih-cec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sti/cec/stih-cec.c b/drivers/media/platform/sti/cec/stih-cec.c

[PATCH] cec: stih: allow to use max CEC logical addresses

Hardware could support up to 16 logical addresses which is more than needed by CEC specifications. Let use CEC_MAX_LOG_ADDRS instead of limited it on one. stih_cec_adap_log_addr() function was alredy written to support multiple addresses requests. Signed-off-by: Benjamin Gaignard

Re: [PATCH] rc-core: cleanup rc_register_device (v2)

On Wed, May 17, 2017 at 09:09:57PM +0100, Sean Young wrote: >Hi David, > >On Wed, May 03, 2017 at 12:04:00PM +0200, David Härdeman wrote: >> The device core infrastructure is based on the presumption that >> once a driver calls device_add(), it must be ready to accept >> userspace interaction. >>