Re: [PATCH v5] v4l2-async: Match parent devices

2017-12-06 Thread Sakari Ailus
On Wed, Dec 06, 2017 at 02:58:39PM +, Kieran Bingham wrote: > From: Kieran Bingham > > Devices supporting multiple endpoints on a single device node must set > their subdevice fwnode to the endpoint to allow distinct comparisons. > > Adapt the

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-06 Thread Sakari Ailus
Hej Niklas, Tack för dina kommentarer! On Wed, Dec 06, 2017 at 04:57:48PM +0100, Niklas Söderlund wrote: > CC Jacopo, Kieran > > Hi Sakari, > > Thanks for your patch. > > On 2017-12-04 23:03:02 +0200, Sakari Ailus wrote: > > V4L2 async framework can use both device's fwnode and endpoints's

cron job: media_tree daily build: ERRORS

2017-12-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Dec 7 05:00:17 CET 2017 media-tree git hash:781b045baefdabf7e0bc9f33672ca830d3db9f27 media_build

Re: build failure on ubuntu 16.04 LTS

2017-12-06 Thread Jasmin J.
Hello Hans! > Jasmin, you've done some work on this in the past. Let me know if you > have time to look at this, I would really appreciate that. THX! > No, it really is broken. I don't quite understand why it is failing ... I noticed this already, but I am currently very busy to finish al my

Re: [PATCH for 4.15] ddbridge update to 0.9.32

2017-12-06 Thread Daniel Scheller
Am Sun, 15 Oct 2017 22:51:49 +0200 schrieb Daniel Scheller : > From: Daniel Scheller > > For the 4.15 merge window. These patches update the mainline ddbridge > driver to version 0.9.32, which was released ~3 weeks ago by upstream. > > Nothing

[PATCH 1/2] [media] ddbridge: improve error handling logic on fe attach failures

2017-12-06 Thread Daniel Scheller
From: Daniel Scheller This change makes sure that demod frontends are always detached whenever a tuner frontend attach failed. Achieve this by moving the detach-on- failure logic at the end of dvb_input_attach(), and adding a goto to this block on every tuner attach failure

[PATCH 0/2] ddbridge: error handling improvements

2017-12-06 Thread Daniel Scheller
From: Daniel Scheller Two commits which will improve the error handling when attaching of (tuner) frontends fail, which complements the recent fixes in the DVB core (esp. dvb_frontend.c), making sure that on failure there won't be any frontend drivers left with a usecount > 0

[PATCH 2/2] [media] ddbridge: don't break on single/last port attach failure

2017-12-06 Thread Daniel Scheller
From: Daniel Scheller As all error handling improved quite a bit, don't stop attaching frontends if one of them failed, since - if other tuner modules are connected to the PCIe bridge - other hardware may just work, so lets not break on a single port failure, but rather

[PATCH 09/45] drivers: media: remove duplicate includes

2017-12-06 Thread Pravin Shedge
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge --- drivers/media/platform/pxa_camera.c | 1 - drivers/media/platform/ti-vpe/cal.c | 3 ---

[PATCH] media: pxa_camera: disable and unprepare the clock source on error

2017-12-06 Thread Flavio Ceolin
pxa_camera_probe() was not calling pxa_camera_deactivate(), responsible to call clk_disable_unprepare(), on the failure path. This was leading to unbalancing source clock. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin ---

[PATCH] media: s5p-jpeg: Fix off-by-one problem

2017-12-06 Thread Flavio Ceolin
s5p_jpeg_runtime_resume() does not call clk_disable_unprepare() for jpeg->clocks[0] when one of the clk_prepare_enable() fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin --- drivers/media/platform/s5p-jpeg/jpeg-core.c |

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-06 Thread Kieran Bingham
Hi Niklas, On 06/12/17 15:57, Niklas Söderlund wrote: > CC Jacopo, Kieran > > Hi Sakari, > > Thanks for your patch. > > On 2017-12-04 23:03:02 +0200, Sakari Ailus wrote: >> V4L2 async framework can use both device's fwnode and endpoints's fwnode >> for matching the async sub-device with the

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-06 Thread Niklas Söderlund
CC Jacopo, Kieran Hi Sakari, Thanks for your patch. On 2017-12-04 23:03:02 +0200, Sakari Ailus wrote: > V4L2 async framework can use both device's fwnode and endpoints's fwnode > for matching the async sub-device with the sub-device. In order to proceed > moving towards endpoint matching assign

Re: [PATCH v5] v4l2-async: Match parent devices

2017-12-06 Thread Kieran Bingham
Hi Jacopo, On 06/12/17 15:33, jacopo mondi wrote: > Hi Kieran, > > On Wed, Dec 06, 2017 at 02:58:39PM +, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Devices supporting multiple endpoints on a single device node must set >> their subdevice

Re: [PATCH v5] v4l2-async: Match parent devices

2017-12-06 Thread jacopo mondi
Hi Kieran, On Wed, Dec 06, 2017 at 02:58:39PM +, Kieran Bingham wrote: > From: Kieran Bingham > > Devices supporting multiple endpoints on a single device node must set > their subdevice fwnode to the endpoint to allow distinct comparisons. > > Adapt

[PATCH v8] uvcvideo: Add a metadata device node

2017-12-06 Thread Guennadi Liakhovetski
From: Guennadi Liakhovetski Some UVC video cameras contain metadata in their payload headers. This patch extracts that data, adding more clock synchronisation information, on both bulk and isochronous endpoints and makes it available to the user space on a

Re: [PATCH 3/3 v7] uvcvideo: add a metadata device node

2017-12-06 Thread Guennadi Liakhovetski
Hi Laurent, While testing the new patch version, we did introduce a couple of differences: 1. We cannot (easily) reuse .vidioc_querycap() - the metadata node uses v4l2_fh_open() directly, so, it has a different struct file::private_data pointer. 2. After your video device unification, the

[PATCH v5] v4l2-async: Match parent devices

2017-12-06 Thread Kieran Bingham
From: Kieran Bingham Devices supporting multiple endpoints on a single device node must set their subdevice fwnode to the endpoint to allow distinct comparisons. Adapt the match_fwnode call to compare against the provided fwnodes first, but to also

Re: [PATCH] media: platform: sti: Adopt SPDX identifier

2017-12-06 Thread Fabien DESSENNE
On 05/12/17 15:52, Benjamin Gaignard wrote: > Add SPDX identifiers to files under sti directory > > Signed-off-by: Benjamin Gaignard For the bdisp part: Reviewed-by: Fabien Dessenne > --- > drivers/media/platform/sti/bdisp/bdisp-debug.c

[PATCH v3 00/12] Rockchip ISP1 Driver

2017-12-06 Thread Jacob Chen
changes in V3: - add some comments - fix wrong use of v4l2_async_subdev_notifier_register - optimize two paths capture at a time - remove compose - re-struct headers - add a tmp wiki page: http://opensource.rock-chips.com/wiki_Rockchip-isp1 changes in V2: mipi-phy: - use async

[PATCH v3 06/12] dt-bindings: Document the Rockchip ISP1 bindings

2017-12-06 Thread Jacob Chen
From: Jacob Chen Add DT bindings documentation for Rockchip ISP1 Signed-off-by: Jacob Chen --- .../devicetree/bindings/media/rockchip-isp1.txt| 57 ++ 1 file changed, 57 insertions(+) create mode 100644

[PATCH v3 02/12] media: doc: add document for rkisp1 meta buffer format

2017-12-06 Thread Jacob Chen
Signed-off-by: Jacob Chen --- Documentation/media/uapi/v4l/meta-formats.rst | 2 ++ .../media/uapi/v4l/pixfmt-meta-rkisp1-params.rst | 17 + .../media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst | 18 ++ 3 files changed, 37

[PATCH v3 05/12] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-12-06 Thread Jacob Chen
From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa ---

[PATCH v3 07/12] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

2017-12-06 Thread Jacob Chen
From: Jacob Chen Add DT bindings documentation for Rockchip MIPI D-PHY RX Signed-off-by: Jacob Chen --- .../bindings/media/rockchip-mipi-dphy.txt | 71 ++ 1 file changed, 71 insertions(+) create mode 100644

[PATCH v3 09/12] ARM: dts: rockchip: add rx0 mipi-phy for rk3288

2017-12-06 Thread Jacob Chen
From: Jacob Chen It's a Designware MIPI D-PHY, used by ISP in rk3288. Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v3 11/12] arm64: dts: rockchip: add rx0 mipi-phy for rk3399

2017-12-06 Thread Jacob Chen
From: Shunqian Zheng It's a Designware MIPI D-PHY, used for ISP0 in rk3399. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++ 1 file changed, 11

[PATCH v3 10/12] arm64: dts: rockchip: add isp0 node for rk3399

2017-12-06 Thread Jacob Chen
From: Shunqian Zheng rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15

[PATCH v3 12/12] MAINTAINERS: add entry for Rockchip ISP1 driver

2017-12-06 Thread Jacob Chen
From: Jacob Chen Add MAINTAINERS entry for the rockchip isp1 driver. This driver is maintained by rockchip officially and it will be used for rockchip SoC on all linux-kernel based OS. Signed-off-by: Jacob Chen --- MAINTAINERS | 10

[PATCH v3 08/12] ARM: dts: rockchip: add isp node for rk3288

2017-12-06 Thread Jacob Chen
From: Jacob Chen rk3288 have a Embedded 13M ISP Signed-off-by: Jacob Chen --- arch/arm/boot/dts/rk3288.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v3 03/12] media: rkisp1: Add user space ABI definitions

2017-12-06 Thread Jacob Chen
From: Jeffy Chen Add the header for userspace Signed-off-by: Jeffy Chen Signed-off-by: Jacob Chen --- include/uapi/linux/rkisp1-config.h | 785 + 1 file changed, 785

[PATCH v3 01/12] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format

2017-12-06 Thread Jacob Chen
From: Shunqian Zheng Add the Rockchip ISP1 specific processing parameter format V4L2_META_FMT_RK_ISP1_PARAMS and metadata format V4L2_META_FMT_RK_ISP1_STAT_3A for 3A. Signed-off-by: Shunqian Zheng Signed-off-by: Jacob Chen

Re: build failure on ubuntu 16.04 LTS

2017-12-06 Thread Hans Verkuil
On 12/06/17 11:43, Vincent McIntyre wrote: > Hi, > > the build has been broken for over a week for me. > Possibly my checkout is out of date?? No, it really is broken. I don't quite understand why it is failing or how to fix it, and I lack time to dig into this. Hopefully I can find some time

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-06 Thread Kieran Bingham
Hi Sakari, Thanks for the patch. On 04/12/17 21:03, Sakari Ailus wrote: > V4L2 async framework can use both device's fwnode and endpoints's fwnode > for matching the async sub-device with the sub-device. In order to proceed > moving towards endpoint matching assign the endpoint to the async >

build failure on ubuntu 16.04 LTS

2017-12-06 Thread Vincent McIntyre
Hi, the build has been broken for over a week for me. Possibly my checkout is out of date?? I am using the normal build --main-git method. Setup details: + date Wednesday 6 December 21:25:28 AEDT 2017 + uname -a Linux ubuntu 4.4.0-101-generic #124-Ubuntu SMP Fri Nov 10 18:29:59 UTC 2017

Re: [PATCH v2 3/4] media: ov5640: add support of DVP parallel interface

2017-12-06 Thread Hugues FRUCHET
Hi Fabio, I will do. On 11/30/2017 08:09 PM, Fabio Estevam wrote: > Hi Hugues, > > On Wed, Nov 29, 2017 at 3:11 PM, Hugues Fruchet wrote: >> Add support of DVP parallel mode in addition of >> existing MIPI CSI mode. The choice between two modes >> and configuration is

Re: [PATCH v2 2/4] media: ov5640: check chip id

2017-12-06 Thread Hugues FRUCHET
Thanks Fabio for review, This make sense, I'll try to change my code that way. On 11/30/2017 08:07 PM, Fabio Estevam wrote: > Hi Hugues, > > On Wed, Nov 29, 2017 at 3:11 PM, Hugues Fruchet wrote: > >> /* read exposure, in number of line periods */ >> static int

Re: [PATCH v2 3/4] media: ov5640: add support of DVP parallel interface

2017-12-06 Thread Hugues FRUCHET
Hi Steve, On 12/03/2017 10:58 PM, Steve Longerbeam wrote: > > > On 11/29/2017 09:11 AM, Hugues Fruchet wrote: >> Add support of DVP parallel mode in addition of >> existing MIPI CSI mode. The choice between two modes >> and configuration is made through device tree. >> >> Signed-off-by: Hugues

Re: [PATCH v2 2/4] media: ov5640: check chip id

2017-12-06 Thread Hugues FRUCHET
Hi Steve, thanks for review, comments below. On 12/03/2017 10:34 PM, Steve Longerbeam wrote: > > > On 11/29/2017 09:11 AM, Hugues Fruchet wrote: >> Verify that chip identifier is correct before starting streaming >> >> Signed-off-by: Hugues Fruchet >> --- >>