Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

On 01/08/2018 06:55 PM, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify this using the same text as is provided

Re: [PATCH v2] media: i2c: adv748x: fix HDMI field heights

On 01/08/2018 07:14 PM, Kieran Bingham wrote: > The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field > types. The correct specification for the height on the mbus is the > image height, in this instance, the field height. > > The AFE component already correctly adjusts the

Re: [PATCH 7/9] lgdt3306a: Set fe ops.release to NULL if probed

Am 05.01.2018 um 01:19 schrieb Michael Ira Krufky: > On Thu, Jan 4, 2018 at 7:04 PM, Brad Love wrote: >> If release is part of frontend ops then it is called in the >> course of dvb_frontend_detach. The process also decrements >> the module usage count. The problem is if

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jan 9 05:00:16 CET 2018 media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361 media_build

Re: [PATCH v2 2/2] media: dt-bindings: Add OF properties to ov7670

On Thu, Jan 04, 2018 at 10:52:33AM +0100, Jacopo Mondi wrote: > Describe newly introduced OF properties for ov7670 image sensor. > The driver supports two standard properties to configure synchronism > signals polarities and two custom properties already supported as > platform data options by the

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Mon, Jan 8, 2018 at 3:23 AM, Laurent Pinchart wrote: > Hi Dan, > > Thank you for the patch. > > On Saturday, 6 January 2018 03:10:32 EET Dan Williams wrote: >> Static analysis reports that 'index' may be a user controlled value that >> is used as a data

Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

Hi Kieran, Thanks for your patch. On 2018-01-08 17:55:24 +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify

Re: [PATCH v2 3/4] media: ov2685: add support for OV2685 sensor

Hi Shunqian, On Mon, Jan 08, 2018 at 09:37:20PM +0800, Shunqian Zheng wrote: ... > > > +static int ov2685_probe(struct i2c_client *client, > > > + const struct i2c_device_id *id) > > > +{ > > > + struct device *dev = >dev; > > > + struct ov2685 *ov2685; > > > + int ret; > > > + >

Re: [PATCH v3 1/4] media: ov5695: add support for OV5695 sensor

Hi Shunqian, Could you next time add a cover page to the patchset that details the changes from the previous version? Please also add a MAINTAINERS entry. DT binding files should also precede the driver. On Mon, Jan 08, 2018 at 09:36:04PM +0800, Shunqian Zheng wrote: > This patch adds driver

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 22:44:27 +0100 Peter Zijlstra wrote: > On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote: > > I did expected the issue to get worse, when you load the Pi with > > network traffic, as now the softirq time-budget have to be shared > >

Re: dvb usb issues since kernel 4.9

On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote: > I did expected the issue to get worse, when you load the Pi with > network traffic, as now the softirq time-budget have to be shared > between networking and USB/DVB. Thus, I guess you are running TCP and > USB/mpeg2ts on

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 17:26:10 +0100 "Josef Griebichler" wrote: > I tried your mentioned patch but unfortunately no real improvement for me. > dmesg http://ix.io/DOg > tvheadend service log http://ix.io/DOi > > Errors during recording are still there. Are you _also_

Re: [ANN] Meeting notes on naming meeting 2017-10-11/13

Hi Mauro, On Mon, Jan 08, 2018 at 02:17:52PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 8 Jan 2018 15:47:21 +0200 > Sakari Ailus escreveu: > > > Hi folks, > > > > Here are the meeting notes on the IRC meeting that took place 11th and 13th > > last October. The brief

Re: [PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

Hi Kieran, Thanks for the update. On Mon, Jan 08, 2018 at 05:55:24PM +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. >

Re: [PATCH] drivers/media/common/videobuf2: rename from videobuf

On Mon, Jan 08, 2018 at 09:20:01PM +0100, Hans Verkuil wrote: > This directory contains the videobuf2 framework, so name the > directory accordingly. > > The name 'videobuf' typically refers to the old and deprecated > videobuf version 1 framework so that was confusing. > > Signed-off-by: Hans

RE: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

Hello Hugues, thank you for the patch series. I am having a go with your patches, and although they seem alright, I don't seem to be able to grab a non-black picture on the iWave iwg20d in plain DVP mode, but if I switch to BT656 just by setting register 0x4730 to 0x01 (I know, it's a nasty

Re: [PATCH 2/2] lgdt3306a: Fix a double kfree on i2c device remove

On 2018-01-08 14:34, Matthias Schwarzott wrote: > Am 05.01.2018 um 15:57 schrieb Brad Love: >> Both lgdt33606a_release and lgdt3306a_remove kfree state, but _release is >> called first, then _remove operates on states members before kfree'ing it. >> This can lead to random oops/GPF/etc on USB

Re: Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 12:35:08 -0500 (EST) Alan Stern wrote: > On Mon, 8 Jan 2018, Josef Griebichler wrote: > > > No I can't sorry. There's no sat connection near to my workstation. > > Can we ask the person who made this post: >

Re: [PATCH 2/2] lgdt3306a: Fix a double kfree on i2c device remove

Am 05.01.2018 um 15:57 schrieb Brad Love: > Both lgdt33606a_release and lgdt3306a_remove kfree state, but _release is > called first, then _remove operates on states members before kfree'ing it. > This can lead to random oops/GPF/etc on USB disconnect. > lgdt3306a_release does nothing but the

[PATCH] drivers/media/common/videobuf2: rename from videobuf

This directory contains the videobuf2 framework, so name the directory accordingly. The name 'videobuf' typically refers to the old and deprecated videobuf version 1 framework so that was confusing. Signed-off-by: Hans Verkuil --- drivers/media/common/Kconfig

Re: dvb usb issues since kernel 4.9

On Mon, Jan 8, 2018 at 11:15 AM, Alan Stern wrote: > > Both dwc2_hsotg and ehci-hcd use the tasklets embedded in the > giveback_urb_bh member of struct usb_hcd. See usb_hcd_giveback_urb() > in drivers/usb/core/hcd.c; the calls are > > else if (high_prio_bh) >

Travelers List

Hi, Greeting of the day! Would you be interested in acquiring an email list of "Travelers" from USA? We also have data for Frequent Travelers List, Camping and Outdoor List, Scuba Divers List, Cruise Travelers List, Vacation Travelers List,Boat Owners List, Fishing Enthusiasts List, Apparel

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Linus Torvalds wrote: > Can somebody tell which softirq it is that dvb/usb cares about? I don't know about the DVB part. The USB part is a little difficult to analyze, mostly because the bug reports I've seen are mostly from people running non-vanilla kernels. For example,

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

* Alan Cox wrote: > On Mon, 8 Jan 2018 11:08:36 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > > wrote: >

Re: dvb usb issues since kernel 4.9

On Mon, Jan 8, 2018 at 9:55 AM, Ingo Molnar wrote: > > as I doubt we have enough time to root-case this properly. Well, it's not like this is a new issue, and we don't have to get it fixed for 4.15. It's been around since 4.9, it's not a "have to suddenly fix it this week"

[PATCH v2] media: i2c: adv748x: fix HDMI field heights

The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field types. The correct specification for the height on the mbus is the image height, in this instance, the field height. The AFE component already correctly adjusts the height on the mbus, but the HDMI component got left behind.

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

Hi Hans, Niklas, Sakari, Thank you for the very prompt reviews! I fired the patch - disappeared to teach code club, and came back to the answers :-D - very streamlined! On 08/01/18 15:48, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: >> Hi, >> >> Thanks for your patch.

Re: [PATCH] media: i2c: adv748x: fix HDMI field heights

Hi Niklas, On 08/01/18 17:56, Niklas Söderlund wrote: > Hi Kieran, > > Thanks for your patch. > > On 2018-01-08 17:39:30 +, Kieran Bingham wrote: >> The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field >> types. The correct specification for the height on the mbus is the

[PATCH v2] v4l: doc: Clarify v4l2_mbus_fmt height definition

The v4l2_mbus_fmt width and height corresponds directly with the v4l2_pix_format definitions, yet the differences in documentation make it ambiguous what to do in the event of field heights. Clarify this using the same text as is provided for the v4l2_pix_format which is explicit on the matter,

Re: [PATCH v9 21/28] rcar-vin: add group allocator functions

Hi Niklas, On Monday, 8 January 2018 19:24:47 EET Niklas Söderlund wrote: > On 2017-12-08 22:12:56 +0200, Laurent Pinchart wrote: > > On Friday, 8 December 2017 03:08:35 EET Niklas Söderlund wrote: > >> In media controller mode all VIN instances needs to be part of the same > >> media graph.

Re: [PATCH] media: i2c: adv748x: fix HDMI field heights

Hi Kieran, Thanks for your patch. On 2018-01-08 17:39:30 +, Kieran Bingham wrote: > The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field > types. The correct specification for the height on the mbus is the > image height, in this instance, the field height. > > The AFE

Re: dvb usb issues since kernel 4.9

* Linus Torvalds wrote: > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > wrote: > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebichler" escreveu: > >> > >> the causing commit has been

Re: [PATCH v9 07/28] rcar-vin: change name of video device

Hi Niklas, On Monday, 8 January 2018 18:42:05 EET Niklas Söderlund wrote: > On 2018-01-08 18:35:23 +0200, Laurent Pinchart wrote: > > On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > >> On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > >>> On Thursday, 14 December 2017

[PATCH] media: i2c: adv748x: fix HDMI field heights

The ADV748x handles interlaced media using V4L2_FIELD_ALTERNATE field types. The correct specification for the height on the mbus is the image height, in this instance, the field height. The AFE component already correctly adjusts the height on the mbus, but the HDMI component got left behind.

Re: Aw: Re: Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Josef Griebichler wrote: > No I can't sorry. There's no sat connection near to my workstation. Can we ask the person who made this post: https://forum.libreelec.tv/thread/4235-dvb-issue-since-le-switched-to-kernel-4-9-x/?postID=75965#post75965 to run the test? The post

Re: [PATCH v9 21/28] rcar-vin: add group allocator functions

Hi Laurent, Thanks for your comments. On 2017-12-08 22:12:56 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday, 8 December 2017 03:08:35 EET Niklas Söderlund wrote: > > In media controller mode all VIN instances needs to be part of the same > > media graph.

Aw: Re: Re: dvb usb issues since kernel 4.9

No I can't sorry. There's no sat connection near to my workstation.     Gesendet: Montag, 08. Januar 2018 um 17:31 Uhr Von: "Alan Stern" An: "Josef Griebichler" Cc: "Mauro Carvalho Chehab" , "Greg Kroah-Hartman"

Re: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

Hi Maxime, I'm using a ST board with OV5640 wired in parallel bus output in order to interface to my STM32 DCMI parallel interface. Perhaps could you describe your setup so I could help on understanding the problem on your side. From my past experience with this sensor module, you can first

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

On 01/08/2018 05:11 PM, Niklas Söderlund wrote: > On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: >> On 01/08/2018 04:32 PM, Niklas Söderlund wrote: >>> Hi, >>> >>> Thanks for your patch. >>> >>> On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: Hi Kieran, On Mon, Jan 08, 2018 at

Re: [PATCH v9 07/28] rcar-vin: change name of video device

Hi Laurent, On 2018-01-08 18:35:23 +0200, Laurent Pinchart wrote: > Hi Niklas, > > On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > > On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > > >> On Fri, Dec

Re: [PATCH v9 07/28] rcar-vin: change name of video device

Hi Niklas, On Wednesday, 20 December 2017 17:20:55 EET Niklas Söderlund wrote: > On 2017-12-14 17:50:24 +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > >> On Fri, Dec 08, 2017 at 10:17:36AM +0200, Laurent Pinchart wrote: > >>> On Friday, 8

Re: Aw: Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Josef Griebichler wrote: > Hi Maro, > > I tried your mentioned patch but unfortunately no real improvement for me. > dmesg http://ix.io/DOg > tvheadend service log http://ix.io/DOi > Errors during recording are still there. > Errors increase if there is additional tcp load on

Aw: Re: dvb usb issues since kernel 4.9

Hi Maro, I tried your mentioned patch but unfortunately no real improvement for me. dmesg http://ix.io/DOg tvheadend service log http://ix.io/DOi Errors during recording are still there. Errors increase if there is additional tcp load on raspberry. Unfortunately there's no usbmon or tshark on

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote: > > Let find the root-cause of this before reverting, as this will hurt the > > networking use-case. > > > > I want to see if the increase buffer will solve the issue (the current > > buffer of 0.63 ms seem too small). > > For TV, high latency

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On 01/05/18 22:30, Dan Williams wrote: On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman wrote: Please expand this. It is not clear what the static analysis is looking for. Have a clear description of what is being fixed is crucial for allowing any of these changes.

Re: [ANN] Meeting notes on naming meeting 2017-10-11/13

Em Mon, 8 Jan 2018 15:47:21 +0200 Sakari Ailus escreveu: > Hi folks, > > Here are the meeting notes on the IRC meeting that took place 11th and 13th > last October. The brief summary is below, the full log can be found here: > >

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

On 2018-01-08 16:48:35 +0100, Hans Verkuil wrote: > On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > > Hi, > > > > Thanks for your patch. > > > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > >> Hi Kieran, > >> > >> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > >>> The

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote: > Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) > Alan Stern escreveu: > > > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > > > It seems that the original patch were designed to solve some IRQ > > > > > issues >

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

On 01/08/2018 04:32 PM, Niklas Söderlund wrote: > Hi, > > Thanks for your patch. > > On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: >> Hi Kieran, >> >> On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: >>> The v4l2_mbus_fmt width and height corresponds directly with the >>>

Re: [PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

Hi Hugues, On Wed, Jan 03, 2018 at 10:57:27AM +0100, Hugues Fruchet wrote: > Enhance OV5640 CSI driver to support also DVP parallel interface. > Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing > YUV422 UYVY format. > Some other improvements on chip identifier check and removal

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

Hi, Thanks for your patch. On 2018-01-08 17:13:53 +0200, Sakari Ailus wrote: > Hi Kieran, > > On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > > The v4l2_mbus_fmt width and height corresponds directly with the > > v4l2_pix_format definitions, yet the differences in

Re: [PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

Hi Kieran, On Mon, Jan 08, 2018 at 02:45:49PM +, Kieran Bingham wrote: > The v4l2_mbus_fmt width and height corresponds directly with the > v4l2_pix_format definitions, yet the differences in documentation make > it ambiguous what to do in the event of field heights. > > Clarify this by

Re: [PATCH] media: media-device: use strlcpy() instead of strncpy()

On Mon, Jan 08, 2018 at 08:40:59PM +0800, Xiongfeng Wang wrote: > From: Xiongfeng Wang > > gcc-8 reports > > drivers/media/media-device.c: In function 'media_device_get_topology': > ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified > bound 64

[PATCH] v4l: doc: clarify v4l2_mbus_fmt height definition

The v4l2_mbus_fmt width and height corresponds directly with the v4l2_pix_format definitions, yet the differences in documentation make it ambiguous what to do in the event of field heights. Clarify this by referencing the v4l2_pix_format which is explicit on the matter, and by matching the

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

Em Mon, 8 Jan 2018 15:26:50 +0100 Hans Verkuil escreveu: > A quick follow-up: > > On 01/08/2018 02:54 PM, Hans Verkuil wrote: > >> +/* > >> + * Videobuf operations > >> + */ > >> +int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int > >> nonblocking) > >> +{ > >>

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

Em Mon, 8 Jan 2018 14:54:51 +0100 Hans Verkuil escreveu: > Hi Mauro, > > Thanks for this patch series, nice to see this moving forward. > > Some comments below (note the wrong queue_setup code in particular since that > relates to my comment about the '[PATCH v3] media:

Re: [PATCH 2/2] media: staging: atomisp: cleanup whitespaces

On Mon, 8 Jan 2018 16:21:21 +0200 Sakari Ailus wrote: > Hi Mauro, > > On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote: > > There are lots of bad whitespaces at atomisp driver. > > > > Fix them. > > > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

A quick follow-up: On 01/08/2018 02:54 PM, Hans Verkuil wrote: >> +/* >> + * Videobuf operations >> + */ >> +int dvb_vb2_init(struct dvb_vb2_ctx *ctx, const char *name, int nonblocking) >> +{ >> +struct vb2_queue *q = >vb_q; >> +int ret; >> + >> +memset(ctx, 0, sizeof(struct

[PATCH] media: usbtv: prevent double free in error case

Quoting the original report: It looks like there is a double-free vulnerability in Linux usbtv driver on an error path of usbtv_probe function. When audio registration fails, usbtv_video_free function ends up freeing usbtv data structure, which gets freed the second time under usbtv_video_fail

Re: [PATCH 2/2] media: staging: atomisp: cleanup whitespaces

Hi Mauro, On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote: > There are lots of bad whitespaces at atomisp driver. > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > > Sakari/Alan, > > This is a script-generated patch that can be

Re: [PATCH 02/11] media: videobuf2: Add new uAPI for DVB streaming I/O

Hi Mauro, Thanks for this patch series, nice to see this moving forward. Some comments below (note the wrong queue_setup code in particular since that relates to my comment about the '[PATCH v3] media: videobuf2-core: don't go out of the buffer range' patch). On 12/21/2017 05:18 PM, Mauro

[ANN] Meeting notes on naming meeting 2017-10-11/13

Hi folks, Here are the meeting notes on the IRC meeting that took place 11th and 13th last October. The brief summary is below, the full log can be found here: Attendees: Laurent Pinchart Mauro Chehab

[PATCH v3 3/4] media: ov2685: add support for OV2685 sensor

This patch adds driver for Omnivision's ov2685 sensor. Though the ov2685 can output yuv data, this driver only supports the raw bayer format, including the following features: - output 1600x1200 at 30fps - test patterns - manual exposure/gain control - vblank and hblank - media

[PATCH v3 1/4] media: ov5695: add support for OV5695 sensor

This patch adds driver for Omnivision's ov5695 sensor, the driver supports following features: - supported resolutions + 2592x1944 at 30fps + 1920x1080 at 30fps + 1296x972 at 60fps + 1280x720 at 30fps + 640x480 at 120fps - test patterns - manual exposure/gain(analog and digital)

[PATCH v3 4/4] dt-bindings: media: Add bindings for OV2685

Add device tree binding documentation for the OV2685 sensor. Signed-off-by: Shunqian Zheng --- .../devicetree/bindings/media/i2c/ov2685.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

[PATCH v3 2/4] dt-bindings: media: Add bindings for OV5695

Add device tree binding documentation for the OV5695 sensor. Signed-off-by: Shunqian Zheng --- .../devicetree/bindings/media/i2c/ov5695.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

Re: [PATCH v3] media: videobuf2-core: don't go out of the buffer range

On 01/08/2018 02:15 PM, Mauro Carvalho Chehab wrote: > Em Mon, 8 Jan 2018 12:34:15 +0100 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> On 12/28/2017 03:16 PM, Mauro Carvalho Chehab wrote: >>> Currently, there's no check if an invalid buffer range >>> is passed. However, while

Re: [PATCH v3] media: videobuf2-core: don't go out of the buffer range

Em Mon, 8 Jan 2018 12:34:15 +0100 Hans Verkuil escreveu: > Hi Mauro, > > On 12/28/2017 03:16 PM, Mauro Carvalho Chehab wrote: > > Currently, there's no check if an invalid buffer range > > is passed. However, while testing DVB memory mapped apps, > > I got this: > > > >

[PATCH] media: intel-ipu3: cio2: mark more PM functions as __maybe_unused

My earlier patch missed two functions, these must be __maybe_unused as well: drivers/media/pci/intel/ipu3/ipu3-cio2.c:1867:12: error: 'cio2_runtime_resume' defined but not used [-Werror=unused-function] drivers/media/pci/intel/ipu3/ipu3-cio2.c:1849:12: error: 'cio2_runtime_suspend' defined but

Re: dvb usb issues since kernel 4.9

Em Mon, 8 Jan 2018 12:59:10 +0100 Jesper Dangaard Brouer escreveu: > On Mon, 8 Jan 2018 08:02:00 -0200 > Mauro Carvalho Chehab wrote: > > > Hi Linus, > > > > Em Sun, 7 Jan 2018 13:23:39 -0800 > > Linus Torvalds

[PATCH] media: i2c: ov7740: add media-controller dependency

Without CONFIG_MEDIA_CONTROLLER, the new driver fails to build: drivers/perf/arm_dsu_pmu.c: In function 'dsu_pmu_probe_pmu': drivers/perf/arm_dsu_pmu.c:661:2: error: implicit declaration of function 'bitmap_from_u32array'; did you mean 'bitmap_from_arr32'?

[PATCH] [media] dibx000_common: use strlcpy() instead of strncpy()

From: Xiongfeng Wang gcc-8 reports drivers/media/dvb-frontends/dibx000_common.c: In function 'i2c_adapter_init': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 48 equals destination size [-Wstringop-truncation] We need to use strlcpy()

[PATCH] media: media-device: use strlcpy() instead of strncpy()

From: Xiongfeng Wang gcc-8 reports drivers/media/media-device.c: In function 'media_device_get_topology': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified bound 64 equals destination size [-Wstringop-truncation] We need to use strlcpy() to make

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

Hi Mauro, On 18.12.2017 08:32, Michal Simek wrote: > Hi guys, > > On 15.12.2017 10:27, Mauro Carvalho Chehab wrote: >> Em Fri, 15 Dec 2017 10:55:26 +0530 >> Dhaval Shah escreveu: >> >>> Hi Laurent/Mauro/Greg, >>> >>> On Fri, Dec 15, 2017 at 3:32 AM, Laurent Pinchart

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 08:02:00 -0200 Mauro Carvalho Chehab wrote: > Hi Linus, > > Em Sun, 7 Jan 2018 13:23:39 -0800 > Linus Torvalds escreveu: > > > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > >

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Mon, Jan 08, 2018 at 11:43:42AM +, Alan Cox wrote: > On Mon, 8 Jan 2018 11:08:36 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > >

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Mon, 8 Jan 2018 11:08:36 +0100 Peter Zijlstra wrote: > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > > wrote: > > > In at least one place (mpls) you are patching a fast

Re: Adjustments for a lot of function implementations

> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Are you going to answer any of my remaining questions in a more constructive way? Regards, Markus

Re: [PATCH v3] media: videobuf2-core: don't go out of the buffer range

Hi Mauro, On 12/28/2017 03:16 PM, Mauro Carvalho Chehab wrote: > Currently, there's no check if an invalid buffer range > is passed. However, while testing DVB memory mapped apps, > I got this: > >videobuf2_core: VB: num_buffers -2143943680, buffer 33, index -2143943647 >unable to handle

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

Hi Dan, Thank you for the patch. On Saturday, 6 January 2018 03:10:32 EET Dan Williams wrote: > Static analysis reports that 'index' may be a user controlled value that > is used as a data dependency to read 'pin' from the > 'selector->baSourceID' array. In order to avoid potential leaks of >

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

Hi Sakari, On Mon, Jan 08, 2018 at 11:37:12AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, Jan 08, 2018 at 10:18:38AM +0100, jacopo mondi wrote: > > > @@ -1561,9 +1605,19 @@ static const struct i2c_device_id ov965x_id[] = { > > > }; > > > MODULE_DEVICE_TABLE(i2c, ov965x_id); > > > > > >

Re: [linux-sunxi] [PATCH v4 0/2] Initial Allwinner V3s CSI Support

Hi, On Thu, Jan 04, 2018 at 04:27:41PM +0100, Ondřej Jirman wrote: > On Thu, Jan 04, 2018 at 03:06:25PM +0100, Maxime Ripard wrote: > > On Mon, Dec 25, 2017 at 09:58:02AM +0100, Ondřej Jirman wrote: > > > Hello, > > > > > > On Mon, Dec 25, 2017 at 11:15:26AM +0800, Yong wrote: > > > > Hi, > > >

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote: > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman > wrote: > > In at least one place (mpls) you are patching a fast path. Compile out > > or don't load mpls by all means. But it is not acceptable to change

Re: dvb usb issues since kernel 4.9

Hi Linus, Em Sun, 7 Jan 2018 13:23:39 -0800 Linus Torvalds escreveu: > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > wrote: > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebichler" escreveu:

Re: dvb usb issues since kernel 4.9

Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) Alan Stern escreveu: > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > It seems that the original patch were designed to solve some IRQ issues > > > > with network cards with causes data losses on high traffic.

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

Hi Jacopo, On Mon, Jan 08, 2018 at 10:18:38AM +0100, jacopo mondi wrote: > > @@ -1561,9 +1605,19 @@ static const struct i2c_device_id ov965x_id[] = { > > }; > > MODULE_DEVICE_TABLE(i2c, ov965x_id); > > > > +#if IS_ENABLED(CONFIG_OF) > > +static const struct of_device_id ov965x_of_match[] = { >

Re: [PATCH v2 2/2] media: ov9650: add device tree binding

Hi Akinobu, Thanks for the update. On Mon, Jan 08, 2018 at 01:54:24AM +0900, Akinobu Mita wrote: > Now the ov9650 driver supports device tree probing. So this adds a > device tree binding documentation. > > Cc: Jacopo Mondi > Cc: H. Nikolaus Schaller >

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

Hi Akinobu, just one small comments below On Mon, Jan 08, 2018 at 01:54:23AM +0900, Akinobu Mita wrote: > The ov9650 driver currently only supports legacy platform data probe. > This change adds device tree probing. > > There has been an attempt to add device tree support for ov9650 driver >