Re: cron job: media_tree daily build: ERRORS

2018-02-04 Thread Jasmin J.
Will look into this during the next days. BR, Jasmin

Re: [PATCH] [BUGFIX] media: vb2: Fix videobuf2 to map correct area

2018-02-04 Thread Masami Hiramatsu
On Mon, 5 Feb 2018 11:30:41 +0900 Masami Hiramatsu wrote: > Fixes vb2_vmalloc_get_userptr() to ioremap correct area. > Since the current code does ioremap the page address, if the offset > 0, > it does not do ioremap the last page and results in kernel panic. > > This

cron job: media_tree daily build: ERRORS

2018-02-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Feb 5 05:00:16 CET 2018 media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1 media_build

[PATCH] media: v4l2_fh.h: add missing kconfig.h include

2018-02-04 Thread Alexandre Courbot
v4l2_fh.h uses the IS_ENABLED() macro and thus should include kconfig.h. Signed-off-by: Alexandre Courbot --- include/media/v4l2-fh.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/media/v4l2-fh.h b/include/media/v4l2-fh.h index 62633e7d2630..ea73fef8bdc0

[PATCH] [BUGFIX] media: vb2: Fix videobuf2 to map correct area

2018-02-04 Thread Masami Hiramatsu
Fixes vb2_vmalloc_get_userptr() to ioremap correct area. Since the current code does ioremap the page address, if the offset > 0, it does not do ioremap the last page and results in kernel panic. This fixes to pass the page address + offset to ioremap so that ioremap can map correct area. Also,

[PATCH] v4l: vidioc-prepare-buf.rst: fix link to VIDIOC_QBUF

2018-02-04 Thread Alexandre Courbot
The description for VIDIOC_PREPARE_BUF results in the following sentence: "...before actually enqueuing it, using the ioctl VIDIOC_QBUF, VIDIOC_DQBUF ioctl...". The intent is to only refer to VIDIOC_QBUF though, so fix this. Signed-off-by: Alexandre Courbot ---

[PATCH] media: media-types.rst: fix typo

2018-02-04 Thread Alexandre Courbot
with -> which Signed-off-by: Alexandre Courbot --- Documentation/media/uapi/mediactl/media-types.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/uapi/mediactl/media-types.rst b/Documentation/media/uapi/mediactl/media-types.rst

[PATCH 17/20] media: sec: Remove PLAT_S5P dependency

2018-02-04 Thread Ulf Magnusson
The PLAT_S5P symbol was removed in commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code"). Remove the PLAT_S5P dependency from VIDEO_SAMSUNG_S5P_CEC. Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf

Re: [PATCH] build: Added temporarily v4.9_uvcvideo_ktime_conversion.patch

2018-02-04 Thread Hans Verkuil
On 02/04/2018 11:33 PM, Jasmin J. wrote: > From: Jasmin Jessich > > Due the delay with merging patches to media_tree, add the mentioned > patch temporarily to backports. Once this patch is merged to media_tree, > revert this patch. Merged! Please notify me when I can revert this

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-02-04 Thread Jasmin J.
Hi! > Strictly speaking, building the media subsystem on older kernels is a job of > the media build system. Yes I agree. > In general I would thus ask for the fix to be merged in media-build.git. Which I do mostly, but in this case it is a coding error in mainline. > In this specific case,

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-02-04 Thread Jasmin J.
Hi! > We're waiting for the end of the 4.16 merge window. Ahh, this is the reason for the delay. > For me that meant that I simply did (and still don't) have time to look at > fixing the media_build. No problem, I do it when I have time ;) > The media_build is also broken worse than usual

Re: [PATCH] build: Added temporarily v4.9_uvcvideo_ktime_conversion.patch

2018-02-04 Thread Jasmin J.
Hi! I tested to build with Kernel 4.14.17 and 4.4 and this worked. Kernel 3.17 is currently not working, but I would like to wait with fixes for Kernel 3.x after this patch has been applied to media_build. BR, Jasmin

[PATCH] build: Added temporarily v4.9_uvcvideo_ktime_conversion.patch

2018-02-04 Thread Jasmin J.
From: Jasmin Jessich Due the delay with merging patches to media_tree, add the mentioned patch temporarily to backports. Once this patch is merged to media_tree, revert this patch. Signed-off-by: Jasmin Jessich --- backports/backports.txt|

Re: [RFCv2 02/17] videodev2.h: Add request_fd field to v4l2_buffer

2018-02-04 Thread Sakari Ailus
Hi Alexandre, On Wed, Jan 31, 2018 at 07:24:20PM +0900, Alexandre Courbot wrote: > From: Hans Verkuil > > When queuing buffers allow for passing the request that should > be associated with this buffer. > > Signed-off-by: Hans Verkuil >

Re: [PATCH] media-types.rst: fix type, small improvements

2018-02-04 Thread Sakari Ailus
On Sun, Feb 04, 2018 at 02:40:37PM +0100, Hans Verkuil wrote: > data conector -> connector > > ... -> etc. > > ... looked odd when my browser put the ... by itself on the next line, 'etc.' > is clearer IMHO. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

[ANN] v4l2-ctl/v4l2-compliance: now v4l-subdev and media aware

2018-02-04 Thread Hans Verkuil
Hi all, I've been busy this weekend and the v4l2-ctl utility is now able to work with /dev/v4l-subdevX devices, and the v4l2-compliance utility can now test /dev/v4l-subdevX devices and /dev/mediaX devices. v4l2-ctl will also show any media entity information of the device. And with the new

[RFC PATCH] media-device: add index field to media_v2_pad

2018-02-04 Thread Hans Verkuil
Userspace has no way of knowing the pad index for the entity that owns the pad with the MEDIA_IOC_G_TOPOLOGY ioctl. However, various v4l-subdev ioctls need to pass this as an argument. Add this missing information. Signed-off-by: Hans Verkuil --- RFC, so no documentation

MEDIA_IOC_G_TOPOLOGY and entity flags

2018-02-04 Thread Hans Verkuil
Another thing that is missing in the G_TOPOLOGY ioctl are the entity flags MEDIA_ENT_FL_DEFAULT and MEDIA_ENT_FL_CONNECTOR. The DEFAULT flag should be part of the interface flags (it describes which interface is the default). The CONNECTOR flag should be a new field in the media_v2_entity struct.

[PATCH] media-types.rst: fix type, small improvements

2018-02-04 Thread Hans Verkuil
data conector -> connector ... -> etc. ... looked odd when my browser put the ... by itself on the next line, 'etc.' is clearer IMHO. Signed-off-by: Hans Verkuil --- Note: 'data connector' makes no sense. Just 'connector' is fine, I think. --- diff --git

Compliance tests for new public API features

2018-02-04 Thread Hans Verkuil
Hi Gustavo, Alexandre, As you may have seen I have been extending the v4l2-compliance utility with tests for v4l-subdevX and mediaX devices. In the process of doing that I promptly found a bunch of bugs. Mostly little things that are easy to fix, but much harder to find without proper tests.

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-02-04 Thread Laurent Pinchart
Hi Jasmin, On Sunday, 4 February 2018 12:37:08 EET Jasmin J. wrote: > Hi Laurent! > > > Reviewed-by: Laurent Pinchart > > THX! > Don't forget the "Acked-by: Arnd Bergmann " (see Patchwork: > https://patchwork.linuxtv.org/patch/46464 ). Sure.

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

2018-02-04 Thread Laurent Pinchart
Hi Hans, On Sunday, 4 February 2018 15:16:26 EET Hans Verkuil wrote: > On 02/04/2018 02:13 PM, Laurent Pinchart wrote: > > On Sunday, 4 February 2018 15:06:42 EET Hans Verkuil wrote: > >> Hi Mauro, > >> > >> I'm working on adding proper compliance tests for the MC but I think > >> something is

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

2018-02-04 Thread Hans Verkuil
On 02/04/2018 02:13 PM, Laurent Pinchart wrote: > Hi Hans, > > On Sunday, 4 February 2018 15:06:42 EET Hans Verkuil wrote: >> Hi Mauro, >> >> I'm working on adding proper compliance tests for the MC but I think >> something is missing in the G_TOPOLOGY ioctl w.r.t. pads. >> >> In several

Re: MEDIA_IOC_G_TOPOLOGY and pad indices

2018-02-04 Thread Laurent Pinchart
Hi Hans, On Sunday, 4 February 2018 15:06:42 EET Hans Verkuil wrote: > Hi Mauro, > > I'm working on adding proper compliance tests for the MC but I think > something is missing in the G_TOPOLOGY ioctl w.r.t. pads. > > In several v4l-subdev ioctls you need to pass the pad. There the pad is an >

MEDIA_IOC_G_TOPOLOGY and pad indices

2018-02-04 Thread Hans Verkuil
Hi Mauro, I'm working on adding proper compliance tests for the MC but I think something is missing in the G_TOPOLOGY ioctl w.r.t. pads. In several v4l-subdev ioctls you need to pass the pad. There the pad is an index for the corresponding entity. I.e. an entity has 3 pads, so the pad argument

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-02-04 Thread Hans Verkuil
Hi Jasmin, On 02/04/2018 11:37 AM, Jasmin J. wrote: > Hi Laurent! > >> Reviewed-by: Laurent Pinchart > THX! > Don't forget the "Acked-by: Arnd Bergmann " (see Patchwork: > https://patchwork.linuxtv.org/patch/46464 ). > >> and taken into my tree

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-02-04 Thread Jasmin J.
Hi Laurent! > Reviewed-by: Laurent Pinchart THX! Don't forget the "Acked-by: Arnd Bergmann " (see Patchwork: https://patchwork.linuxtv.org/patch/46464 ). > and taken into my tree for v4.17. When will this merged to the media-tree trunk? In