cron job: media_tree daily build: ERRORS

2018-03-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 7 05:00:12 CET 2018 media-tree git hash:60d0bbec5965590d72b1a2091ec7a2cc589cb8e0 media_build

[linuxtv-media:master 180/263] drivers/media/usb/em28xx/em28xx-dvb.c:1140:26: error: implicit declaration of function 'dvb_module_probe'; did you mean 'module_put'?

2018-03-06 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: 60d0bbec5965590d72b1a2091ec7a2cc589cb8e0 commit: ad32495b1513fe8cbab717411b9cd8d2d285de30 [180/263] media: em28xx-dvb: simplify DVB module probing logic config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.2.0

Re: [PATCHv2 5/7] cec-pin: add error injection support

2018-03-06 Thread Hans Verkuil
On 05/03/18 14:51, Hans Verkuil wrote: > From: Hans Verkuil > > Implement all the error injection commands. > > The state machine gets new states for the various error situations, > helper functions are added to detect whether an error injection is > active and the

[PATCH] cec: improve CEC pin event handling

2018-03-06 Thread Hans Verkuil
It turns out that the struct cec_fh event buffer size of 64 events (64 for CEC_EVENT_PIN_CEC_LOW and 64 for _HIGH) is too small. It's about 160 ms worth of events and if the Raspberry Pi is busy, then it might take too long for the application to be scheduled so that it can drain the pending

Re: [PATCH 3/3] media: vb2-core: vb2_ops: document non-interrupt-cantext calling

2018-03-06 Thread Luca Ceresoli
Hi, I noticed a typo in the title: cantext -> context I will fix in v2. On 28/02/2018 23:24, Luca Ceresoli wrote: > Driver writers can benefit in knowing if/when callbacks are called in > interrupt context. But it is not completely obvious here, so document it. > > Signed-off-by: Luca Ceresoli

[PATCH 4/4] cx23885: Override 888 ImpactVCBe crystal frequency

2018-03-06 Thread Brad Love
Hauppauge produced a revision of ImpactVCBe using an 888, with a 25MHz crystal, instead of using the default third overtone 50Mhz crystal. This overrides that frequency so that the cx25840 is properly configured. Without the proper crystal setup the cx25840 cannot load the firmware or decode

[PATCH 1/4] cx25840: Use subdev host data for PLL override

2018-03-06 Thread Brad Love
The cx25840 driver currently configures 885, 887, and 888 using default divisors for each chip. This check to see if the cx23885 driver has passed the cx25840 a non-default clock rate for a specific chip. If a cx23885 board has left clk_freq at 0, the clock default values will be used to configure

[PATCH 3/4] cx23885: Set subdev host data to clk_freq pointer

2018-03-06 Thread Brad Love
Currently clk_freq is ignored entirely, because the cx235840 driver configures the xtal at the chip defaults. This is an issue if a board is produced with a non-default frequency crystal. If clk_freq is not zero the cx25840 will attempt to use the setting provided, or fall back to defaults

[PATCH 0/4] [resend] cx25840: Add non-default crystal frequency support

2018-03-06 Thread Brad Love
Hauppauge produced a revision of ImpactVCBe using an 888, with a 25MHz crystal, instead of using the default third overtone 50Mhz crystal. Custom configuration of the cx25840 is required to load the firmware and properly decode video. This patch set add an extra clocking option to the cx25840

[PATCH 2/4] cx23885: change 887/888 default to 888

2018-03-06 Thread Brad Love
Proper cx2388x chip type is detected in cx25840 probe, the clock rate is untouched however in probe. The cx25840 only checks for non default clock values for 888 and provides custom settings for 25MHz 888. This change ensures that cx23888 chips with default 50MHz crystals will not get configured

[PATCH 8/8] cx23885: Fix gpio on Hauppauge QuadHD PCIe cards

2018-03-06 Thread Brad Love
Bug fix for gpios Signed-off-by: Brad Love --- drivers/media/pci/cx23885/cx23885-cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c index 5a64098..41f5669

[PATCH 1/8] lgdt3306a: remove symbol count mismatch fix

2018-03-06 Thread Brad Love
This symbol mismatch is handled by NULL'ing out the release callback if the driver is loaded as an i2c device. This patch reverts: - 94448e21cf08b10f7dc7acdaca387594370396b0 - 835d66173a38538c072a7c393d02360dcfac8582 The symbol count mismatch is handled by: -

[PATCH 3/8] cx231xx: Use frontend i2c adapter with tuner

2018-03-06 Thread Brad Love
Utilize the i2c mux adapter returned by the frontend. Signed-off-by: Brad Love --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c

[PATCH 4/8] cx23885: Add tuner type and analog inputs to 1265

2018-03-06 Thread Brad Love
Missing composite and s-video inputs Signed-off-by: Brad Love --- drivers/media/pci/cx23885/cx23885-cards.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c index

[PATCH 0/8] FIXME: Assorted of missed bits from merge

2018-03-06 Thread Brad Love
Hello Mauro, Here are the assorted bits and bobs that wound up missing due to the patchwork snafu. One new patch is: - cx231xx: Set mfe_shared if second frontend found Due to your suggestion in regards to the shared tuner logic. I put the check in what seems like a sensical spot. Brad Love

[PATCH 2/8] em28xx: Change hex to lower case

2018-03-06 Thread Brad Love
Checkpatch fix. Signed-off-by: Brad Love --- drivers/media/usb/em28xx/em28xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c index bb1b650..36d341f 100644 ---

[PATCH 6/8] cx231xx: Use constant instead of hard code for max

2018-03-06 Thread Brad Love
Nit regarding hard coded value. Signed-off-by: Brad Love --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c b/drivers/media/usb/cx231xx/cx231xx-dvb.c index

[PATCH 5/8] cx231xx: Set mfe_shared if second frontend found

2018-03-06 Thread Brad Love
If frontend[1] exists, then enable the dvb adapter mfe lock system. Signed-off-by: Brad Love --- drivers/media/usb/cx231xx/cx231xx-dvb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-dvb.c

[PATCH 7/8] cx231xx: Add second i2c demod to Hauppauge 975

2018-03-06 Thread Brad Love
Hauppauge HVR-975 is a hybrid, dual frontend, single tuner USB device. It contains lgdt3306a and si2168 frontends and one si2157 tuner. The lgdt3306a frontend is currently enabled. This creates the second demodulator and attaches it to the tuner. Enables lgdt3306a|si2168 + si2157 Signed-off-by:

[PATCH] media: rc: meson-ir: add timeout on idle

2018-03-06 Thread Matthias Reichl
Meson doesn't seem to be able to generate timeout events in hardware. So install a software timer to generate the timeout events required by the decoders to prevent "ghost keypresses". Signed-off-by: Matthias Reichl --- drivers/media/rc/meson-ir.c | 22 ++ 1

[PATCH 1/2] [media] ngene: move the tsin_exchange() stripcopy block into a function

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller Move the copy logic that will skip previously inserted TS NULL frames when moving data to the DVB ring buffers into an own function. This is done to not duplicate code all over the place with the following TS offset shift fixup patch. While we're

[PATCH 2/2] [media] ngene: compensate for TS buffer offset shifts

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller A possible hardware bug was discovered when using CA addon hardware attached to the ngene hardware, in that the TS input buffer much likely will shift and thus become unaligned to 188 byte blocks (a full TS frame) when things like CA module

[PATCH 0/2] ngene CI TS fixup

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller Remainder of the ngene updates series, taking care of the TS buffer offset shift which occurs in conjunction with CICAM hardware during CAM inits. Changed as requested to get rid of the DEBUG_CI_XFER ifdeffery. This might aswell be considered a v3 of

Re: [PATCH] w1: fix w1_ds2438 documentation

2018-03-06 Thread Mauro Carvalho Chehab
Em Fri, 2 Mar 2018 08:55:24 +0100 Mariusz Bialonczyk escreveu: > Signed-off-by: Mariusz Bialonczyk > --- > Documentation/w1/slaves/w1_ds2438 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/w1/slaves/w1_ds2438 >

Re: [v2] [media] Use common error handling code in 20 functions

2018-03-06 Thread SF Markus Elfring
I got the following notification. - http://patchwork.linuxtv.org/patch/47270/ - for: Linux Media kernel patches was: New now: Rejected Would you like to clarify still any other variant for this change proposal? Regards, Markus

[PATCH] media: ov5640: fix get_/set_fmt colorspace related fields

2018-03-06 Thread Hugues Fruchet
Fix set of missing colorspace related fields in get_/set_fmt. Detected by v4l2-compliance tool. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git

Re: [PATCH v2 01/11] media: tw9910: Re-order variables declaration

2018-03-06 Thread Mauro Carvalho Chehab
Em Tue, 6 Mar 2018 17:57:15 +0100 jacopo mondi escreveu: > Hi Mauro, > > On Tue, Mar 06, 2018 at 01:51:52PM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 2 Mar 2018 15:46:33 +0100 > > Jacopo Mondi escreveu: > > > > > Re-order variables

[PATCH] media: ov5640: fix colorspace compliance

2018-03-06 Thread Hugues Fruchet
Fix format ioctl colorspace related fields. Detected by v4l2-compliance tool. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

Re: [PATCH v2 01/11] media: tw9910: Re-order variables declaration

2018-03-06 Thread jacopo mondi
Hi Mauro, On Tue, Mar 06, 2018 at 01:51:52PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 2 Mar 2018 15:46:33 +0100 > Jacopo Mondi escreveu: > > > Re-order variables declaration to respect 'reverse christmas tree' > > ordering whenever possible. > > To be frank, I

[PATCH] media: ov5640: fix colorspace compliance

2018-03-06 Thread Hugues Fruchet
Fix format ioctl colorspace related fields. Detected by v4l2-compliance tool. Change-Id: I645138297033bc409751a3c7fc63e014650b8417 Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 29 + 1 file changed, 21 insertions(+), 8

Re: [PATCH v2 01/11] media: tw9910: Re-order variables declaration

2018-03-06 Thread Mauro Carvalho Chehab
Em Fri, 2 Mar 2018 15:46:33 +0100 Jacopo Mondi escreveu: > Re-order variables declaration to respect 'reverse christmas tree' > ordering whenever possible. To be frank, I don't like the idea of reverse christmas tree ordering myself... Perhaps due to the time I used

[PATCH 2/4] [media] ngene: add I2C_FUNC_I2C to the I2C interface functionality

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller Report I2C_FUNC_I2C in .functionality() aswell. The I2C interface can handle this fine and even is required for all I2C client drivers that utilise the regmap API which are used from within the ngene driver. Signed-off-by: Daniel Scheller

[PATCH 3/4] [media] dvb-frontends/cxd2099: remove remainders from old attach way

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller As all drivers using the cxd2099 are converted to handle attach/detach the generic I2C client way, the static inline cxd2099_attach isn't required anymore. Thus cleanup cxd2099.h from the remainders, the adr struct member isn't used anymore aswell.

[PATCH 1/4] [media] ddbridge: adapt cxd2099 attach to new i2c_client way

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller Change the way the cxd2099 hardware is being attached to the new I2C client interface way. Signed-off-by: Daniel Scheller Signed-off-by: Jasmin Jessich --- drivers/media/pci/ddbridge/ddbridge-ci.c | 62

[PATCH 4/4] [media] MAINTAINERS: add entry for cxd2099

2018-03-06 Thread Daniel Scheller
From: Jasmin Jessich The cxd2099 driver is now maintained and being taken care of by * Jasmin Jessich Signed-off-by: Jasmin Jessich --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 0/4] cxd2099 series fixup

2018-03-06 Thread Daniel Scheller
From: Daniel Scheller These are the missing bits from the cxd2099 that went MIA during the merge of the series. Please pull - ngene driver requires the ngene patch for all I2C clients to work (including the tda18212 that's now used since the merge of the other ngene series)

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-06 Thread Mauro Carvalho Chehab
Em Tue, 06 Mar 2018 18:35:32 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > > > VIDEO_RENESAS_VSP1 depends on

Re: [PATCH] media: ov772x: constify ov772x_frame_intervals

2018-03-06 Thread Mauro Carvalho Chehab
Em Tue, 6 Mar 2018 17:05:26 +0100 jacopo mondi escreveu: > Hi Mauro, > > On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote: > > The values on this array never changes. Make it const. > > > > Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-06 Thread Laurent Pinchart
Hi Mauro, On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF. > > As ARCH_RENESAS implies OF, the latter can be dropped. > > > > Signed-off-by: Geert

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-06 Thread Mauro Carvalho Chehab
Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF. > As ARCH_RENESAS implies OF, the latter can be dropped. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH v2 11/12] [media] ngene: move the tsin_exchange() stripcopy block into a function

2018-03-06 Thread Mauro Carvalho Chehab
Em Sun, 25 Feb 2018 13:31:39 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Move the copy logic that will skip previously inserted TS NULL frames when > moving data to the DVB ring buffers into an own function. This is done to > not

Re: [PATCH v2 08/12] [media] ngene: deduplicate I2C adapter evaluation

2018-03-06 Thread Mauro Carvalho Chehab
Em Tue, 6 Mar 2018 13:06:15 -0300 Mauro Carvalho Chehab escreveu: > Em Sun, 25 Feb 2018 13:31:36 +0100 > Daniel Scheller escreveu: > > > From: Daniel Scheller > > > > The I2C adapter evaluation (based on chan->number) is

Re: [PATCH v2 08/12] [media] ngene: deduplicate I2C adapter evaluation

2018-03-06 Thread Mauro Carvalho Chehab
Em Sun, 25 Feb 2018 13:31:36 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > The I2C adapter evaluation (based on chan->number) is duplicated at > several places (tuner_attach_() functions, demod_attach_stv0900() and > cineS2_probe()).

Re: [PATCH] media: ov772x: constify ov772x_frame_intervals

2018-03-06 Thread jacopo mondi
Hi Mauro, On Tue, Mar 06, 2018 at 10:35:22AM -0500, Mauro Carvalho Chehab wrote: > The values on this array never changes. Make it const. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jacopo Mondi Since I'm sure there will be more

[PATCH] media: ov772x: constify ov772x_frame_intervals

2018-03-06 Thread Mauro Carvalho Chehab
The values on this array never changes. Make it const. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/ov772x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c index

Re: [PATCH v9 2/2] media: V3s: Add support for Allwinner CSI.

2018-03-06 Thread Sakari Ailus
Hi Yong, Thanks for the patchset; please see my comments below. On Tue, Mar 06, 2018 at 10:16:02AM +0800, Yong Deng wrote: > Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > interface and CSI1 is used for parallel interface. This is not > documented in datasheet but by

[PATCH] media: rc: oops in ir_timer_keyup after device unplug

2018-03-06 Thread Sean Young
If there is IR in the raw kfifo when ir_raw_event_unregister() is called, then kthread_stop() causes ir_raw_event_thread to be scheduled, decode some scancodes and re-arm timer_keyup. The timer_keyup then fires when the rc device is long gone. Cc: sta...@vger.kernel.org Signed-off-by: Sean Young

[PATCH v2] media: rc: new driver for early iMon device

2018-03-06 Thread Sean Young
These devices were supported by the lirc_imon.c driver which was removed from staging in commit f41003a23a02 ("[media] staging: lirc_imon: port remaining usb ids to imon and remove"). Signed-off-by: Sean Young --- MAINTAINERS | 7 ++ drivers/media/rc/Kconfig

Re: [PATCH 3/7] si2157: Add hybrid tuner support

2018-03-06 Thread Brad Love
Hi Mauro, On 2018-03-06 06:24, Mauro Carvalho Chehab wrote: > Hi Brad, > > As patches 1 and 2 are independent of this one, and should be backward > compatible, I'm applying them, but I have issues with this one too :-) > > Em Tue, 16 Jan 2018 14:48:35 -0600 > Brad Love

Re: [PATCH 1/2] media: ov5645: Fix write_reg return code

2018-03-06 Thread Sakari Ailus
HI Mauro, On Tue, Mar 06, 2018 at 10:40:10AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 8 Feb 2018 11:41:59 +0200 > Todor Tomov escreveu: > > > I2C transfer functions return number of successful operations (on success). > > > > Do not return the received positive

Re: [PATCH 2/2] media: ov5645: Improve mode finding function

2018-03-06 Thread Sakari Ailus
Hi Todor, On Thu, Feb 08, 2018 at 11:42:00AM +0200, Todor Tomov wrote: > Find the sensor mode by comparing the size of the requested image size > and the sensor mode's image size. The distance between image sizes is the > size in pixels of the non-overlapping regions between the requested size >

Re: [PATCH 1/2] media: ov5645: Fix write_reg return code

2018-03-06 Thread Mauro Carvalho Chehab
Em Thu, 8 Feb 2018 11:41:59 +0200 Todor Tomov escreveu: > I2C transfer functions return number of successful operations (on success). > > Do not return the received positive return code but instead return 0 on > success. The users of write_reg function already use this

Re: [PATCH v2 1/5] media: dvb_frontend: add FEC modes, S2X modulations and 64K transmission

2018-03-06 Thread Mauro Carvalho Chehab
Hi Daniel, Em Mon, 22 Jan 2018 18:13:42 +0100 Daniel Scheller escreveu: > From: Daniel Scheller > > Add 1/4 and 1/3 FEC ratios, 64/128/256-APSK S2X modulations and 64K > transmission mode. Update relevant doc items aswell. Please properly

Re: [PATCH 3/7] si2157: Add hybrid tuner support

2018-03-06 Thread Mauro Carvalho Chehab
Hi Brad, As patches 1 and 2 are independent of this one, and should be backward compatible, I'm applying them, but I have issues with this one too :-) Em Tue, 16 Jan 2018 14:48:35 -0600 Brad Love escreveu: > On 2018-01-15 23:05, Antti Palosaari wrote: > > Hello > > So

Re: [PATCH] dvb: Save port number and provide sysfs attributes to pass values to udev

2018-03-06 Thread Mauro Carvalho Chehab
Hi David, Em Wed, 10 Jan 2018 14:50:35 + David Howells escreveu: > Some devices, such as the DVBSky S952 and T982 cards, are dual port cards > that provide two cx23885 devices on the same PCI device, which means the > attributes available for writing udev rules are

[PATCH v2] media: s5h14*.h: fix typos for CONTINUOUS

2018-03-06 Thread Mauro Carvalho Chehab
There is a typo at the several s5h14*.h headers: continuous were spelled incorrectly. Fix it with this script: for i in $(git grep -l S5H1409_MPEGTIMING_CONTINOUS_NONINVERTING_CLOCK); do sed

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
On Tue, Mar 06, 2018 at 06:52:16PM +0900, Tomasz Figa wrote: > On Tue, Mar 6, 2018 at 6:46 PM, Sakari Ailus > wrote: > > On Tue, Mar 06, 2018 at 06:28:43PM +0900, Tomasz Figa wrote: > >> On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus > >>

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Tomasz Figa
On Tue, Mar 6, 2018 at 6:46 PM, Sakari Ailus wrote: > On Tue, Mar 06, 2018 at 06:28:43PM +0900, Tomasz Figa wrote: >> On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus >> wrote: >> > On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
On Tue, Mar 06, 2018 at 06:28:43PM +0900, Tomasz Figa wrote: > On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus > wrote: > > On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa wrote: > >> On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus > >>

Re: [PATCH 0/7] media: sun6i: Various fixes and improvements

2018-03-06 Thread Maxime Ripard
On Mon, Mar 05, 2018 at 06:35:35PM +0800, Yong wrote: > > Hi Yong, > > > > Here are a bunch of patches I came up with after testing your last > > (v8) version of the CSI patches. > > > > There's some improvements (patches 1 and 7) and fixes for > > regressions found in the v8 compared to the v7

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Tomasz Figa
On Tue, Mar 6, 2018 at 6:18 PM, Sakari Ailus wrote: > On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa wrote: >> On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus >> wrote: >> > Hi Tomasz and Andy, >> > >> > On Sat, Mar 03, 2018 at

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
On Tue, Mar 06, 2018 at 05:51:36PM +0900, Tomasz Figa wrote: > On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus > wrote: > > Hi Tomasz and Andy, > > > > On Sat, Mar 03, 2018 at 12:43:59AM +0900, Tomasz Figa wrote: > > ... > >> > +static int imx258_set_ctrl(struct

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Tomasz Figa
On Tue, Mar 6, 2018 at 5:40 PM, Sakari Ailus wrote: > Hi Tomasz and Andy, > > On Sat, Mar 03, 2018 at 12:43:59AM +0900, Tomasz Figa wrote: > ... >> > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) >> > +{ >> > + struct imx258 *imx258 = >> > +

Re: [PATCH v6] media: imx258: Add imx258 camera sensor driver

2018-03-06 Thread Sakari Ailus
Hi Tomasz and Andy, On Sat, Mar 03, 2018 at 12:43:59AM +0900, Tomasz Figa wrote: ... > > +static int imx258_set_ctrl(struct v4l2_ctrl *ctrl) > > +{ > > + struct imx258 *imx258 = > > + container_of(ctrl->handler, struct imx258, ctrl_handler); > > + struct i2c_client