cron job: media_tree daily build: ERRORS

2018-05-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 12 05:00:12 CEST 2018 media-tree git hash:2a5f2705c97625aa1a4e1dd4d584eaa05392e060 media_build

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Jasmin, On 2018-05-11 16:43, Jasmin J. wrote: > Hello Brad! > > THX for this clarification! > > So you tried already to fix the config_compat script and I agree with you that > it is difficult for you because of the various Kernels and distributions you > have to maintain. > > Then your

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Jasmin J.
Hello Brad! THX for this clarification! So you tried already to fix the config_compat script and I agree with you that it is difficult for you because of the various Kernels and distributions you have to maintain. Then your workaround is indeed a possibility to use media-build to build your

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Jasmin, On 2018-05-11 15:02, Jasmin J. wrote: > Hello Brad! > >> and which the media_build system does not pick up on for whatever >> reason. > Maybe it would be better to analyse why "make_config_compat.pl" selects > wrongly the compatibility code. I've found several reasons, but the one I

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Jasmin J.
Hello Brad! > and which the media_build system does not pick up on for whatever > reason. Maybe it would be better to analyse why "make_config_compat.pl" selects wrongly the compatibility code. > It seems there is quite often at least one backport I must disable, > and some target kernels

Re: i.MX6 IPU CSI analog video input on Ventana

2018-05-11 Thread Steve Longerbeam
On 05/10/2018 10:37 PM, Krzysztof Hałasa wrote: Steve Longerbeam writes: Second, the image format information I'm getting out of "ipu2_csi1 capture" device is: open("/dev/video6") ioctl(VIDIOC_S_FMT, {V4L2_BUF_TYPE_VIDEO_CAPTURE, fmt.pix={704x576,

[PATCH v2] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
config-mycompat.h is for use with kernels/distros whose maintainers have integrated various backports, which the media_build system does not detect for whatever reason. At that point there are options defined in config-compat.h, which enable backports in compat.h, but which already exist in the

[PATCH] zoran: move to staging in preparation for removal

2018-05-11 Thread Hans Verkuil
This driver hasn't been tested in a long, long time. The hardware is ancient and pretty much obsolete. This driver also needs to be converted to newer media frameworks (vb2!) but due to the lack of time and interest that is unlikely to happen. So this driver is a prime candidate for removal. If

Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'

2018-05-11 Thread Alan Cox
On Fri, 2018-05-11 at 17:09 +0200, Julia Lawall wrote: > > On Fri, 11 May 2018, Christophe JAILLET wrote: > > > The use of 'fail1' and 'fail2' is not correct. Reorder these calls > > to > > branch at the right place of the error handling path. > > Maybe it would be good to improve the names at

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Hans, On 2018-05-11 10:11, Hans Verkuil wrote: > On 05/11/18 17:08, Brad Love wrote: >> Hi Hans, >> >> >> On 2018-05-11 09:41, Hans Verkuil wrote: >>> Hi Brad, >>> >>> On 04/26/18 19:19, Brad Love wrote: config-mycompat.h is for overriding macros which are incorrectly enabled on

Re: [PATCH v2 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Sergei Shtylyov
Hello! On 05/11/2018 05:41 PM, Niklas Söderlund wrote: > When refactoring the Gen3 enablement series crop and compose handling > where broken. This went unnoticed but can result in writing out side the s/Where/Were/? > capture buffer. Fix this by restoring the crop and compose to reflect >

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Hans Verkuil
On 05/11/18 17:08, Brad Love wrote: > Hi Hans, > > > On 2018-05-11 09:41, Hans Verkuil wrote: >> Hi Brad, >> >> On 04/26/18 19:19, Brad Love wrote: >>> config-mycompat.h is for overriding macros which are incorrectly >>> enabled on certain kernels by the build system. The file should be >>> left

Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'

2018-05-11 Thread Julia Lawall
On Fri, 11 May 2018, Christophe JAILLET wrote: > The use of 'fail1' and 'fail2' is not correct. Reorder these calls to > branch at the right place of the error handling path. Maybe it would be good to improve the names at the same time? julia > > Signed-off-by: Christophe JAILLET

[GIT PULL FOR v4.18] Various fixes

2018-05-11 Thread Hans Verkuil
The following changes since commit 901b9dd5e31e8c58e30bf81ea4ab12641fb3ea76: media: update/fix my e-mail on some places (2018-05-10 07:27:15 -0400) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.18c for you to fetch changes up to

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Brad Love
Hi Hans, On 2018-05-11 09:41, Hans Verkuil wrote: > Hi Brad, > > On 04/26/18 19:19, Brad Love wrote: >> config-mycompat.h is for overriding macros which are incorrectly >> enabled on certain kernels by the build system. The file should be >> left empty, unless build errors are encountered for a

[PATCH 1/3] media: staging: atomisp: Return an error code in case of error in 'lm3554_probe()'

2018-05-11 Thread Christophe JAILLET
If 'v4l2_ctrl_handler_init()' fails, we go to the error handling path, do some clean-up and return err, which is known to be 0 (i.e. success). Axe the 'ret' variable and use 'err' directly in order to return the error code instead. Also remove the initialization of 'err' which was hiding this

[PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'

2018-05-11 Thread Christophe JAILLET
The use of 'fail1' and 'fail2' is not correct. Reorder these calls to branch at the right place of the error handling path. Signed-off-by: Christophe JAILLET --- drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 3/3] media: staging: atomisp: Fix usage of 'media_entity_cleanup()'

2018-05-11 Thread Christophe JAILLET
According to the doc, 'media_entity_cleanup()' must be called after unregistering the entity. All places I've check do it that way. So, move the call after 'v4l2_device_unregister_subdev()' as done elsewhere. Actually, this is not an issue, because 'media_entity_cleanup()' does nothing, but it is

[PATCH 0/3] media: staging: atomisp:

2018-05-11 Thread Christophe JAILLET
These 3 patches fixes (at least I hope) some issues found in or around 'lm3554_probe()'. Please review them carefully. I've only compile tested the changes and I propose them because they sound logical to me. The first one, return an error code instead of 0 if the call to an initialisation

[PATCH] lgdt330x.h: fix compiler warning

2018-05-11 Thread Hans Verkuil
Add missing 'inline' to fix this compiler warning: In file included from drivers/media/common/b2c2/flexcop-fe-tuner.c:21:0: drivers/media/dvb-frontends/lgdt330x.h:61:22: warning: 'lgdt330x_attach' defined but not used [-Wunused-function] struct dvb_frontend *lgdt330x_attach(const struct

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-11 Thread jacopo mondi
Hi Hans, On Fri, May 11, 2018 at 12:28:55PM +0200, Hans Verkuil wrote: > On 05/11/18 11:59, Jacopo Mondi wrote: > > Since commit (015060cb "media: rcar-vin: enable field toggle after a set > > number of lines for Gen3) the VIN generates an internal field signal > > toggle after a fixed number of

[PATCH v2 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-11 Thread Niklas Söderlund
The offending commit was an attempt to fix the issue of writing outside the capture buffer for VIN Gen3. Unfortunately it only fixed the symptom of the problem to such a degree I could no longer reproduce it. Revert the offending commit before a proper fix can be added in a follow-up patch. This

[PATCH v2 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Niklas Söderlund
When refactoring the Gen3 enablement series crop and compose handling where broken. This went unnoticed but can result in writing out side the capture buffer. Fix this by restoring the crop and compose to reflect the format dimensions as we have not yet enabled the scaler for Gen3. Fixes:

[PATCH v2 0/2] Fix potential buffer overrun root cause

2018-05-11 Thread Niklas Söderlund
Hi, Commit 015060cb7795eac3 ("media: rcar-vin: enable field toggle after a set number of lines for Gen3") was an attempt to fix the issue of writing outside the capture buffer for VIN Gen3. Unfortunately it only fixed a symptom of a problem to such a degree I could no longer reproduce it. Jacopo

Re: [PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-05-11 Thread Hans Verkuil
Hi Brad, On 04/26/18 19:19, Brad Love wrote: > config-mycompat.h is for overriding macros which are incorrectly > enabled on certain kernels by the build system. The file should be > left empty, unless build errors are encountered for a kernel. The > file is removed by distclean, therefore should

Re: [PATCH 1/1] cadence: csi2rx: Fix csi2rx_start error handling

2018-05-11 Thread Maxime Ripard
On Wed, May 09, 2018 at 11:31:30PM +0300, Sakari Ailus wrote: > The clocks enabled by csi2rx_start function are intended to be disabled in > an error path but there are two issues: > > 1) the loop condition is always true and > > 2) the first clock disabled is the the one enabling of which

Re: [PATCH 6/7] Fix frame vector wildcard file check

2018-05-11 Thread Hans Verkuil
On 04/26/18 19:19, Brad Love wrote: > This check was consistently failing on all systems tested. > The path to object directory is used here to explicitly override > CWD. The thought is, if frame_vector.c exists in the build > directory then the build system has determined it is required, > and

Re: [PATCH 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-11 Thread Hans Verkuil
On 05/11/18 16:15, Niklas Söderlund wrote: > This reverts commit 015060cb7795eac34454696cc9c9f8b76926a401. Why? The cover letter states the reason, but it also needs to be added here in the commit log. Regards, Hans > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 20

[PATCH] media: dvb_frontends: fix spelling mistake: "unexpcted" -> "unexpected"

2018-05-11 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dprintk message text Signed-off-by: Colin Ian King --- drivers/media/dvb-frontends/l64781.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Niklas Söderlund
When refactoring the Gen3 enablement series crop and compose handling where broken. This went unnoticed but can result in writing out side the capture buffer. Fix this by restoring the crop and compose to reflect the format dimensions as we have not yet enabled the scaler for Gen3. Fixes:

[PATCH 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-11 Thread Niklas Söderlund
This reverts commit 015060cb7795eac34454696cc9c9f8b76926a401. --- drivers/media/platform/rcar-vin/rcar-dma.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index

[PATCH 0/2] rcar-vin: Fix potential buffer overrun root cause

2018-05-11 Thread Niklas Söderlund
Hi, Commit 015060cb7795eac3 ("media: rcar-vin: enable field toggle after a set number of lines for Gen3") was an attempt to fix the issue of writing outside the capture buffer for VIN Gen3. Unfortunately it only fixed a symptom of a problem to such a degree I could no longer reproduce it.

[PATCH v2] media: i2c: adv748x: Fix pixel rate values

2018-05-11 Thread Niklas Söderlund
From: Laurent Pinchart The pixel rate, as reported by the V4L2_CID_PIXEL_RATE control, must include both horizontal and vertical blanking. Both the AFE and HDMI receiver program it incorrectly: - The HDMI receiver goes to the trouble of removing

Re: [PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Niklas Söderlund
Hi again, On 2018-05-11 13:10:37 +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote: > > The crop_scale routine uses the crop rectangle memebers to configure the > > VIN clipping rectangle. When crop is not configured all

Re: [PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work. On 2018-05-11 11:59:40 +0200, Jacopo Mondi wrote: > The crop_scale routine uses the crop rectangle memebers to configure the > VIN clipping rectangle. When crop is not configured all its fields are > 0s, and setting the clipping rectangle vertical and horizontal

Re: [PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your work! The comments here apply to both 2/5 and 3/5. On 2018-05-11 11:59:38 +0200, Jacopo Mondi wrote: > Add support for digital input subdevices to Gen-3 rcar-vin. > The Gen-3, media-controller compliant, version has so far only accepted > CSI-2 input subdevices.

Re: [PATCH 1/5] media: rcar-vin: Add support for R-Car R8A77995 SoC

2018-05-11 Thread Niklas Söderlund
Hi Jacopo, Thanks for your patch. On 2018-05-11 11:59:37 +0200, Jacopo Mondi wrote: > Add R-Car R8A77995 SoC to the rcar-vin supported ones. > > Signed-off-by: Jacopo Mondi I would move this to be the last patch in the series as a indication that capture on

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-11 Thread Hans Verkuil
On 05/11/18 11:59, Jacopo Mondi wrote: > Since commit (015060cb "media: rcar-vin: enable field toggle after a set > number of lines for Gen3) the VIN generates an internal field signal > toggle after a fixed number of received lines, and uses the internal > field signal to drive capture

Re: [PATCH v3 02/14] drivers: soc: sunxi: Add dedicated compatibles for the A13, A20 and A33

2018-05-11 Thread Maxime Ripard
On Thu, May 10, 2018 at 10:05:33PM -0700, Chen-Yu Tsai wrote: > On Mon, May 7, 2018 at 5:44 AM, Paul Kocialkowski > wrote: > > This introduces platform-specific compatibles for the A13, A20 and A33 > > SRAM driver. No particular adaptation for these platforms is

[PATCH 4/5] media: rcar-vin: Do not use crop if not configured

2018-05-11 Thread Jacopo Mondi
The crop_scale routine uses the crop rectangle memebers to configure the VIN clipping rectangle. When crop is not configured all its fields are 0s, and setting the clipping rectangle vertical and horizontal extensions to (0 - 1) causes the registers to be written with an incorrect 0x

[PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-11 Thread Jacopo Mondi
Since commit (015060cb "media: rcar-vin: enable field toggle after a set number of lines for Gen3) the VIN generates an internal field signal toggle after a fixed number of received lines, and uses the internal field signal to drive capture operations. When capturing from digital input, using FTEH

[PATCH 3/5] media: rcar-vin: [un]bind and link digital subdevice

2018-05-11 Thread Jacopo Mondi
Add support for binding and unbinding digital subdevices to rcar-vin. On 'complete' also create direct links between the VIN instance and the digital subdevice. Signed-off-by: Jacopo Mondi --- drivers/media/platform/rcar-vin/rcar-core.c | 133

[PATCH 0/5] rcar-vin: Add support for digital input on Gen3

2018-05-11 Thread Jacopo Mondi
Hello, this series add support for 'digital' input to the Gen3 version of rcar-vin driver. 'Digital' inputs (the terms comes from the existing Gen2 version of the driver) describe parallel video input sources connected to a VIN instance. So far, the Gen3-version of the driver (the

[PATCH 1/5] media: rcar-vin: Add support for R-Car R8A77995 SoC

2018-05-11 Thread Jacopo Mondi
Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi --- drivers/media/platform/rcar-vin/rcar-core.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c

[PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

2018-05-11 Thread Jacopo Mondi
Add support for digital input subdevices to Gen-3 rcar-vin. The Gen-3, media-controller compliant, version has so far only accepted CSI-2 input subdevices. Remove assumptions on the supported bus_type and accepted number of subdevices, and allow digital input connections on port@0. Signed-off-by:

[PATCH 3/3] media: lirc-func.rst: new ioctl LIRC_GET_REC_TIMEOUT is not in a separate file

2018-05-11 Thread Sean Young
This fixes the warning: Documentation/media/uapi/rc/lirc-func.rst:9: WARNING: toctree contains reference to nonexisting document 'media/uapi/rc/lirc-get-rec-timeout' The ioctl is documented in lirc-set-rec-timeout. Signed-off-by: Sean Young ---

[PATCH 1/3] media: mceusb: filter out bogus timing irdata of duration 0

2018-05-11 Thread Sean Young
A mceusb device has been observed producing invalid irdata. Proactively guard against this. Suggested-by: Matthias Reichl Signed-off-by: Sean Young --- drivers/media/rc/mceusb.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/rc/mceusb.c

[PATCH 2/3] media: mceusb: add missing break

2018-05-11 Thread Sean Young
Fallthrough is not intended here. Signed-off-by: Sean Young --- drivers/media/rc/mceusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 1ca49491abc8..4c0c8008872a 100644 --- a/drivers/media/rc/mceusb.c +++

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

2018-05-11 Thread Chris Wilson
Quoting Ezequiel Garcia (2018-05-09 21:14:49) > Change how dma_fence_add_callback() behaves, when the fence > has error-signaled by the time it is being add. After this commit, > dma_fence_add_callback() returns the fence error, if it > has error-signaled before dma_fence_add_callback() is called.

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

2018-05-11 Thread Chris Wilson
Quoting Ezequiel Garcia (2018-05-10 13:51:56) > On Wed, 2018-05-09 at 19:42 -0300, Gustavo Padovan wrote: > > Hi Ezequiel, > > > > On Wed, 2018-05-09 at 17:14 -0300, Ezequiel Garcia wrote: > > > Change how dma_fence_add_callback() behaves, when the fence > > > has error-signaled by the time it is

Re: i.MX6 IPU CSI analog video input on Ventana

2018-05-11 Thread Franz Melchior
Hey, * Krzysztof Hałasa, 2018-05-10 10:19: > I'm using analog PAL video in on GW53xx/54xx boards (through ADV7180 > chip and 8-bit parallel CSI input, with (presumably) BT.656). [...] > First, I can't find a way to change to PAL standard. *s_std() doesn't > propagate from "ipu2_csi1 capture"