Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Tomasz Figa
On Tue, Jul 31, 2018 at 12:54 PM Chen, Ping-chung wrote: > > Hi Tomasz, > > >-Original Message- > > +/* Get bayer order based on flip setting. */ static __u32 > > +imx208_get_format_code(struct imx208 *imx208) > > >Why not just "u32"? > > Its return value will be assigned to the variable

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Chen, Ping-chung
Hi Tomasz, >-Original Message- > +/* Get bayer order based on flip setting. */ static __u32 > +imx208_get_format_code(struct imx208 *imx208) >Why not just "u32"? Its return value will be assigned to the variable code which belongs to the structure v4l2_subdev_mbus_code_enum, and the

cron job: media_tree daily build: WARNINGS

2018-07-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jul 31 05:00:10 CEST 2018 media-tree git hash:1d06352e18ef502e30837cedfe618298816fb48c media_build

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Chen, Ping-chung
Hi Sakari, We will test the new flow on Atlas. If everything is fine we will merge the code into patch v3 or v4. Thanks, PC Chen -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Monday, July 30, 2018 6:39 PM To: Chen, Ping-chung Cc:

Re: [PATCH 06/22] [media] tvp5150: add FORMAT_TRY support for get/set selection handlers

2018-07-30 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 18:20:38 +0200 Marco Felsch escreveu: > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") > the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is > no way to try different selections. The patch adds a helper function to > select the

Re: [PATCH v3 0/5] Add BPF decoders to ir-keytable

2018-07-30 Thread Matthias Reichl
Hi Sean, On Sat, Jul 28, 2018 at 10:29:31AM +0100, Sean Young wrote: > Hi Hias, > > On Sat, Jul 21, 2018 at 08:13:27PM +0200, Matthias Reichl wrote: > > Hi Sean, > > > > thanks a lot, this is a really nice new feature! > > Thank you for testing it and finding all those issues, it has become

Re: [PATCH] media: rc: read out of bounds if bpf reports high protocol number

2018-07-30 Thread Matthias Reichl
Hi Sean, On Sat, Jul 28, 2018 at 10:11:15AM +0100, Sean Young wrote: > The repeat period is read from a static array. If a keydown event is > reported from bpf with a high protocol number, we read out of bounds. This > is unlikely to end up with a reasonable repeat period at the best of times, >

Re: [PATCH 19/22] [media] tvp5150: add input source selection of_graph support

2018-07-30 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 18:20:51 +0200 Marco Felsch escreveu: > The currrent driver layout had the following layout: >++ > +---+ |TVP5150 | > | Comp0 +--+ || > +---+ | | +-+ > +---+ | +--+ | Src | >

Re: [PATCH 18/22] partial revert of "[media] tvp5150: add HW input connectors support"

2018-07-30 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 18:20:50 +0200 Marco Felsch escreveu: > From: Javier Martinez Canillas > > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") > added input signals support for the tvp5150, but the approach was found > to be incorrect so the corresponding DT binding

Re: [PATCH 16/22] [media] tvp5150: add querystd

2018-07-30 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 18:20:48 +0200 Marco Felsch escreveu: > From: Philipp Zabel > > Add the querystd video_op and make it return V4L2_STD_UNKNOWN while the > TVP5150 is not locked to a signal. > > Signed-off-by: Philipp Zabel > Signed-off-by: Marco Felsch > --- >

Re: [PATCH 13/22] [media] tvp5150: disable output while signal not locked

2018-07-30 Thread Mauro Carvalho Chehab
Em Mon, 30 Jul 2018 15:00:58 -0300 Mauro Carvalho Chehab escreveu: > Em Thu, 28 Jun 2018 18:20:45 +0200 > Marco Felsch escreveu: > > > From: Philipp Zabel > > > > To avoid short frames on stream start, keep output pins at high impedance > > while we are not properly locked onto the input

Re: [PATCH 13/22] [media] tvp5150: disable output while signal not locked

2018-07-30 Thread Mauro Carvalho Chehab
Em Thu, 28 Jun 2018 18:20:45 +0200 Marco Felsch escreveu: > From: Philipp Zabel > > To avoid short frames on stream start, keep output pins at high impedance > while we are not properly locked onto the input signal. > > Signed-off-by: Philipp Zabel > Signed-off-by: Marco Felsch > --- >

Re: [PATCH] [media] dvb-frontends/tda18271c2dd: silence sparse fall through warning

2018-07-30 Thread Mauro Carvalho Chehab
Em Sun, 24 Jun 2018 15:42:50 +0200 Daniel Scheller escreveu: > From: Daniel Scheller > > Add a break statement in set_params() for the SYS_DVBT(2) case to silence > this sparse warning: > > drivers/media/dvb-frontends/tda18271c2dd.c:1144:3: warning: this > statement may fall through

Re: [PATCH 01/19] [media] dvb-frontends/mxl5xx: add break to case DVBS2 in get_frontend()

2018-07-30 Thread Mauro Carvalho Chehab
Em Sat, 23 Jun 2018 17:35:57 +0200 Daniel Scheller escreveu: > From: Daniel Scheller > > Fix one sparse warning: > > drivers/media/dvb-frontends/mxl5xx.c:731:3: warning: this statement may > fall through [-Wimplicit-fallthrough=] > > as seen in Hans' daily media_tree builds. > >

Re: [PATCH 1/1] i2c: Fix pm_runtime_get_if_in_use() usage in sensor drivers

2018-07-30 Thread Tomasz Figa
On Mon, Jul 30, 2018 at 9:12 PM Sakari Ailus wrote: > > pm_runtime_get_if_in_use() returns -EINVAL if runtime PM is disabled. This > should not be considered an error. Generally the driver has enabled > runtime PM already so getting this error due to runtime PM being disabled > will not happen. >

[PATCH 1/1] i2c: Fix pm_runtime_get_if_in_use() usage in sensor drivers

2018-07-30 Thread Sakari Ailus
pm_runtime_get_if_in_use() returns -EINVAL if runtime PM is disabled. This should not be considered an error. Generally the driver has enabled runtime PM already so getting this error due to runtime PM being disabled will not happen. Instead of checking for lesser or equal to zero, check for zero

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Tomasz Figa
On Mon, Jul 30, 2018 at 8:39 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote: > ... > > > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl) > > > +{ > > > + struct imx208 *imx208 = > > > + container_of(ctrl->handler,

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Sakari Ailus
Hi Tomasz, On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote: ... > > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl) > > +{ > > + struct imx208 *imx208 = > > + container_of(ctrl->handler, struct imx208, ctrl_handler); > > + struct i2c_client *client =

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Sakari Ailus
Hi Ping-chung, On Mon, Jul 30, 2018 at 05:26:39PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Ping-Chung Chen

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Tomasz Figa
Hi Ping-chung, On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > Please see my comments inline. [snip] >

[PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Ping-chung Chen
From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- since v1: -- Update the function media_entity_pads_init for upstreaming. -- Change the

Re: [PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

2018-07-30 Thread Sakari Ailus
On Mon, Jul 30, 2018 at 09:51:25AM +0200, jacopo mondi wrote: > Hi Sakari, > > On Mon, Jul 30, 2018 at 10:26:27AM +0300, Sakari Ailus wrote: > > While this isn't a bug, initialise the variable to quash the warning. > > > > Reported-by: Stephen Rothwell > > Signed-off-by: Sakari Ailus > > --- >

Re: [PATCH] media: i2c: fix warning in Aptina MT9V111

2018-07-30 Thread jacopo mondi
Hi Jasmin, On Sat, Jul 28, 2018 at 03:54:49PM +0200, Jasmin J. wrote: > From: Jasmin Jessich > > This fixes the "'idx' may be used uninitialized in this function" > warning. > > Cc: Jacopo Mondi > Signed-off-by: Jasmin Jessich Thanks for the patch Acked-by: Jacopo Mondi Thanks j > ---

Re: [PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

2018-07-30 Thread jacopo mondi
Hi Sakari, On Mon, Jul 30, 2018 at 10:26:27AM +0300, Sakari Ailus wrote: > While this isn't a bug, initialise the variable to quash the warning. > > Reported-by: Stephen Rothwell > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/mt9v111.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH 1/1] mt9v111: Fix compiler warning by initialising a variable

2018-07-30 Thread Sakari Ailus
While this isn't a bug, initialise the variable to quash the warning. Reported-by: Stephen Rothwell Signed-off-by: Sakari Ailus --- drivers/media/i2c/mt9v111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c index