cron job: media_tree daily build: OK

2018-09-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Sep 5 04:17:40 CEST 2018 media-tree git hash:d842a7cf938b6e0f8a1aa9f1aec0476c9a599310 media_build

[RFP] Automated testing on the media subsystem

2018-09-04 Thread Ezequiel Garcia
There is a lot of discussion going on around testing, so it's a good opportunity for us to talk about our current testing infrastructure. We are already doing a good job with v4l2-compliance. Can we do more? I expect this discussion can span 30-40 minutes. Regards, Ezequiel

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-04 Thread Loic Poulain
Hi Jacopo, > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), > -on ? 0 : BIT(5)); > - if (ret) > - return ret; > - ret = ov5640_write_reg(sensor, OV5640_REG_PAD_OUTPUT00, > - on ? 0x00 : 0x70);

Re: [RFCv2 PATCH 1/3] uapi/linux/media.h: add property support

2018-09-04 Thread Sakari Ailus
On Tue, Sep 04, 2018 at 06:43:20PM +0300, Sakari Ailus wrote: > media_v2_prop, called e.g. payload_length. I also think we should have the > size (and length) of the property in a specific unit, such as bytes, so the > parser does not have to know a given property type to determine it > correctly.

Re: [RFCv2 PATCH 1/3] uapi/linux/media.h: add property support

2018-09-04 Thread Sakari Ailus
Hi Hans, On Tue, Sep 04, 2018 at 03:50:33PM +0200, Hans Verkuil wrote: > On 09/04/18 15:01, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for the set. > > > > On Tue, Aug 07, 2018 at 12:28:45PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Add a new topology struct that

Re: [RFCv2 PATCH 1/3] uapi/linux/media.h: add property support

2018-09-04 Thread Hans Verkuil
On 09/04/18 15:01, Sakari Ailus wrote: > Hi Hans, > > Thanks for the set. > > On Tue, Aug 07, 2018 at 12:28:45PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add a new topology struct that includes properties. >> >> Signed-off-by: Hans Verkuil >> --- >> include/uapi/linux/media.h |

Re: [RFCv2 PATCH 1/3] uapi/linux/media.h: add property support

2018-09-04 Thread Sakari Ailus
Hi Hans, Thanks for the set. On Tue, Aug 07, 2018 at 12:28:45PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add a new topology struct that includes properties. > > Signed-off-by: Hans Verkuil > --- > include/uapi/linux/media.h | 40 ++ > 1 file

Re: [PATCHv4 09/10] media-request: EPERM -> EACCES/EBUSY

2018-09-04 Thread Hans Verkuil
On 09/04/18 10:21, Tomasz Figa wrote: > On Tue, Sep 4, 2018 at 4:59 PM Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> If requests are not supported by the driver, then return EACCES, not >> EPERM. >> >> If you attempt to mix queueing buffers directly and using requests, >> then EBUSY is

cron job: media_tree daily build: OK

2018-09-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 4 09:37:57 CEST 2018 media-tree git hash:d842a7cf938b6e0f8a1aa9f1aec0476c9a599310 media_build

Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-04 Thread Philipp Zabel
Hi Jacopo, thank you for the review! On Tue, 2018-09-04 at 10:04 +0200, jacopo mondi wrote: > Hi Philipp, > > On Fri, Aug 10, 2018 at 05:18:22PM +0200, Philipp Zabel wrote: [...] > > +static struct pxp_fmt formats[] = { > > + { > > + .fourcc = V4L2_PIX_FMT_XBGR32, > > +

Re: [PATCHv4 09/10] media-request: EPERM -> EACCES/EBUSY

2018-09-04 Thread Tomasz Figa
On Tue, Sep 4, 2018 at 4:59 PM Hans Verkuil wrote: > > From: Hans Verkuil > > If requests are not supported by the driver, then return EACCES, not > EPERM. > > If you attempt to mix queueing buffers directly and using requests, > then EBUSY is returned instead of EPERM: once a specific queueing

Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-04 Thread jacopo mondi
Hi Philipp, On Fri, Aug 10, 2018 at 05:18:22PM +0200, Philipp Zabel wrote: > Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) > version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. > > Since this driver only uses the legacy pipeline, it should be reasonably >

[PATCHv4 00/10] Post-v18: Request API updates

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil Hi all, This patch series sits on top of the request_api topic branch in the media_tree. It makes some final (?) changes as discussed in: https://www.mail-archive.com/linux-media@vger.kernel.org/msg134419.html and: https://www.spinics.net/lists/linux-media/msg138596.html

[PATCHv4 02/10] v4l2-ctrls: return -EACCES if request wasn't completed

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil For now (this might be relaxed in the future) we do not allow getting controls from a request that isn't completed. In that case we return -EACCES. Update the documentation accordingly. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa ---

[PATCHv4 05/10] vb2: set reqbufs/create_bufs capabilities

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil Set the capabilities field of v4l2_requestbuffers and v4l2_create_buffers. The various mapping modes were easy, but for signaling the request capability a new 'supports_requests' bitfield was added to videobuf2-core.h (and set in vim2m and vivid). Drivers have to set this

[PATCHv4 07/10] v4l2-ctrls: use media_request_(un)lock_for_access

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil When getting control values from a completed request, we have to protect the request against being re-inited when it is being accessed by calling media_request_(un)lock_for_access. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa ---

[PATCHv4 09/10] media-request: EPERM -> EACCES/EBUSY

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil If requests are not supported by the driver, then return EACCES, not EPERM. If you attempt to mix queueing buffers directly and using requests, then EBUSY is returned instead of EPERM: once a specific queueing mode has been chosen the queue is 'busy' if you attempt the other

[PATCHv4 08/10] v4l2-ctrls: improve media_request_(un)lock_for_update

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil The request reference count was decreased again once a reference to the request object was taken. Postpone this until we finished using the object. In theory I think it is possible that the request_fd can be closed by the application from another thread. In that case when

[PATCHv4 04/10] videodev2.h: add new capabilities for buffer types

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil VIDIOC_REQBUFS and VIDIOC_CREATE_BUFFERS will return capabilities telling userspace what the given buffer type is capable of. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa --- .../media/uapi/v4l/vidioc-create-bufs.rst | 14 ++-

[PATCHv4 10/10] media-request: update documentation

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil Various clarifications and readability improvements based on Laurent Pinchart's review of the documentation. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa --- .../uapi/mediactl/media-ioc-request-alloc.rst | 3 +- .../uapi/mediactl/media-request-ioc-queue.rst | 7

[PATCHv4 03/10] buffer.rst: only set V4L2_BUF_FLAG_REQUEST_FD for QBUF

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil Document that V4L2_BUF_FLAG_REQUEST_FD should only be used with VIDIOC_QBUF and cleared otherwise. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa --- Documentation/media/uapi/v4l/buffer.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCHv4 06/10] media-request: add media_request_(un)lock_for_access

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil Add helper functions to prevent a completed request from being re-inited while it is being accessed. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa --- drivers/media/media-request.c | 10 +++ include/media/media-request.h | 56 +++

[PATCHv4 01/10] media-request: return -EINVAL for invalid request_fds

2018-09-04 Thread Hans Verkuil
From: Hans Verkuil Instead of returning -ENOENT when a request_fd was not found (VIDIOC_QBUF and VIDIOC_G/S/TRY_EXT_CTRLS), we now return -EINVAL. This is in line with what we do when invalid dmabuf fds are passed to e.g. VIDIOC_QBUF. Also document that EINVAL is returned for invalid m.fd

Re: cron job: media_tree daily build: ERRORS

2018-09-04 Thread Hans Verkuil
Hi Jasmin, On 09/04/2018 08:33 AM, Hans Verkuil wrote: > This message is generated daily by a cron job that builds media_tree for > the kernels and architectures in the list below. > > Results of the daily build of media_tree: Thank you for all your work, it looks much better now. It seems a

cron job: media_tree daily build: ERRORS

2018-09-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 4 04:00:14 CEST 2018 media-tree git hash:d842a7cf938b6e0f8a1aa9f1aec0476c9a599310 media_build