On Mon, Jun 25, 2018 at 11:02 AM, Sakari Ailus
wrote:
> Hi Alan,
> On Mon, Jun 25, 2018 at 03:29:41PM +0800, alanx.chi...@intel.com wrote:
Agreed on all Sakari's comments against the series.
--
With Best Regards,
Andy Shevchenko
tainers (at least Mauro).
--
With Best Regards,
Andy Shevchenko
atic struct pci_driver pt1_driver = {
> .probe = pt1_probe,
> .remove = pt1_remove,
> .id_table = pt1_id_table,
> -#if CONFIG_PM_SLEEP
> +#ifdef CONFIG_PM_SLEEP
> .driver.pm = _pm_ops,
> #endif
> };
> --
> 2.17.0
>
--
With Best Regards,
Andy Shevchenko
ax as pt1_init_frontends() does.
> + is_sat = !strncmp(cl->name, TC90522_I2C_DEV_SAT,
> + strlen(TC90522_I2C_DEV_SAT));
In this case I don't see a point to use strNcmp(). Plain strcmp() would work.
--
With Best Regards,
Andy Shevchenko
t;height;
> }
>
> - if (!atomisp_subdev_get_rect(sd, cfg, which, pad, target))
> + p = atomisp_subdev_get_rect(sd, cfg, which, pad, target);
> + if (!p)
> return -EINVAL;
> - *r = *atomisp_subdev_get_rect(sd, cfg, which, pad, target);
> +
sony_pic_camera_command(int command, u8 value);
> +#else
> +static inline int sony_pic_camera_command(int command, u8 value) { return 0;
> };
> +#endif
>
> #endif /* __KERNEL__ */
--
With Best Regards,
Andy Shevchenko
> + *wdata = be32_to_cpu(*(__be32 *)[2]);
For x86 it is okay, though in general it should use get_unaligned().
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
Could you contact the original developers?
>> > The answer is interesting, but I have no idea.
>
>> It seems it will be included in the 4.16 release:
>
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg122619.html
>
>> Probably just a bit too late for 4.15.
>
>> Frederic
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
With Best Regards,
Andy Shevchenko
+be used
What DT stands for?
--
With Best Regards,
Andy Shevchenko
re:
linux/cfag12864b.h
linux/ks0108.h
misc/charlcd.h
Another possibility to get rid of them under include/ by (re)moving to
drivers/auxdisplay/.
--
With Best Regards,
Andy Shevchenko
ch shouldn't be done for working
driver.
--
With Best Regards,
Andy Shevchenko
t; Remove the OV8858 kconfig and files.
Fine with me. We can sort things out later (repository will have the
sources still in any case) when the driver itself shows signs of life.
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
On Fri, Jan 26, 2018 at 2:49 PM, LABBE Corentin <cla...@baylibre.com> wrote:
> On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote:
>> On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote:
>> > On Tue, Jan 23, 2018 at 4:37 PM, Corentin La
way, do you have hardware to test? This is *most* important reason
why to accept or decline a change to the driver.
--
With Best Regards,
Andy Shevchenko
data->rxring, data->rxdma);
> - dma_free_coherent(0,
> + dma_free_coherent(>pdev->dev,
> TSI108_TXRING_LEN * sizeof(tx_desc),
> data->txring, data->txdma);
>
> @@ -1576,6 +1579,7 @@ tsi108_init_one(struct platform_device *pdev)
> printk("tsi108_eth%d: probe...\n", pdev->id);
> data = netdev_priv(dev);
> data->dev = dev;
> + data->pdev = pdev;
>
>
> pr_debug("tsi108_eth%d:regs:phyresgs:phy:irq_num=0x%x:0x%x:0x%x:0x%x\n",
> pdev->id, einfo->regs, einfo->phyregs,
> --
> 2.14.2
>
--
With Best Regards,
Andy Shevchenko
On Sat, 2017-12-30 at 20:57 +, Alan Cox wrote:
> On Tue, 19 Dec 2017 22:37:01 +0200
> Andy Shevchenko <andriy.shevche...@linux.intel.com> wrote:
> > On Tue, 2017-12-19 at 14:00 +0200, Sakari Ailus wrote:
> > > > I am trying to get the cameras in a Lenovo
can't currently do much as my latest Intel Android tablet has
> died and it's getting hard to find more because I guess the rest of
> those
> made have also died.
I have MRD7 with some BIOS on it I even don't know if there is any newer
still available inside.
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
terrupts from it, but not much more at this point.
Seems you are ahead of everyone who is trying AtomISP till now.
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
On Sun, Dec 31, 2017 at 5:19 PM, Kristian Beilke <bei...@posteo.de> wrote:
> On 12/28/2017 05:03 PM, Andy Shevchenko wrote:
>> On Sat, 2017-12-23 at 01:31 +0100, Kristian Beilke wrote:
>>> On 12/21/2017 03:23 PM, Andy Shevchenko wrote:
>>>> On Thu, 2017-12-21 a
+Cc Hans.
On Thu, 2017-12-28 at 18:03 +0200, Andy Shevchenko wrote:
> On Sat, 2017-12-23 at 01:31 +0100, Kristian Beilke wrote:
> > On 12/21/2017 03:23 PM, Andy Shevchenko wrote:
I spend more time on investigating some additional stuff Sakari gave me, but no
result so far.
So, th
On Fri, 2017-12-29 at 14:10 +0100, Thomas Gleixner wrote:
> On Fri, 29 Dec 2017, Andy Shevchenko wrote:
>
> > On Thu, 2017-12-28 at 22:59 +0100, Thomas Gleixner wrote:
> > > On Thu, 28 Dec 2017, Thomas Gleixner wrote:
> > > > On Thu, 28 Dec 2017, Andy Shevchenk
On Thu, 2017-12-28 at 22:59 +0100, Thomas Gleixner wrote:
> On Thu, 28 Dec 2017, Thomas Gleixner wrote:
> > On Thu, 28 Dec 2017, Andy Shevchenko wrote:
> > > The result w/o above is (full log is available here
> > > https://pastebin.com
> > > /J5yaTbM9):
On Thu, 2017-12-28 at 21:18 +0100, Thomas Gleixner wrote:
> On Thu, 28 Dec 2017, Andy Shevchenko wrote:
> > On Thu, 2017-12-28 at 18:44 +0100, Thomas Gleixner wrote:
> > > On Thu, 28 Dec 2017, Andy Shevchenko wrote:
> > > > On Thu, 2017-12-28 at 18:2
On Thu, 2017-12-28 at 21:31 +0200, Andy Shevchenko wrote:
> Anything I missed?
Perhaps I could bisect, though it's not so trivial in this case, when I
have a little more time. I guess it might take up to ~16 steps. If you
can point to more narrow range, it would be great.
--
Andy Shevche
On Thu, 2017-12-28 at 18:44 +0100, Thomas Gleixner wrote:
> On Thu, 28 Dec 2017, Andy Shevchenko wrote:
> > On Thu, 2017-12-28 at 18:21 +0100, Thomas Gleixner wrote:
> > > > [ 85.167061] spurious APIC interrupt through vector ff on
> > > > C
> --- a/arch/x86/kernel/apic/x2apic_cluster.c
> +++ b/arch/x86/kernel/apic/x2apic_cluster.c
> @@ -184,7 +184,7 @@ static struct apic apic_x2apic_cluster _
> .apic_id_valid = x2apic_apic_id_valid,
> .apic_id_registered =
> x2apic_apic_id_registered,
>
> - .irq_delivery_mode = dest_LowestPrio,
> + .irq_delivery_mode = dest_Fixed,
> .irq_dest_mode = 1, /* logical */
>
> .disable_esr= 0,
>
>
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
On Thu, 2017-12-28 at 19:17 +0200, Andy Shevchenko wrote:
> Hi!
>
> Experimenting with AtomISP (yes, code is ugly and MSI handling rather
> hackish, though...).
>
> So, with v4.14 base:
See additional note below.
>
> [ 33.639224] atomisp-isp2 :00:03.0: Start st
tps://www.spinics.net/lists/linux-media/msg126250.html
>
> https://patchwork.linuxtv.org/project/linux-media/list/?submitter=Andy
> +Shevchenko=*
> <https://patchwork.linuxtv.org/project/linux-media/list/?submitter=And
> y+Shevchenko=*>
>
> as a result:
>
> [69.67
On Sat, 2017-12-23 at 01:31 +0100, Kristian Beilke wrote:
> On 12/21/2017 03:23 PM, Andy Shevchenko wrote:
> > On Thu, 2017-12-21 at 13:54 +0100, Kristian Beilke wrote:
> > > On Tue, Dec 19, 2017 at 10:37:01PM +0200, Andy Shevchenko wrote:
> > > > On Tue, 2017-12-1
On Thu, 2017-12-21 at 13:54 +0100, Kristian Beilke wrote:
> On Tue, Dec 19, 2017 at 10:37:01PM +0200, Andy Shevchenko wrote:
> > On Tue, 2017-12-19 at 14:00 +0200, Sakari Ailus wrote:
> > > Cc Alan and Andy.
> > >
> > > On Sat, Dec 16, 2017 at 04:50:04PM +0100,
On Wed, Dec 20, 2017 at 6:54 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
>> @@ -1147,10 +1145,8 @@ static int gc2235_probe(struct i2c_client *client)
>> if (ret)
>> gc2235_rem
There is no need to keep a reference to PCI root bridge.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_internal.h | 1 -
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8
2 files chan
In case devm_clk_get() call fails the previously requested GPIOs are
left requested.
Fix this by moving GPIO request code after devm_clk_get() call.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.
There is no need to export function which is only used once in
the same module where it's defined.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/include/linux/atomisp_gmin_platform.h | 1 -
.../staging/media/atomisp/platform/int
The traditional pattern is to use DMI matching table and provide a
corresponding driver_data in it.
Convert driver to use DMI matching table.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../platform/intel-mid/atomisp_gmin_platform.c | 109 +-
-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/include/linux/atomisp.h | 2 ++
drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c | 5 -
drivers/staging/media/atomisp/pci/atomisp2/atomisp_subdev.c | 2 ++
3 files changed, 8 insertions
MRD7 board has in particular
Base Board Information
Manufacturer: Intel Corp.
Product Name: TABLET
Version: MRD 7
Fix the DMI matching entry for it.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../staging
Driver fails to initialize due to insane settings in the
control init array.
Fix this by moving to sanity.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 10 +-
1 file changed, 5 insertions(+), 5 del
Since all drivers are solely requiring ACPI enumeration, there is no
need to additionally check for legacy platform data or ACPI handle.
Remove leftovers from the sensors and platform code.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomi
GPIO framework checks for NULL pointer when gpiod_set_value() is called.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/d
In a preparation of split PCI glue driver from core part, convert
the driver to use more generic struct device_driver.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 17 -
.../staging/media/a
I do not get a camera device.
> >
> > Am I missing some firmware or dependency?
See above.
> > Can I somehow help to improve
> > the driver?
Yes, definitely, but first of all we need to find at least one device
and corresponding firmware where it actually works.
For me it doesn't generate any interrupt (after huge hacking to make
that firmware loaded and settings / platform data applied).
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c
> index a319bf1e49de..ef5c16dfabfa 100644
Acked-by: Andy Shevchenko <andy.shevche...@gmail.com>
for PDx86 changes.
--
With Best Regards,
Andy Shevchenko
case of ov2680, we don't seem to use the timestamp at
> all, so I just remove it.
>
Yep,
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
> v2: use min_t() as suggested by Andy Shevchenko
> -
(u32)DELAY_MAX_PER_STEP_NS));
Since you are touching this, it might make sense to convert to
min_t(u32, ...)
...and locate lines something like:
ktime_t timeday = ns_to_ktime(min_t(u32,
param1,
param2));
>From my pov will make readability better.
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
There is no need to repeat what check_range() does for us, i.e. BITMASK
validation in v4l2_ctrl_new().
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/media/v4l2-core/v4l2-ctrls.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/media/v4l2-cor
Since i2c_unregister_device() became NULL-aware we may remove duplicate
NULL check.
Cc: Kieran Bingham <kieran.bing...@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Cc: linux-media@vger.kernel.org
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.co
Since i2c_unregister_device() became NULL-aware we may remove duplicate checks.
Cc: Lars-Peter Clausen <l...@metafoo.de>
Cc: Mauro Carvalho Chehab <mche...@kernel.org>
Cc: linux-media@vger.kernel.org
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers
On Wed, 2017-10-18 at 23:53 +0300, Sakari Ailus wrote:
> On Wed, Sep 27, 2017 at 09:24:55PM +0300, Andy Shevchenko wrote:
> > The driver has been submitted with a limitation to few platforms and
> > sensors which it does support. Even though two sensor drivers have
> > no
>
On Wed, Oct 11, 2017 at 5:01 PM, Tuukka Toivonen
<tuukka.toivo...@intel.com> wrote:
> On Wed, 2017-10-11 at 16:31 +0300, Andy Shevchenko wrote:
>> On Wed, Oct 11, 2017 at 10:29 AM, sakari.ai...@linux.intel.com
>> <sakari.ai...@linux.intel.com> wrote:
>> > On W
w much bits we need to shift divider to
get it less than counter.
I would consider to use something from log2.h.
Roughly like
if (!counter || divider < counter)
return 0;
return order_base_2(divider) - order_base_2(counter);
--
With Best Regards,
Andy Shevchenko
e (_CID, "INT5648") // _CID: Compatible ID
> Name (_SUB, "INTL") // _SUB: Subsystem ID
> Name (_DDN, "ov5648") // _DDN: DOS Device Name
> ...
>
> I was not able to properly test this patch on my Lenovo Miix 310 due
> to other
&
hat I have mentioned (converting to smbus calls and regulator
framework) would be a material for future changes.
Other than that, please, address the rest of comments and we will be fine.
You may also refer to my last patch series WRT atomisp driver where I
tried to address my own comments to the rest of the code.
--
With Best Regards,
Andy Shevchenko
device.
> +3. The driver is intended to drive the PCI exposed versions of the device.
> It will not detect those devices enumerated via ACPI as a field of the
> i915 GPU driver.
>
> -5. The driver supports only v2 of the IPU/Camera. It will not work with the
> +4. The driver supports only v2 of the IPU/Camera. It will not work with the
> versions of the hardware in other SoCs.
>
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
There is redundant callback which does nothing in upstreamed version of
the driver.
Remove it along with user call places.
Mostly done with help of coccinelle.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/gc
There is redundant callback which does nothing in upstreamed version of
the driver.
Remove it along with user call places.
Mostly done with help of coccinelle.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/gc
struct camera_af_platform_data and bound functions are not used anywhere.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../media/atomisp/include/linux/atomisp_platform.h | 6 --
.../platform/intel-mid/atomisp_gmin_platform.c | 22 --
2
depends on a && b && c@
identifier b.e, a.x;
declarer name module_exit;
declarer name module_i2c_driver;
@@
-module_exit(e);
+module_i2c_driver(x);
//
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/gc0310.c| 15 +-
Remove unused members along with dead code.
Mostly done with help of coccinelle.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/gc0310.c | 13 -
drivers/staging/media/atomisp/i2c/gc
This sensor is not used by any known ACPI-enabled platform
(and no kernel users for it so far).
Just remove it for good until we get a platform which actually uses it.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/Kconfig
-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/gc0310.h| 4
drivers/staging/media/atomisp/i2c/libmsrlisthelper.c | 4
drivers/staging/media/atomisp/i2c/lm3554.c
media/lm3642.h is not used anywhere. Moreover, there is a driver under
LEDs framework for very same IP which would be used anyway.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../staging/media/atomisp/include/media/lm3642.h | 153 -
1 file c
There are 3 declarations that are present in atomisp_platform.h and
atomisp_gmin_platform.h. Remove duplications from the latter.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/include/linux/atomisp_gmin_platform.h | 3 ---
1 file chan
this as an intermediate clean up. This part toughly related to
removal of unused sensor drivers in patches 1 and 2.
Patch series has been partially compile tested. It would be nice to see
someone with hardware to confirm it doesn't break anything.
Andy Shevchenko (13):
staging: atomisp: Remove IMX sensor
GPIO handling is done only in two modules, the rest do not need to
include linux/gpio.h header.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/gc0310.c| 1 -
drivers/staging/media/atomisp/i2c/gc2235.c| 1 -
drivers/s
Since most of the drivers are being used on ACPI enabled platforms
there is no need to keep legacy API support for them. Thus, switch
to ->probe_new() callback and remove orphaned code.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/at
gpiod_get() configures GPIO line at the time of successful request.
Thus, no need to do this explicitly.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../atomisp/platform/intel-mid/atomisp_gmin_platform.c | 14 ++
1 file changed, 2 insertions(
T, OV5648_SW_STREAM,
> + enable ? OV5648_START_STREAMING :
> + OV5648_STOP_STREAMING);
> +
> + mutex_unlock(>input_lock);
> +
> + return ret;
> +}
> +static int ov5648_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov5648_device *dev = to_ov5648_sensor(sd);
> + dev_dbg(>dev, "ov5648_remove...\n");
Noise, remove.
> +
> + dev->platform_data->csi_cfg(sd, 0);
> +
> + v4l2_device_unregister_subdev(sd);
> + media_entity_cleanup(>sd.entity);
> + v4l2_ctrl_handler_free(>ctrl_handler);
> + kfree(dev);
> +
> + return 0;
> +}
> +
> +static int ov5648_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
> +{
> + struct ov5648_device *dev;
> + size_t len = CAMERA_MODULE_ID_LEN * sizeof(char);
> + int ret;
> + void *pdata;
> + unsigned int i;
> +
> + dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> + if (!dev) {
> + dev_err(>dev, "out of memory\n");
> + return -ENOMEM;
> + }
> +
> + dev->camera_module = kzalloc(len, GFP_KERNEL);
> + if (!dev->camera_module) {
> + kfree(dev);
> + dev_err(>dev, "out of memory\n");
> + return -ENOMEM;
> + }
> +
> + mutex_init(>input_lock);
> +
> + dev->fmt_idx = 0;
> + //otp functions
Wrong style, noisy comment. Remove.
> + dev->current_otp.otp_en = 1;// enable otp functions
Ditto.
> + v4l2_i2c_subdev_init(&(dev->sd), client, _ops);
> +
> + if (gmin_get_config_var(>dev, "CameraModule",
> + dev->camera_module, )) {
> + kfree(dev->camera_module);
> + dev->camera_module = NULL;
> + dev_info(>dev, "Camera module id is
> missing\n");
> + }
> +
> + if (ACPI_COMPANION(>dev))
> + pdata = gmin_camera_platform_data(>sd,
> + ATOMISP_INPUT_FORMA
> T_RAW_10,
> + atomisp_bayer_order
> _bggr);
> + else
> + pdata = client->dev.platform_data;
What kind of platforms will use platform_data?
> +out_free:
> + v4l2_device_unregister_subdev(>sd);
Doesn't v4l2 have devm_*() helpers?
> + kfree(dev->camera_module);
> + kfree(dev);
Shouldn't those be devm_kzalloc() ?
> + return ret;
> +}
> +
> +static const struct acpi_device_id ov5648_acpi_match[] = {
> + {"XXOV5648"},
WTF is that?
> + {"INT5648"},
> + {},
> +};
> +MODULE_DEVICE_TABLE(acpi, ov5648_acpi_match);
> +
> +MODULE_DEVICE_TABLE(i2c, ov5648_id);
Where is the table?
> +static struct i2c_driver ov5648_driver = {
> + .driver = {
> + .owner = THIS_MODULE,
Redundant.
> + .name = OV5648_NAME,
> + .acpi_match_table = ACPI_PTR(ov5648_acpi_match),
> + },
> + .probe = ov5648_probe,
> + .remove = ov5648_remove,
> + .id_table = ov5648_id,
> +};
> +
> +static int init_ov5648(void)
> +{
> + return i2c_add_driver(_driver);
> +}
> +
> +static void exit_ov5648(void)
> +{
> +
> + i2c_del_driver(_driver);
> +}
> +
> +module_init(init_ov5648);
> +module_exit(exit_ov5648);
module_i2c_driver();
> +#ifndef __OV5648_H__
> +#define __OV5648_H__
+ empty line.
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include "../include/linux/atomisp_platform.h"
Why? Are they all needed for definitions below?
I'm pretty sure you may leave only couple out of them.
> +
> +#define OV5648_NAME "ov5648"
Why it's here?
> +static const struct i2c_device_id ov5648_id[] = {
> + {OV5648_NAME, 0},
> + {}
> +};
WTF?! It shouldn't be in the header!
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
On Wed, 2017-09-20 at 12:01 -0500, Pierre-Louis Bossart wrote:
>
> On 09/20/2017 04:12 AM, Andy Shevchenko wrote:
> > On Tue, 2017-09-19 at 15:45 -0500, Pierre-Louis Bossart wrote:
> > > The Atom ISP driver initializes and configures PMC clocks which
> > > are
>
nd without -D implied?)
Other than that - nice clean up!
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Tested-by: Carlo Caione <ca...@endlessm.com>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.
> com>
> ---
> dr
re.
Second, Devid, please answer to the following:
is it an official BIOS which is available in the wild?
If it's so, please, add a paragraph to the commit message explaining how do you
get this and point to the DSDT excerpt.
Put an answer to above question to the commit message as well.
--
Andy Shevchenko <andriy.shevche...@linux.intel.com>
Intel Finland Oy
There is a common for x86 IOSF MBI API. Move atomisp code to use it.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/pci/Kconfig | 1 +
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 20 +++-
.../media/atomi
intel_mid_soc_stepping() is not used anywhere.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/include/asm/intel_mid_pcihelpers.h | 1 -
.../media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c| 7 ---
2 files chan
In many files in the driver the intel-mid.h header inclusion is redundant.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/staging/media/atomisp/i2c/imx/drv201.c| 1 -
drivers/staging/media/atomisp/i2c/imx/dw9714.c
Since we switched to upstream IOSF MBI API the custom code become not in
use anymore.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 22 -
.../media/atomisp/pci/atomisp2/atomisp_internal.h | 1 -
.../media/a
Remove dead code. If someone needs it the P-Unit semaphore is handled by
I2C DesignWare driver (drivers/i2c/busses/i2c-designware-baytrail.c).
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 2 -
.../platform/int
intel_mid_msgbus_*_raw*() are not used anywhere.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 4 --
.../platform/intel-mid/intel_mid_pcihelpers.c | 58 --
2 files changed, 62 del
The d3_delay parameter is set by arch/x86/pci/intel_mid_pci.c and
drivers/pci/quirks.c.
No need to override that settings in unrelated driver.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
.../atomisp/include/asm/intel_mid_pcihelpers.h | 8 --
.../pl
On Sat, Jun 17, 2017 at 9:43 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote:
> On Sat, Jun 17, 2017 at 01:54:51AM +0300, Andy Shevchenko wrote:
>> On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi <yong@intel.com> wrote:
>> > +static void writes(void *mem,
235
> and the main part:
> http://elixir.free-electrons.com/linux/v4.11.6/source/drivers/base/power/runtime.c#L1027
>
> [2]
> http://elixir.free-electrons.com/linux/v4.11.6/source/Documentation/power/runtime_pm.txt#L128
--
With Best Regards,
Andy Shevchenko
v, "failed to set imgu power\n");
> + pm_runtime_put(dev);
I'm not sure it's a right thing to do.
How did you test runtime PM counters in this case?
> + return r;
> + }
--
With Best Regards,
Andy Shevchenko
writel(*(u32 *)mem, reg);
> + mem += 4;
> + reg += 4;
> + len -= 4;
> + }
> +}
Again, I just looked into patches and first what I see is reinventing the wheel.
memcpy_toio()
--
With Best Regards,
Andy Shevchenko
s function.
It's *highly* recommended you learn what we have under lib/ (and not
only there) in kernel bewfore submitting a new version.
--
With Best Regards,
Andy Shevchenko
at I can find.
Just a side note: it would be good to put it there. Hopefully the
firmware for IPUv3 is not going to be changed two times per day.
--
With Best Regards,
Andy Shevchenko
There is no need to split long string literals.
Join them back.
No functional change intended.
Signed-off-by: Andy Shevchenko <andy.shevche...@gmail.com>
---
drivers/media/i2c/as3645a.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/as3
letely silencing the missing warning for these actually is a good
> thing.
Perhaps removing all code related explicitly to Gmin is a right thing to do.
--
With Best Regards,
Andy Shevchenko
On Fri, Jan 6, 2017 at 11:43 AM, Nicolas Dichtel
<nicolas.dich...@6wind.com> wrote:
> This header file is exported, thus move it to uapi.
Just hint for the future:
-M (move)
-C (copy)
-D (delete) [though this is NOT for applying]
--
With Best Regards,
Andy Shevchenko
--
To unsubsc
The module is used only as a library for now. Remove module init and exit
routines to show this.
While here, remove FSF snail address and attach EXPORT_SYMBOL() macros to
corresponding functions.
Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
drivers/media
map through platform data
Why not unified device properties?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 20, 2015 at 2:30 PM, Peter Ujfalusi <peter.ujfal...@ti.com> wrote:
> On 11/20/2015 02:24 PM, Andy Shevchenko wrote:
>> On Fri, Nov 20, 2015 at 12:58 PM, Arnd Bergmann <a...@arndb.de> wrote:
>>> On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote:
>
On Wed, Nov 18, 2015 at 5:51 PM, Arnd Bergmann <a...@arndb.de> wrote:
> On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote:
>> >
>> > I assume that the sst-firmware.c case is a mistake, it should just use a
>> > plain DMA_SLAVE and not DMA_MEMCPY.
>
torm which does nothing useful
(IIRC Russel's opinion).
On the other hand there are a lot of drivers that are used on the set
of platforms starting from legacy and abandoned ones (like AVR32) to
relatively new and newest.
And I'm not a fan of those thousands of API calls either.
--
With Bes
sure how valid are these...
>
> I just had a look myself. carma has been removed fortunately in linux-next,
> so we don't have to worry about that any more.
>
> I assume that the sst-firmware.c case is a mistake, it should just use a
> plain DMA_SLAVE and not DMA_MEMCPY.
Other way around.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
think you may just incorporate that patch into your series.
--
Andy Shevchenko andriy.shevche...@intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
-dereference
Author: Andy Shevchenko andy.shevche...@gmail.com
Date:Tue Jan 6 22:53:37 2015 -0300
We have to check pointer for NULL and then dereference it.
Sorry, seems I forgot to write that it is non-needed fix.
Regarding to the current poll_wait() implementation and that fact that
wait_poll
)
+
+#define LM3642_NAME lm3642
+#define LM3642_I2C_ADDR (0x63)
+
+#define LM3648_NAME lm3648
+#define LM3648_I2C_ADDR (0x63)
+
+#define SINGLE_STRING_FLASH_NAME ti_ss_flash
+
+#endif /* __TI_SS_FLASH_H__ */
--
Andy Shevchenko andriy.shevche...@intel.com
Intel Finland Oy
reported this.
Regards
Guennadi
On Wed, 7 Jan 2015, Andy Shevchenko wrote:
We have to check the pointer before dereferencing it.
Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com
---
drivers/media/platform/soc_camera/soc_camera.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
On Wed, Jan 7, 2015 at 10:05 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
On Wed, Jan 7, 2015 at 9:44 PM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
Hi Andy,
Thanks for the patch. Will queue for the next pull request.
If you didn't do that please wait. It seems it has one
We have to check pointer for NULL and then dereference it.
Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com
---
drivers/media/rc/lirc_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index 1e0545a
We have to check the pointer before dereferencing it.
Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com
---
drivers/media/platform/soc_camera/soc_camera.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media
1 - 100 of 218 matches
Mail list logo
