Re: [PATCH v11 3/4] dt-bindings: media: Add Cadence MIPI-CSI2 TX Device Tree bindings

Acked-by: Benoit Parrot <bpar...@ti.com> Maxime Ripard <maxime.rip...@bootlin.com> wrote on Tue [2018-Apr-24 14:26:59 +0200]: > The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4 > video streams and can output on up to 4 CSI-2 lanes, depending

Re: [PATCH v11 4/4] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

Acked-by: Benoit Parrot <bpar...@ti.com> Maxime Ripard <maxime.rip...@bootlin.com> wrote on Tue [2018-Apr-24 14:27:00 +0200]: > The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used > as a bridge between pixel interfaces and a CSI-2 bus. > &g

Re: [PATCH v11 2/4] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

PI > + select V4L2_FWNODE > + help > + Support for the Cadence MIPI CSI2 Receiver controller. > + > + To compile this driver as a module, choose M here: the module will be > + called cdns-csi2rx. > + > +endif > diff --git a/drivers/media/platform/c

Re: [PATCH v5 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

Maxime, Thanks you for the patch, Maxime Ripard wrote on Thu [2018-Mar-01 12:30:49 +0100]: > The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used > as a bridge between pixel interfaces and a CSI-2 bus. > > It supports operating with an internal

Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Maxime, Thank you for the patch. Maxime Ripard wrote on Thu [2018-Feb-15 14:33:35 +0100]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

Maxime, Thank you for the patch. Maxime Ripard wrote on Fri [2018-Jan-19 09:15:47 +0100]: > The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used > as a bridge between pixel interfaces and a CSI-2 bus. > > It supports operating with an

Re: [PATCH v5 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Maxime, Thank you for the patch. Maxime Ripard wrote on Fri [2018-Jan-19 09:13:57 +0100]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

For am437x/am437x-vpfe.c & ti-vpe/cal.c Acked-by: Benoit Parrot <bpar...@ti.com> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote on Mon [2017-Dec-18 17:53:57 -0200]: > The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one > struct to be filled

Re: [Patch 4/6] dt-bindings: media: ti-vpe: Document VPE driver

Rob Herring <r...@kernel.org> wrote on Tue [2017-Oct-17 16:00:51 -0500]: > On Thu, Oct 12, 2017 at 02:27:17PM -0500, Benoit Parrot wrote: > > Device Tree bindings for the Video Processing Engine (VPE) driver. > > > > Signed-off-by: Benoit Parrot <bpar...@ti.c

Re: [Patch 5/6] ARM: DRA7: hwmod: Add VPE nodes

Tony Lindgren <t...@atomide.com> wrote on Fri [2017-Oct-13 10:05:13 -0700]: > * Benoit Parrot <bpar...@ti.com> [171012 12:28]: > > +static struct omap_hwmod_class_sysconfig dra7xx_vpe_sysc = { > > + .sysc_offs = 0x0010, > > + .sysc_flags = (SYSC_H

Re: [Patch 3/6] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only

Tony Lindgren <t...@atomide.com> wrote on Fri [2017-Oct-13 10:01:13 -0700]: > * Benoit Parrot <bpar...@ti.com> [171012 12:29]: > > HWSUP on this domain is only working when VIP1 probes. > > If only VIP2 on DRA74x or CAL on DRA72x probes the domain does > > not

Re: [Patch 2/6] ARM: DRA7: hwmod: Add CAL nodes

Tony Lindgren <t...@atomide.com> wrote on Fri [2017-Oct-13 09:56:54 -0700]: > * Benoit Parrot <bpar...@ti.com> [171012 12:28]: > > This patch adds the required hwmod nodes to support the Camera > > Adaptation Layer (CAL) for the DRA72 family of devices.

Re: [Patch 1/6] ARM: dts: DRA72: Add CAL dtsi node

Tony Lindgren <t...@atomide.com> wrote on Fri [2017-Oct-13 09:54:09 -0700]: > * Benoit Parrot <bpar...@ti.com> [171012 12:29]: > > This patch adds the required dtsi node to support the Camera > > Adaptation Layer (CAL) for the DRA72 family of devices. > > >

Re: [ANN] Agenda (v1) for the media mini-summit on Friday Oct 27 in Prague

Hans, Just to confirm that I will be attending the media mini-summit. Regards, Benoit Hans Verkuil wrote on Fri [2017-Oct-13 10:02:53 +0200]: > Hi all, > > We are organizing a media mini-summit on Friday October 27 in Prague, > co-located > with the ELCE conference: > >

[Patch 4/6] dt-bindings: media: ti-vpe: Document VPE driver

Device Tree bindings for the Video Processing Engine (VPE) driver. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- Documentation/devicetree/bindings/media/ti-vpe.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/me

[Patch 0/6] ARM: dts/hwmod: Add CAL and VPE nodes

This patch series adds the needed HWMOD and DTSI nodes for the CAL and VPE modules. We also document the VPE DT bindings. Benoit Parrot (6): ARM: dts: DRA72: Add CAL dtsi node ARM: DRA7: hwmod: Add CAL nodes ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only dt-bindings: media: ti-vpe

[Patch 2/6] ARM: DRA7: hwmod: Add CAL nodes

not support standby mode per se hwmod would not enabled the functional/interface clock if module is not a master. Hence the SWSUP mode flags ifor SIDLE ans MSTANDBY are also enabled. This ensure that i/f clocks are available when CAL is enabled. Signed-off-by: Benoit Parrot <bpar...@ti.com> ---

[Patch 6/6] ARM: dts: dra7: Add VPE dtsi node

Add the necessary node and configuration data for the VPE (Video Processing Engine) hardware block on DRA7x. The corresponding driver for this entry is in drivers/media/platform/ti-vpe/vpe.c. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- arch/arm/boot/dts/dra7.dts

[Patch 1/6] ARM: dts: DRA72: Add CAL dtsi node

This patch adds the required dtsi node to support the Camera Adaptation Layer (CAL) for the DRA72 family of devices. - Added CAL entry in dra72x.dtsi. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- arch/arm/boot/dts/dra72x.dtsi | 31 +++ 1 file chang

[Patch 3/6] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only

HWSUP on this domain is only working when VIP1 probes. If only VIP2 on DRA74x or CAL on DRA72x probes the domain does not get enabled. This might indicates an issue in the HW Auto state-machine for this domain. Work around is to set the CAM domain to use SWSUP only. Signed-off-by: Benoit Parrot

[Patch 5/6] ARM: DRA7: hwmod: Add VPE nodes

were set to reflect this fact and make sure that both are software supervised (SWSUSP). Signed-off-by: Benoit Parrot <bpar...@ti.com> --- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/arch/arm/mach

Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

Hi Maxime, Maxime Ripard <maxime.rip...@free-electrons.com> wrote on Wed [2017-Oct-11 13:55:44 +0200]: > Hi Benoit, > > On Fri, Sep 29, 2017 at 06:21:25PM +, Benoit Parrot wrote: > > > +struct csi2tx_priv { > > > + struct device

Re: [PATCH v4 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Hi Maxime, Maxime Ripard <maxime.rip...@free-electrons.com> wrote on Wed [2017-Oct-11 11:24:09 +0200]: > Hi Benoit, > > On Fri, Sep 29, 2017 at 05:27:09PM +, Benoit Parrot wrote: > > > +static int csi2rx_get_resources(struct csi2rx_priv *csi2rx, > > >

Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

Maxime, Thank you for the patch. Maxime Ripard wrote on Fri [2017-Sep-22 13:47:03 +0200]: > The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used > as a bridge between pixel interfaces and a CSI-2 bus. > > It supports operating with an

Re: [PATCH v4 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Maxime Ripard wrote on Fri [2017-Sep-22 12:08:23 +0200]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes,

Re: [PATCH v3 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Benoit Parrot <bpar...@ti.com> wrote on Tue [2017-Sep-12 13:23:39 -0500]: > > +static int csi2rx_start(struct csi2rx_priv *csi2rx) > > +{ > > + unsigned int i; > > + u32 reg; > > + int ret; > > + > > + /* > > +

Re: [PATCH v3 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Maxime, Thanks for the patch. Maxime Ripard wrote on Mon [2017-Sep-04 15:03:35 +0200]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/cdns-csi2rx.txt > Acked-by: Benoit Parrot <bpar...@ti.com>

Re: [PATCH v2 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

Maxime Ripard wrote on Thu [2017-Jul-20 11:23:02 +0200]: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes,

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

sek...@ti.com> > --- > drivers/media/platform/davinci/vpif_capture.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > Acked-by: Benoit Parrot <bpar...@ti.com>

Re: [Patch 0/2] media: ti-vpe: allow user specified stride

Hans, Mauro, Ping. Regards, Benoit Tomi Valkeinen <tomi.valkei...@ti.com> wrote on Fri [2017-Feb-17 11:45:41 +0200]: > On 13/02/17 15:06, Benoit Parrot wrote: > > This patch series enables user specified buffer stride to be used > > instead of always forcing the stride

Re: [PATCH v1.1 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

For: ov2569.c, am437x/am437x-vpfe.c and ti-cal/cal.c: Acked-by: Benoit Parrot <bpar...@ti.com> Sakari Ailus <sakari.ai...@linux.intel.com> wrote on Tue [2017-Feb-14 09:12:32 +0200]: > Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. > > Existing

Re: [Patch 2/2] media: ti-vpe: vpe: allow use of user specified stride

Tomi Valkeinen <tomi.valkei...@ti.com> wrote on Wed [2017-Feb-15 13:22:42 +0200]: > Hi, > > On 13/02/17 15:06, Benoit Parrot wrote: > > Bytesperline/stride was always overwritten by VPE to the most > > adequate value based on needed alignment. > > > > Ho

Re: [PATCH 5/8] v4l: Switch from V4L2 OF not V4L2 fwnode API

Sakari Ailus wrote on Mon [2017-Feb-13 15:28:13 +0200]: > Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs. > > Existing OF matching continues to be supported. omap3isp and smiapp > drivers are converted to fwnode matching as well. > >

[Patch 0/2] media: ti-vpe: allow user specified stride

This patch series enables user specified buffer stride to be used instead of always forcing the stride from the driver side. Benoit Parrot (2): media: ti-vpe: vpdma: add support for user specified stride media: ti-vpe: vpe: allow use of user specified stride drivers/media/platform/ti-vpe

[Patch 1/2] media: ti-vpe: vpdma: add support for user specified stride

This patch introduce the needed vpdma API changes to support user space specified stride instead of forcing a driver calculated one. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpdma.c | 14 -- drivers/media/platform/ti-vpe/vpdma.

[Patch 2/2] media: ti-vpe: vpe: allow use of user specified stride

the provided one when it is larger than the calculated one. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/pl

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

Laurent Pinchart wrote on Tue [2017-Feb-07 12:26:32 +0200]: > Hi Steve, > > On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote: > > On 02/06/2017 02:33 PM, Laurent Pinchart wrote: > > > On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote: > > >> On 02/05/2017

Re: [patch] [media] media: ti-vpe: vpdma: fix a timeout loop

Dan, Thanks for the patch. Acked-by: Benoit Parrot <bpar...@ti.com> Dan Carpenter <dan.carpen...@oracle.com> wrote on Sat [2016-Nov-26 00:28:34 +0300]: > The check assumes that we end on zero but actually we end on -1. Change > the post-op to a pre-op so that we do end on z

[Patch v2 01/35] media: ti-vpe: vpdma: Make vpdma library into its own module

The VPDMA (Video Port DMA) as found in devices such as DRA7xx is used for both the Video Processing Engine (VPE) and the Video Input Port (VIP). In preparation for this we need to turn vpdma into its own kernel module. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/pl

[Patch v2 08/35] media: ti-vpe: Increasing max buffer height and width

From: Harinarayan Bhatta <harinara...@ti.com> Increasing max buffer height and width to allow for padded buffers. Signed-off-by: Harinarayan Bhatta <harinara...@ti.com> Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com>

[Patch v2 00/35] media: ti-vpe: fixes and enhancements

line average de-interlacing for first 2 frames Benoit Parrot (16): media: ti-vpe: vpdma: Make vpdma library into its own module media: ti-vpe: vpdma: Add multi-instance and multi-client support media: ti-vpe: vpdma: Add helper to set a background color media: ti-vpe: vpdma: Fix bus error

[Patch v2 05/35] media: ti-vpe: Use line average de-interlacing for first 2 frames

motion based frames for a total of N frames. Signed-off-by: Archit Taneja <arc...@ti.com> Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 33 +++-- 1 file chan

[Patch v2 07/35] media: ti-vpe: Add support for SEQ_TB buffers

ndling source buffer lists. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 125 +--- 1 file change

[Patch v2 02/35] media: ti-vpe: vpdma: Add multi-instance and multi-client support

support for multi instances and multiple clients has been added to VPDMA. Needed modification to the existing helper functions were then reflected to VPE. Multi-clients registers offset have also been added in preparation. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <

[Patch v2 15/35] media: ti-vpe: vpe: configure line mode separately

lt;nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.

[Patch v2 13/35] media: ti-vpe: vpdma: Make list post atomic operation

of mutex as the list post is also called from interrupt context. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpdma.c | 4 drivers/media/pl

[Patch v2 03/35] media: ti-vpe: vpdma: Add helper to set a background color

Add a helper to set the background color during vpdma transfer. This is needed when VPDMA is generating 32 bits RGB format to have the Alpha channel set to an appropriate value. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- d

[Patch v2 04/35] media: ti-vpe: vpdma: Fix bus error when vpdma is writing a descriptor

On DRA7 since l3_noc event are being reported it was found that when the write descriptor was being written it was consistently causing bus error events. The write address was improperly programmed. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@

[Patch v2 10/35] media: ti-vpe: Free vpdma buffers in vpe_release

..@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c ind

[Patch v2 09/35] media: ti-vpe: vpe: Return NULL for invalid buffer type

crash. Return NULL when the passed type is invalid. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed, 1 insertion(+), 1

[Patch v2 19/35] media: ti-vpe: vpdma: allocate and maintain hwlist

easier to allocate one list per client and let it use it. This way, the list numbers need not be hard-coded into the driver. Add support for allocating hwlist and maintain them with a priv data. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com&

[Patch v2 06/35] media: ti-vpe: vpe: Do not perform job transaction atomically

..@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index ad838b8a98c4..9

[Patch v2 16/35] media: ti-vpe: vpe: Setup srcdst parameters in start_streaming

l would make sure that the context is re-initialized before it is being used by the driver. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe

[Patch v2 11/35] media: ti-vpe: vpdma: Add support for setting max width height

or max width and height. Make use of different max width & height sets for different of capture module (i.e. slices). Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/m

[Patch v2 22/35] media: ti-vpe: vpdma: RGB data type yield inverted data

The VPDMA RGB data type definition have been updated to match with Errata i839. But some of the ARGB definition appeared to be wrong in the document also. As they would yield RGBA instead. They have been corrected based on experimentation. Signed-off-by: Benoit Parrot <bpar...@ti.com>

[Patch v2 17/35] media: ti-vpe: vpe: Post next descriptor only for list complete IRQ

uffers even before DMA is complete and also schedule next descriptor list. Fix this by _actually_ handling the IRQ only when ListComplete IRQ occurs. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <h

[Patch v2 20/35] media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint

ti_vpe module currently does not get loaded automatically. Added MODULE_DEVICE_TABLE hint to the driver to assist. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>

[Patch v2 18/35] media: ti-vpe: vpe: Add RGB565 and RGB5551 support

r. Set the default color to make alpha component full when the dst format is of RGB color space. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/pl

[Patch v2 21/35] media: ti-vpe: vpdma: Corrected YUV422 data type label.

ent). It was decided to explicitly label them CR to remove any confusion. Bear in mind that the type label refer to the memory packed order (LSB - MSB). Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/p

[Patch v2 23/35] media: ti-vpe: sc: Fix incorrect optimization

ed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/sc.c | 9 - drivers/media/platform/ti-vpe/sc.h | 3 --- 2 files changed, 12 deletions(-) diff --git a/d

[Patch v2 27/35] media: ti-vpe: vpe: Fix line stride for output motion vector

y: Ravikumar Kattekola <r...@ti.com> Signed-off-by: Ravi Babu <ravib...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/me

[Patch v2 29/35] media: ti-vpe: Make scaler library into its own module

In preparation to add scaler support into VIP we need to turn sc.c into its own kernel module. Add support for multiple SC memory block as VIP contains 2 scaler instances. This is done by passing the resource name to sc_create() and modify the vpe invocation accordingly. Signed-off-by: Benoit

[Patch v2 25/35] media: ti-vpe: vpdma: Fix race condition for firmware loading

dma before hand so that the race condition is avoided. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpdma.c | 17 + drivers/media/platform/t

[Patch v2 12/35] media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs

array of channels for which abort_channel descriptors should be posted. It is driver's responsibility to post for all the channels or the channels which were used in the last context. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> Acke

[Patch v2 30/35] media: ti-vpe: scaler: Add debug support for multi-instance

Since there might be more then one instance it is better to show the base address when dumping registers to help with debugging. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/sc.c | 2 ++ 1 fil

[Patch v2 26/35] media: ti-vpe: vpdma: Use bidirectional cached buffers

n. When mapping/unmapping the buffer, driver has to take care of WriteBack and invalidation of the cache so that all the coherency is maintained from both directions. Use DMA_BIDIRECTIONAL to maintain coherency between CPU and VPDMA. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com>

[Patch v2 33/35] media: ti-vpe: Make colorspace converter library into its own module

In preparation to add colorspace conversion support to VIP, we need to turn csc.c into its own kernel module. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/Kconfig | 4 drivers/media/platform/ti-

[Patch v2 32/35] media: ti-vpe: vpdma: Add RAW8 and RAW16 data types

. RAW16 handles from 9 to 16 bits. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpdma.c | 23 +++ drivers/media/platform/ti-vpe/vpdma.h | 6 ++ 2 files changed, 29 insertions(+)

[Patch v2 35/35] media: ti-vpe: vpe: Add proper support single and multi-plane buffer

-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 58 ++--- 1 file changed, 48 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/pla

[Patch v2 31/35] media: ti-vpe: vpe: Make sure frame size dont exceed scaler capacity

otherwise the vb2 framework will issue kernel WARN messages. In this case we also give an error message. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/sc.h | 6 drivers/media/platform/ti-vp

[Patch v2 34/35] media: ti-vpe: csc: Add debug support for multi-instance

Since there might be more then one instance it is better to show the base address when dumping registers to help with debugging. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/csc.c | 2 ++ 1 fil

[Patch v2 28/35] media: ti-vpe: vpe: Enable DMABUF export

Allow VPE to be able to export DMA buffer. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media

[Patch v2 24/35] media: ti-vpe: vpe: Fix vb2 buffer cleanup

as upon aborting a conversion. Make sure every vb2 buffers is properly handled in all cases. Signed-off-by: Benoit Parrot <bpar...@ti.com> Acked-by: Hans Verkuil <hans.verk...@cisco.com> --- drivers/media/platform/ti-vpe/vpe.c | 62 +++-- 1 file changed, 6

[Patch v2 14/35] media: ti-vpe: vpdma: Clear IRQs for individual lists

From: Nikhil Devshatwar <nikhil...@ti.com> VPDMA IRQs are registered for multiple lists When clearing an IRQ for a list interrupt, all the IRQs for the individual lists are to be cleared separately. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <

Re: [Patch 05/35] media: ti-vpe: Use line average de-interlacing for first 2 frames

Hans Verkuil <hverk...@xs4all.nl> wrote on Mon [2016-Oct-17 16:14:35 +0200]: > On 09/28/2016 11:20 PM, Benoit Parrot wrote: > > From: Archit Taneja <arc...@ti.com> > > > > For n input fields, the VPE de-interlacer creates n - 2 progressive frames. > > Tha

Re: [Patch 00/35] media: ti-vpe: fixes and enhancements

Hans, Thank you for taking the time to review my patches. I'll update the patch set relating to your comments and submit a v2 shortly. Regards Benoit Hans Verkuil <hverk...@xs4all.nl> wrote on Mon [2016-Oct-17 16:35:01 +0200]: > On 09/28/2016 11:16 PM, Benoit Parrot wrote: > > Th

Re: [Patch 06/35] media: ti-vpe: vpe: Do not perform job transaction atomically

Hans Verkuil <hverk...@xs4all.nl> wrote on Mon [2016-Oct-17 16:17:15 +0200]: > On 09/28/2016 11:20 PM, Benoit Parrot wrote: > > From: Nikhil Devshatwar <nikhil...@ti.com> > > > > Current VPE driver does not start the job until all the buffers for > > a t

Re: [Patch 01/35] media: ti-vpe: vpdma: Make vpdma library into its own module

Hans, Thanks for the review. Hans Verkuil <hverk...@xs4all.nl> wrote on Mon [2016-Oct-17 16:08:55 +0200]: > On 09/28/2016 11:16 PM, Benoit Parrot wrote: > > The VPDMA (Video Port DMA) as found in devices such as DRA7xx is > > used for both the Video Processing Engine (VPE

Re: [PATCH 29/57] [media] ti-vpe: don't break long lines

Acked-by: Benoit Parrot <bpar...@ti.com> Mauro Carvalho Chehab <mche...@s-opensource.com> wrote on Fri [2016-Oct-14 17:20:17 -0300]: > Due to the 80-cols checkpatch warnings, several strings > were broken into multiple lines. This is not considered > a good practice anymor

[Patch 16/35] media: ti-vpe: vpe: Setup srcdst parameters in start_streaming

l would make sure that the context is re-initialized before it is being used by the driver. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 4 1 file changed, 4 insertions(+) diff --git

[Patch 10/35] media: ti-vpe: Free vpdma buffers in vpe_release

..@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index b66b55322dd4..17451237220c 100644 --- a/drivers/media/platf

[Patch 12/35] media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs

array of channels for which abort_channel descriptors should be posted. It is driver's responsibility to post for all the channels or the channels which were used in the last context. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com>

[Patch 15/35] media: ti-vpe: vpe: configure line mode separately

lt;nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 000cd

[Patch 20/35] media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint

ti_vpe module currently does not get loaded automatically. Added MODULE_DEVICE_TABLE hint to the driver to assist. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/ti-vpe/vp

[Patch 18/35] media: ti-vpe: vpe: Add RGB565 and RGB5551 support

r. Set the default color to make alpha component full when the dst format is of RGB color space. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 22 -- 1 file changed, 2

[Patch 17/35] media: ti-vpe: vpe: Post next descriptor only for list complete IRQ

uffers even before DMA is complete and also schedule next descriptor list. Fix this by _actually_ handling the IRQ only when ListComplete IRQ occurs. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.

[Patch 09/35] media: ti-vpe: vpe: Return NULL for invalid buffer type

crash. Return NULL when the passed type is invalid. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/ti-vp

[Patch 34/35] media: ti-vpe: csc: Add debug support for multi-instance

Since there might be more then one instance it is better to show the base address when dumping registers to help with debugging. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/csc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platf

[Patch 29/35] media: ti-vpe: Make scaler library into its own module

In preparation to add scaler support into VIP we need to turn sc.c into its own kernel module. Add support for multiple SC memory block as VIP contains 2 scaler instances. This is done by passing the resource name to sc_create() and modify the vpe invocation accordingly. Signed-off-by: Benoit

[Patch 33/35] media: ti-vpe: Make colorspace converter library into its own module

In preparation to add colorspace conversion support to VIP, we need to turn csc.c into its own kernel module. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/Kconfig | 4 drivers/media/platform/ti-vpe/Makefile | 4 +++- drivers/media/platform/ti-vpe

[Patch 30/35] media: ti-vpe: scaler: Add debug support for multi-instance

Since there might be more then one instance it is better to show the base address when dumping registers to help with debugging. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/sc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platf

[Patch 24/35] media: ti-vpe: vpe: Fix vb2 buffer cleanup

as upon aborting a conversion. Make sure every vb2 buffers is properly handled in all cases. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 62 +++-- 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/drivers

[Patch 28/35] media: ti-vpe: vpe: Enable DMABUF export

Allow VPE to be able to export DMA buffer. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index 3e1b8b1ccb7c..875da06acd67

[Patch 25/35] media: ti-vpe: vpdma: Fix race condition for firmware loading

dma before hand so that the race condition is avoided. Signed-off-by: Nikhil Devshatwar <nikhil...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpdma.c | 17 + drivers/media/platform/ti-vpe/vpdma.h | 2 +- drivers/media/platform/ti-vpe/

[Patch 27/35] media: ti-vpe: vpe: Fix line stride for output motion vector

y: Ravikumar Kattekola <r...@ti.com> Signed-off-by: Ravi Babu <ravib...@ti.com> Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/t

[Patch 32/35] media: ti-vpe: vpdma: Add RAW8 and RAW16 data types

. RAW16 handles from 9 to 16 bits. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpdma.c | 23 +++ drivers/media/platform/ti-vpe/vpdma.h | 6 ++ 2 files changed, 29 insertions(+) diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/d

[Patch 31/35] media: ti-vpe: vpe: Make sure frame size dont exceed scaler capacity

otherwise the vb2 framework will issue kernel WARN messages. In this case we also give an error message. Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/sc.h | 6 drivers/media/platform/ti-vpe/vpe.c | 71 - 2 files c

[Patch 35/35] media: ti-vpe: vpe: Add proper support single and multi-plane buffer

-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpe.c | 58 ++--- 1 file changed, 48 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c index ae5acb5f42b8..c3ff7df780a9

[Patch 21/35] media: ti-vpe: vpdma: Corrected YUV422 data type label.

ent). It was decided to explicitly label them CR to remove any confusion. Bear in mind that the type label refer to the memory packed order (LSB - MSB). Signed-off-by: Benoit Parrot <bpar...@ti.com> --- drivers/media/platform/ti-vpe/vpdma.c | 18 ++ drivers/media/platfor

  1   2   >