Re: [PATCH 1/4] soc: qcom: mdt_loader: Add check to make scm calls

2018-05-17 Thread Bjorn Andersson
On Thu 17 May 04:32 PDT 2018, Vikash Garodia wrote: > In order to invoke scm calls, ensure that the platform > has the required support to invoke the scm calls in > secure world. > > Signed-off-by: Vikash Garodia > --- > drivers/soc/qcom/mdt_loader.c | 21

Re: [PATCH 11/15] remoteproc: make device_type const

2017-08-24 Thread Bjorn Andersson
On Sat 19 Aug 01:22 PDT 2017, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Applied, thanks. Regards, Bjorn > --- >

Re: [PATCH] rpmsg: Solve circular dependencies involving RPMSG_VIRTIO

2017-06-27 Thread Bjorn Andersson
On Tue 27 Jun 12:08 PDT 2017, Suman Anna wrote: > Hi Bjorn, > > Thanks for the patch. > > On 06/27/2017 01:43 AM, Bjorn Andersson wrote: > > While it's very common to use RPMSG for communicating with firmware > > running on these remoteprocs there is no fun

[PATCH] rpmsg: Solve circular dependencies involving RPMSG_VIRTIO

2017-06-27 Thread Bjorn Andersson
Kconfig dependencies for Davinci and Keystone remoteproc drivers. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/media/platform/Kconfig | 2 +- drivers/remoteproc/Kconfig | 4 drivers/rpmsg/Kconfig | 20 +--- 3 files chang

Re: [PATCH v8 01/10] firmware: qcom_scm: Fix to allow COMPILE_TEST-ing

2017-05-02 Thread Bjorn Andersson
t;Cc" means that you really do expect Stephen and myself to say something - i.e. it's not the same as To and Cc in the email header. > Cc: Stephen Boyd <sb...@codeaurora.org> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Signed-off-by: Stanimir Varbanov <stanimir.va

Re: [PATCH v8 05/10] media: venus: adding core part and helper functions

2017-05-02 Thread Bjorn Andersson
On Tue 02 May 01:52 PDT 2017, Stanimir Varbanov wrote: > Hei Sakari, > > On 04/30/2017 01:21 AM, Sakari Ailus wrote: > > Hi, Stan!! > > > > On Fri, Apr 28, 2017 at 12:13:52PM +0300, Stanimir Varbanov wrote: > > ... > >> +int helper_get_bufreq(struct venus_inst *inst, u32 type, > >> +

Re: [PATCH v8 05/10] media: venus: adding core part and helper functions

2017-04-29 Thread Bjorn Andersson
On Fri 28 Apr 15:02 PDT 2017, Jordan Crouse wrote: > On Fri, Apr 28, 2017 at 12:13:52PM +0300, Stanimir Varbanov wrote: > > +int venus_boot(struct device *parent, struct device *fw_dev) > > +{ > > + const struct firmware *mdt; > > + phys_addr_t mem_phys; > > + ssize_t fw_size; > > +

Re: [PATCH v6 4/9] media: venus: adding core part and helper functions

2017-02-07 Thread Bjorn Andersson
On Tue 07 Feb 05:10 PST 2017, Stanimir Varbanov wrote: > * firmware loader > I like the way this turns out, just some style comments below. [..] > diff --git a/drivers/media/platform/qcom/venus/firmware.c > b/drivers/media/platform/qcom/venus/firmware.c > new file mode 100644 > index

Re: [PATCH 2/8] media: vidc: adding core part and helper functions

2016-08-25 Thread Bjorn Andersson
On Thu 25 Aug 05:59 PDT 2016, Stanimir Varbanov wrote: > Hi Bjorn, > > Thanks for the review and comments! > > On 08/23/2016 05:50 AM, Bjorn Andersson wrote: > > On Mon 22 Aug 06:13 PDT 2016, Stanimir Varbanov wrote: > > > > Hi Stan, > > > >&g

Re: [PATCH 6/8] media: vidc: add Venus HFI files

2016-08-22 Thread Bjorn Andersson
On Mon 22 Aug 06:13 PDT 2016, Stanimir Varbanov wrote: > Here is the implementation of Venus video accelerator low-level > functionality. It contanins code which setup the registers and > startup uthe processor, allocate and manipulates with the shared > memory used for sending commands and

Re: [PATCH 5/8] media: vidc: add Host Firmware Interface (HFI)

2016-08-22 Thread Bjorn Andersson
On Mon 22 Aug 06:13 PDT 2016, Stanimir Varbanov wrote: > This is the implementation of HFI. It is loaded with the > responsibility to comunicate with the firmware through an > interface commands and messages. > > - hfi.c has interface functions used by the core, decoder > and encoder parts to

Re: [PATCH 2/8] media: vidc: adding core part and helper functions

2016-08-22 Thread Bjorn Andersson
On Mon 22 Aug 06:13 PDT 2016, Stanimir Varbanov wrote: Hi Stan, > This adds core part of the vidc driver common helper functions > used by encoder and decoder specific files. I believe "vidc" is short for "video core" and this is not the only "video core" from Qualcomm. This driver is the v4l2