ORESOURCE_MEM, 0);
> if (mem == NULL)
> return -EINVAL;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call
orter
- r8a7792/blanche
- r8a7793/gose
- r8a7794/alt
- r8a7794/silk
I don't know about r8a7792/wheat. But according to its .dts file, it has two
instances of the ADV7513, not ADV7511.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond i
default y
> + default n
"default n" is the default, so you can just drop this line.
For the principle:
Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@l
On Wed, Sep 13, 2017 at 10:50 AM, Geert Uytterhoeven
<ge...@linux-m68k.org> wrote:
> On Thu, Jul 20, 2017 at 12:54 PM, Mauro Carvalho Chehab
> <mche...@s-opensource.com> wrote:
>> This is an automatic generated email to let you know that the following
>> patch wer
Author: Ulrich Hecht <ulrich.hecht+rene...@gmail.com>
> Date:Mon Jul 3 04:43:33 2017 -0400
>
> Fixes a crash on Renesas R8A7793 Gose board that uses these "compatible"
> entries.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com>
> Tested-by: Ge
_DMA. Make VIDEO_QCOM_CAMSS depend on HAS_DMA to fix this.
Fixes: f5c074947f56533c ("media: camss: Enable building")
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Hi Todor,
On Mon, Sep 11, 2017 at 8:56 AM, Todor Tomov <todor.to...@linaro.org> wrote:
> On 10.09.2017 12:58, Geert Uytterhoeven wrote:
>> On Tue, Aug 8, 2017 at 3:30 PM, Todor Tomov <todor.to...@linaro.org> wrote:
>>> Use VFE PIX input interface and do format conver
_id {
> VFE_LINE_NONE = -1,
> VFE_LINE_RDI0 = 0,
> VFE_LINE_RDI1 = 1,
> - VFE_LINE_RDI2 = 2
> + VFE_LINE_RDI2 = 2,
> + VFE_LINE_PIX = 3
> };
>
> struct vfe_output {
> - u8 wm_idx;
> + u8 wm_num;
> + u8 wm_idx[3];
Hi Laurent,
On Wed, Aug 30, 2017 at 12:10 PM, Laurent Pinchart
<laurent.pinch...@ideasonboard.com> wrote:
> On Wednesday, 30 August 2017 12:57:31 EEST Geert Uytterhoeven wrote:
>> Use the preferred generic node name in the example.
>>
>> Signed-off-by: Geert Uytterhoev
Use the preferred generic node name in the example.
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
---
Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/renesa
No, this one is for of_fwnode_graph_get_port_parent().
You're letting too many similarly-named new functions through ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call
() really the only place outside
drivers/of/property.c that calls of_node_get() on a node obtained by
to_of_node()?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with
gt; +}
> +EXPORT_SYMBOL_GPL(i2c_release_bounce_buf);
^^
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with t
lock
> for the CEC block. Specify this in the dts to enable CEC support.
>
> Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's l
tem is in a good state anyway.
kmalloc() may have printed a big fat warning and invoked the OOM-killer
already.
[*] while checking if you perhaps removed the "dev" games in a later patch.
No, you added another one :-(
Gr{oetje,eeting}s,
Geert
--
Ge
Hi Ulrich,
On Mon, Jul 3, 2017 at 10:43 AM, Ulrich Hecht
<ulrich.hecht+rene...@gmail.com> wrote:
> Fixes a crash on Renesas R8A7793 Gose board that uses these "compatible"
> entries.
Thanks!
> Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com>
Teste
r/0 Not tainted 4.12.0-rc7-rcar2-initrd #37
Hardware name: Generic R-Car Gen2 (Flattened Device Tree)
task: df427040 task.stack: df436000
PC is at adv7180_probe+0x84/0x3cc
In the absence of an entry in adv7180_id[], the passed i2c_device_id
pointer is NULL, and thus dereferencing it c
; provide analogue decoding and HDMI receiving capabilities
The subject says adv7*1*81, adv7*1*82.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a h
every detail you
>> changed in re-writing this. If they did, it should all be separate
>> commits.
>
>AFAIK this is a way that's things are dealt with when you submit somebody
> else's work with your changes. Sorry if the list is too long...
Based on a patch by Konsta
On Fri, Jun 23, 2017 at 11:25 AM, Ramesh Shanmugasundaram
<ramesh.shanmugasunda...@bp.renesas.com> wrote:
> Add r8a7796 DRIF bindings.
>
> Signed-off-by: Ramesh Shanmugasundaram
> <ramesh.shanmugasunda...@bp.renesas.com>
Acked-by: Geert Uytterhoeven <geert+rene...@gl
Hi Kieran,
On Wed, Jun 14, 2017 at 11:43 AM, Kieran Bingham
<kieran.bingham+rene...@ideasonboard.com> wrote:
> On 14/06/17 10:39, Geert Uytterhoeven wrote:
>> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbing...@kernel.org> wrote:
>>> From: Kiera
hould be applied to salvator-common.dtsi instead of salvator-x.dtsi.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I
sleep_us); \
Same for sleep_us.
Also in readx_poll_timeout_atomic(), and in your second patch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Kieran,
On Tue, Jun 13, 2017 at 11:32 AM, Kieran Bingham
<kieran.bingham+rene...@ideasonboard.com> wrote:
> On 13/06/17 10:24, Geert Uytterhoeven wrote:
>> On Tue, Jun 13, 2017 at 2:35 AM, Kieran Bingham <kbing...@kernel.org> wrote:
>>> From: Kiera
r of regmap_read_poll_timeout macro.
> +*/
> + return regmap_read_poll_timeout(ctx->regmap, idx, val,
> + (max2175_get_bitval(val, msb, lsb) == exp_bitval),
> + 1000, (timeout_ms * 1000));
I don't think that issue should be fixed here, so
lrate':
:(.text+0x1b8b1c): undefined reference to `__aeabi_uldivmod'
v4l2_bt_timings.pixelclock is u64, so you should use DIV_ROUND_CLOSEST_ULL()
instead.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In pe
dr, val, cond, sleep_us,
timeout_us) \
({ \
...
if (timeout_us && ktime_compare(ktime_get(), timeout) > 0) { \
For increased safety, and to avoid this warning, "timeout_us" should be
inside parentheses.
Gr{oetje,eeting}s,
Gee
quot;);
>> break;
>> + case FD1_IP_H3_ES2:
>> + dprintk(fdp1, "FDP1 Version R-Car H3-ES2\n");
Please drop dashes between SoC names and revisions.
>> + break;
>> default:
>> dev_err(fdp1->
On Sun, May 28, 2017 at 11:30 AM, Wolfram Sang
<wsa+rene...@sang-engineering.com> wrote:
> It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive text.
>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
Acked-by: Geert Uytterhoeven <geer
On Sun, May 28, 2017 at 11:30 AM, Wolfram Sang
<wsa+rene...@sang-engineering.com> wrote:
> It is 'R-Car', not 'RCar'. No code or binding changes, only descriptive text.
>
> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>
Acked-by: Geert Uytterhoeven <geer
container_of(ent, struct v4l2_subdev, entity)
> + ent ? container_of(ent, struct v4l2_subdev, entity) : NULL
Due to the low precedence level of the ternary operator, you want
to enclose this in parentheses.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's l
y to
> +* prevent writing out frames
> + */
> + spin_lock_irqsave(>irqlock, flags);
> + video->frame_end = NULL;
> + rwpf->mem = (struct vsp1_rwpf_memory) { 0 };
Likewise:
- rwpf->mem = (struct vsp1_r
ingham <kieran.bingham+rene...@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 147 ++-
You have to do this only once, in salvator-x.dtsi ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia
};
> };
>
> + {
> + status = "okay";
Please extend the existing " { ... }" section.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with
en3 CHSEL manipulation
>> + */
>> +
>> +int rvin_set_chsel(struct rvin_dev *vin, u8 chsel)
>> +{
>> + u32 ifmd;
>> +
>> + pm_runtime_get_sync(vin->dev);
>
> Can this fail? Just wondering.
In theory, yes.
In practice, no, unless th
int zpos;
> + u32 colorkey;
> + bool colorkey_en;
Please move this bool down, together with the other bool, to reduce
object size due to alignment.
> + u32 colorkey_alpha;
> bool interlaced;
> };
Gr{oetje,eeting}s,
Geert
--
Geer
Hi Laurent,
On Tue, May 2, 2017 at 11:17 PM, Laurent Pinchart
<laurent.pinch...@ideasonboard.com> wrote:
> On Wednesday 22 Mar 2017 10:34:16 Geert Uytterhoeven wrote:
>> On Thu, Mar 9, 2017 at 9:08 PM, Sergei Shtylyov wrote:
>> > --- /dev/null
>> > +++ media_tree/
ms : Ohms
> -micro-ohms: micro Ohms
> -microvolt : micro volts
> +-pF: pico farads
All electrical units seem to use long(er) names.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@
..]
>>
>> @@ -387,6 +403,50 @@
>> };
>> };
>>
>> + {
>> + status = "okay";
>> +
>> + clock-frequency = <10>;
>> +
>> + video_receiver@70 {
>
>
>Hyphens are preferred in the node
nd in the R-Car gen3 SoCs,
> + where the examples with are:
> + - "renesas,r8a7795-imr-lx4" for R-Car H3,
> + - "renesas,r8a7796-imr-lx4" for R-Car M3-W.
Laurent: what do you think about the need for SoC-specific compatible
values for the various IM* blocks?
Gr{oetje,
.compatible = "renesas,vin-r8a7796",
> + .data = _info_r8a7796,
> + },
> + {
Shouldn't this be inserted above the r8a7795 entry?
All other entries in this table are sorted in reverse alphabetical order.
> .compatible = &q
Hi Mauro,
On Mon, Mar 13, 2017 at 2:02 AM, Mauro Carvalho Chehab
<mche...@osg.samsung.com> wrote:
> Em Sun, 12 Mar 2017 14:16:56 +0100
> Geert Uytterhoeven <ge...@linux-m68k.org> escreveu:
>
>> Submitters of device tree binding documentation may forget to CC
Submitters of device tree binding documentation may forget to CC
the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Cc: Mauro Carvalho Chehab <mche...@osg.samsung.com&g
On Fri, Mar 3, 2017 at 12:56 PM, Sergei Shtylyov
<sergei.shtyl...@cogentembedded.com> wrote:
>>> + - "renesas,imr-lx4-v3m" for R-Car V3M.
>>
>>
>> "renesas,-EPROBE_DEFER-imr-lx4"
>
>
>Huh? :-)
Do you know the part number of V3M
ot; for R-Car M3-W,
"renesas,r8a7796-imr-lx4"
> + - "renesas,imr-lx4-v3m" for R-Car V3M.
"renesas,-EPROBE_DEFER-imr-lx4"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In perso
bus->data_lanes[i] = v;
> }
> bus->num_data_lanes = i;
> @@ -63,6 +70,15 @@ static int v4l2_of_parse_csi_bus(const struct device_node
> *node,
> }
>
> if (!of_property_read_u32(node, "clock-lanes", )) {
> +
inchartl/media.git iommu/devel/du
Dropped from renesas-drivers, as this branch is based on a very old tree
(v4.8-rc2), and many (but not all!) commits have found their way upstream.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge
se properties
> similarly.
Note that the last two properties match the those in
Documentation/devicetree/bindings/spi/sh-msiof.txt.
We may want to use one DRIF channel as a plain SPI slave with the
(modified) MSIOF driver in the future.
Gr{oetje,eeting}s,
COMPILE_TEST
> + depends on (!ARCH_RENESAS && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
Which tree and config is this? I don't have fdp1_pm_runtime_resume in my
renesas-drivers tree.
Why are the dummies for !CONFIG_VIDEO_RENESAS_FCP in include/media/rcar-fcp.h
not working?
Gr{oetje,
drop the "0":
mem = (struct vsp1_rwpf_memory) { };
or add an additional pair of braces:
mem = (struct vsp1_rwpf_memory) { { 0 } };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.o
ntation/devicetree/bindings/media/
> +video-interfaces.txt. Port 0 should connect the node that is the video
> +source for to the CSI-2. Port 1 should connect all the R-Car VIN
Trailing space at the end of previous line.
Gr{oetje,eeting}s,
Geert
--
Geert Uytt
rdware block. If we want to use a
>> DT
>> node to convey group information, option 2 seems better to me. However, it
>> somehow abuses the DT parent-child model that is supposed to describe
>> relationships from a control bus point of view. Option 3 has the drawback of
>>
reg = <0 0xfea8 0 0x1>;
> +interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> +clocks = < CPG_MOD 714>;
> +power-domains = < R8A7796_PD_ALWAYS_ON>;
7796
You'd better match the SoC part numbers ;-)
Gr{oetje,eeting}s,
On Wed, Nov 2, 2016 at 2:23 PM, Niklas Söderlund
<niklas.soderlund+rene...@ragnatech.se> wrote:
> Add the SoC specific information for Renesas Salvator-X M3 (r8a7796)
> board.
Same comments as for patch 31/32.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeve
{
>
> static const struct of_device_id rvin_of_id_table[] = {
> {
> + .compatible = "renesas,vin-r8a7795",
> + .data = (void *)_info_r8a7795,
Cast not needed
> + },
Gr{oetje,eeting}s,
Geert
--
Geert U
reg = <0 0xfea8 0 0x1>;
> +interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> +clocks = < CPG_MOD 714>;
> +power-domains = <>;
Please update the power-domains property to match reality.
Gr{oetje,eeting}s
>;
> +
> +port@1 {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +
> +reg = <1>;
> +
> +csi20vin1: endpoint@1 {
> +
},
> + {
> + .compatible = "renesas,rcar-gen2-vin",
> + .data = (void *)_info_gen2,
> + },
> { },
> };
> MODULE_DEVICE_TABLE(of, rvin_of_id_table);
> @@ -281,7 +314,7 @@ static int rcar_vin_probe(struct platform_dev
On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart
<laurent.pinchart+rene...@ideasonboard.com> wrote:
> The r8a7796 has a single FDP1 instance.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+rene
Hi Laurent,
On Mon, Oct 24, 2016 at 11:46 AM, Laurent Pinchart
<laurent.pinch...@ideasonboard.com> wrote:
> On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote:
>> On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote:
>> > --- /dev/null
>> > +++ b/Docume
to respective power domain.
Still, too many power domains in one sentence?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to
On Tue, Oct 18, 2016 at 5:01 PM, Ulrich Hecht
<ulrich.hecht+rene...@gmail.com> wrote:
> From: Hans Verkuil <hverk...@xs4all.nl>
>
> Add support in the dts for the HDMI input. Based on the Lager dts
> patch from Ultich Hecht.
Ulrich ;-)
Gr{oetje,eeting}s,
On Tue, Oct 18, 2016 at 5:02 PM, Ulrich Hecht
<ulrich.hecht+rene...@gmail.com> wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterh
two sets of dmas, one for each DMAC.
> + power-domains = < R8A7795_PD_ALWAYS_ON>;
> + status = "disabled";
> +
> + sub-channel0 {
> + status = "disabled";
> + };
> +
> + sub-channel1 {
> +
hdl,
> + _eu_rx_mode,
> NULL);
> + ctx->rx_modes = (struct max2175_rxmode *)eu_rx_modes;
> + } else {
> + ctx->rx_mode = v4l2_ctrl_new_custom(hdl,
> +
introducing
an #ifdef.
Fixes: 57b978ada073106d ("[media] s5p-cec: fix system and runtime PM
integration")
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
---
The above commit didn't take into account Arnd's previous fix...
drivers/staging/media/s5p-cec/s5p_cec.c | 4 ++--
1
to fix this.
Fixes: 2ceeca0499d74521 ("[media] rc: split nec protocol into its three
variants")
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
---
Is RC_TYPE_NECX correct, or should it be RC_TYPE_NEC?
I used RC_TYPE_NECX based on the checks for {,not_}data and
{,not_}syst
interrupt-parent = <>;
>> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
>
> Isn't the interrupt signal connected to GP4_2 ?
No idea about Gose, but on Koelsch it is (hence koelsch DTS is wrong??)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots o
Hi Ulrich,
On Fri, Sep 16, 2016 at 3:09 PM, Ulrich Hecht
<ulrich.hecht+rene...@gmail.com> wrote:
> Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
> --- a/arch/arm/boot/dts/r8a7793.dtsi
> +++ b/arc
; and available for convenience at
>
> git://linuxtv.org/pinchartl/media.git vsp1/hgo
I've dropped the above branch from today's renesas-drivers release due to too
many merge conflicts.
Thanks for your understanding.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterh
build-testing is really all you need. Any
> problems caused by adding 'const' to a definition will be seen by build
> errors or warnings.
Unfortunately in this particular case they could lead to failures that can only
be detected at runtime, when failing o write to a read-only piece of m
Hi Laurent,
On Mon, Sep 5, 2016 at 10:25 AM, Laurent Pinchart
<laurent.pinch...@ideasonboard.com> wrote:
> On Monday 05 Sep 2016 10:20:52 Geert Uytterhoeven wrote:
>> On Mon, Sep 5, 2016 at 10:17 AM, Laurent Pinchart wrote:
>> >> BTW, it seems I missed a f
turns -110
>> PM: Device fea38000.vsp failed to resume noirq: error -110
>>
>> -13 == -EACCES, returned by rcar_fcp_enable() as pm_runtime_get_sync()
>> is called too early during system resume,
>
> Do you have a fix for this ? :-)
Unfortuately not.
Gr{oetje,eeting}s,
Hi Laurent,
On Wed, Aug 17, 2016 at 2:55 PM, Laurent Pinchart
<laurent.pinch...@ideasonboard.com> wrote:
> On Tuesday 09 Aug 2016 17:36:41 Geert Uytterhoeven wrote:
>> When resuming from suspend-to-RAM on r8a7795/salvator-x:
>>
>> dpm_run_callback(): pm_genpd_resu
stead to ensure that it won't disappear being
... behind
> the caller's back.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. Bu
lt;sergei.shtyl...@cogentembedded.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
() to be failures.
Fixes: 7b49235e83b2347c ("[media] v4l: Add Renesas R-Car FCP driver")
Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
---
drivers/media/platform/rcar-fcp.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/rcar-
drivers/media/v4l2-core/videobuf2-dma-contig.c:486: error: implicit
declaration of function ‘dma_get_cache_alignment’
VIDEO_MEDIATEK_VCODEC selects VIDEOBUF2_DMA_CONTIG, which bypasses its
dependency on HAS_DMA. Make VIDEO_MEDIATEK_VCODEC depend on HAS_DMA to
fix this.
Signed-off-by: Geert U
If NO_DMA=y:
ERROR: "bad_dma_ops" [drivers/media/platform/mtk-vpu/mtk-vpu.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletio
ps.queue_setup().
To fix this:
- Update the signature of fdp1_queue_setup(),
- Convert the FDP1 driver to use the new vb2_queue dev field, cfr.
commit 53ddcc683faef8c7 ("[media] media/platform: convert drivers to
use the new vb2_queue dev field").
Signed-off-by: Geert Uytterhoeven <gee
Hi Mauro,
On Sun, Jul 10, 2016 at 5:27 PM, Mauro Carvalho Chehab
<mche...@osg.samsung.com> wrote:
> Em Sun, 22 May 2016 11:06:05 +0200
> Geert Uytterhoeven <ge...@linux-m68k.org> escreveu:
>
>> Submitters of device tree binding documentation may forget to CC
amily? ;-)
> Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
> [uli: removed "renesas," prefixes from pfc nodes]
> Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of
ore of the following
> + - "renesas,csi2-r8a7795" for the R8A7795 device
Please use "renesas,-" for new bindings, i.e.
"renesas,r8a7795-csi2".
> + - "renesas,rcar-gen3-csi2" for a generic R-Car Gen3 compatible device.
Gr{oetje,eeting}s,
kets, is noticeable enough to make it obvious that
you are responsible for last-minute changes."
Hence a name should be sufficient.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal convers
it_freeable) from [] (kernel_init+0x8/0x110)
+[] (kernel_init) from [] (ret_from_fork+0x14/0x2c)
Also seen on Salvator-X.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call
Hi Rob,
CC linux-pm
On Fri, Jun 10, 2016 at 11:33 PM, Rob Herring <r...@kernel.org> wrote:
> On Fri, Jun 10, 2016 at 2:11 PM, Geert Uytterhoeven
> <ge...@linux-m68k.org> wrote:
>> On Fri, Jun 10, 2016 at 7:39 PM, Rob Herring <r...@kernel.org> wrote:
>>> O
A7795_PD_A3VP>;
>
> This needs to be documented above too, not just the example.
Why? Power domains are an optional feature, whose presence depends
on the platform, not on the device.
Hence "power-domains" properties may appear in any device node.
Having to document them in every s
is used to pass a (negative) error
code, it should always be signed.
2. EINPROGRESS is 150 on mips, 245 on parisc.
Hence -EINPROGRESS doesn't fit in a signed 8-bit number.
Change the callback status from "char" to "int" to fix these.
Signed-off-by: Geert Uytterhoeven <g
it renesas/fcpf for
> convenience.
As this is based on previous renesas-drivers release, which included the
Salvator-X HDMI prototype, I created a topic branch topic/fcpf-v1 just
containing your changes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux
vice tree.
Please reduce the CC list. Not everyone who ever touched a line in the
files you modified is working on media or atmel devices.
get_maintainer.pl gives hints, not exact lists of people.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux
to -ENODEV to fix this.
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
---
Can num_frontends ever be zero?
drivers/media/usb/dvb-usb/dvb-usb-dvb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb/dvb-usb-dvb.c
b/drivers/media/usb/dvb-u
for generic compatible 'FCP for VSP'
I guess checkpatch complained about your dtsi additions because you forgot
to add "renesas,fcpf" here?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal
; CPG_MOD 602>;
> + power-domains = < R8A7795_PD_A3VP>;
Adding it to the example doesn't hurt, though.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In
Submitters of device tree binding documentation may forget to CC
the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mche...@osg.samsung.com>
Cc: linux-media@vger.kernel.org
---
Please apply this patch dir
XI transactions in order to reduce the
> memory bandwidth.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots
tly support a single type, as that's all the driver
> currently supports and I'm not comfortable merging bindings without at least
> one test implementation. Should I clarify that with something as "These DT
> bindings currently support the "FCP for Video" type only" ?
Yes ple
as: Enable PM
and PM_GENERIC_DOMAINS for SoCs with PM Domains") and 71d076ceb245f0d9 ("ARM:
shmobile: Enable PM and PM_GENERIC_DOMAINS for SoCs with PM Domains").
Even before that, drivers/sh/pm_runtime.c would have taken care of
enabling the clocks for you.
Gr{oetje,eeting}s,
*/
> +void rcar_fcp_enable(struct rcar_fcp_device *fcp)
> +{
> + if (fcp)
> + pm_runtime_get_sync(fcp->dev);
Given pm_runtime_get_sync() returns an error code (which is usually just
ignored), perhaps you want to forward that?
> +}
> +EXPORT_SYMBOL_GPL(rcar_fcp_enable);
Reg
ompatible value, I guess the type is determined
automatically at run-time?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when
r8a7792-specific driver
>> code to be activated in an updated driver should the need arise.
>>
>> Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
>> Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>
>
> Strictly speaking, I see an ack from Geert
101 - 200 of 334 matches
Mail list logo
