Re: [PATCH v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

On Thu, Nov 08, 2018 at 01:46:32PM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event

Re: [PATCH v2 for v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation

On Wed, Nov 14, 2018 at 11:37:53AM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

On Mon, Nov 26, 2018 at 08:27:59AM +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 22, 2018 at 01:33:33PM +0200, Sakari Ailus wrote: > > On Tue, Nov 20, 2018 at 09:21:50AM -0200, Mauro Carvalho Chehab wrote: > > > Em Tue, 20 Nov 2018 12:49:46 +0200 > > > Sakari Ailus

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

On Thu, Nov 22, 2018 at 01:33:33PM +0200, Sakari Ailus wrote: > On Tue, Nov 20, 2018 at 09:21:50AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 20 Nov 2018 12:49:46 +0200 > > Sakari Ailus escreveu: > > > > > Hi Greg, > > > > > > On Mon, Nov

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote: > Hi Greg, > > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote: > > > [ upstream commit 92539d3eda2c090b

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] There is no such git commit id in Linus's tree :(

Re: [PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

On Mon, Apr 02, 2018 at 04:26:50PM +0200, Robert Jarzmik wrote: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

On Tue, Mar 13, 2018 at 09:00:54PM +0100, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer > --- > drivers/staging/media/imx/imx-media-csi.c | 5 + > 1 file changed, 5 insertions(+) I know I don't take patches with an empty changelog description, but other

Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe wrote: > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 > > ("media: staging: atomisp: Remove IMX sensor support") > > Lets remove this

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

On Thu, Nov 23, 2017 at 11:07:51AM -0200, Mauro Carvalho Chehab wrote: > Hi Laurent, > > Em Thu, 16 Nov 2017 02:33:48 +0200 > Laurent Pinchart escreveu: > > > Device unplug being asynchronous, it naturally races with operations > > performed by

Re: [PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

> >> On Fri, Nov 17, 2017 at 3:58 PM, Mauro Carvalho Chehab > >> <mche...@s-opensource.com> wrote: > >> > Em Fri, 17 Nov 2017 15:18:26 +0100 > >> > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > >> > > >> > I

Re: [PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

gt; > > Em Fri, 17 Nov 2017 15:18:26 +0100 > > > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > > > >> There is no need to #define the license of the driver, just put it in > > >> the MODULE_LICENSE() line directly as a text str

Re: [PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

On Fri, Nov 17, 2017 at 12:58:47PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 17 Nov 2017 15:18:26 +0100 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENS

[PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

Verkuil <hverk...@xs4all.nl> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Johan Hovold <jo...@kernel.org> Cc: Davidlohr Bueso <d...@stgolabs.net> Cc: Sakari Ailus <sakari.ai...@linux.intel.com> Reported-by: Philippe Ombredanne <pombreda...@nexb.com> Si

Re: [PATCH v3 1/3] staging: greybus: light: fix memory leak in v4l2 register

On Thu, Aug 10, 2017 at 06:49:45PM +0300, Sakari Ailus wrote: > From: Rui Miguel Silva > > We are allocating memory for the v4l2 flash configuration structure and > leak it in the normal path. Just use the stack for this as we do not > use it outside of this function. > > Also

Re: [PATCH v3.2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

On Tue, Aug 15, 2017 at 02:28:11PM +0300, Sakari Ailus wrote: > The V4L2 flash interface allows controlling multiple LEDs through a single > sub-devices if, and only if, these LEDs are of different types. This > approach scales badly for flash controllers that drive multiple flash LEDs > or for

Re: [PATCH 00/14] gcc-7 warnings

On Fri, Jul 14, 2017 at 11:25:12AM +0200, Arnd Bergmann wrote: > This series should shut up all warnings introduced by gcc-6 or gcc-7 on > today's linux-next, as observed in "allmodconfig" builds on x86, > arm and arm64. > > I have sent some of these before, but some others are new, as I had > at

Re: Lots of new warnings with gcc-7.1.1

On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote: > [ Very random list of maintainers and mailing lists, at least > partially by number of warnings generated by gcc-7.1.1 that is then > correlated with the get_maintainers script ] > > So I upgraded one of my boxes to F26, which

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

On Tue, Jul 11, 2017 at 06:39:59PM +0100, Colin Ian King wrote: > On 11/07/17 18:30, Greg Kroah-Hartman wrote: > > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: > >> From: Colin Ian King <colin.k...@canonical.com> > >> > >> Don't populate arr

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate array gamma_par_mask on the stack but instead make it > static. Makes the object code smaller by 148 bytes: > > Before: >text data bss dec

Re: [PATCH v2 24/27] usb: gadget: u_uac1: Kill set_fs() usage

On Thu, Jun 01, 2017 at 10:58:47PM +0200, Takashi Iwai wrote: > With the new API to perform the in-kernel buffer copy, we can get rid > of set_fs() usage in this driver, finally. > > Signed-off-by: Takashi Iwai <ti...@suse.de> > --- Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

[PATCH 08/13] staging: media: atomisp: Make undeclared symbols static

From: Guru Das Srinagesh <gurooo...@gmail.com> Fix sparse warnings: "symbol not declared; should it be static?" Signed-off-by: Guru Das Srinagesh <gurooo...@gmail.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/staging/media/atomisp

[PATCH 10/13] staging: media: atomisp: one char read beyond end of string

om> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../pci/atomisp2/css2400/hive_isp_css_include/string_support.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 13/13] staging: media: atomisp: don't treat warnings as errors

ed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers/staging/media/atomisp/i2c/Makefile | 2 -- drivers/staging/media/atomisp/i2c/imx/Makefile | 2 -- drivers/staging/media/atomisp/i2c/ov5

[PATCH 11/13] staging: media: atomisp: putting NULs in the wrong place

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../pci/atomisp2/css2400/hive_isp_css_include/string_support.h| 4 ++--

[PATCH 12/13] staging: media: atomisp: fix missing blank line coding style issue in atomisp_tpg.c

From: Manny Vindiola <man...@gmail.com> This is a patch to the atomisp_tpg.c file that fixes up a missing blank line warning found by the checkpatch.pl tool Signed-off-by: Manny Vindiola <man...@gmail.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- dri

[PATCH 09/13] staging: media: atomisp: Fix -Werror=int-in-bool-context compile errors

CEIL_DIV(x, y * z) triggers this error, note we cannot do as the error suggests since b is evaluated multiple times. This commit fixes these compile errors. Signed-off-by: Hans de Goede <hdego...@redhat.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- drivers

[PATCH 02/13] staging: media: atomisp: use logical AND, not bitwise

From: Guru Das Srinagesh <gurooo...@gmail.com> Fixes sparse warning "dubious: x & !y" in logical expression. Signed-off-by: Guru Das Srinagesh <gurooo...@gmail.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../media/atomisp/pci/ato

[PATCH 06/13] staging: media: atomisp: fixed coding style errors

t the compiled code in any way. Signed-off-by: Avraham Shukron <avraham.shuk...@gmail.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../platform/intel-mid/atomisp_gmin_platform.c | 156 ++--- .../platform/intel-mid/intel_mid_pcihelper

[PATCH 07/13] staging: media: atomisp: fix coding style warnings

m.shuk...@gmail.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../platform/intel-mid/atomisp_gmin_platform.c | 45 ++ .../platform/intel-mid/intel_mid_pcihelpers.c | 9 +++-- 2 files changed, 35 insertions(+), 19 deletions(-) diff --

[PATCH 01/13] staging: media: atomisp: Add __printf validation and fix fallout

From: Joe Perches <j...@perches.com> __printf validation adds format and argument validation. Fix the various broken format/argument mismatches. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../isp/ker

[PATCH 00/13] staging: media: atomisp queued up patches

Hi Mauro, Here's the set of accumulated atomisp staging patches that I had in my to-review mailbox. After this, my queue is empty, the driver is all yours! Good Luck! :) thanks, greg k-h Avraham Shukron (3): staging: media: atomisp: fixed sparse warnings staging: media: atomisp: fixed

[PATCH 04/13] staging: media: atomisp: fixed sparse warnings

From: Avraham Shukron <avraham.shuk...@gmail.com> Added "static" storage class to 4 not-declared functions Signed-off-by: Avraham Shukron <avraham.shuk...@gmail.com> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- .../media/atomisp/platform/intel

[PATCH 05/13] staging: media: atomisp: drop unused qos variable

From: Valentin Vidic <valentin.vi...@carnet.hr> Fixes a sparse warning: drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c:35:5: warning: symbol 'qos' was not declared. Should it be static? Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> Signed-off-by

[PATCH 03/13] staging: media: atomisp: Fix unnecessary initialization of static

From: Fabrizio Perria <fabrizio.per...@gmail.com> Fix checkpatch warning: removed unnecessary initialization of static variable "skip_fwload" to 0 in source atomisp_v4l2.c Signed-off-by: Fabrizio Perria <fabrizio.per...@gmail.com> Signed-off-by: Greg Kroah-Hartman <g

Re: [PATCH] media: fix one code style problem

On Fri, May 05, 2017 at 01:18:24PM -0700, Remco wrote: > From: Remco Verhoef > > this patch will fix one code style problem (ctx:WxE), space > prohibited before that Your subject needs work :) And why just one issue, is that the only place this type of problem is needed

Re: [PATCHv3 13/22] staging: android: ion: Use CMA APIs directly

On Mon, Apr 03, 2017 at 11:57:55AM -0700, Laura Abbott wrote: > When CMA was first introduced, its primary use was for DMA allocation > and the only way to get CMA memory was to call dma_alloc_coherent. This > put Ion in an awkward position since there was no device structure > readily available

Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular

dy contained at the top of the file in the comments. > > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Alan Cox <a...@linux.intel.com> > Cc: linux-media@vger.kernel.org > Cc: de...@driverdev.osuosl.org > S

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

On Tue, Apr 11, 2017 at 03:36:39PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 11 Apr 2017 16:58:40 +0200 > Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > > > On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Ap

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Corbet wrote: > > On Wed, 5 Apr 2017 10:22:54 -0300 > > Mauro Carvalho Chehab <mche...@s-opensource.com> wrote: > > > > > Currently,

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

On Mon, Apr 10, 2017 at 09:20:27AM -0700, Laura Abbott wrote: > On 04/08/2017 03:38 AM, Greg Kroah-Hartman wrote: > > On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: > >> Hi, > >> > >> This is v3 of the series to do some serious Ion cleanu

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Corbet wrote: > On Wed, 5 Apr 2017 10:22:54 -0300 > Mauro Carvalho Chehab wrote: > > > Currently, there are several USB core documents that are at either > > written in plain text or in DocBook format. Convert them to

Re: [PATCH] staging: media/platform/bcm2835: remove gstreamer workaround

On Sun, Apr 02, 2017 at 12:48:15AM -0400, Kevin Wern wrote: > Gstreamer's v4l2src reacted poorly to certain outputs from the bcm2835 > video driver's ioctl ops function vidioc_enum_framesizes, so a > workaround was created that could be activated by user input. This > workaround would replace the

Re: [PATCH] add blank line after declarations

On Fri, Apr 07, 2017 at 08:41:11AM -0400, Manny Vindiola wrote: > Add blank line after variable declarations as part of checkpatch.pl style > fixup. > > Signed-off-by: Manny Vindiola > --- > drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 + > 1 file changed, 1

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: > Hi, > > This is v3 of the series to do some serious Ion cleanup in preparation for > moving out of staging. I didn't hear much on v2 so I'm going to assume > people are okay with the series as is. I know there were still some open >

Re: [PATCH v3] Revert "staging: radio-bcm2048: fixed bare use of unsigned int"

On Mon, Mar 27, 2017 at 05:20:29PM +1100, Eddie Youseph wrote: > This reverts previous changes to checkpatch warning: > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > --- > Changes in v2: > - Added changelog > > Changes in v3: > - Revert changes to using bare unsigned I

Re: [PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

On Fri, Mar 24, 2017 at 02:20:24PM +0100, Arnd Bergmann wrote: > The revert reintroduced a build failure without CONFIG_ION: > > media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array > initializer [-Werror] > media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near

Re: [PATCH] staging: media: atomisp: use kvmalloc and kvfree

On Thu, Mar 23, 2017 at 09:12:39PM +0800, Geliang Tang wrote: > Use kvmalloc() and kvfree() instead of open-coding. These functions are not in Linus's tree, so I can't apply this patch without breaking things :( thanks, greg k-h

Re: [PATCH v2] staging: radio-bcm2048: fixed bare use of unsigned int

On Wed, Mar 22, 2017 at 01:33:39PM +1100, Eddie Youseph wrote: > Fixed checkpatch WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Eddie Youseph > --- > Changes in v2: > - Added changelog Did you actually build this change? Please do

Re: [PATCH] bcm2048: Fix checkpatch checks

On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: > Fix following checks: > > CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather > than BUG() or BUG_ON() > + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); > > CHECK: spaces preferred around that '+' (ctx:VxV) > +

Re: [PATCH] Staging: media: bcm2048: Fixed an error

On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote: > Hello Greg, > First, I appreciate you taking the time to educate me. I used the checkpatch > script on the file I fixed and he reported the line as an error. Do you > consider all checkpatch warnings/error/checks as coding style fixes?

Re: [PATCH] staging: davinci_vpfe: fix multiline comment style

On Wed, Feb 08, 2017 at 01:52:05PM +0200, Avraham Shukron wrote: > Signed-off-by: Avraham Shukron I can't take patches without a changelog text, and neither should any other maintainer... -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

On Sun, Feb 05, 2017 at 10:15:21PM +, Dave Stevenson wrote: > Newbie question: if this has already been merged to staging, where am I > looking for the relevant tree to add patches on top of? > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git branch > staging-next? Yes, that

Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

On Thu, Feb 02, 2017 at 01:11:36PM +0100, Arnd Bergmann wrote: > On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann wrote: > > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann wrote: > >> I got a link error in allyesconfig: > >> Fixes: 7b3ad5abf027 ("staging: Import the

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

On Wed, Oct 19, 2016 at 08:10:25PM +0200, Jean-Baptiste Abbadie wrote: > On 19/10/16 19:51, Greg Kroah-Hartman wrote: > > I can't take a patch with no changelog text, sorry. > Hello, > > Should I add the changelog in the same thread or start a new thread ? Whol

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote: > Signed-off-by: Jean-Baptiste Abbadie I can't take a patch with no changelog text, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH -next] staging: media: stih-cec: remove unused including

On Wed, Sep 28, 2016 at 03:13:13PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun > Acked-by: Benjamin Gaignard > --- >

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > Hi Baoyou, > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > 2016-09-18 Baoyou Xie : > > > >> We get 1 warning when building kernel with W=1: > >>

Re: [PATCH for 4.6] davinci_vpfe: Revert "staging: media: davinci_vpfe: remove,unnecessary ret variable"

;thaissa.fa...@gmail.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > --- > > Greg, this patch was never seen by us. Can you redirect patches for > staging/media > to the linux-media mailinglist? We'd like to stay on top of what is happening > t

Re: [PATCH] Add tw5864 driver

On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote: > From: Andrey Utkin > > Support for boards based on Techwell TW5864 chip which provides > multichannel video & audio grabbing and encoding (H.264, MJPEG, > ADPCM G.726). > > Signed-off-by: Andrey

Re: [PATCH] Add tw5864 driver

On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote: > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2333,6 +2333,7 @@ > #define PCI_VENDOR_ID_CAVIUM 0x177d > > #define PCI_VENDOR_ID_TECHWELL 0x1797 > +#define PCI_DEVICE_ID_TECHWELL_5864

Re: Failed to build on 4.2.6

On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote: > Hi, > > The attached config doesn't build on 4.2.6, but changing it to the > following: > > VIDEO_V4L2_SUBDEV_API n -> y > +V4L2_FLASH_LED_CLASS n > > does build. Did this work on older kernels (4.2.5? .4? older?) thanks,

Re: [PATCH] staging: media: omap4iss: Reformat overly long lines

On Tue, May 26, 2015 at 10:54:18AM +0200, Piotr S. Staszewski wrote: This reformats lines that were previously above 80 characters long, improving readability and making checkpatch.pl happy. Signed-off-by: Piotr S. Staszewski p.staszew...@gmail.com ---

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote: Switch to use ma_request_slave_channel_compat_reason() to request the DMA channels. In case of error, return the error code we received including -EPROBE_DEFER I think you typed the function name wrong here :( -- To unsubscribe

Re: [PATCH] radio-bcm2048: Fix region selection

On Fri, May 15, 2015 at 11:32:51PM +0200, Pali Rohár wrote: From: maxx m...@spaceboyz.net I need a real name here, sorry. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] radio-bcm2048: Enable access to automute and ctrl registers

On Fri, May 15, 2015 at 11:31:51PM +0200, Pali Rohár wrote: From: maxx m...@spaceboyz.net Same here, real name please. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: From: Greg Kroah-Hartman On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: Consider the following scenario: - plugin a webcam - play the stream via gst-launch-0.10 v4l2src device=/dev/video0

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

On Tue, Dec 09, 2014 at 05:01:35PM +0100, Sebastian Andrzej Siewior wrote: On 12/09/2014 04:24 PM, 'Greg Kroah-Hartman' wrote: On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: From: Greg Kroah-Hartman On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: Consider the following scenario: - plugin a webcam - play the stream via gst-launch-0.10 v4l2src device=/dev/video0… - remove the USB-HCD during playback via rmmod $HCD and now wait for the crash Which you deserve,

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

On Sat, Dec 06, 2014 at 12:13:13AM +0100, Sebastian Andrzej Siewior wrote: * Greg Kroah-Hartman | 2014-12-05 13:19:32 [-0800]: On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: Consider the following scenario: - plugin a webcam - play the stream via gst-launch

Re: [PATCH] staging: media: lirc: modify print calls

On Wed, Nov 05, 2014 at 03:43:44PM +0200, Aya Mahfouz wrote: On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 4 Nov 2014 23:43:07 +0200 Aya Mahfouz mahfouz.saif.elya...@gmail.com escreveu: This patches replaces one pr_debug call by dev_dbg and changes

Re: [RFC 2/4] cenalloc: Constraint-Enabled Allocation helpers for dma-buf

are done. Signed-off-by: Sumit Semwal sumit.sem...@linaro.org Cc: linux-ker...@vger.kernel.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-media@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org --- MAINTAINERS

Re: [PATCH v4 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

On Mon, Sep 29, 2014 at 11:45:23AM +0200, Philipp Zabel wrote: Am Montag, den 29.09.2014, 12:13 +0300 schrieb Dan Carpenter: On Mon, Sep 29, 2014 at 10:15:44AM +0200, Philipp Zabel wrote: In preparation for a following patch, stop decrementing the endpoint node refcount in the loop. This

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

| 9 + drivers/staging/imx-drm/imx-drm-core.c | 12 ++-- 3 files changed, 5 insertions(+), 19 deletions(-) No objection from me for this, but Grant is in charge of drivers/of/base.c, so I'll leave it for him to apply. Acked-by: Greg Kroah

Re: [PATCH 1/1] drivers/base/dma-buf.c: replace dma_buf_uninit_debugfs by debugfs_remove_recursive

: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-media@vger.kernel.org Signed-off-by: Fabian Frederick f...@skynet.be --- This is untested. drivers/base/dma-buf.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

On Wed, Apr 30, 2014 at 04:02:50PM +0200, Andrzej Hajda wrote: Generic framework for tracking internal interfaces == Summary --- interface_tracker is a generic framework which allows to track appearance and disappearance of different

Re: [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices

...@samsung.com Cc: Luca Risolia luca.riso...@studio.unibo.it Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- I consider this a bug fix, I believe it should go upstream ASAP. Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] staging: media: omap24xx: fix up some checkpatch.pl issues

On Wed, Apr 09, 2014 at 11:25:18PM +1000, Vitaly Osipov wrote: Fixes the following issues: tcm825x.c: ERROR: Macros with complex values should be enclosed in parenthesis WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to

Re: [PATCH] staging: rtl2832_sdr: fixup checkpatch/style issues

On Wed, Apr 09, 2014 at 08:07:28PM -0400, Anthony DeStefano wrote: rtl2832_sdr.c: fixup checkpatch issues about long lines Signed-off-by: Anthony DeStefano a...@fastmail.fm --- drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 23 --- 1 file changed, 16 insertions(+),

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote: Hi Joe, On Wednesday 05 March 2014 16:28:03 Joe Perches wrote: On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote: Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define CONFIG_DEBUG'. 'DEBUG'

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross ccr...@android.com wrote: dma_buf_map_attachment and dma_buf_vmap can return NULL or ERR_PTR on a error. This encourages a common buggy pattern in callers: sgt =

Re: [PATCH v3 0/2] *** SUBJECT HERE ***

On Fri, Feb 07, 2014 at 06:09:46PM +0100, Jean-Francois Moine wrote: *** BLURB HERE *** Subject and BLURB forgotten? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

On Fri, Feb 07, 2014 at 09:22:37AM -0800, Colin Cross wrote: On Fri, Feb 7, 2014 at 8:43 AM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross ccr...@android.com wrote

Re: Fw: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

option for old fixed style. Add note to mention that configuration option too. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi Acked-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from this list

Re: [PATCHv2] staging: go7007: fix use of uninitialised pointer

On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote: go variable is initialised only after the switch case so it cannot be dereferenced prior to that happening. Signed-off-by: Michal Nazarewicz min...@mina86.com --- drivers/staging/media/go7007/go7007-usb.c | 8 1

Re: staging: media: Use dev_err() instead of pr_err()

On Sun, Nov 17, 2013 at 10:03:21AM -0200, Mauro Carvalho Chehab wrote: Em Fri, 15 Nov 2013 15:29:39 +0900 Greg Kroah-Hartman gre...@linuxfoundation.org escreveu: On Thu, Nov 14, 2013 at 11:08:14AM -0200, Mauro Carvalho Chehab wrote: Hi, I'm not sure how this patch got applied

Re: Fw: staging: media: Use dev_err() instead of pr_err()

Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org But, from the custody chain, it seems it was not C/C to linux-media ML, doesn't have the driver maintainer's ack[1] and didn't went via my tree. It came in through my tree as part of the OPW intern application process

Re: [PATCH] staging: go7007: fix use of uninitialised pointer

On Sun, Nov 10, 2013 at 07:37:57PM +0100, Michal Nazarewicz wrote: From: Michal Nazarewicz min...@mina86.com The go variable is declade without initialisation and invocation of dev_dbg immediatelly tries to dereference it. --- drivers/staging/media/go7007/go7007-usb.c | 2 +- 1 file

Re: [GIT PULL FOR v3.13] OMAP4 ISS driver

On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote: Hello, Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera interface). I don't take pull requests for staging drivers. But even if I did, Mauro takes drivers/staging/media/ code, so it's up to him to

Re: [PATCH v2 8/8] drivers: misc: use module_platform_driver_probe()

On Thu, Mar 14, 2013 at 06:09:38PM +0100, Fabio Porcedda wrote: This patch converts the drivers to use the module_platform_driver_probe() macro which makes the code smaller and a bit simpler. Someone else beat you to this fix for these files, sorry. greg k-h -- To unsubscribe from this list:

Re: [PATCH v3 0/9] Media Controller capture driver for DM365

On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote: Em Wed, 28 Nov 2012 12:56:10 +0100 Hans Verkuil hansv...@cisco.com escreveu: On Wed 28 November 2012 12:45:37 Dan Carpenter wrote: I wish people wouldn't submit big patches right before the merge window opens... :/

Re: [PATCH v3 0/9] Media Controller capture driver for DM365

On Wed, Nov 28, 2012 at 08:18:20PM +0100, Hans Verkuil wrote: On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote: On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote: Em Wed, 28 Nov 2012 12:56:10 +0100 Hans Verkuil hansv...@cisco.com escreveu: On Wed 28

Re: [PATCH v3 0/9] Media Controller capture driver for DM365

On Wed, Nov 28, 2012 at 08:30:04PM +0100, Sylwester Nawrocki wrote: On 11/28/2012 01:22 PM, Dan Carpenter wrote: In the end this is just a driver, and I don't especially care. But it's like not just this one which makes me frustrated. I really believe in linux-next and I think everything

Re: Fw: [PATCH] dma-mapping: fix dma_common_get_sgtable() conditional compilation

2012 14:41:48 +0100 dma_common_get_sgtable() function doesn't depend on ARCH_HAS_DMA_DECLARE_COHERENT_MEMORY, so it must not be compiled conditionally. Reported-by: Stephen Rothwell s...@canb.auug.org.au Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Greg Kroah-Hartman

Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c

On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... - WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to

Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c

On Mon, Nov 05, 2012 at 07:11:11AM -0800, Joe Perches wrote: On Mon, 2012-11-05 at 14:11 +0100, Greg Kroah-Hartman wrote: On Mon, Nov 05, 2012 at 08:34:42PM +0900, YAMANE Toshiaki wrote: fixed below checkpatch warnings. - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev

Re: [Q] reprobe deferred-probing drivers

On Wed, Oct 17, 2012 at 10:27:36AM +0200, Guennadi Liakhovetski wrote: Hi I've got a situation, for which I currently don't have a (good) solution. Let's say device A depends on device B and as long as B hasn't probed, A requests deferred probing. Now B probes, which causes A to also

Re: [PATCH 05/16] mm/drivers: use vm_flags_t for vma flags

...@infradead.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: John Stultz john.stu...@linaro.org Cc: Arve Hjønnevåg a...@android.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 3.0.y 0/4] Re: lirc_serial spuriously claims assigned port and irq to be in use

On Wed, Mar 07, 2012 at 02:17:09PM -0600, Jonathan Nieder wrote: Greg Kroah-Hartman wrote: On Fri, Mar 02, 2012 at 02:39:13PM -0600, Jonathan Nieder wrote: Ben Hutchings wrote: On Thu, 2012-03-01 at 21:45 -0600, Jonathan Nieder wrote: Would some of these patches (e.g., at least patches

Re: [PATCH 3.0.y 0/4] Re: lirc_serial spuriously claims assigned port and irq to be in use

On Fri, Mar 02, 2012 at 02:39:13PM -0600, Jonathan Nieder wrote: Ben Hutchings wrote: On Thu, 2012-03-01 at 21:45 -0600, Jonathan Nieder wrote: Would some of these patches (e.g., at least patches 1, 2, and 5) be appropriate for inclusion in the 3.0.y and 3.2.y stable kernels from

  1   2   >