Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

gpr.c > > @@ -29,7 +29,7 @@ > > #include > > #include > > #include > > -#include > > +#include > > #include > > #include > > #include Acked-by: James Hogan <jho...@kernel.org> Cheers James signature.asc Description: PGP signature

[GIT PULL] Remove metag architecture

Hi Arnd, On Fri, Feb 23, 2018 at 01:26:09PM +0100, Arnd Bergmann wrote: > On Fri, Feb 23, 2018 at 12:02 PM, James Hogan <jho...@kernel.org> wrote: > > I'm happy to put v2 in linux-next now (only patch 4 has changed, I just > > sent an updated version), and send you a pull re

Re: [PATCH 00/13] Remove metag architecture

On Fri, Feb 23, 2018 at 11:26:58AM +0100, Arnd Bergmann wrote: > On Thu, Feb 22, 2018 at 12:38 AM, James Hogan <jho...@kernel.org> wrote: > > So lets call it a day and drop the Meta architecture port from the > > kernel. RIP Meta. > > Since I brought up the architectu

Re: [PATCH 00/13] Remove metag architecture

On Thu, Feb 22, 2018 at 10:26:54AM +0100, Peter Zijlstra wrote: > On Wed, Feb 21, 2018 at 11:38:12PM +0000, James Hogan wrote: > > So lets call it a day and drop the Meta architecture port from the > > kernel. RIP Meta. > > So long, and thanks for all the fish! > >

[PATCH 00/13] Remove metag architecture

e...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux...@kvack.org Cc: linux-g...@vger.kernel.org Cc: linux-watch...@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-...@vger.kernel.org James Hogan (13): metag: Remove arch/metag/ docs: Remove metag docs docs: Remove remaining re

[PATCH 12/13] media: img-ir: Drop METAG dependency

Now that arch/metag/ has been removed, remove the METAG dependency from the IMG IR device driver. The hardware is also present on MIPS SoCs so the driver still has value. Signed-off-by: James Hogan <jho...@kernel.org> Cc: Mauro Carvalho Chehab <mche...@s-opensource.com> Cc: Mauro Car

Re: [PATCH 04/12] media: img-ir-hw: fix one kernel-doc comment

ning: Excess function > parameter 'timings' description in 'img_ir_decoder_convert' > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Very true. Acked-by: James Hogan <jho...@kernel.org> Thanks James > --- > drivers/media/rc/img-ir/img-ir-hw.c | 2 +- >

Re: [PATCH v5 02/18] [media] img-ir: use new wakeup_protocols sysfs mechanism

Hi Sean, On Tue, Dec 13, 2016 at 07:54:16AM +, Sean Young wrote: > So that leaves the question open of whether we want to guess the protocol > variant from the scancode for img-ir or if we can live with having to > select this using wakeup_protocols. Having to do this does solve the issue >

Re: [PATCH v5 02/18] [media] img-ir: use new wakeup_protocols sysfs mechanism

Hi Sean (and Sifan), On Mon, Dec 12, 2016 at 09:13:43PM +, Sean Young wrote: > Rather than guessing what variant a scancode is from its length, > use the new wakeup_protocol. > > Signed-off-by: Sean Young <s...@mess.org> > Cc: James Hogan <james.ho...@imgtec.com>

Re: Build regressions/improvements in v4.5-rc7

Hi, On Mon, Mar 07, 2016 at 10:01:09AM +0100, Geert Uytterhoeven wrote: > On Mon, Mar 7, 2016 at 9:55 AM, Geert Uytterhoeven > wrote: > > JFYI, when comparing v4.5-rc7[1] to v4.5-rc6[3], the summaries are: > > - build errors: +8/-7 > + error: debugfs.c: undefined

Re: [PATCH] rc: img-ir: fix error in parameters passed to irq_free()

to have been introduced while getting the driver ready for upstream (it used to use the devm_* API to request the IRQ, but I changed it to avoid the ISR racing with module removal). Acked-by: James Hogan james.ho...@imgtec.com Cheers James --- drivers/media/rc/img-ir/img-ir-core.c |2 +- 1

Re: [PATCH v2] rc: img-ir: Add and enable sys clock for img-ir

or the driver will malfunction. Signed-off-by: Sifan Naeem sifan.na...@imgtec.com Thanks Sifan, looks good to me, doesn't break tz1090, and seems to still cope with no clocks provided in DT. Acked-by: James Hogan james.ho...@imgtec.com Cheers James --- Changes from v1: System clock enabled

Re: [PATCH] rc: img-ir: Add and enable sys clock for IR

Hi Sifan, On 03/02/15 17:30, Sifan Naeem wrote: Gets a handle to the system clock, already described in the binding document, and calls the appropriate common clock framework functions to mark it prepared/enabled, the common clock framework initially enables the clock and doesn't disable it

Re: [PATCH 3/5] rc: img-ir: biphase enabled with workaround

Hi Sifan, On 11/12/14 18:54, Sifan Naeem wrote: +/* + * Timer function to re-enable the current protocol after it had been + * cleared when invalid interrupts were generated due to a quirk in +the + * img-ir decoder. + */ +static void img_ir_suspend_timer(unsigned long arg) { + struct

Re: [PATCH v2 3/5] rc: img-ir: biphase enabled with workaround

it. So for the whole patchset feel free to add my: Acked-by: James Hogan james.ho...@imgtec.com Thanks James Signed-off-by: Sifan Naeem sifan.na...@imgtec.com --- drivers/media/rc/img-ir/img-ir-hw.c | 60 +-- drivers/media/rc/img-ir/img-ir-hw.h |4

Re: [PATCH v2 3/5] rc: img-ir: biphase enabled with workaround

On 12/12/14 12:07, James Hogan wrote: Hi Sifan, On 11/12/14 20:06, Sifan Naeem wrote: Biphase decoding in the current img-ir has got a quirk, where multiple Interrupts are generated when an incomplete IR code is received by the decoder. Patch adds a work around for the quirk and enables

Re: [REVIEW PATCH 1/2] img-ir/hw: Avoid clearing filter for no-op protocol change

Hi Mauro, On 04/12/14 17:38, Mauro Carvalho Chehab wrote: Em Mon, 1 Dec 2014 12:55:09 + James Hogan james.ho...@imgtec.com escreveu: When the img-ir driver is asked to change protocol, if the chosen decoder is already loaded then don't call img_ir_set_decoder(), so as not to clear

[REVIEW PATCH v2] rc-main: Re-apply filter for no-op protocol change

: simplify sysfs code) Reported-by: Sifan Naeem sifan.na...@imgtec.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: David Härdeman da...@hardeman.nu Cc: sta...@vger.kernel.org # v3.17+ Cc: linux-media@vger.kernel.org --- Changes in v2: - Move fix

Re: [PATCH 1/5] rc: img-ir: add scancode requests to a struct

more easily without touching all the hardware decode callbacks. Signed-off-by: Sifan Naeem sifan.na...@imgtec.com Acked-by: James Hogan james.ho...@imgtec.com Cheers James --- drivers/media/rc/img-ir/img-ir-hw.c| 16 +--- drivers/media/rc/img-ir/img-ir-hw.h| 16

Re: [PATCH 2/5] rc: img-ir: pass toggle bit to the rc driver

-by: James Hogan james.ho...@imgtec.com Cheers James Signed-off-by: Sifan Naeem sifan.na...@imgtec.com --- drivers/media/rc/img-ir/img-ir-hw.c |8 +--- drivers/media/rc/img-ir/img-ir-hw.h |2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/img-ir

Re: [PATCH 3/5] rc: img-ir: biphase enabled with workaround

On 04/12/14 15:38, Sifan Naeem wrote: Biphase decoding in the current img-ir has got a quirk, where multiple Interrupts are generated when an incomplete IR code is received by the decoder. Patch adds a work around for the quirk and enables biphase decoding. Signed-off-by: Sifan Naeem

Re: [PATCH 4/5] rc: img-ir: add philips rc5 decoder module

decoder block. + +config IR_IMG_RC5 + bool Phillips RC5 protocol support I think that should be Philips (if wikipedia is anything to go by). Same elsewhere in this patch and patch 5. Other than that, Acked-by: James Hogan james.ho...@imgtec.com (Note, I don't have RC-5/RC-6 capable

Re: [PATCH 5/5] rc: img-ir: add philips rc6 decoder module

On 04/12/14 15:38, Sifan Naeem wrote: Add img-ir module for decoding Philips rc6 protocol. Signed-off-by: Sifan Naeem sifan.na...@imgtec.com Aside from the Philips thing: Acked-by: James Hogan james.ho...@imgtec.com (It's unpleasant having unexplained timings for RC-6, but it's better than

[REVIEW PATCH 0/2] img-ir: Some more fixes

for stable (v3.15+). Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Sifan Naeem sifan.na...@imgtec.com Cc: linux-media@vger.kernel.org James Hogan (2): img-ir/hw: Avoid clearing filter for no-op protocol change img-ir/hw: Fix potential deadlock stopping timer drivers/media/rc/img-ir/img

[REVIEW PATCH 1/2] img-ir/hw: Avoid clearing filter for no-op protocol change

0x filter_mask $ echo nec protocols After this, messages which don't match the filter still get received. Reported-by: Sifan Naeem sifan.na...@imgtec.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: sta...@vger.kernel.org # v3.15+ Cc: linux

[REVIEW PATCH 2/2] img-ir/hw: Fix potential deadlock stopping timer

the main spin lock while performing the del_timer_sync() call. The timer is prevented from restarting before the lock is reacquired by a new stopping flag which img_ir_handle_data() checks before updating the timer. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che

Re: [REVIEW] Submitting Media Patches

On 22 October 2014 15:12, Hans Verkuil hverk...@xs4all.nl wrote: How to submit patches for a stable kernel = The standard method is to add this tag: Cc: sta...@vger.kernel.org possibly with a comment saying to which versions it should be

[REVIEW PATCH 0/5] img-ir: Some fixes

Here are a few fixes for the img-ir RC driver. Patch 1 is the important one. I've tagged it for stable. The other 4 are minor fixes/improvements that don't need backporting to stable. Dylan Rajaratnam (1): img-ir/hw: Always read data to clear buffer James Hogan (4): img-ir/hw: Drop [un

[REVIEW PATCH 4/5] img-ir: Don't set driver's module owner

Don't bother setting .owner = THIS_MODULE, since it's already handled by the platform_driver_register macro. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/img-ir-core.c | 1 - 1 file

[REVIEW PATCH 3/5] img-ir: Depend on METAG or MIPS or COMPILE_TEST

allmodconfig builds), to avoid cluttering the Kconfig menu with drivers for hardware that isn't yet available on other platforms. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/Kconfig | 1 + 1

[REVIEW PATCH 2/5] img-ir/hw: Drop [un]register_decoder declarations

-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/img-ir/img-ir-hw.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/rc/img-ir/img-ir-hw.h b/drivers/media/rc/img-ir/img-ir-hw.h index

[REVIEW PATCH 5/5] MAINTAINERS: Add myself as img-ir maintainer

Add myself as the maintainer for the Imagination Technologies Infrared Decoder driver. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git

[REVIEW PATCH FOR v3.18 1/5] img-ir/hw: Always read data to clear buffer

...@imgtec.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org Cc: sta...@vger.kernel.org # v3.15+ --- drivers/media/rc/img-ir/img-ir-hw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc

Re: [PATCH 01/29] img-ir: fix sparse warnings

-sanyo.c:82:23: warning: symbol 'img_ir_sanyo' was not declared. Should it be static? Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: James Hogan james.ho...@imgtec.com Thanks James -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

Hi Mauro, On Wednesday 23 July 2014 16:39:36 Mauro Carvalho Chehab wrote: Em Fri, 14 Mar 2014 23:04:10 + James Hogan ja...@albanarts.com escreveu: A recent discussion about proposed interfaces for setting up the hardware wakeup filter lead to the conclusion that it could help to have

Re: [PATCH v6 2/3] ARM: sunxi: Add driver for sunxi IR controller

Hi Alexander, Just a few probe error handling suggestions... On 13/05/14 19:39, Alexander Bersenev wrote: +static int sunxi_ir_probe(struct platform_device *pdev) +{ + int ret = 0; + unsigned long tmp = 0; + + struct device *dev = pdev-dev; + struct device_node *dn =

Re: [PATCH 41/49] rc-core: rename mutex

On Friday 04 April 2014 01:34:43 David Härdeman wrote: Having a mutex named lock is a bit misleading. Why? A mutex is a type of lock so what's the problem? A little grep'ing and sed'ing reveals that out of the 1578 unique mutex names in the kernel source I have to hand, 540 contain lock, and

Re: [PATCH 05/49] rc-core: split dev-s_filter

in to the patch apply here too (sorry I didn't spot that when I first looked at it!). But if you fix that you're welcome to my: Acked-by: James Hogan james.ho...@imgtec.com Cheers James drivers/media/rc/rc-main.c | 31 +++ include/media/rc-core.h |6

Re: [PATCH 04/49] rc-core: do not change 32bit NEC scancode format for now

comments: Acked-by: James Hogan james.ho...@imgtec.com Cheers James + addr = bitrev8(in-data 24); + addr_m = bitrev8(in-mask 24); + addr_inv = bitrev8(in-data 16); + addr_inv_m = bitrev8(in-mask 16); + data

Re: [PATCH 06/49] rc-core: remove generic scancode filter

in a different email that reverting the last two hunks of b8c7d915087c97a21fa415fa0e860e59739da202 should be in this patch rather than combined into patch 5. But if you fix that you're welcome to my: Reviewed-by: James Hogan james.ho...@imgtec.com Thanks James Based on a patch from James Hogan

Re: [PATCH 1/3] rc-core: do not change 32bit NEC scancode format for now

in this series. v2: make sure img-ir scancodes are bitrev8():ed as well v3: update comments Signed-off-by: David Härdeman da...@hardeman.nu Acked-by: James Hogan james.ho...@imgtec.com Thanks James --- drivers/media/rc/img-ir/img-ir-nec.c | 27 ++- drivers/media/rc/ir-nec

Re: [PATCH 2/3] rc-core: split dev-s_filter

explicit. v2: hopefully address James' comments on what should be moved from this to the next patch. Signed-off-by: David Härdeman da...@hardeman.nu Acked-by: James Hogan james.ho...@imgtec.com Thanks James --- drivers/media/rc/img-ir/img-ir-hw.c | 15 ++- drivers/media/rc

Re: [PATCH 3/3] rc-core: remove generic scancode filter

On Saturday 05 April 2014 00:06:06 David Härdeman wrote: The generic scancode filtering has questionable value and makes it impossible to determine from userspace if there is an actual scancode hw filter present or not. So revert the generic parts. Based on a patch from James Hogan

Re: [PATCH 05/11] rc-core: split dev-s_filter

Hi David, On Saturday 29 March 2014 17:11:11 David Härdeman wrote: Overloading dev-s_filter to do two different functions (set wakeup filters and generic hardware filters) makes it impossible to tell what the hardware actually supports, so create a separate dev-s_wakeup_filter and make the

Re: [PATCH 04/11] rc-core: do not change 32bit NEC scancode format for now

On 29/03/14 16:11, David Härdeman wrote: This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2 The patch ignores the fact that NEC32 scancodes are generated not only in the NEC raw decoder but also directly in some drivers. Whichever approach is chosen it should be consistent across

Re: [PATCH 06/11] rc-core: remove generic scancode filter

On 29/03/14 16:11, David Härdeman wrote: The generic scancode filtering has questionable value and makes it impossible to determine from userspace if there is an actual scancode hw filter present or not. So revert the generic parts. Based on a patch from James Hogan james.ho...@imgtec.com

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

On 29/03/14 16:11, David Härdeman wrote: Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core and the nec decoder without any loss of functionality. In order to maintain backwards compatibility, some heuristics are added in rc-main.c to convert scancodes to NEC32 as

Re: [PATCH 03/11] rc-core: document the protocol type

On 29/03/14 16:11, David Härdeman wrote: Right now the protocol information is not preserved, rc-core gets handed a scancode but has no idea which protocol it corresponds to. This patch (which required reading through the source/keymap for all drivers, not fun) makes the protocol information

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

On 31/03/14 11:19, David Härdeman wrote: On 2014-03-31 11:44, James Hogan wrote: On 29/03/14 16:11, David Härdeman wrote: Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core and the nec decoder without any loss of functionality. In order to maintain backwards

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

On 31/03/14 14:22, David Härdeman wrote: On 2014-03-31 12:56, James Hogan wrote: This would mean that if the data is put in the right bit order (first bit received in BIT(0), last bit received in BIT(31)), then the scancode = raw, and if the data is received in the reverse bit order (like

Re: [PATCH 06/11] rc-core: remove generic scancode filter

On Monday 31 March 2014 21:38:13 David Härdeman wrote: The rest looks reasonable, though it could easily have been a separate patch (at least as long as the show/store callbacks don't assume the presence of the callbacks they use). Yes, I wanted to avoid there being more intermediary states

Re: [PATCH] rc-core: do not change 32bit NEC scancode format for now

On Friday 28 March 2014 01:08:56 David Härdeman wrote: On Thu, Mar 27, 2014 at 11:21:23PM +, James Hogan wrote: Hi David, On Thursday 27 March 2014 22:00:37 David Härdeman wrote: This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2 The patch ignores the fact that NEC32 scancodes

Re: [PATCH] rc-core: do not change 32bit NEC scancode format for now

Hi David, On Thursday 27 March 2014 22:00:37 David Härdeman wrote: This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2 The patch ignores the fact that NEC32 scancodes are generated not only in the NEC raw decoder but also directly in some drivers. Whichever approach is chosen it should be

Re: [PATCH v4 00/10] media: rc: ImgTec IR decoder driver

On 25/03/14 23:53, David Härdeman wrote: On Fri, Feb 28, 2014 at 11:28:50PM +, James Hogan wrote: Add a driver for the ImgTec Infrared decoder block. Two separate rc input devices are exposed depending on kernel configuration. One uses the hardware decoder which is set up with timings

Re: [PATCH 1/5] rc-main: add generic scancode filtering

On 26/03/14 13:44, David Härdeman wrote: On 2014-03-26 08:08, Antti Seppälä wrote: On 26 March 2014 01:21, David Härdeman da...@hardeman.nu wrote: On Tue, Mar 25, 2014 at 09:12:11AM +, James Hogan wrote: On Tuesday 25 March 2014 00:51:46 David Härdeman wrote: What's the purpose

[PATCH 0/3] rc: Misc fixes for v3.15

A few misc fixes for v3.15, all relating to my previous patches. James Hogan (3): rc-main: Revert generic scancode filtering support rc-main: Limit to a single wakeup protocol group rc: img-ir: Expand copyright headers with GPL notices drivers/media/rc/img-ir/img-ir-core.c | 5

[PATCH 1/3] rc-main: Revert generic scancode filtering support

. the software filtering) should be removed until it has had further discussion. Reported-by: David Härdeman da...@hardeman.nu Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: David Härdeman da...@hardeman.nu Cc: Antti Seppälä a.sepp...@gmail.com

[PATCH 3/3] rc: img-ir: Expand copyright headers with GPL notices

Add the basic GPLv2+ license notice to the copyright headers at the top of all the source files in the img-ir driver. Reported-by: David Härdeman da...@hardeman.nu Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: David Härdeman da...@hardeman.nu

[PATCH 2/3] rc-main: Limit to a single wakeup protocol group

wakeup protocol since only a single protocol can usually be used for wakeup at a time, and doing so with encode based wakeup will result in an arbitrary protocol being used if multiple are possible. Reported-by: Antti Seppälä a.sepp...@gmail.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc

Re: [PATCH 1/5] rc-main: add generic scancode filtering

On Tuesday 25 March 2014 00:51:46 David Härdeman wrote: On Fri, Feb 28, 2014 at 11:17:02PM +, James Hogan wrote: Add generic scancode filtering of RC input events, and fall back to permitting any RC_FILTER_NORMAL scancode filter to be set if no s_filter callback exists. This allows raw IR

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

On Monday 17 March 2014 19:01:51 Antti Seppälä wrote: On 17 March 2014 00:41, James Hogan ja...@albanarts.com wrote: Yeh I'm in two minds about this now. It's actually a little awkward since some of the protocols have multiple variants (i.e. rc-5 = RC5+RC5X), but an encoded message is only

Re: [PATCH v2 6/9] rc: ir-rc5-sz-decoder: Add ir encoding support

Hi Antti, On Sunday 16 March 2014 10:34:31 Antti Seppälä wrote: +/** + * ir_rc5_sz_encode() - Encode a scancode as a stream of raw events + * + * @protocols: allowed protocols + * @scancode: scancode filter describing scancode (helps distinguish between + * protocol

Re: [PATCH v2 9/9] rc: nuvoton-cir: Add support for writing wakeup samples via sysfs filter callback

On Sunday 16 March 2014 10:39:39 Antti Seppälä wrote: +static int nvt_write_wakeup_codes(struct rc_dev *dev, + const u8 *wakeup_sample_buf, int count) +{ + int i = 0; + u8 reg, reg_learn_mode; + unsigned long flags; + struct

Re: [PATCH v2 6/9] rc: ir-rc5-sz-decoder: Add ir encoding support

On Sunday 16 March 2014 14:14:58 Antti Seppälä wrote: Hi James. On 16 March 2014 13:50, James Hogan ja...@albanarts.com wrote: Hi Antti, On Sunday 16 March 2014 10:34:31 Antti Seppälä wrote: + + /* all important bits of scancode should be set in mask

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

On Sunday 16 March 2014 10:22:02 Antti Seppälä wrote: On 15 March 2014 01:04, James Hogan ja...@albanarts.com wrote: A recent discussion about proposed interfaces for setting up the hardware wakeup filter lead to the conclusion that it could help to have the generic capability to encode

[PATCH v2 5/9] rc: ir-rc5-decoder: Add encode capability

in both data and mask is unambiguously RC-5X. The Manchester modulation helper is used, and for RC-5X it is used twice with two sets of timings, the first with a short trailer space for the space in the middle, and the second with no leader so that it can continue the space. Signed-off-by: James

[PATCH v2 0/9] rc: Add IR encode based wakeup filtering

encoder) helper rc: ir-rc5-sz-decoder: Add ir encoding support rc: nuvoton-cir: Add support for writing wakeup samples via sysfs filter callback James Hogan (6): rc: ir-raw: Add scancode encoder callback rc: ir-raw: Add pulse-distance modulation helper rc: ir-nec-decoder: Add encode

[PATCH v2 1/9] rc: ir-raw: Add scancode encoder callback

Add a callback to raw ir handlers for encoding and modulating a scancode to a set of raw events. This could be used for transmit, or for converting a wakeup scancode filter to a form that is more suitable for raw hardware wake up filters. Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro

[PATCH v2 3/9] rc: ir-raw: Add Manchester encoder (phase encoder) helper

From: Antti Seppälä a.sepp...@gmail.com Adding a simple Manchester encoder to rc-core. Manchester coding is used by at least RC-5 protocol and its variants. Signed-off-by: Antti Seppälä a.sepp...@gmail.com Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che

[PATCH v2 4/9] rc: ir-nec-decoder: Add encode capability

Add the capability to encode NEC scancodes as raw events. The scancode_to_raw is pretty much taken from the img-ir NEC filter() callback, and modulation uses the pulse distance helper added in a previous commit. Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che

[PATCH v2 6/9] rc: ir-rc5-sz-decoder: Add ir encoding support

From: Antti Seppälä a.sepp...@gmail.com The encoding in rc5-sz first inserts a pulse and then simply utilizes the generic Manchester encoder available in rc-core. Signed-off-by: Antti Seppälä a.sepp...@gmail.com Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che

[PATCH v2 7/9] rc: rc-core: Add support for encode_wakeup drivers

the sysfs interface to know which wakeup protocols are allowed for encode_wakeup drivers, also ensure that the IR decoders/encoders are loaded when an encode_wakeup driver is registered. Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Antti Seppälä

[PATCH v2 8/9] rc: rc-loopback: Add loopback of filter scancodes

Add the s_filter callback to the rc-loopback driver, which instead of setting the filter just feeds the scancode back through the input device so that it can be verified. Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Antti Seppälä a.sepp

[PATCH v2 2/9] rc: ir-raw: Add pulse-distance modulation helper

Add IR encoding helper for pulse-distance modulation as used by the NEC protocol. Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Antti Seppälä a.sepp...@gmail.com Cc: David Härdeman da...@hardeman.nu --- Changes in v2: - Alter encode API

[PATCH v2 9/9] rc: nuvoton-cir: Add support for writing wakeup samples via sysfs filter callback

to enable wake up functionality. Signed-off-by: Antti Seppälä a.sepp...@gmail.com Signed-off-by: James Hogan ja...@albanarts.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Jarod Wilson ja...@redhat.com Cc: Wei Yongjun yongjun_...@trendmicro.com.cn Cc: Hans Verkuil hans.verk...@cisco.com

[PATCH 1/3] rc: img-ir: hw: Remove unnecessary semi-colon

Fix a coccicheck warning in img-ir driver: drivers/media/rc/img-ir/img-ir-hw.c:500:2-3: Unneeded semicolon Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com --- I don't object to this patch being squashed into the patch rc: img-ir: add hardware

[PATCH 0/3] rc: img-ir: Fixes a few warnings

These patches fix a few warnings in the img-ir driver, one from coccinelle and two more from W=1 (thanks Mauro). James Hogan (3): rc: img-ir: hw: Remove unnecessary semi-colon rc: img-ir: hw: Fix min/max bits setup rc: img-ir: jvc: Remove unused no-leader timings drivers/media/rc/img-ir

[PATCH 3/3] rc: img-ir: jvc: Remove unused no-leader timings

initialization for ‘img_ir_jvc.timings.s01’) [-Woverride-init] Reported-by: Mauro Carvalho Chehab m.che...@samsung.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com --- I don't object to this patch being squashed into the patch rc: img-ir: add JVC

[PATCH 2/3] rc: img-ir: hw: Fix min/max bits setup

-variable] Reported-by: Mauro Carvalho Chehab m.che...@samsung.com Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com --- I don't object to this patch being squashed into the patch rc: img-ir: add hardware decoder driver. --- drivers/media/rc/img-ir/img-ir

Re: [PATCH v4 10/10] rc: img-ir: add Sanyo decoder module

On 12/03/14 10:57, Mauro Carvalho Chehab wrote: Hi James, Em Fri, 28 Feb 2014 23:29:00 + James Hogan james.ho...@imgtec.com escreveu: Add an img-ir module for decoding the Sanyo infrared protocol. After applying this series, some new warnings are popping up, when compiled with W=1

Re: [PATCH 0/5] rc: scancode filtering improvements

Hi Antti, On Wednesday 05 March 2014 20:12:15 Antti Seppälä wrote: After reviewing the series and porting my nuvoton changes to it I haven't noticed any errors worth mentioning. In fact I think this series is very well written and should be merged. Thanks for reviewing! James, I hope you

[PATCH] rc-main: fix missing unlock if no devno left

device numbers left. The added code doesn't depend on the device lock, so move it before the lock is taken. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/rc-main.c | 16 1 file

Re: [PATCH v3 06/15] dt: binding: add binding for ImgTec IR block

On 28/02/14 01:28, Rob Herring wrote: On Thu, Feb 27, 2014 at 4:52 PM, James Hogan james.ho...@imgtec.com wrote: v3: - Rename compatible string to img,ir-rev1 (Rob Herring). - Specify ordering of clocks explicitly (Rob Herring). I'd appreciate if somebody could give this another glance after

[PATCH 1/5] rc-main: add generic scancode filtering

to filter out the corner cases. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Antti Seppälä a.sepp...@gmail.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/rc-main.c | 20 +--- 1 file changed, 13 insertions(+), 7

[PATCH 3/5] rc: add allowed/enabled wakeup protocol masks

the first element (RC_FILTER_NORMAL), and add a couple more helper functions for drivers to use for setting the allowed and enabled wakeup protocols. We also rename allowed_protos to allowed_protocols while we're at it, which is more consistent with enabled_protocols. Signed-off-by: James Hogan

[PATCH 5/5] rc-main: automatically refresh filter on protocol change

callback to be omitted entirely if there is only a single available wakeup protocol at a time, since selecting no protocol will automatically clear the wakeup filter, disabling wakeup. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: Antti Seppälä

[PATCH 4/5] rc: add wakeup_protocols sysfs file

Add a wakeup_protocols sysfs file which controls the new rc_dev::enabled_protocols[RC_FILTER_WAKEUP], which is the mask of protocols that are used for the wakeup filter. A new RC driver callback change_wakeup_protocol() is called to change the wakeup protocol mask. Signed-off-by: James Hogan

[PATCH 2/5] rc: abstract access to allowed/enabled protocols

The allowed and enabled protocol masks need to be expanded to be per filter type in order to support wakeup filter protocol selection. To ease that process abstract access to the rc_dev::allowed_protos and rc_dev::enabled_protocols members with inline functions. Signed-off-by: James Hogan

[PATCH 0/5] rc: scancode filtering improvements

Carvalho Chehab m.che...@samsung.com Cc: Bruno Prémont bonb...@linux-vserver.org Cc: Maxim Levitsky maximlevit...@gmail.com Cc: Sean Young s...@mess.org Cc: David Härdeman da...@hardeman.nu Cc: Jiri Kosina jkos...@suse.cz Cc: Antti Seppälä a.sepp...@gmail.com James Hogan (5): rc-main: add generic

[PATCH v4 00/10] media: rc: ImgTec IR decoder driver

-...@vger.kernel.org Cc: Tomasz Figa tomasz.f...@gmail.com James Hogan (10): dt: binding: add binding for ImgTec IR block rc: img-ir: add base driver rc: img-ir: add raw driver rc: img-ir: add hardware decoder driver rc: img-ir: add to build rc: img-ir: add NEC decoder module rc: img-ir: add JVC

[PATCH v4 01/10] dt: binding: add binding for ImgTec IR block

Add device tree binding for ImgTec Consumer Infrared block, specifically major revision 1 of the hardware. Signed-off-by: James Hogan james.ho...@imgtec.com Acked-by: Rob Herring r...@kernel.org Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org Cc: Pawel Moll pawel.m

[PATCH v4 02/10] rc: img-ir: add base driver

Add base driver for the ImgTec Infrared decoder block. The driver is split into separate components for raw (software) decode and hardware decoder which are in following commits. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media

[PATCH v4 05/10] rc: img-ir: add to build

Add ImgTec IR decoder driver to the build system. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/Kconfig | 2 ++ drivers/media/rc/Makefile| 1 + drivers/media/rc/img-ir

[PATCH v4 07/10] rc: img-ir: add JVC decoder module

Add an img-ir module for decoding the JVC infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v4 08/10] rc: img-ir: add Sony decoder module

Add an img-ir module for decoding the Sony infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v4 09/10] rc: img-ir: add Sharp decoder module

Add an img-ir module for decoding the Sharp infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v4 03/10] rc: img-ir: add raw driver

Add raw IR remote control input driver for the ImgTec Infrared decoder block's raw edge interrupts. Generic software protocol decoders are used to allow multiple protocols to be supported at a time, including those not supported by the hardware decoder. Signed-off-by: James Hogan james.ho

[PATCH v4 06/10] rc: img-ir: add NEC decoder module

Add an img-ir module for decoding the NEC and extended NEC infrared protocols. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update scancode and filter callbacks to handle 32-bit NEC as used by Apple

[PATCH v4 10/10] rc: img-ir: add Sanyo decoder module

Add an img-ir module for decoding the Sanyo infrared protocol. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org --- v2: - Update to new scancode interface (32-bit NEC). - Update to new filtering interface (generic

[PATCH v4 04/10] rc: img-ir: add hardware decoder driver

filter conversion function will be provided in separate files for each protocol which this part of the driver can use. The new generic scan code filter interface is made use of to reduce interrupts and control wake events. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab

  1   2   >