Re: [PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

2017-12-15 Thread Jose Abreu
Hi Hans, On 13-12-2017 20:49, Hans Verkuil wrote: > On 13/12/17 15:00, Jose Abreu wrote: >> >> Indeed. I compared the values with the spec and they are not >> correct. Even hsync is wrong. I already corrected in the code the >> hsync but regarding interlace I'm n

Re: [PATCH] v4l2-dv-timings: add v4l2_hdmi_colorimetry()

2017-12-15 Thread Jose Abreu
nd return RGB in that case. Anyway, I took a quick look at the spec and everything seems ok. Reviewed-by: Jose Abreu <joab...@synopsys.com> Best Regards, Jose Miguel Abreu > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> > --- > Tim, you can add this patch to your

Re: [PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

2017-12-13 Thread Jose Abreu
Hi Hans, On 13-12-2017 10:00, Hans Verkuil wrote: > On 12/12/17 17:02, Jose Abreu wrote: >> >>>> +static int dw_hdmi_s_routing(struct v4l2_subdev *sd, u32 input, u32 >>>> output, >>>> + u32 config) >>>

[PATCH v10 1/4] dt-bindings: media: Document Synopsys DesignWare HDMI RX

2017-12-11 Thread Jose Abreu
Document the bindings for the Synopsys DesignWare HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Rob Herring <r...@kernel.org> (v8) Cc: Joao Pinto <jpi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com

[PATCH v10 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

2017-12-11 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v10 3/4] [media] platform: Add Synopsys DesignWare HDMI RX PHY e405 Driver

2017-12-11 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v10 2/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI drivers

2017-12-11 Thread Jose Abreu
Add an entry for Synopsys DesignWare HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7a52a66..a1

[PATCH v10 0/4] Synopsys DesignWare HDMI Video Capture Controller + PHY

2017-12-11 Thread Jose Abreu
several audio output interfaces). Version 10 addresses review comments from Hans Verkuil and from Philippe Ombredanne. This series was tested in a FPGA platform using an embedded platform called ARC AXS101. Jose Abreu (4): dt-bindings: media: Document Synopsys DesignWare HDMI RX MAINTAINERS: Add

Re: [PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

2017-12-07 Thread Jose Abreu
Hi Hans, On 07-12-2017 12:33, Hans Verkuil wrote: > Hi Jose, > > Some (small) comments below: Thanks for the review! > > On 12/07/17 10:47, Jose Abreu wrote: >> This is an initial submission for the Synopsys DesignWare HDMI RX >> Controller Driver. This driver int

[PATCH v9 0/4] Synopsys DesignWare HDMI Video Capture Controller + PHY

2017-12-07 Thread Jose Abreu
several audio output interfaces). Version 9 implements the work developed by Sakari Ailus regarding subdevices pipelines registration. This series was tested in a FPGA platform using an embedded platform called ARC AXS101. Jose Abreu (4): dt-bindings: media: Document Synopsys DesignWare HDMI RX

[PATCH v9 1/4] dt-bindings: media: Document Synopsys DesignWare HDMI RX

2017-12-07 Thread Jose Abreu
Document the bindings for the Synopsys DesignWare HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Rob Herring <r...@kernel.org> (v8) Cc: Joao Pinto <jpi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com

[PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

2017-12-07 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v9 2/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI drivers

2017-12-07 Thread Jose Abreu
Add an entry for Synopsys DesignWare HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7a52a66..a1

[PATCH v9 3/4] [media] platform: Add Synopsys DesignWare HDMI RX PHY e405 Driver

2017-12-07 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Joao Pinto <jpi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

Re: [PATCH v8 0/5] Synopsys Designware HDMI Video Capture Controller + PHY

2017-11-27 Thread Jose Abreu
equested' since it depends >> on >> Sakari's subnotifier work. Once that is accepted I assume you'll make a v9 >> on top >> and then this can hopefully be merged. >> >> Regards, >> >> Hans >> >> On 10/07/17 17:46, Jose Abreu wrote: &

Re: [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2017-11-27 Thread Jose Abreu
++ Joao, ++ Luis Hi Hans, We will take a look into this. Thanks for pointing this out! Best Regards, Jose Miguel Abreu On 27-11-2017 12:01, Hans Verkuil wrote: > I'm CC-ing Jose Abreu from Synopsys to this. Jose, can you or a colleague take > a look at this as well? > > Jacob, I ha

Re: [PATCH 08/10] video/hdmi: Reject illegal picture aspect ratios

2017-11-13 Thread Jose Abreu
ha...@intel.com> > Cc: "Lin, Jia" <lin.a@intel.com> > Cc: Akashdeep Sharma <akashdeep.sha...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.c

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

2017-09-21 Thread Jose Abreu
Hi Jernej, On 20-09-2017 21:01, Jernej Skrabec wrote: > [added media mailing list due to CEC question] > > This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only > video and CEC functionality is supported. Audio needs more tweaks. > > Series is based on the H3 DE2 patch

Re: [PATCH] [media] cec: GIVE_PHYSICAL_ADDR should respond to unregistered device

2017-09-15 Thread Jose Abreu
Hi Hans, On 14-09-2017 16:46, Hans Verkuil wrote: > On 09/14/2017 05:30 PM, Jose Abreu wrote: >> >> On 14-09-2017 16:09, Hans Verkuil wrote: >>> On 09/14/17 15:28, Jose Abreu wrote: >>> >>>> Actually, I have at least one more fix which I don'

Re: [PATCH] [media] cec: GIVE_PHYSICAL_ADDR should respond to unregistered device

2017-09-14 Thread Jose Abreu
On 14-09-2017 16:09, Hans Verkuil wrote: > On 09/14/17 15:28, Jose Abreu wrote: > >> Actually, I have at least one more fix which I don't know if it's >> valid and I didn't manage to actually write it in a nice way. >> This one is for CEC 2.0. My test equipment (which

[PATCH v2] [media] cec: Respond to unregisterd initiators, when applicable

2017-09-14 Thread Jose Abreu
n the same category so, respond also to these messages. With this fix we pass CEC 1.4 official compliance. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Hans Verkuil <hans.verk...@cisco.com> Cc: Joao Pinto <jpi...@synopsys.com> --- Changes from v1: - Also resp

Re: [PATCH] [media] cec: GIVE_PHYSICAL_ADDR should respond to unregistered device

2017-09-14 Thread Jose Abreu
Hi Hans, On 14-09-2017 14:10, Hans Verkuil wrote: > On 09/14/17 13:33, Jose Abreu wrote: >> Running CEC 1.4 compliance test we get the following error on test >> 11.1.6.2: "ERROR: The DUT did not broadcast a >> message to the unregistered device." >> >

[PATCH] [media] cec: GIVE_PHYSICAL_ADDR should respond to unregistered device

2017-09-14 Thread Jose Abreu
Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Hans Verkuil <hans.verk...@cisco.com> Cc: Joao Pinto <jpi...@synopsys.com> --- drivers/media/cec/cec-adap.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/cec/cec-adap.c b/drivers/media/

Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-10 Thread Jose Abreu
Hi Rob, On 10-07-2017 16:24, Rob Herring wrote: > On Mon, Jun 26, 2017 at 11:42 AM, Jose Abreu <jose.ab...@synopsys.com> wrote: >> Hi Rob, >> >> >> On 23-06-2017 22:58, Rob Herring wrote: >>> On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote: &

[PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier()

2017-07-10 Thread Jose Abreu
Add a new stub function for cec_register_cec_notifier() so that we can still call this function when CONFIG_CEC_NOTIFIER and CONFIG_CEC_CORE are not set. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Hans Verkuil <hans.ve

[PATCH v8 0/5] Synopsys Designware HDMI Video Capture Controller + PHY

2017-07-10 Thread Jose Abreu
platform called ARC AXS101. Jose Abreu (5): [media] cec.h: Add stub function for cec_register_cec_notifier() dt-bindings: media: Document Synopsys Designware HDMI RX MAINTAINERS: Add entry for Synopsys Designware HDMI drivers [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

[PATCH v8 3/5] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-07-10 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7e

[PATCH v8 2/5] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-10 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

[PATCH v8 4/5] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-07-10 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.

[PATCH v8 5/5] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-10 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v7.1 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier()

2017-07-07 Thread Jose Abreu
Add a new stub function for cec_register_cec_notifier() so that we can still call this function when CONFIG_CEC_NOTIFIER and CONFIG_CEC_CORE are not set. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Hans Verkuil <hans.ve

Re: [PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration

2017-07-07 Thread Jose Abreu
Hi Hans, On 07-07-2017 12:16, Hans Verkuil wrote: > On 07/07/17 13:08, Jose Abreu wrote: >> When CONFIC_CEC_NOTIFIER is not set and we only include cec-notifier.h >> we can get build warnings like these ones: >> >> "warning: ‘struct cec_notifier

[PATCH v7 4/6] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-07-07 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7e

[PATCH v7 3/6] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-07 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

[PATCH v7 0/6] Synopsys Designware HDMI Video Capture Controller + PHY

2017-07-07 Thread Jose Abreu
. Jose Abreu (6): [media] cec.h: Add stub function for cec_register_cec_notifier() [media] cec-notifier.h: Prevent build warnings using forward declaration dt-bindings: media: Document Synopsys Designware HDMI RX MAINTAINERS: Add entry for Synopsys Designware HDMI drivers [media] platform

[PATCH v7 5/6] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-07-07 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.

[PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration

2017-07-07 Thread Jose Abreu
eclaration of notifier structure. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Hans Verkuil <hans.verk...@cisco.com> --- include/media/cec-notifier.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/in

[PATCH v7 6/6] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-07 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v7 1/6] [media] cec.h: Add stub function for cec_register_cec_notifier()

2017-07-07 Thread Jose Abreu
Add a new stub function for cec_register_cec_notifier() so that we can still call this function when CONFIG_CEC_NOTIFIER and CONFIG_CEC_CORE are not set. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Hans Verkuil <hans.ve

Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-07 Thread Jose Abreu
On 06-07-2017 21:52, kbuild test robot wrote: >drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_registered': >>> drivers/media//platform/dwc/dw-hdmi-rx.c:1452:9: error: implicit >>> declaration of function 'v4l2_async_subnotifier_register' >>>

Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-07 Thread Jose Abreu
On 06-07-2017 21:30, Sylwester Nawrocki wrote: > On 07/06/2017 12:24 PM, Jose Abreu wrote: >>>> +- edid-phandle: phandle to the EDID handler block. >>> Could you make this property optional and when it is missing assume that >>> device >>> correspondi

Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-06 Thread Jose Abreu
Hi Sylwester, On 05-07-2017 21:52, Sylwester Nawrocki wrote: > On 07/04/2017 04:11 PM, Jose Abreu wrote: >> Document the bindings for the Synopsys Designware HDMI RX. >> >> Signed-off-by: Jose Abreu <joab...@synopsys.com> >> --- >> .../devicetree/b

[PATCH v6 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-07-04 Thread Jose Abreu
platform called ARC AXS101. Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver MAINTAINERS: Add entry for Synopsys Designware HDMI drivers dt-bindings: media: Document Synopsys Designware

[PATCH v6 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-07-04 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.

[PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-07-04 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

[PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-04 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v6 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-07-04 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7e

Re: [PATCH v5 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-04 Thread Jose Abreu
On 04-07-2017 14:02, Hans Verkuil wrote: > On 07/04/17 14:33, Jose Abreu wrote: >> >> On 04-07-2017 10:39, Hans Verkuil wrote: >>>>>>>> +static const struct v4l2_subdev_video_ops >>>>>>>> dw_hdmi_sd_video_ops = { >>>

Re: [PATCH v5 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-04 Thread Jose Abreu
On 04-07-2017 10:39, Hans Verkuil wrote: > >> +static const struct v4l2_subdev_video_ops >> dw_hdmi_sd_video_ops = { >> +.s_routing = dw_hdmi_s_routing, >> +.g_input_status = dw_hdmi_g_input_status, >> +.g_parm = dw_hdmi_g_parm, >> +.g_dv_timings =

Re: [PATCH v5 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-04 Thread Jose Abreu
Hi Hans, On 03-07-2017 11:33, Hans Verkuil wrote: > On 07/03/2017 11:53 AM, Jose Abreu wrote: >> Hi Hans, >> >> >> On 03-07-2017 10:27, Hans Verkuil wrote: >>> On 06/29/2017 12:46 PM, Jose Abreu wrote: >>>> This is an initial submission for the

Re: [PATCH v5 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-07-03 Thread Jose Abreu
Hi Hans, On 03-07-2017 10:27, Hans Verkuil wrote: > On 06/29/2017 12:46 PM, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver interacts with a phy driver so >> that >> a communication between

[PATCH v5 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-29 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.

[PATCH v5 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-29 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v5 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-29 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

[PATCH v5 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-29 Thread Jose Abreu
was tested in a FPGA platform. Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver MAINTAINERS: Add entry for Synopsys Designware HDMI drivers dt-bindings: media: Document Synopsys Designware HDMI

[PATCH v5 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-29 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7e

Re: [PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-28 Thread Jose Abreu
Hi Sylwester, On 27-06-2017 21:34, Sylwester Nawrocki wrote: > Hi Jose, > > On 06/27/2017 10:43 AM, Jose Abreu wrote: >> On 25-06-2017 22:13, Sylwester Nawrocki wrote: >>> On 06/20/2017 07:26 PM, Jose Abreu wrote: >>>> This is an initial submission

Re: [PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-27 Thread Jose Abreu
Hi Sylwester, On 25-06-2017 22:13, Sylwester Nawrocki wrote: > On 06/20/2017 07:26 PM, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver interacts with a phy driver so that >> a communication be

Re: [PATCH v4 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-26 Thread Jose Abreu
Hi Sylwester, On 25-06-2017 22:13, Sylwester Nawrocki wrote: > Hi Jose, > > Thank you for addressing my review comments. Couple more suggestions below. > > On 06/20/2017 07:26 PM, Jose Abreu wrote: >> This adds support for the Synopsys Designware HDMI RX PHY e405.

Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-26 Thread Jose Abreu
Hi Rob, On 23-06-2017 22:58, Rob Herring wrote: > On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote: >> Document the bindings for the Synopsys Designware HDMI RX. >> >> Signed-off-by: Jose Abreu <joab...@synopsys.com> >> Cc: Carlos Palminha <palmi

[PATCH v4 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-20 Thread Jose Abreu
. Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver MAINTAINERS: Add entry for Synopsys Designware HDMI drivers dt-bindings: media: Document Synopsys Designware HDMI RX Cc: Carlos Palminha <pa

[PATCH v4 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-20 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.

[PATCH v4 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-20 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7e

[PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-20 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-20 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

Re: [PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-20 Thread Jose Abreu
HI Sylwester, On 19-06-2017 23:10, Sylwester Nawrocki wrote: > On 06/19/2017 11:33 AM, Jose Abreu wrote: >> On 18-06-2017 19:04, Sylwester Nawrocki wrote: >>> On 06/16/2017 06:38 PM, Jose Abreu wrote: >>>> This is an initial submission for the Synopsys Designware

Re: [PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-20 Thread Jose Abreu
Hi Sylwester, On 19-06-2017 22:18, Sylwester Nawrocki wrote: > On 06/19/2017 11:01 AM, Jose Abreu wrote: >> Using fixed-clock was already in my todo list. Regarding phy I >> need to pass pdata so that the callbacks between controller and >> phy are established. I also need

Re: [PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-19 Thread Jose Abreu
Hi Sylwester, Thanks again for the feedback! On 18-06-2017 19:04, Sylwester Nawrocki wrote: > On 06/16/2017 06:38 PM, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver interacts with a phy driver so that >

Re: [PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-19 Thread Jose Abreu
Hi Sylwester, Thanks for the feedback! On 18-06-2017 18:34, Sylwester Nawrocki wrote: > Hi Jose, > > On 06/16/2017 06:38 PM, Jose Abreu wrote: >> Document the bindings for the Synopsys Designware HDMI RX. >> >> Signed-off-by: Jose Abreu <joab...@synopsys.com>

[PATCH v3 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-16 Thread Jose Abreu
several audio output interfaces). Version 3 addresses review comments from Hans Verkuil regarding CEC and also uses a CEC notifier so that userspace does not have to manually set the CEC physical address. SCDC support was also implemented. This series was tested in a FPGA platform. Jose Abreu (4

[PATCH v3 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-16 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk..

[PATCH v3 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-16 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bd..e7

[PATCH v3 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-16 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@k

[PATCH v3 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-16 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

Re: [PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-16 Thread Jose Abreu
Hi Hans, On 16-06-2017 14:44, Hans Verkuil wrote: > >>> >>> + /* CEC */ + dw_dev->cec_adap = cec_allocate_adapter(_hdmi_cec_adap_ops, + dw_dev, dev_name(dev), CEC_CAP_TRANSMIT | + CEC_CAP_PHYS_ADDR | CEC_CAP_LOG_ADDRS, >>> Add CEC_CAP_RC

Re: [PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-16 Thread Jose Abreu
Hi Hans, On 16-06-2017 13:38, Hans Verkuil wrote: > Hi Jose, > > Just a quick review of the new CEC code: Thanks! > > On 06/16/17 12:07, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver int

[PATCH v2 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-16 Thread Jose Abreu
several audio output interfaces). Version 2 is just a respin of the previous version with some minor bug fixes in the controller driver and I also added CEC support. This series was tested in a FPGA platform. Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media

[PATCH v2 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-16 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bd..e7

[PATCH v2 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-16 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk..

[PATCH v2 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-16 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

[PATCH v2 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-16 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Mauro Carvalho Chehab <mche...@kern

Re: [PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-13 Thread Jose Abreu
On 13-06-2017 11:54, Hans Verkuil wrote: > On 06/13/17 12:31, Hans Verkuil wrote: >> On 06/13/17 12:06, Jose Abreu wrote: >>> Hi Hans, >>> >>> >>> On 13-06-2017 11:01, Jose Abreu wrote: >>> >>> [snip] >>>> Changes from RF

Re: [PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-13 Thread Jose Abreu
Hi Hans, On 13-06-2017 11:01, Jose Abreu wrote: [snip] > Changes from RFC: > - Added support for HDCP 1.4 [snip] > + > +/* HDCP 1.4 */ > +#define DW_HDMI_HDCP14_BKSV_SIZE 2 > +#define DW_HDMI_HDCP14_KEYS_SIZE (2 * 40) > + > +struct dw_hdmi_hdcp1

[PATCH 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-13 Thread Jose Abreu
several audio output interfaces). Jose Abreu (4): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver MAINTAINERS: Add entry for Synopsys Designware HDMI drivers dt-bindings: media: Document Synopsys Designware

[PATCH 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-13 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Rob Herring <robh...@kernel.org> --- .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 D

[PATCH 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-13 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk..

[PATCH 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-13 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu <joab...@synopsys.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 053c3bd..e798040 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1

[PATCH 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-13 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

Re: [RFC 2/2] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-05-23 Thread Jose Abreu
Hi Hans, Thanks for the review! On 22-05-2017 11:36, Hans Verkuil wrote: > On 04/21/2017 11:53 AM, Jose Abreu wrote: >> This is an initial submission for the Synopsys Designware HDMI RX >> Controller Driver. This driver interacts with a phy driver so that >> a commu

Re: [RFC 1/2] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-05-22 Thread Jose Abreu
Hi Hans, Thanks for the review! On 22-05-2017 11:04, Hans Verkuil wrote: > On 04/21/2017 11:53 AM, Jose Abreu wrote: >> This adds support for the Synopsys Designware HDMI RX PHY e405. This >> phy receives and decodes HDMI video that is delivered to a controller. >> >

Re: [RFC 0/2] Synopsys Designware HDMI Video Capture Controller + PHY

2017-05-22 Thread Jose Abreu
Hi Hans, On 21-04-2017 10:53, Jose Abreu wrote: > Hi All, > > This is a RFC series that is intended to collect comments regarding the > Synopsys Designware HDMI RX controller and Synopsys Designware HDMI RX e405 > PHY > drivers. > > The Synopsys Designware HDMI RX contro

[RFC 0/2] Synopsys Designware HDMI Video Capture Controller + PHY

2017-04-21 Thread Jose Abreu
about design decisions and would like to know wether these were the best choices. With best regards, Jose Miguel Abreu Jose Abreu (2): [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver [media] platform: Add Synopsys Designware HDMI RX Controller Driver Cc: Carlos Palminha

[RFC 1/2] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-04-21 Thread Jose Abreu
. configuration functions) and the controller must provide read/write callbacks, as well as other specific functions. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.

[RFC 2/2] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-04-21 Thread Jose Abreu
sources might not be very stable at sending the video (i.e. we must react accordingly). Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Hans Verkuil <hans.verk...@cis

Re: [PATCH 3/3] [media] cobalt: Use v4l2_calc_timeperframe helper

2017-04-19 Thread Jose Abreu
Hi Hans, On 31-03-2017 09:59, Jose Abreu wrote: > Hi Hans, > > > On 30-03-2017 14:42, Hans Verkuil wrote: >> Hi Jose, >> >> On 21/03/17 12:49, Jose Abreu wrote: >>> Currently, cobalt driver always returns 60fps in g_parm. >>> This patch uses the ne

Re: [PATCH 3/3] [media] cobalt: Use v4l2_calc_timeperframe helper

2017-03-31 Thread Jose Abreu
Hi Hans, On 30-03-2017 14:42, Hans Verkuil wrote: > Hi Jose, > > On 21/03/17 12:49, Jose Abreu wrote: >> Currently, cobalt driver always returns 60fps in g_parm. >> This patch uses the new v4l2_calc_timeperframe helper to >> calculate the time per frame value. >

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-29 Thread Jose Abreu
Hi Hans, On 28-03-2017 11:07, Hans Verkuil wrote: > On 27/03/17 13:58, Jose Abreu wrote: >> Hi Hans, >> >> >> On 24-03-2017 12:28, Hans Verkuil wrote: >>> On 03/24/17 13:21, Jose Abreu wrote: >>>> Hi Hans, >>>> >>>> >

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-27 Thread Jose Abreu
Hi Hans, On 24-03-2017 12:28, Hans Verkuil wrote: > On 03/24/17 13:21, Jose Abreu wrote: >> Hi Hans, >> >> >> On 24-03-2017 12:12, Hans Verkuil wrote: >>> On 03/24/17 12:52, Jose Abreu wrote: >>>> Hi Hans, >>>> >>>> >>

Re: [PATCH] cec-core.rst: document the new cec_get_drvdata() helper

2017-03-27 Thread Jose Abreu
Hi Hans, Thanks! I totally forgot about the documentation update. On 27-03-2017 10:53, Hans Verkuil wrote: > Document the new cec_get_drvdata() helper function. > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best

[PATCH 2/8] [media] staging: st-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/staging/media/st-cec/stih-cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

  1   2   >