Re: [bug report] [media] davinci: vpif_capture: get subdevs from DT when available

Dan Carpenter <dan.carpen...@oracle.com> writes: > Hello Kevin Hilman, > > The patch 4a5f8ae50b66: "[media] davinci: vpif_capture: get subdevs > from DT when available" from Jun 6, 2017, leads to the following > static checker warning: > > drivers/media

[PATCH] [media] davinci: vpif_capture: fix potential NULL deref

Fix potential NULL pointer dereference in the error path of memory allocation failure. Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 10 ++ 1 file changed, 6 inse

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

Sakari Ailus <sakari.ai...@iki.fi> writes: > Hi Kevin, > > On Fri, Jun 09, 2017 at 09:10:26AM -0700, Kevin Hilman wrote: >> The davinci VPIF is a single hardware block, but the existing driver >> is broken up into a common library (vpif.c), output (vpif_display.c) an

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

Hi Hans, Mauro, On Fri, Jun 9, 2017 at 9:10 AM, Kevin Hilman <khil...@baylibre.com> wrote: > The davinci VPIF is a single hardware block, but the existing driver > is broken up into a common library (vpif.c), output (vpif_display.c) and > intput (vpif_capture.c). > >

[PATCH v2] [media] davinci: vpif: adaptions for DT support

the platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- Changes since v1: - added proper error checking to kzalloc calls - rebased onto media/master drivers/media/platform/d

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: > On 07/06/17 01:37, Kevin Hilman wrote: >> Enable getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) >> am437x-vpfe.c

Re: [PATCH 0/4] [media] davinci: vpif_capture: raw camera support

On Tue, Jun 6, 2017 at 1:34 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: > Hi Kevin, > > On 02/06/17 23:34, Kevin Hilman wrote: >> This series fixes/updates the support for raw camera input to the VPIF. >> >> Tested on da850-evm boards using the add-on UI boar

[PATCH v2 4/4] [media] davinci: vpif: adaptions for DT support

the platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 49 ++- 1 file changed, 48 insertions(+), 1 de

[PATCH v2 3/4] [media] davinci: vpif_capture: cleanup raw camera support

, and also tested that composite video input still works from ti,tvp514x decoder. Both tests done on the da850-evm board with the add-on UI board. NOTE: Will need further testing for other sensors with different bus formats. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers

[PATCH v2 0/4] [media] davinci: vpif_capture: raw camera support

=0virtualkey0virtualkeyMT9V032C12STCH-GEVB Kevin Hilman (4): [media] davinci: vpif_capture: drop compliance hack [media] davinci: vpif_capture: get subdevs from DT when available [media] davinci: vpif_capture: cleanup raw camera support [media] davinci: vpif: adaptions for DT support drivers/media

[PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

Enable getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 126 +- drivers/media/pl

[PATCH v2 1/4] [media] davinci: vpif_capture: drop compliance hack

. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 128e92d1dd5a..fc5c76

[PATCH 0/4] [media] davinci: vpif_capture: raw camera support

], as this was the only camera board with the right connector for the da850-evm UI board. Verified that composite video capture is still working well after these updates. [1] http://www.mouser.com/search/ProductDetail.aspx?R=0virtualkey0virtualkeyMT9V032C12STCH-GEVB Kevin Hilman (4): [media] davinci

[PATCH 4/4] [media] davinci: vpif: adaptions for DT support

the platform_devices for the display and capture platform_drivers. [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 49 ++- 1 file changed, 48 insertions(+), 1 de

[PATCH 1/4] [media] davinci: vpif_capture: drop compliance hack

. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 128e92d1dd5a..fc5c76

[PATCH 3/4] [media] davinci: vpif_capture: cleanup raw camera support

, and also tested that composite video input still works from ti,tvp514x decoder. Both tests done on the da850-evm board with the add-on UI board. NOTE: Will need further testing for other sensors with different bus formats. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers

[PATCH 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

Enable getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 126 +- drivers/media/pl

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

of OMAP-L138 > Technical Reference Manual, SPRUH77A. > > The VPIF driver incorrectly sets the default format > to V4L2_PIX_FMT_YUV422P. Fix it. > > Reported-by: Alejandro Hernandez <ajhernan...@ti.com> > Signed-off-by: Sekhar Nori <nsek...@ti.com> Acked-by: Kevin Hilman <khil...@baylibre.com>

Re: [PATCH] ARM64: defconfig: enable IR core, decoders and Meson IR device

Neil Armstrong writes: > This patch enables the MEDIA Infrared RC Decoders and Meson Infrared > decoder for ARM64 defconfig. > These drivers are selected as modules by default. > > Signed-off-by: Neil Armstrong > --- >

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

Kevin Hilman <khil...@baylibre.com> writes: > Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > >> Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > I'll fold this one into the original since it's not yet merged. Oops, Sekhar has alr

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

Kevin Hilman <khil...@baylibre.com> writes: > Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > >> There's a stray tab in da850_vpif_legacy_init(). Remove it. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> > > Fo

Re: [PATCH 07/10] ARM: davinci: fix a whitespace error

Bartosz Golaszewski writes: > There's a stray tab in da850_vpif_legacy_init(). Remove it. > > Signed-off-by: Bartosz Golaszewski Folding into the original, Kevin > --- > arch/arm/mach-davinci/pdata-quirks.c | 2 +- > 1 file changed, 1

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

Sekhar Nori <nsek...@ti.com> writes: > On Tuesday 07 February 2017 11:51 PM, Kevin Hilman wrote: >> Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: >> >>> When we enable vpif capture on the da850-evm we hit a BUG_ON() because >>> the i2c ada

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

Bartosz Golaszewski writes: > Signed-off-by: Bartosz Golaszewski I'll fold this one into the original since it's not yet merged. Kevin > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors

Bartosz Golaszewski <bgolaszew...@baylibre.com> writes: > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Acked-by: Kevin Hilman <khil...@baylibre.com> > --- > arch/arm/boot/dts/da850-evm.dts | 10 +- > 1 file changed, 5 insertions(+),

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

Hi Bartosz, Bartosz Golaszewski writes: > Similarly to vpif capture: we need to register the vpif display driver > and the corresponding adv7343 encoder in pdata-quirks as the DT > support is not complete. > > Signed-off-by: Bartosz Golaszewski

Re: [PATCH 08/10] ARM: davinci: fix the DT boot on da850-evm

v_count = 1; > > - /* EVM (UI card) uses i2c adapter 1 (not default: zero) */ > - if (of_machine_is_compatible("ti,da850-evm")) > - da850_vpif_capture_config.i2c_adapter_id = 1; > - oops, my bad. Acked-by: Kevin Hilman <khil...@baylibre.com> &

Re: [PATCH 10/10] ARM: davinci: add pdata-quirks for da850-evm vpif display

is not complete since there isn't currently a way to define the output_routing in the V4L2 drivers (c.f. s_routing) via DT. > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> minor nit below, otherwise Reviewed-by: Kevin Hilman <khil...@baylibre.com> > --- > arch/

Re: [PATCH 09/10] media: vpif: use a configurable i2c_adapter_id for vpif display

; Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> Acked-by: Kevin Hilman <khil...@baylibre.com> > --- > arch/arm/mach-davinci/board-da850-evm.c | 1 + > drivers/media/platform/davinci/vpif_display.c | 2 +- > include/media/davinci/vpif_types.h

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

On Fri, Dec 16, 2016 at 4:49 PM, Kevin Hilman <khil...@baylibre.com> wrote: > Hans Verkuil <hverk...@xs4all.nl> writes: > >> On 07/12/16 19:30, Kevin Hilman wrote: >>> Prepare the groundwork for adding DT support for davinci VPIF drivers. >>> This seri

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

Hans Verkuil <hverk...@xs4all.nl> writes: > On 07/12/16 19:30, Kevin Hilman wrote: >> Prepare the groundwork for adding DT support for davinci VPIF drivers. >> This series does some fixups/cleanups and then adds the DT binding and >> DT compatible str

[PATCH v6.1 1/5] [media] davinci: VPIF: fix module loading, init errors

Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- Minor tweaks since v6

Re: [PATCH v6 1/5] [media] davinci: VPIF: fix module loading, init errors

Hans Verkuil <hverk...@xs4all.nl> writes: > On 07/12/16 19:30, Kevin Hilman wrote: >> Fix problems with automatic module loading by adding MODULE_ALIAS. Also >> fix various load-time errors cause by incorrect or not present >> platform_data. >> >

Re: [PATCH v6 0/5] davinci: VPIF: add DT support

Hi Javier, Javier Martinez Canillas <jav...@dowhile0.org> writes: > On Wed, Dec 7, 2016 at 3:30 PM, Kevin Hilman <khil...@baylibre.com> wrote: >> Prepare the groundwork for adding DT support for davinci VPIF drivers. >> This series does some fixups/cleanups and then ad

[PATCH v6 2/5] [media] davinci: vpif_capture: remove hard-coded I2C adapter id

Remove hard-coded I2C adapter in favor of getting the ID from platform_data. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 5 - include/media/davinci/vpif_types.h| 1 + 2 files changed, 5 insertions(+), 1 deletion(-)

[PATCH v6 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

this list, and update the irqlock comment to reflect what it actually protects. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/medi

[PATCH v6 4/5] [media] dt-bindings: add TI VPIF documentation

Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../devicetree/bindings/media/ti,da850-vpif.txt| 83 ++ 1 file changed, 83 insertions(+)

[PATCH v6 1/5] [media] davinci: VPIF: fix module loading, init errors

Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 5 - drivers/media/platform/d

[PATCH v6 0/5] davinci: VPIF: add DT support

fixes/updates based on reviews from Sakari Changes since v2: - DT binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (5): [media] davinci: VPIF

[PATCH v6 5/5] [media] davinci: VPIF: add basic support for DT init

Add basic support for initialization via DT Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index f50148

Re: [PATCH v5 4/5] [media] dt-bindings: add TI VPIF documentation

Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 06 Dec 2016 21:08:25 Kevin Hilman wrote: >> Acked-by: Rob Herring <r...@kernel.org> >> Signed-off-by: Kevin Hilman <khil...@baylibre.com&g

Re: [PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 06 Dec 2016 21:08:24 Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disable

Re: [PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Kevin, > > On Tuesday 06 Dec 2016 08:49:38 Kevin Hilman wrote: >> Laurent Pinchart writes: >> > On Tuesday 29 Nov 2016 15:57:09 Kevin Hilman wrote: >> >> Video capture subdevs may be

[PATCH v5 4/5] [media] dt-bindings: add TI VPIF documentation

Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../devicetree/bindings/media/ti,da850-vpif.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt

[PATCH v5 5/5] [media] davinci: VPIF: add basic support for DT init

Add basic support for initialization via DT Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index f50148

[PATCH v5 1/5] [media] davinci: VPIF: fix module loading, init errors

Fix problems with automatic module loading by adding MODULE_ALIAS. Also fix various load-time errors cause by incorrect or not present platform_data. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 5 - drivers/media/platform/d

[PATCH v5 0/5] davinci: VPIF: add DT support

strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (5): [media] davinci: VPIF: fix module loading, init errors [media] davinci: vpif_capture: remove hard-coded I2C adapter id [media] davinci: vpif_capture: fix start/stop streaming locking

[PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking

this list. Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_

[PATCH v5 2/5] [media] davinci: vpif_capture: remove hard-coded I2C adapter id

Remove hard-coded I2C adapter in favor of getting the ID from platform_data. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 5 - include/media/davinci/vpif_types.h| 1 + 2 files changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

On Tue, Dec 6, 2016 at 9:40 AM, Kevin Hilman <khil...@baylibre.com> wrote: > Hans Verkuil <hverk...@xs4all.nl> writes: > >> On 12/01/2016 10:16 AM, Laurent Pinchart wrote: >>> Hello, >>> >>> On Thursday 01 Dec 2016 09:57:31 Sakari Ailus wrote: &

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Hans Verkuil <hverk...@xs4all.nl> writes: > On 12/01/2016 10:16 AM, Laurent Pinchart wrote: >> Hello, >> >> On Thursday 01 Dec 2016 09:57:31 Sakari Ailus wrote: >>> On Wed, Nov 30, 2016 at 04:14:11PM -0800, Kevin Hilman wrote: >>>> Sakari Ailus &l

Re: [PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

Laurent Pinchart <laurent.pinch...@ideasonboard.com> writes: > Hi Kevin, > > Thank you for the patch. > > On Tuesday 29 Nov 2016 15:57:09 Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disable

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Sakari Ailus <sakari.ai...@iki.fi> writes: > Hi Kevin, > > On Wed, Nov 23, 2016 at 03:25:32PM -0800, Kevin Hilman wrote: >> Hi Sakari, >> >> Sakari Ailus <sakari.ai...@iki.fi> writes: >> >> > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevi

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Sakari Ailus <sakari.ai...@iki.fi> writes: > Hi Rob and Kevin, > > On Tue, Nov 29, 2016 at 08:41:44AM -0600, Rob Herring wrote: >> On Mon, Nov 28, 2016 at 4:30 PM, Kevin Hilman <khil...@baylibre.com> wrote: >> > Hi Rob, >> > >> > Rob Herri

[PATCH v4 1/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH v4 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 138 +- include/media/d

[PATCH v4 4/4] [media] dt-bindings: add TI VPIF documentation

Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../devicetree/bindings/media/ti,da850-vpif.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt diff --git a/Documentation/devicetree/bi

[PATCH v4 0/4] davinci: VPIF: add DT support

binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: vpif_capture: don't lock over s_stream [media] davinci: VPIF: add basic

[PATCH v4 2/4] [media] davinci: VPIF: add basic support for DT init

. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 48 ++- drivers/media/platform/davinci/vpif_capture.c | 6 drivers/media/platform/davinci/vpif_display.c | 6 3 files changed, 59 insertions(+), 1 de

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Hi Rob, Rob Herring <r...@kernel.org> writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman <khil...@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >>

Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Rob Herring <r...@kernel.org> writes: > On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote: >> Signed-off-by: Kevin Hilman <khil...@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >> ++ >

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

On Fri, Nov 18, 2016 at 4:32 PM, Kevin Hilman <khil...@baylibre.com> wrote: > Cc: Rob Herring <r...@kernel.org> > Signed-off-by: Kevin Hilman <khil...@baylibre.com> > --- > .../devicetree/bindings/media/ti,vpif-capture.txt | 65 > ++ &g

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Hi Sakari, Sakari Ailus <sakari.ai...@iki.fi> writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capt

Re: [PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Hi Sakari, Sakari Ailus <sakari.ai...@iki.fi> writes: > On Tue, Nov 22, 2016 at 07:52:43AM -0800, Kevin Hilman wrote: >> Allow getting of subdevs from DT ports and endpoints. >> >> The _get_pdata() function was larely inspired by (i.e. stolen from) > > vpif_capt

[PATCH v3 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/d

[PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation

Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/me

[PATCH v3 1/4] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[PATCH v3 0/4] [media] davinci: VPIF: add DT support

Add DT support, including getting subdevs from DT ports/endpoints. Changes since v2: - DT binding doc: fix example to use correct compatible Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4

[PATCH v3 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

Hans Verkuil <hverk...@xs4all.nl> writes: > On 22/11/16 02:44, Kevin Hilman wrote: >> Cc: Rob Herring <r...@kernel.org> >> Signed-off-by: Kevin Hilman <khil...@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 >>

[PATCH v2 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/d

[PATCH v2 4/4] [media] dt-bindings: add TI VPIF documentation

Cc: Rob Herring <r...@kernel.org> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,da850-vpif.txt| 8 +++ 2 files changed, 73 insertions(+) create

[PATCH v2 1/4] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[PATCH v2 0/4] [media] davinci: VPIF: add DT support

Add DT support, including getting subdevs from DT ports/endpoints. Changes since v1: - more specific compatible strings, based on SoC: ti,da850-vpif* - fix locking bug when unlocking over subdev s_stream Kevin Hilman (4): [media] davinci: add support for DT init [media] davinci: vpif_capture

[PATCH v2 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

Re: [PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Hans Verkuil <hverk...@xs4all.nl> writes: > On 19/11/16 01:32, Kevin Hilman wrote: >> Video capture subdevs may be over I2C and may sleep during xfer, so we >> cannot do IRQ-disabled locking when calling the subdev. >> >> Signed-off-by: Kevin Hilman <khil...@ba

Re: [PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

Arnd Bergmann <a...@arndb.de> writes: > On Friday, November 18, 2016 4:32:08 PM CET Kevin Hilman wrote: >> + >> +Required properties: >> +- compatible: must be "ti,vpif-capture" >> +- reg: physical base address and length of the registers set for the d

[PATCH 3/4] [media] davinci: vpif_capture: get subdevs from DT

Allow getting of subdevs from DT ports and endpoints. The _get_pdata() function was larely inspired by (i.e. stolen from) am437x-vpfe.c Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 130 +- include/media/d

[PATCH 4/4] [media] dt-bindings: add TI VPIF documentation

Cc: Rob Herring <r...@kernel.org> Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- .../devicetree/bindings/media/ti,vpif-capture.txt | 65 ++ .../devicetree/bindings/media/ti,vpif.txt | 8 +++ 2 files changed, 73 insertions(+) create mode 100644 D

[PATCH 1/4] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[PATCH 2/4] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/d

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

Hans Verkuil <hverk...@xs4all.nl> writes: > Hi Kevin, > > On 10/26/2016 01:55 AM, Kevin Hilman wrote: >> This series attempts to add DT support to the davinci VPIF capture >> driver. >> >> I'm not sure I've completely grasped the proper use of the po

Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support

Kevin Hilman <khil...@baylibre.com> writes: > This series attempts to add DT support to the davinci VPIF capture > driver. > > I'm not sure I've completely grasped the proper use of the ports and > endpoints stuff, so this RFC is primarily to get input on whether I'm

[RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT

osed to be done via DT? Not-Yet-Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 132 +- include/media/davinci/vpif_types.h| 9 +- 2 files changed, 134 insertions(+), 7 deletions(-) diff --git a/dri

[RFC PATCH 4/6] ARM: dts: davinci: da850-lcdk: enable VPIF capture

Enable video capture via the on-board TVP5147 decoder hooked up to ch0 one of the VPIF capture input. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- arch/arm/boot/dts/da850-lcdk.dts | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/bo

[RFC PATCH 2/6] ARM: davinci: da8xx: VPIF: enable DT init

Add basic support for DT initializaion of VPIF (capture) via DT. Clocks and mux still need to happen in this file until there are real clock and pinctrl drivers, but the video nodes and subdevs can all come from DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- arch/arm/mach-d

[RFC PATCH 1/6] [media] davinci: add support for DT init

Add basic support for initialization via DT. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif.c | 9 + drivers/media/platform/davinci/vpif_capture.c | 14 ++ 2 files changed, 23 insertions(+) diff --git a/drivers

[RFC PATCH 5/6] [media] davinci: vpif_capture: don't lock over s_stream

Video capture subdevs may be over I2C and may sleep during xfer, so we cannot do IRQ-disabled locking when calling the subdev. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- drivers/media/platform/davinci/vpif_capture.c | 4 1 file changed, 4 insertions(+) diff --git a/d

[RFC PATCH 3/6] ARM: dts: davinci: da850: add VPIF

Add VPIF and VPIF capture nodes to da850. Note that these are separate nodes because the current media drivers have two separate drivers for vpif and vpif_capture. Signed-off-by: Kevin Hilman <khil...@baylibre.com> --- arch/arm/boot/dts/da850.dtsi | 28

Re: [PATCH 3/5] [media] rc: meson-ir: Fix module autoload

T*Camlogic,meson-gxbb-irC* > alias: of:N*T*Camlogic,meson-gxbb-ir > alias: of:N*T*Camlogic,meson8b-irC* > alias: of:N*T*Camlogic,meson8b-ir > alias: of:N*T*Camlogic,meson6-irC* > alias: of:N*T*Camlogic,meson6-ir > > Signed-off-by: J

Re: [PATCH v5 0/6] Add Meson 8b / GXBB support to the IR driver

Martin Blumenstingl writes: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register. Without the changes to the > meson-ir driver

Re: [PATCH v4 4/6] media: rc: meson-ir: Add support for newer versions of the IR decoder

new bindings so the driver knows which register has to be > used. > > Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> > Signed-off-by: Martin Blumenstingl <martin.blumensti...@googlemail.com> Acked-by: Kevin Hilman <khil...@baylibre.com> Mauro, are you t

Re: [PATCH v4 1/6] pinctrl: amlogic: gxbb: add the IR remote pin

O_5, 0) }; > > +static const unsigned int ir_in_ao_pins[] = {PIN(GPIOAO_7, 0) }; > + I'm trying to keep the names here so they match the datasheet, which calls this remote_input_ao. Please update throughout the patch. Otherwise looks good to me. Feel free to add Reviewed-by: Kevin Hilman &l

Re: [PATCH v3 0/4] Add Meson 8b / GXBB support to the IR driver

Hi Martin, On Tue, Jun 28, 2016 at 12:17 PM, Martin Blumenstingl wrote: > Newer Amlogic platforms (Meson 8b and GXBB) use a slightly different > register layout for their Infrared Remoete Controller. The decoder mode > is now configured in another register.

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

Hi Sakari, Sakari Ailus sakari.ai...@iki.fi writes: The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to the actual CSI-2 receivers outside the ISP itself. Allow changing this configuration from the ISP driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi These

Re: [PATCH v2 1/2] omap3: Provide means for changing CSI2 PHY configuration

Sakari Ailus sakari.ai...@iki.fi writes: Hi Kevin, Thanks for the comments! On Tue, Oct 09, 2012 at 01:50:04PM -0700, Kevin Hilman wrote: Hi Sakari, Sakari Ailus sakari.ai...@iki.fi writes: The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to the actual CSI-2

Re: [PATCH v2 05/11] OMAP4: Add base addresses for ISS

Sergio Aguirre saagui...@ti.com writes: NOTE: This isn't the whole list of features that the ISS supports, but the only ones supported at the moment. Signed-off-by: Sergio Aguirre saagui...@ti.com [...] diff --git a/arch/arm/plat-omap/include/plat/omap44xx.h

Re: [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections

+Benoit, Aguirre, Sergio saagui...@ti.com writes: Hi Vaibhav, Thanks for the comments. On Thu, Dec 1, 2011 at 12:34 AM, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of

Re: [PATCH v2 04/11] OMAP4: hwmod: Include CSI2A and CSIPHY1 memory sections

Aguirre, Sergio saagui...@ti.com writes: [...] Also, work with Benoit to make sure at the scripts that autogenerate this data are updated to include these two regions. Ok. As a side note, I might need more addresses for the rest of the ISP components later on. I'll enable more subsystems

Re: [PATCH v3 2/4] OMAP4: hwmod data: add mmu hwmod for ipu and dsp

Ramirez Luna, Omar omar.rami...@ti.com writes: Hi, On Fri, Nov 4, 2011 at 6:23 PM, Kevin Hilman khil...@ti.com wrote: +     .flags          = HWMOD_INIT_NO_RESET, Why is this needed? ... +     .flags          = HWMOD_INIT_NO_RESET, And this? I have this because the hwmod complains

  1   2   >