Re: [PATCH v3] media: davinci vpbe: array underflow in vpbe_enum_outputs()

davinci vpbe: VPBE display driver") > Signed-off-by: Dan Carpenter > --- > v2: fix it a different way > v3: change everything to unsigned because that's the right thing to do > and looks nicer. > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > diff --git a/

Re: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

by: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > drivers/media/platform/am437x/am437x-vpfe.c| 6 +++--- For above: Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

Re: [PATCH 4/7] media: davinci: fix kernel-doc warnings

c:1750: warning: No > description found for parameter 'dev' > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > drivers/media/platform/davinci/vpif_capture.c | 27 > ++- > drivers/media/platform/davinci/vpif_display.c | 16 > 2 files changed, 22 insertions(+), 21 deletions(-) > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Regards, --Prabhakar Lad

Re: [PATCH 06/12] media: vpif: don't generate a kernel-doc warning on a constant

nnot understand > function prototype: 'const struct vpif_channel_config_params vpif_ch_params[] > = ' > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > drivers/media/platform/davinci/vpif.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH v2 12/26] media: davinci: fix a debug printk

--- > drivers/media/platform/davinci/vpif_capture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

Re: [PATCH 3/3] [media] DaVinci-VPBE-Display: Adjust 12 checks for null pointers

coding: 8bit > > The script “checkpatch.pl” pointed information out like the following. > > Comparison to NULL could be written … > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

Re: [PATCH 2/3] [media] DaVinci-VPBE-Display: Improve a size determination in two functions

parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

Re: [PATCH 1/3] [media] DaVinci-VPBE-Display: Delete an error message for a failed memory allocation in init_vpbe_layer()

This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

Re: [PATCH 2/3] [media] davinci: constify platform_device_id

gt; const. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

[v4] media: platform: davinci: return -EINVAL for VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

returns -EINVAL and backport this patch as far as possible. Fixes: 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture driver") Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++

Re: [PATCH] media: Convert to using %pOF instead of full_name

ff-by: Rob Herring <r...@kernel.org> > Cc: Kyungmin Park <kyungmin.p...@samsung.com> > Cc: Andrzej Hajda <a.ha...@samsung.com> > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: "Lad, Prabhakar" <prabhakar.cse...@gmail.com> > Cc: Songjun Wu <s

[v3 2/2] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

as both the __user pointer for input and pass it through phys_to_virt to come up with a kernel pointer to copy the data to. This looks like a trivially exploitable root hole. Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> --- drivers/media/platform/davinci/ccdc_hw_device.h

[v3 0/2] media: platform: davinci: remove VPFE_CMD_S_CCDC_RAW_PARAMS IOCTL

changes would produce conflicts, just applying this patch would produce build warning of unused functions. [2] commit 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture driver") Lad, Prabhakar (2): media: platform: davinci: prepare f

[v3 1/2] media: platform: davinci: prepare for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

vpfe capture driver") Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/

[PATCH v2 0/2] media: platform: davinci: remove VPFE_CMD_S_CCDC_RAW_PARAMS IOCTL

changes would produce conflicts, just applying this patch would produce build warning of unused functions. [2] commit 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture driver") Lad, Prabhakar (2): media: platform: davinci: prepare f

[PATCH v2 1/2] media: platform: davinci: prepare for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

preparing for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl having minimalistic code changes so as it can be applied for backports. Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++ 1 file changed, 2 inse

[PATCH v2 2/2] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

For dm355 and dm644x the vpfe driver provided a ioctl to configure the raw bayer config using a IOCTL, but since the code was not properly implemented and aswell the IOCTL was marked as 'experimental ioctl that will change in future kernels', dropping this IOCTL. Signed-off-by: Lad, Prabhakar

Re: [PATCH] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

Hi Arnd, On Fri, Jun 30, 2017 at 11:03 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Fri, Jun 30, 2017 at 11:32 AM, Prabhakar <prabhakar.cse...@gmail.com> > wrote: >> From: "Lad, Prabhakar" <prabhakar.cse...@gmail.com> >> >> For dm355 and dm6

Re: [PATCH] [media] media/platform: add const to v4l2_file_operations structures

lly the above statement should go below --- (after the signoff) so that its not the part of commit message. > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> > --- > drivers/media/platform/davinci/vpbe_display.c | 2 +- > drivers/media/platform/davinci/vpif_capture.c | 2 +-

Re: [PATCH] [media] davinci/dm644x: work around ccdc_update_raw_params trainwreck

Hi Arnd, On Tue, Jun 27, 2017 at 12:08 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Tue, Jun 27, 2017 at 12:13 PM, Sekhar Nori <nsek...@ti.com> wrote: >> On Tuesday 20 June 2017 06:36 PM, Lad, Prabhakar wrote: >>> Hi Arnd, >>> >>> Thanks for th

Re: [PATCH] [media] davinci/dm644x: work around ccdc_update_raw_params trainwreck

Hi Arnd, Thanks for the patch. On Fri, Jun 9, 2017 at 10:36 PM, Arnd Bergmann wrote: > Now that the davinci drivers can be enabled in compile tests on other > architectures, I ran into this warning on a 64-bit build: > > drivers/media/platform/davinci/dm644x_ccdc.c: In function

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

node > will have endpoints defined for its subdevs. Therefore, vpif_probe() > checks for the presence of endpoints, and if detected manually creates > the platform_devices for the display and capture platform_drivers. > > [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt >

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

Hi Kevin, Thanks for the patch. On Fri, Jun 9, 2017 at 2:01 AM, Kevin Hilman wrote: > On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: >> On 07/06/17 01:37, Kevin Hilman wrote: >>> Enable getting of subdevs from DT ports and endpoints. >>> >>> The

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

Signed-off-by: Sekhar Nori <nsek...@ti.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Can you also post a similar patch for vpif_display as well ? Cheers, --Prabhakar Lad

Re: [PATCH] media: vpif: use a configurable i2c_adapter_id for vpif display

inci/vpif_display.c | 2 +- > include/media/davinci/vpif_types.h| 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad

Re: [PATCH] media: platform: constify vb2_ops structures

Hi, Thanks for the patch. On Sat, Jan 21, 2017 at 9:29 AM, Bhumika Goyal wrote: > Declare vb2_ops structures as const as they are only stored in > the ops field of a vb2_queue structure. This field is of type > const, so vb2_ops structures having same properties can be made

Re: [PATCH 00/34] [media] DaVinci-Video Processing: Fine-tuning for several function implementations

++--- > drivers/media/platform/davinci/vpfe_capture.c | 88 - > drivers/media/platform/davinci/vpif_capture.c | 28 > drivers/media/platform/davinci/vpif_display.c | 30 - > 4 files changed, 109 insertions(+), 130 deletions(-) >

Re: [PATCH v2 54/58] i2c: don't break long lines

;"; > } else { > if (m/\"$/) { > if (!m/\\n\"$/) { > $next=$_; > next; > } > } > } > print $_; &g

Re: [PATCH 22/57] [media] davinci: don't break long lines

harder to grep for > strings at the source code. So, join those continuation > lines. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the lin

Re: [PATCH v2.2 10/10] v4l: Add 16-bit raw bayer pixel format definitions

ed before the patch. Rework the > documentation to match that of the other sample depths. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> > --- Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad > Documentation/DocBook/media/v4l/pixfmt-sbggr16

Re: [PATCH 7/9] vpbe_display: convert g/s_crop to g/s_selection.

akar Lad <prabhakar.cse...@gmail.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad > --- > drivers/media/platform/davinci/vpbe_display.c | 65 > +++ > 1 file changed, 37 insertions(+), 28 deletions(-) > &g

Re: [PATCH 03/14] davinci: drop unused control callbacks

..@cisco.com> > Cc: Prabhakar Lad <prabhakar.cse...@gmail.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad > --- > drivers/media/platform/davinci/ccdc_hw_device.h | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/m

Re: [PATCH v2.2 09/10] v4l: 16-bit BGGR is always 16 bits

ari Ailus <sakari.ai...@linux.intel.com> > --- Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad > Documentation/DocBook/media/v4l/pixfmt-sbggr16.xml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/DocBook

Re: [PATCH 6/9] vpfe_capture: convert g/s_crop to g/s_selection.

akar Lad <prabhakar.cse...@gmail.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad > --- > drivers/media/platform/davinci/vpfe_capture.c | 52 > +-- > 1 file changed, 34 insertions(+), 18 deletions(-) > &g

Re: [PATCH 2/2] [media] tvp5150: propagate I2C write error in .s_register callback

inez Canillas <jav...@osg.samsung.com> > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad > --- > > drivers/media/i2c/tvp5150.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/med

Re: [PATCH 1/2] [media] tvp5150: return I2C write operation failure to callers

sistent with tvp5150_read() and also because it's called > in a lot of places, so making inline is in fact counter productive > since it makes the kernel image size to be much bigger (~16 KiB). > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Lad, Prabh

Re: [PATCHv4 06/13] staging/media: convert drivers to use the new vb2_queue dev field

Hi Hans, On Sat, Apr 23, 2016 at 12:03 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil <hans.verk...@cisco.com> >

Re: [PATCHv3 05/12] staging/media: convert drivers to use the new vb2_queue dev field

Hi Hans, Thanks for the patch. On Fri, Apr 22, 2016 at 9:38 AM, Hans Verkuil <hverk...@xs4all.nl> wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil <hans.verk...@ci

Re: [PATCHv4 07/13] media/platform: convert drivers to use the new vb2_queue dev field

Hi Hans, Thanks for the patch. On Sat, Apr 23, 2016 at 12:03 PM, Hans Verkuil <hverk...@xs4all.nl> wrote: > From: Hans Verkuil <hans.verk...@cisco.com> > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil <hans.verk...@ci

Re: [PATCH v6 0/2] media: Add entity types

> > > Laurent Pinchart (2): > media: Add obj_type field to struct media_entity > media: Rename is_media_entity_v4l2_io to > is_media_entity_v4l2_video_device > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad -- To unsubscribe fr

Re: [PATCH] [media] media: am437x-vpfe: ensure ret is initialized

Hi Colin, On Mon, Mar 21, 2016 at 11:32 PM, Colin King wrote: > From: Colin Ian King > > ret should be initialized to 0; for example if pfe->fmt.fmt.pix.field > is V4L2_FIELD_NONE then ret will contain garbage from the > uninitialized state

Re: [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index

conversion, and it's > clear that the comparison was meant to compare the iterator > to the current subdev instead, as we do in the line above. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: d37232390fd4 ("[media] media: am437x-vpfe: match the OF node/i2c addr >

Re: [patch] [media] am437x-vpfe: fix an uninitialized variable bug

rt for AM437X') > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.k

Re: [PATCH 4/8] media: Rename is_media_entity_v4l2_io to is_media_entity_v4l2_video_device

not to check whether > it can perform I/O. Rename it accordingly, we will introduce a more > specific is_media_entity_v4l2_io() check when needed. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.c

Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

On Wed, Jan 6, 2016 at 4:34 PM, Al Viro <v...@zeniv.linux.org.uk> wrote: > On Tue, Jan 05, 2016 at 05:37:06PM +0000, Lad, Prabhakar wrote: >> On Sun, Dec 13, 2015 at 12:32 AM, Al Viro <v...@zeniv.linux.org.uk> wrote: >> > Passing a physical address

Re: [PATCH] media: i2c: ov2659: speedup probe if no device connected

9 declared as I2C_CLIENT_SCCB and NACKs > are ignored in this case). > > Let's fix that by checking the chip version first and start > initialization only if it's supported. > > Cc: Benoit Parrot <bpar...@ti.com> > Signed-off-by: Grygorii Strashko <grygorii.stras...@t

Re: [PATCH] media: use unsigned for pad index

Mauro Carvalho Chehab <mche...@osg.samsung.com> > --- > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +- > drivers/staging/media/davinci_vpfe/dm365_isif.c| 2 +- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- For the above: Acked-by: Lad, Prabhakar <prabh

Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

e_pages() > is its phys_to_virt(). ccdc_close() does that properly, but > ccdc_update_raw_params() doesn't. > > Signed-off-by: Al Viro <v...@zeniv.linux.org.uk> > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Regards, --Prabhakar Lad > diff --git a/drivers/media/p

Re: [PATCH] [media] davinci: add i2c Kconfig dependencies

i/vpif_display.c:1298:14: error: implicit declaration of > function 'i2c_get_adapter' [-Werror=implicit-function-declaration] > > This adds explicit Kconfig dependencies so we don't see the > driver options if I2C is turned off. > > Signed-off-by: Arnd Bergmann <a...@arndb.de

Re: [GIT PULL FOR v4.5] Davinci staging fixes

Hi Mauro, On Tue, Nov 17, 2015 at 4:29 PM, Mauro Carvalho Chehab wrote: > Em Mon, 09 Nov 2015 23:27:02 +0200 > Laurent Pinchart escreveu: > >> Hi Mauro, >> >> I've collected the pending Davinci staging fixes from patchwork and prepared

Re: [PATCH] [media] i2c: constify v4l2_ctrl_ops structures

ll <julia.law...@lip6.fr> > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.com> Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] tvp5150: add support for asynchronous probing

On Mon, Sep 21, 2015 at 12:23 PM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > Allow the subdevice to be probed asynchronously. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> > Acked-by: Lad, Prabhakar <prabhakar.cse...@gmail.co

Re: drivers/media/platform/am437x/am437x-vpfe.c:1698: bad test ?

Hi David, On Mon, Aug 3, 2015 at 3:02 PM, David Binderman dcb...@hotmail.com wrote: Hello there, drivers/media/platform/am437x/am437x-vpfe.c:1698:27: warning: self-comparison always evaluates to true [-Wtautological-compare] if (client-addr == curr_client-addr

Re: [Patch v3 1/1] media: am437x-vpfe: Fix a race condition during release

: platform: add VPFE capture driver support for AM437X) Cc: sta...@vger.kernel.org # v4.0+ Signed-off-by: Benoit Parrot bpar...@ti.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad --- Changes since v2: - fix the stable commit reference syntax drivers/media

Re: [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting

: platform: add VPFE capture driver support for AM437X) Cc: sta...@vger.kernel.org # v4.0+ Signed-off-by: Benoit Parrot bpar...@ti.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad --- Changes since v2: - fix the stable commit reference syntax drivers/media/platform

Re: [PATCH 08/12] media/i2c/tvp514x: Remove compat control ops

On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: They are no longer used in old non-control-framework bridge drivers. Reported-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Acked-by: Lad

Re: [PATCH 01/12] media/i2c/adv7343: Remove compat control ops

On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: They are no longer used in old non-control-framework bridge drivers. Reported-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Acked-by: Lad

Re: [PATCH 09/12] media/i2c/tvp7002: Remove compat control ops

On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: They are no longer used in old non-control-framework bridge drivers. Reported-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Acked-by: Lad

[PATCH] media: davinci: vpbe: use v4l2_get_timestamp()

From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch makes use of helper function v4l2_get_timestamp() to set the timestamp of vb2 buffer. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/platform/davinci/vpbe_display.c | 9 ++--- 1 file changed, 2 insertions

[PATCH 0/3] davinci_vpfe: minor cleanups

From: Lad, Prabhakar prabhakar.cse...@gmail.com Hi Hans, These patch series includes minor cleanups for davinci vpfe driver. Lad, Prabhakar (3): media: davinci_vpfe: clear the output_specs media: davinci_vpfe: set minimum required buffers to three media: davinci_vpfe: use monotonic

[PATCH 1/3] media: davinci_vpfe: clear the output_specs

From: Lad, Prabhakar prabhakar.cse...@gmail.com clear of the output_specs before passing it to the configure_resizer_out_params(), so that no garbage values are set. This fixes following build warning: drivers/staging/media/davinci_vpfe/dm365_resizer.c: In function 'resizer_set_stream': drivers

[PATCH 3/3] media: davinci_vpfe: use monotonic timestamp

From: Lad, Prabhakar prabhakar.cse...@gmail.com V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 3 ++- 1 file changed

[PATCH 2/3] media: davinci_vpfe: set minimum required buffers to three

From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch sets nbuffers to three or more and drops the unset member video_limit which just a copy paste from earlier driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.h | 2

Re: [PATCH 1/2] usb drivers: use BUG_ON() instead of if () BUG

should convert them to use VB2, in order to avoid those crappy things. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH] [media] ov2659: add v4l2_subdev dependency

Hi Arnd, Thanks for the patch. On Tue, May 19, 2015 at 1:39 PM, Arnd Bergmann a...@arndb.de wrote: The newly added ov2659 driver uses the v4l2 subdev API, but can be enabled even when that API is not part of the kernel, resulting in this build error: media/i2c/ov2659.c: In function

[PATCH] media: v4l2-core/v4l2-of.c: determine bus_type only on hsync/vsync flags

From: Lad, Prabhakar prabhakar.cse...@gmail.com the bus_type needs to be determined only on the hsync/vsync flags, this patch fixes the above by moving the check just after hsync/vsync flags are being set. Reported-by: Nikhil Devshatwar nikhil...@ti.com Signed-off-by: Lad, Prabhakar

Re: [PATCH] ov2659: Don't depend on subdev API

...@osg.samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek mkube...@suse.cz wrote: On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: This fixes a checkpatch style error in vpfe_buffer_queue_setup. Signed-off-by: Alex Dowad alexinbeij...@gmail.com ---

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

Hi Hans, On Mon, May 18, 2015 at 9:15 AM, Hans Verkuil hverk...@xs4all.nl wrote: On 05/18/2015 10:06 AM, Lad, Prabhakar wrote: On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek mkube...@suse.cz wrote: On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: This fixes a checkpatch style

Re: [PATCH v4 00/17] media: blackfin: bfin_capture enhancements

Hi Scott, On Tue, May 5, 2015 at 10:58 AM, Scott Jiang scott.jiang.li...@gmail.com wrote: 2015-04-24 18:04 GMT+08:00 Hans Verkuil hverk...@xs4all.nl: On 04/10/2015 12:42 PM, Scott Jiang wrote: Hi Hans, Hans, I tried to use v4l2-compliance but it failed to compile. Sorry for telling you it

Re: [PATCH 09/14] zoran: fix indent

be recovered from git logs. Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 18/27] cx25840: fix bad identing

On Thu, Apr 30, 2015 at 12:06 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: drivers/media/i2c/cx25840/cx25840-core.c:974 input_change() warn: inconsistent indenting Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Re: [PATCH 1/3] am437x-vpfe: really update the vpfe_ccdc_update_raw_params data

...@ti.com Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 2/3] am437x: Fix a wrong identation

-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] am437x: remove unused variable

-variable] struct vpfe_subdev_info *sdinfo; ^ Cc: Benoit Parrot bpar...@ti.com Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line

Re: [media] i2c: ov2659: signedness bug inov2659_set_fmt()

Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c index edebd11..d700a1d 100644 --- a/drivers/media/i2c/ov2659.c +++ b/drivers/media/i2c/ov2659.c @@ -1102,7 +1102,7 @@ static int ov2659_set_fmt

Re: [PATCH 1/7] v4l2: replace enum_mbus_fmt by enum_mbus_code

| 16 + drivers/media/i2c/tvp514x.c| 20 drivers/media/i2c/tvp7002.c| 20 For the above 2, Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad drivers/media/i2c/vs6624.c

Re: [PATCH 6/7] v4l2: replace s_mbus_fmt by set_fmt in bridge drivers

/pvrusb2/pvrusb2-hdw.c| 17 +++--- include/media/v4l2-subdev.h| 8 --- 25 files changed, 256 insertions(+), 222 deletions(-) for am437x Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad

Re: [PATCH 2/7] v4l2: replace video op g_mbus_fmt by pad op get_fmt

--- drivers/media/platform/am437x/am437x-vpfe.c| 6 +-- drivers/media/platform/davinci/vpfe_capture.c | 19 For the above, Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe

[PATCH v2] media: i2c: ov2659: Use v4l2_of_alloc_parse_endpoint()

From: Lad, Prabhakar prabhakar.cse...@gmail.com Instead of parsing the link-frequencies property in the driver, let v4l2_of_alloc_parse_endpoint() do it. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Acked-by: Sakari Ailus sakari.ai...@iki.fi --- Changes for v2: a: Ignoring

Re: [PATCH] media: i2c: ov2659: Use v4l2_of_alloc_parse_endpoint()

Hi Sakari, Thanks for the review. On Sat, Apr 11, 2015 at 1:48 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, On Fri, Apr 10, 2015 at 11:13:28PM +0100, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Instead of parsing the link-frequencies property

[PATCH] media: i2c: ov2659: add VIDEO_V4L2_SUBDEV_API dependency

From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch adds dependency of VIDEO_V4L2_SUBDEV_API for VIDEO_OV2659 so that it doesn't complain for random config builds. Reported-by: Randy Dunlap rdun...@infradead.org Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media

Re: [PATCH v4 4/4] smiapp: Use v4l2_of_alloc_parse_endpoint()

) if (!ep) return NULL; + bus_cfg = v4l2_of_alloc_parse_endpoint(ep); + if (IS_ERR(bus_cfg)) { + rval = PTR_ERR(bus_cfg); this assignment is not required. Apart from that the patch looks good. Reviewed-by: Lad, Prabhakar prabhakar.cse...@gmail.com

[PATCH] media: i2c: ov2659: Use v4l2_of_alloc_parse_endpoint()

From: Lad, Prabhakar prabhakar.cse...@gmail.com Instead of parsing the link-frequencies property in the driver, let v4l2_of_alloc_parse_endpoint() do it. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- This patch depends on https://patchwork.kernel.org/patch/6190901/ drivers

Re: [PATCH v4 3/4] v4l: of: Parse variable length properties --- link-frequencies

, and the result is stored to struct v4l2_of_endpoint field link_frequencies. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad --- drivers/media/v4l2-core/v4l2-of.c

Re: [PATCH v4 2/4] v4l: of: Instead of zeroing bus_type and bus field separately, unify this

...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad --- drivers/media/v4l2-core/v4l2-of.c |5 +++-- include/media/v4l2-of.h |1 + 2 files changed, 4 insertions(+), 2 deletions

Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

On Fri, Mar 20, 2015 at 12:05 PM, Varka Bhadram varkabhad...@gmail.com wrote: On 03/20/2015 05:18 PM, Lad Prabhakar wrote: From: Benoit Parrot bpar...@ti.com this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT

[PATCH v10] media: i2c: add support for omnivision's ov2659 sensor

From: Benoit Parrot bpar...@ti.com this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Lad, Prabhakar prabhakar.cse

Re: [PATCH v7] media: i2c: add support for omnivision's ov2659 sensor

Hi Sakari, Thanks for the review. On Wed, Mar 18, 2015 at 10:13 PM, Sakari Ailus sakari.ai...@linux.intel.com wrote: Hi Prabhakar, Lad Prabhakar wrote: ... +static int ov2659_g_volatile_ctrl(struct v4l2_ctrl *ctrl) +{ + struct ov2659 *ov2659 = + container_of

Re: [PATCH v6] media: i2c: add support for omnivision's ov2659 sensor

Hi Hans, Thanks for the review. On Mon, Mar 16, 2015 at 9:24 AM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, On 03/15/2015 11:34 AM, Lad Prabhakar wrote: From: Benoit Parrot bpar...@ti.com this patch adds support for omnivision's ov2659 sensor, the driver supports following

[PATCH v6] media: i2c: add support for omnivision's ov2659 sensor

From: Benoit Parrot bpar...@ti.com this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Lad, Prabhakar prabhakar.cse

Re: [PATCH v5] media: i2c: add support for omnivision's ov2659 sensor

Hi Sakari, Thanks for the review. On Fri, Mar 13, 2015 at 12:04 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, On Thu, Mar 12, 2015 at 11:22:36PM +, Lad Prabhakar wrote: ... +static int ov2659_probe(struct i2c_client *client, + const struct i2c_device_id

Re: [PATCH v2 2/2] v4l: mt9v032: Add OF support

Hi Laurent, Thanks for the patch. On Fri, Mar 13, 2015 at 12:03 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Parse DT properties into a platform data structure when a DT node is available. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- [snip]

[PATCH v5] media: i2c: add support for omnivision's ov2659 sensor

From: Benoit Parrot bpar...@ti.com this patch adds support for omnivision's ov2659 sensor, the driver supports following features: 1: Asynchronous probing 2: DT support 3: Media controller support Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Lad, Prabhakar prabhakar.cse

Re: [PATCH] v4l: mt9p031: Convert to the gpiod API

Hi Laurent, On Wed, Mar 11, 2015 at 6:29 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Tuesday 10 March 2015 18:29:22 Lad, Prabhakar wrote: On Sun, Mar 8, 2015 at 1:40 PM, Laurent Pinchart wrote: This simplifies platform data and DT integration. Signed

Re: [PATCH v4] media: i2c: add support for omnivision's ov2659 sensor

Hi Laurent, Thanks for the review. On Wed, Mar 11, 2015 at 6:22 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Tuesday 10 March 2015 03:35:57 Sakari Ailus wrote: On Sun, Mar 08, 2015 at 11:33:27AM +, Lad Prabhakar wrote: ... +static struct ov2659_platform_data

Re: [PATCH 2/3] smiapp: Read link-frequencies property from the endpoint node

On Wed, Mar 11, 2015 at 10:25 PM, Lad, Prabhakar prabhakar.cse...@gmail.com wrote: Hi Sakari, Thanks for the patch. On Tue, Mar 10, 2015 at 1:18 AM, Sakari Ailus sakari.ai...@iki.fi wrote: The documentation stated that the link-frequencies property belongs to the endpoint node

Re: [PATCH 1/3] smiapp: Clean up smiapp_get_pdata()

On Wed, Mar 11, 2015 at 10:24 PM, Lad, Prabhakar prabhakar.cse...@gmail.com wrote: Hi Sakari, Thanks for the patch. On Tue, Mar 10, 2015 at 1:18 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Don't set rval when it's not used (the function returns a pointer to struct smiapp_platform_data

Re: [PATCH 3/3] v4l: of: Add link-frequencies array to struct v4l2_of_endpoint

*endpoint) { + int len; + of_graph_parse_endpoint(node, endpoint-base); endpoint-bus_type = 0; memset(endpoint-bus, 0, sizeof(endpoint-bus)); endpoint-link_frequencies = NULL; required here. Apart from that patch looks good. Acked-by: Lad, Prabhakar prabhakar.cse

Re: [PATCH 2/3] smiapp: Read link-frequencies property from the endpoint node

, so a fix in the driver is sufficient. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cheers, --Prabhakar Lad --- drivers/media/i2c/smiapp/smiapp-core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers

  1   2   3   4   5   >