double-buffering with the omap3 parallel interface

2013-06-12 Thread Michael Jones
Hi Laurent co., I'd like to look at what the maximum possible frame rates are for a sensor connected to the OMAP3 ISP CCDC via the parallel interface, writing frames directly to memory. I understand that there is some minimum amount of time required between frames to pass on the finished

omap3isp: timeout in ccdc_disable()

2012-10-02 Thread Michael Jones
Hi Laurent, I am looking at a case where the sensor may stop delivering data, at which point I want to do a STREAMOFF. In this case, the STREAMOFF takes 2s because of the wait_event_timeout() in ccdc_disable(). This wait waits for ccdc-stopping to be CCDC_STOP_FINISHED, which happens in two

Re: Patches submitted via linux-media ML that are at patchwork.linuxtv.org

2012-08-15 Thread Michael Jones
On 08/14/2012 05:21 PM, Laurent Pinchart wrote: Hi Mauro, On Tuesday 14 August 2012 11:28:05 Mauro Carvalho Chehab wrote: Em 14-08-2012 10:46, Hans Verkuil escreveu: That would work if the others would be doing the same. Unfortunately, other usual developers don't do that: they send all

Re: [RFC] omap3-isp G_FMT ENUM_FMT

2012-07-27 Thread Michael Jones
Hi Laurent, On 07/27/2012 01:32 AM, Laurent Pinchart wrote: Hi Michael, On Thursday 26 July 2012 16:22:17 Michael Jones wrote: On 07/26/2012 04:05 PM, Laurent Pinchart wrote: On Thursday 26 July 2012 13:59:54 Michael Jones wrote: Hello, I would like to (re)submit a couple of patches

Re: [RFC] omap3-isp G_FMT ENUM_FMT

2012-07-27 Thread Michael Jones
Hi Laurent, On 07/27/2012 11:35 AM, Laurent Pinchart wrote: On Friday 27 July 2012 11:07:50 Michael Jones wrote: Hi Laurent, On 07/27/2012 01:32 AM, Laurent Pinchart wrote: Hi Michael, [snip] OK, so this sounds like the same behavior I'd like to add before CREATE_BUFS and PREPARE_BUFS

[RFC] omap3-isp G_FMT ENUM_FMT

2012-07-26 Thread Michael Jones
the pr_debug() calls before submitting upstream, but they're useful for testing. [1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg29640.html [2] http://www.mail-archive.com/linux-media@vger.kernel.org/msg40618.html Michael Jones (2): [media] omap3isp: implement ENUM_FMT [media

[PATCH 1/2] [media] omap3isp: implement ENUM_FMT

2012-07-26 Thread Michael Jones
ENUM_FMT will not enumerate all formats that the ISP is capable of, it will only return the format which has been previously configured using the media controller, because this is the only format available to a V4L2 application which is unaware of the media controller. Signed-off-by: Michael

[PATCH 2/2] [media] omap3isp: support G_FMT

2012-07-26 Thread Michael Jones
This allows a V4L2 application which has no knowledge of the media controller to open a video device node of the already-configured ISP and query what it will deliver. Previously, G_FMT only worked after a S_FMT had already been done. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de

Re: [RFC] omap3-isp G_FMT ENUM_FMT

2012-07-26 Thread Michael Jones
Hi Laurent, Thanks for the reply. On 07/26/2012 04:05 PM, Laurent Pinchart wrote: Hi Michael, On Thursday 26 July 2012 13:59:54 Michael Jones wrote: Hello, I would like to (re)submit a couple of patches to support V4L2 behavior at the V4L2 device nodes of the omap3-isp driver, but I'm

[PATCH] v4l2: typos

2012-07-26 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- Documentation/video4linux/v4l2-framework.txt |2 +- drivers/media/video/omap3isp/ispqueue.c |2 +- drivers/media/video/omap3isp/ispresizer.c|6 +++--- drivers/media/video/v4l2-common.c|2

[PATCH] omap3isp: #include videodev2.h in omap3isp.h

2012-07-26 Thread Michael Jones
include/linux/omap3isp.h uses BASE_VIDIOC_PRIVATE from include/linux/videodev2.h but didn't include this file. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- include/linux/omap3isp.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux

Re: [PATCH] Documentation: DocBook DRM framework documentation

2012-07-24 Thread Michael Jones
Hi Laurent, I've used behavior when copying sections from the existing documentation. I'll unify that. Does kernel documentation favour one of the spellings ? Looking at v3.5, the American spelling is more common, but looking at how you spell favour, I think I know which one you favor :)

Re: [PATCH] Documentation: DocBook DRM framework documentation

2012-07-23 Thread Michael Jones
Hi Laurent, At a quick glance I noticed a couple of things: On 07/13/2012 02:00 AM, Laurent Pinchart wrote: [snip] +para + The structnamedrm_driver/structname structure contains static + information that describe the driver and features it supports, and s/describe/describes/

capture_mem limitations in OMAP ISP

2012-07-03 Thread Michael Jones
Hi Laurent co., I'm looking at the memory limitations in the omap3isp driver. 'struct isp_video' contains member 'capture_mem', which is set separately for each of our v4l2 video device nodes. The CCDC, for example, has capture_mem = 4096 * 4096 * 3 = 48MB, while the previewer and resizer

[PATCH] [media] omap3isp: fix dqbuf description comment

2012-06-27 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3isp/ispqueue.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) This comment looks like it was a copy-paste from the description of qbuf. diff --git a/drivers/media/video/omap3isp

Re: reading config parameters of omap3-isp subdevs

2012-03-20 Thread Michael Jones
Hi Laurent, On 03/20/2012 12:22 AM, Laurent Pinchart wrote: Hi Michael, On Friday 16 March 2012 15:06:15 Michael Jones wrote: [snip] Adding a R/W bit to the flag argument should indeed work. However, I'm wondering what your use case for reading parameters back is. The simplest use case

reading config parameters of omap3-isp subdevs

2012-03-16 Thread Michael Jones
Hi all, I am playing around with some parameters in the previewer on the ISP. With ioctl VIDIOC_OMAP3ISP_PRV_CFG I am able to write the various parameters but what I'm missing is a way to read them. For example, I have no way to adjust only coef2 in 'struct omap3isp_prev_wbal' while leaving

Re: Lockup on second streamon with omap3-isp

2012-03-09 Thread Michael Jones
Hi Laurent, On 03/09/2012 11:42 AM, Laurent Pinchart wrote: Hi Jean-Philippe, [snip] From my experience, the ISP doesn't handle free-running sensors very well. There are other things it doesn't handle well, such as sensors stopping in the middle of the frame. I would consider this as

Re: [PATCH v5 09/35] v4l: Add subdev selections documentation

2012-03-07 Thread Michael Jones
Hi Sakari, Hopefully it's not too late to make a few minor suggestions. On 03/06/2012 05:32 PM, Sakari Ailus wrote: Add documentation for V4L2 subdev selection API. This changes also experimental V4L2 subdev API so that scaling now works through selection API only. Signed-off-by: Sakari

Re: Why is the Y12 support 12-bit grey formats at the CCDC input (Y12) is truncated to Y10 at the CCDC output?

2011-12-15 Thread Michael Jones
Hi James, On 12/15/2011 08:14 AM, James wrote: Hi all, I'm using an OMAP3530 board and a monochrome 12-bit grey sensor. Can anyone enlighten me why is the 12-bit grey formats at the CCDC input (Y12) is truncated to Y10 at the CCDC output? There are 2 CCDC outputs: CCDC_PAD_SOURCE_OF and

Re: Why is the Y12 support 12-bit grey formats at the CCDC input (Y12) is truncated to Y10 at the CCDC output?

2011-12-15 Thread Michael Jones
Hi James, On 12/15/2011 10:49 AM, James wrote: Hi Michael, On Thu, Dec 15, 2011 at 3:58 PM, Michael Jones michael.jo...@matrix-vision.de wrote: Hi James, On 12/15/2011 08:14 AM, James wrote: Hi all, I'm using an OMAP3530 board and a monochrome 12-bit grey sensor. Can anyone enlighten

Re: Omap3 ISP + Gstreamer v4l2src

2011-12-07 Thread Michael Jones
Hi Adam, On 12/07/2011 11:34 AM, Laurent Pinchart wrote: Hi Adam, On Wednesday 07 December 2011 09:02:42 Adam Pledger wrote: Hi Laurent, Firstly, please accept my apologies, for what is very probably a naive question. I'm new to V4L2 and am just getting to grips with how things work. No

Re: [beagleboard] Re: [PATCH v7 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-08-22 Thread Michael Jones
Hi Chris, On 08/22/2011 11:41 AM, Laurent Pinchart wrote: Hi Chris, On Monday 22 August 2011 06:12:41 CJ wrote: On 19/08/11 22:12, Laurent Pinchart wrote: I am trying to get the mt9p031 working from nand with a ubifs file system and I am having a few problems. /dev/media0 is not

omap3isp buffer alignment

2011-08-11 Thread Michael Jones
Hi Laurent, If I understood your discussion with Russell [1] correctly, user pointer buffers are required to be page-aligned because of the IOMMU API, and it's desirable to keep the IOMMU driver that way for other subsystems which may use it. So we're stuck with user buffers needing to be

[PATCH v2] [media] omap3isp: queue: fail QBUF if user buffer is too small

2011-08-09 Thread Michael Jones
Add buffer length check to sanity checks for USERPTR QBUF Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- Changes for v2: - only check when V4L2_MEMORY_USERPTR drivers/media/video/omap3isp/ispqueue.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] [media] omap3isp: queue: fail QBUF if buffer is too small

2011-08-08 Thread Michael Jones
Hi Laurent, On 08/08/2011 12:08 PM, Laurent Pinchart wrote: Hi Michael, On Friday 05 August 2011 13:41:54 Michael Jones wrote: On 08/05/2011 10:59 AM, Laurent Pinchart wrote: Hi Michael, Thanks for the patch. On Thursday 04 August 2011 17:40:37 Michael Jones wrote: Add buffer length

Re: ISP CCDC freeze-up on STREAMON

2011-08-05 Thread Michael Jones
Hi Laurent, On 07/20/2011 10:47 AM, Laurent Pinchart wrote: Hi Michael, Sorry for the late reply. Likewise :) On Thursday 30 June 2011 10:31:52 Michael Jones wrote: Hi Laurent, I'm observing a system freeze-up with the ISP when writing data to memory directly from the ccdc

Re: [PATCH] [media] omap3isp: queue: fail QBUF if buffer is too small

2011-08-05 Thread Michael Jones
Hi Laurent, On 08/05/2011 10:59 AM, Laurent Pinchart wrote: Hi Michael, Thanks for the patch. On Thursday 04 August 2011 17:40:37 Michael Jones wrote: Add buffer length to sanity checks for QBUF. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video

[PATCH] [media] omap3isp: queue: fail QBUF if buffer is too small

2011-08-04 Thread Michael Jones
Add buffer length to sanity checks for QBUF. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3isp/ispqueue.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3isp/ispqueue.c b/drivers/media/video/omap3isp

[PATCH] capture-example: don't use bytesperline when allocating buffers

2011-07-18 Thread Michael Jones
fixed. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- contrib/test/capture-example.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/contrib/test/capture-example.c b/contrib/test/capture-example.c index 2f77cbf..417615a 100644 --- a/contrib/test

Re: [RFC PATCH] capture-example: allow V4L2_PIX_FMT_GREY with USERPTR

2011-07-14 Thread Michael Jones
Hi Mauro, On 07/14/2011 12:35 AM, Mauro Carvalho Chehab wrote: Em 28-06-2011 11:23, Michael Jones escreveu: There is an assumption that the format coming from the device needs 2 bytes per pixel, which is not the case when the device delivers e.g. V4L2_PIX_FMT_GREY. This doesn't manifest

Re: [PATCH] v4l: Don't register media entities for subdev device nodes

2011-07-04 Thread Michael Jones
On 04/11/2011 04:26 PM, Laurent Pinchart wrote: Subdevs already have their own entity, don't register as second one when registering the subdev device node. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-dev.c | 15 ++- 1 files

prompt ISP CCDC freeze-up on STREAMON

2011-06-30 Thread Michael Jones
--- yavta.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/yavta.c b/yavta.c index 2a166c6..95976b4 100644 --- a/yavta.c +++ b/yavta.c @@ -485,7 +485,9 @@ static int video_enable(struct device *dev, int enable) int type = dev-type; int ret; +

[PATCH 0/2] media-ctl: minor changes

2011-06-21 Thread Michael Jones
Hi Laurent, These are a couple of commits that I have locally on top of your media-ctl head which I would like to see in your rep. Michael Jones (2): add Y10, Y12 formats try using autoconf 2.61 configure.in |2 +- src/main.c |2 ++ 2 files changed, 3 insertions(+), 1 deletions

[PATCH 1/2] add Y10, Y12 formats

2011-06-21 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- I added these when playing around with the shifter. src/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/main.c b/src/main.c index 35c34a2..b9b9150 100644 --- a/src/main.c +++ b/src/main.c

[PATCH 2/2] allow using autoconf 2.61+

2011-06-21 Thread Michael Jones
Autoconf v2.61 seems to work just fine. Allow it. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- configure.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in index 3f4f35b..fd4c70c 100644 --- a/configure.in +++ b

buffer index when streaming user-ptr buffers

2011-06-14 Thread Michael Jones
In the V4L2 spec, the description for v4l2_buffer.index says This field is only used for memory mapping I/O... However, in v4l-utils/contrib/capture-example.c, even user-pointer buffers are indeed given a buf.index before being passed to VIDIOC_QBUF. And at least in the OMAP ISP driver, this

Re: [RFC/PATCH 1/2] v4l: Add generic board subdev registration function

2011-05-20 Thread Michael Jones
On 05/20/2011 09:29 AM, Laurent Pinchart wrote: [snip] I had an issue when tried to call request_module, to register subdev of platform device type, in probe() of other platform device. Driver's probe() for devices belonging same bus type cannot be nested as the bus lock is taken by the

Re: FW: OMAP 3 ISP

2011-05-19 Thread Michael Jones
On 05/19/2011 03:02 PM, Laurent Pinchart wrote: Hi Alex, On Thursday 19 May 2011 14:51:16 Alex Gershgorin wrote: Thanks Laurent, My video source is not the video camera and performs many other functions. For this purpose I have RS232 port. As for the video, it runs continuously and is not

locking in OMAP ISP subdevs

2011-05-09 Thread Michael Jones
Hi Laurent, I can't find where the locking is handled for ISP subdev standard ioctls like ccdc_v4l2_pad_ops.set_fmt(). Using the CCDC as an example, it looks to me like the following sequence happens when e.g. format is set on CCDC pad 0: 1. # media-ctl --set-format 'OMAP3 ISP CCDC:0 [Y8

Re: [PATCH v4 0/4] omap3isp: lane shifter support

2011-03-30 Thread Michael Jones
Hi Laurent, On 03/29/2011 09:40 PM, Laurent Pinchart wrote: Hi Michael, Thanks for the patches. I've applied them to my tree (http://git.linuxtv.org/pinchartl/media.git?a=shortlog;h=refs/heads/media- next-0001-omap3isp) with modified commit messages. thanks. Could you please check them

[PATCH v4 0/4] omap3isp: lane shifter support

2011-03-29 Thread Michael Jones
changes according to feedback (removed unnecessary tests, etc.) Michael Jones (4): v4l: add V4L2_PIX_FMT_Y12 format media: add 8-bit bayer formats and Y12 omap3isp: ccdc: support Y10/12, 8-bit bayer fmts omap3isp: lane shifter support Documentation/DocBook/media-entities.tmpl|1

[PATCH v4 1/4] v4l: add V4L2_PIX_FMT_Y12 format

2011-03-29 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- Documentation/DocBook/media-entities.tmpl |1 + Documentation/DocBook/v4l/pixfmt-y12.xml | 79 + Documentation/DocBook/v4l/pixfmt.xml |1 + include/linux/videodev2.h |1

[PATCH v4 3/4] omap3isp: ccdc: support Y10/12, 8-bit bayer fmts

2011-03-29 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3isp/ispccdc.c |6 ++ drivers/media/video/omap3isp/ispvideo.c | 12 2 files changed, 18 insertions(+), 0 deletions(-) diff

[PATCH v4 2/4] media: add 8-bit bayer formats and Y12

2011-03-29 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- Documentation/DocBook/v4l/subdev-formats.xml | 59 ++ include/linux/v4l2-mediabus.h|7 ++- 2 files changed, 64 insertions(+), 2 deletions(-) diff --git a/Documentation/DocBook/v4l/subdev

[PATCH v4 4/4] omap3isp: lane shifter support

2011-03-29 Thread Michael Jones
To use the lane shifter, set different pixel formats at each end of the link at the CCDC input. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3isp/isp.c |7 ++- drivers/media/video/omap3isp/isp.h |5 +- drivers/media/video/omap3isp

[PATCH] ignore Documentation/DocBook/media/

2011-03-25 Thread Michael Jones
It only contains generated files Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Re-sending this because patchwork didn't catch it the first time. Documentation/DocBook/.gitignore |1 + 1 files changed, 1

Re: [PATCH] omap3isp: implement ENUM_FMT

2011-03-25 Thread Michael Jones
Hi Sakari, On 03/24/2011 09:04 AM, Sakari Ailus wrote: Michael Jones wrote: Hi Sakari, Hi Michael, On 03/23/2011 10:52 AM, Sakari Ailus wrote: Hi Michael, Thanks for the patch. Michael Jones wrote: From dccbd4a0a717ee72a3271075b1e3456a9c67ca0e Mon Sep 17 00:00:00 2001 From: Michael

Re: [PATCH] omap3isp: implement ENUM_FMT

2011-03-25 Thread Michael Jones
Hi Laurent, On 03/24/2011 11:36 AM, Laurent Pinchart wrote: Hi, [snip] Padding at end of line can be configured through S_FMT. Other than that, all other options (width, height, pixelcode) are fixed for a given mbus format *for the ISP driver*. Other drivers might support different

Re: [PATCH] omap3isp: implement ENUM_FMT

2011-03-24 Thread Michael Jones
Hi Laurent, On 03/23/2011 01:16 PM, Laurent Pinchart wrote: Hi Michael, [snip] Is there a policy decision that in the future, apps will be required to use libv4l to get images from the ISP? Are we not intending to support using e.g. media-ctl + some v4l2 app, as I'm currently doing during

Re: [PATCH] ignore Documentation/DocBook/media/

2011-03-24 Thread Michael Jones
On 03/16/2011 03:22 PM, Michael Jones wrote: From 81a09633855b88d19f013d7e559e0c4f602ba711 Mon Sep 17 00:00:00 2001 From: Michael Jones michael.jo...@matrix-vision.de Date: Thu, 10 Mar 2011 16:16:38 +0100 Subject: [PATCH] ignore Documentation/DocBook/media/ It is created and populated

Re: [PATCH] omap3isp: implement ENUM_FMT

2011-03-23 Thread Michael Jones
Hi Sakari, On 03/23/2011 10:52 AM, Sakari Ailus wrote: Hi Michael, Thanks for the patch. Michael Jones wrote: From dccbd4a0a717ee72a3271075b1e3456a9c67ca0e Mon Sep 17 00:00:00 2001 From: Michael Jones michael.jo...@matrix-vision.de Date: Tue, 22 Mar 2011 11:47:22 +0100 Subject: [PATCH

Re: Demande de support V4L2

2011-03-22 Thread Michael Jones
On 03/21/2011 06:43 PM, Laurent Pinchart wrote: Hi Loïc, On Friday 18 March 2011 16:43:40 Loïc Akue wrote: Hi, Do you know if Gstreamer or Mplayer are able to capture some vidéo from the CCDC output? I've been trying with the v4l2src plugin but Gstreamer can negociate format. I

[PATCH] omap3isp: implement ENUM_FMT

2011-03-22 Thread Michael Jones
From dccbd4a0a717ee72a3271075b1e3456a9c67ca0e Mon Sep 17 00:00:00 2001 From: Michael Jones michael.jo...@matrix-vision.de Date: Tue, 22 Mar 2011 11:47:22 +0100 Subject: [PATCH] omap3isp: implement ENUM_FMT Whatever format is currently being delivered will be declared as the only possible format

Re: [PATCH v3 4/4] omap3isp: lane shifter support

2011-03-17 Thread Michael Jones
Hi Sakari, Thanks for the review. On 03/16/2011 06:46 PM, Laurent Pinchart wrote: Hi Sakari, On Wednesday 16 March 2011 18:08:04 Sakari Ailus wrote: Laurent Pinchart wrote: Hi Sakari, + return in_info-bpp - out_info-bpp + additional_shift = 6; Currently there are no formats that would

Re: [PATCH v3 4/4] omap3isp: lane shifter support

2011-03-17 Thread Michael Jones
On 03/17/2011 04:40 PM, Sakari Ailus wrote: Hi Laurent and Michael, Laurent Pinchart wrote: On Thursday 17 March 2011 11:07:40 Michael Jones wrote: On 03/16/2011 06:46 PM, Laurent Pinchart wrote: On Wednesday 16 March 2011 18:08:04 Sakari Ailus wrote: Laurent Pinchart wrote: Hi Sakari

Re: Where to find 8-bit sbggr patch for omap3-isp

2011-03-16 Thread Michael Jones
Hi Bastian, On 03/16/2011 11:01 AM, Bastian Hecht wrote: Hello dear omap-isp developers, I'm working with a OV5642 sensor with an 8-bit parallel bus. I'm referring to this patch: http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/29876/match=sgrbg8 Michael, you

[PATCH] ignore Documentation/DocBook/media/

2011-03-16 Thread Michael Jones
From 81a09633855b88d19f013d7e559e0c4f602ba711 Mon Sep 17 00:00:00 2001 From: Michael Jones michael.jo...@matrix-vision.de Date: Thu, 10 Mar 2011 16:16:38 +0100 Subject: [PATCH] ignore Documentation/DocBook/media/ It is created and populated by 'make htmldocs' Signed-off-by: Michael Jones

[PATCH v3 0/4] OMAP3-ISP lane shifter support

2011-03-11 Thread Michael Jones
'shift' arg to omap3isp_configure_bridge() -misc minor changes according to feedback (removed unnecessary tests, etc.) Michael Jones (4): v4l: add V4L2_PIX_FMT_Y12 format media: add 8-bit bayer formats and Y12 omap3isp: ccdc: support Y10/12, 8-bit bayer fmts omap3isp: lane shifter support

[PATCH v3 1/4] v4l: add V4L2_PIX_FMT_Y12 format

2011-03-11 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- Documentation/DocBook/v4l/pixfmt-y12.xml | 79 ++ include/linux/videodev2.h|1 + 2 files changed, 80 insertions(+), 0 deletions(-) create mode 100644 Documentation/DocBook/v4l/pixfmt

[PATCH v3 2/4] media: add 8-bit bayer formats and Y12

2011-03-11 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- Documentation/DocBook/v4l/subdev-formats.xml | 59 ++ include/linux/v4l2-mediabus.h|7 ++- 2 files changed, 64 insertions(+), 2 deletions(-) diff --git a/Documentation/DocBook/v4l/subdev

[PATCH v3 3/4] omap3isp: ccdc: support Y10/12, 8-bit bayer fmts

2011-03-11 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/omap3-isp/ispccdc.c |6 ++ drivers/media/video/omap3-isp/ispvideo.c | 12 2 files changed, 18 insertions(+), 0 deletions

[PATCH v3 4/4] omap3isp: lane shifter support

2011-03-11 Thread Michael Jones
To use the lane shifter, set different pixel formats at each end of the link at the CCDC input. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3-isp/isp.c |7 ++- drivers/media/video/omap3-isp/isp.h |5 +- drivers/media/video/omap3-isp

Re: [PATCH v3 1/4] v4l: add V4L2_PIX_FMT_Y12 format

2011-03-11 Thread Michael Jones
On 03/11/2011 10:21 AM, Antonio Ospite wrote: Hi Michael, are you going to release also Y12 conversion routines for libv4lconvert? Regards, Antonio Hi Antonio, As I am neither a user nor developer of libv4lconvert, I am not planning on adding Y12 conversion routines there.

Re: [PATCH v2 4/4] omap3isp: lane shifter support

2011-03-10 Thread Michael Jones
Hi Laurent, Thanks for the review. Most of your suggestions didn't warrant discussion and I will incorporate those changes. The others are below. On 03/10/2011 01:13 AM, Laurent Pinchart wrote: Hi Michael, Thanks for the patch. On Wednesday 09 March 2011 17:07:43 Michael Jones wrote

Re: [PATCH v2 4/4] omap3isp: lane shifter support

2011-03-10 Thread Michael Jones
Hi Laurent, On 03/10/2011 11:21 AM, Laurent Pinchart wrote: Hi Michael, [snip] I've had a closer look at the boards I have here, and it turns out one of them connects a 10-bit sensor to DATA[11:2] :-/ data_lane_shift is thus needed for it. I'm fine with leaving data_lane_shift out of

[PATCH v2 0/4] OMAP3-ISP lane shifter support

2011-03-09 Thread Michael Jones
-moved 'shift' calculation from omap3isp_configure_bridge() to ccdc_configure() -added 'shift' arg to omap3isp_configure_bridge() -misc minor changes according to feedback (removed unnecessary tests, etc.) Michael Jones (4): v4l: add V4L2_PIX_FMT_Y12 format media: add 8-bit bayer formats and Y12

[PATCH v2 1/4] v4l: add V4L2_PIX_FMT_Y12 format

2011-03-09 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/linux/videodev2.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 02da9e7

[PATCH v2 2/4] media: add 8-bit bayer formats and Y12

2011-03-09 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/linux/v4l2-mediabus.h |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/v4l2-mediabus.h b/include/linux/v4l2-mediabus.h

[PATCH v2 3/4] omap3isp: ccdc: support Y10/12, 8-bit bayer fmts

2011-03-09 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3-isp/ispccdc.c |6 ++ drivers/media/video/omap3-isp/ispvideo.c | 12 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3-isp/ispccdc.c b/drivers

[PATCH v2 4/4] omap3isp: lane shifter support

2011-03-09 Thread Michael Jones
To use the lane shifter, set different pixel formats at each end of the link at the CCDC input. Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3-isp/isp.c |6 +- drivers/media/video/omap3-isp/isp.h |5 +- drivers/media/video/omap3-isp

Re: [PATCH v2 1/3] omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set

2011-03-08 Thread Michael Jones
On 03/08/2011 09:31 PM, Guzman Lugo, Fernando wrote: On Tue, Mar 8, 2011 at 2:15 PM, David Cohen daco...@gmail.com wrote: From: Michael Jones michael.jo...@matrix-vision.de commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL address if da_start==0, which would

Re: [PATCH 4/4] omap3isp: lane shifter support

2011-03-07 Thread Michael Jones
Hi Laurent, Thanks for the review. On 03/04/2011 05:33 PM, Laurent Pinchart wrote: Hi Michael, Thanks for the patch. On Friday 04 March 2011 09:58:04 Michael Jones wrote: Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3-isp/isp.c | 82

[PATCH] omap: iommu: disallow mapping NULL address

2011-03-07 Thread Michael Jones
From e7dbe4c4b64eb114f9b0804d6af3a3ca0e78acc8 Mon Sep 17 00:00:00 2001 From: Michael Jones michael.jo...@matrix-vision.de Date: Mon, 7 Mar 2011 13:36:15 +0100 Subject: [PATCH] omap: iommu: disallow mapping NULL address commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL

[PATCH 0/4] OMAP3-ISP lane shifter support

2011-03-04 Thread Michael Jones
check is first done when activating the pipeline. These patches apply to Laurent's media-0005-omap3isp branch, based on 2.6.38-rc5 Michael Jones (4): v4l: add V4L2_PIX_FMT_Y12 format media: add 8-bit bayer formats and Y12 omap3isp: ccdc: support Y10, Y12, SGRBG8, SBGGR8 omap3isp: lane

[PATCH 1/4] v4l: add V4L2_PIX_FMT_Y12 format

2011-03-04 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- include/linux/videodev2.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 02da9e7..6fac463 100644 --- a/include/linux/videodev2.h +++ b/include

[PATCH 3/4] omap3isp: ccdc: support Y10, Y12, SGRBG8, SBGGR8

2011-03-04 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3-isp/ispccdc.c |4 drivers/media/video/omap3-isp/ispvideo.c |8 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/omap3-isp/ispccdc.c b/drivers/media

[PATCH 4/4] omap3isp: lane shifter support

2011-03-04 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- drivers/media/video/omap3-isp/isp.c | 82 +- drivers/media/video/omap3-isp/isp.h |4 +- drivers/media/video/omap3-isp/ispccdc.c |2 +- drivers/media/video/omap3-isp/ispvideo.c | 65

[PATCH 2/4] media: add 8-bit bayer formats and Y12

2011-03-04 Thread Michael Jones
Signed-off-by: Michael Jones michael.jo...@matrix-vision.de --- include/linux/v4l2-mediabus.h |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/linux/v4l2-mediabus.h b/include/linux/v4l2-mediabus.h index 7054a7a..46caecd 100644 --- a/include/linux/v4l2

Re: omap3isp cache error when unloading

2011-03-04 Thread Michael Jones
the problem, which modifies a commit by Fernando Guzman Lugo from December. -Michael From db35fb8edca2a4f8fd37197d77fd58676cb1dcac Mon Sep 17 00:00:00 2001 From: Michael Jones michael.jo...@matrix-vision.de Date: Thu, 3 Mar 2011 16:50:39 +0100 Subject: [PATCH] fix iovmm slab cache error on module

Re: omap3isp cache error when unloading

2011-03-03 Thread Michael Jones
On 03/02/2011 08:18 PM, Laurent Pinchart wrote: Hi Michael, On Tuesday 01 March 2011 17:41:01 Michael Jones wrote: Hi all, I get a warning about a cache error with the following steps: 0. load omap3-isp 1. set up media broken media pipeline. (e.g. set different formats on opposite ends

omap3isp cache error when unloading

2011-03-01 Thread Michael Jones
Hi all, I get a warning about a cache error with the following steps: 0. load omap3-isp 1. set up media broken media pipeline. (e.g. set different formats on opposite ends of a link, as will be the case for using the lane shifter) 2. try to capture images. isp_video_streamon() returns -EPIPE

Re: [RFC] ISP lane shifter support

2011-02-22 Thread Michael Jones
that this is a sensible approach, I will go ahead and submit my patch soon. thanks, Michael On 02/11/2011 02:06 PM, Laurent Pinchart wrote: Hi Michael, On Friday 11 February 2011 13:07:33 Michael Jones wrote: On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote: Looking at the Data-Lane Shifter table (12.27

Re: link error w/ media-0006-sensors

2011-02-21 Thread Michael Jones
? How are you guys getting around this? -Michael On 01/19/2011 12:30 AM, Laurent Pinchart wrote: Hi Michael, On Tuesday 18 January 2011 17:14:37 Michael Jones wrote: Hi Laurent Sakari, On Laurent's media-0006-sensors branch, when compiling with CONFIG_VIDEO_OMAP3=m, I got the following

Re: [RFC] ISP lane shifter support

2011-02-02 Thread Michael Jones
Hi Guennadi, Laurent, On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote: snip I didn't realize the video port can further shift the data. Where can I find this in the TRM? VPIN field of the CCDC_FMTCFG register. This only plays a role, if cam_d is set to 10 bits raw in

Re: [RFC] ISP lane shifter support

2011-01-25 Thread Michael Jones
Hi Laurent, On 01/24/2011 08:45 PM, Laurent Pinchart wrote: Hi Michael, On Monday 24 January 2011 15:16:28 Michael Jones wrote: On 01/24/2011 02:57 PM, Laurent Pinchart wrote: snip As the lane shifter is located at the CCDC input, it might be easier to implement support for this using

Re: [RFC] ISP lane shifter support

2011-01-24 Thread Michael Jones
Hi Laurent, Thanks for the feedback. On 01/24/2011 01:10 AM, Laurent Pinchart wrote: Hi Michael, On Friday 21 January 2011 09:40:21 Michael Jones wrote: Hi all, In the OMAP ISP driver, I'm interested in being able to choose between 8-bit and 12-bit formats when I have a 12-bit sensor

Re: [RFC] ISP lane shifter support

2011-01-24 Thread Michael Jones
Hi Laurent, On 01/24/2011 02:57 PM, Laurent Pinchart wrote: snip As the lane shifter is located at the CCDC input, it might be easier to implement support for this using the CCDC input format. ispvideo.c would need to validate the pipeline when the output of the entity connected to the CCDC

[RFC] ISP lane shifter support

2011-01-21 Thread Michael Jones
Hi all, In the OMAP ISP driver, I'm interested in being able to choose between 8-bit and 12-bit formats when I have a 12-bit sensor attached. At the moment it looks like it's only possible to define this statically with data_lane_shift in the board definition. But with the ISP's lane shifter,

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-20 Thread Michael Jones
Hi Laurent, On 01/19/2011 05:38 PM, Laurent Pinchart wrote: Hi Michael, snip @@ -1144,10 +1148,15 @@ static void ccdc_configure(struct isp_ccdc_device *ccdc) else syn_mode = ~ISPCCDC_SYN_MODE_SDR2RSZ; - isp_reg_writel(isp, syn_mode, OMAP3_ISP_IOMEM_CCDC, ISPCCDC_SYN_MODE); +

Re: [PATCH V2] v4l: OMAP3 ISP CCDC: Add support for 8bit greyscale sensors

2011-01-19 Thread Michael Jones
Hi Martin, a couple of comments inline below. On 01/19/2011 12:27 AM, Laurent Pinchart wrote: Hi Martin, Thanks for the patch. One comment below. On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote: Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in synchronous

link error w/ media-0006-sensors

2011-01-18 Thread Michael Jones
Hi Laurent Sakari, On Laurent's media-0006-sensors branch, when compiling with CONFIG_VIDEO_OMAP3=m, I got the following linking error: ERROR: omap_pm_set_min_bus_tput [drivers/media/video/isp/omap3-isp.ko] undefined! I can get rid of the error with the patch below. But as always, I wonder:

Re: OMAP3530 ISP irqs disabled

2010-11-08 Thread Michael Jones
to fix this problem, however. But I might be just pointing you to wrong direction, better wait for Laurent's answer. :-) Cheers, -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner

Re: OMAP3530 ISP irqs disabled

2010-11-08 Thread Michael Jones
not about the parallel sensor, it's about writing the data from the CCDC to memory. I expect the problem to occur with a serial sensor too if the CCDC writes to memory. -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090

Re: OMAP3530 ISP irqs disabled

2010-11-05 Thread Michael Jones
CCDC_OUTPUT_MEMORY) || + if ((ccdc-output CCDC_OUTPUT_MEMORY) (ccdc-state == ISP_PIPELINE_STREAM_SINGLESHOT)) ccdc-stopping = CCDC_STOP_REQUEST; -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090

Re: OMAP3530 ISP irqs disabled

2010-11-03 Thread Michael Jones
. HS_VS_IRQ is _either_ VS _or_ HS interrupts, but not both. The SYNC_DETECT bits in ISP_CTRL determines which. For writing into memory, the ISP only needs to react per frame, not per line, so it is set up to trigger on VS. -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570

media-ctl header patch

2010-11-02 Thread Michael Jones
, but I don't know how to resurrect an old patch. -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner -- To unsubscribe from this list: send the line unsubscribe

Re: OMAP 3530 camera ISP forks and new media framework

2010-10-28 Thread Michael Jones
so far. -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

controls, subdevs, and media framework

2010-10-26 Thread Michael Jones
it on to the last link in the chain, but none of the subdevs in the ISP currently have a cropcap function implemented (yet). Does this still need to be written? -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer

Re: OMAP 3530 camera ISP forks and new media framework

2010-10-22 Thread Michael Jones
thanks, -- Michael Jones MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

  1   2   >