Re: [RESEND] [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

e Software Foundation. > */ > > #ifndef __XILINX_VTC_H__ > diff --git a/include/dt-bindings/media/xilinx-vip.h > b/include/dt-bindings/media/xilinx-vip.h > index 6298fec00685..94ed3edfcc70 100644 > --- a/include/dt-bindings/media/xilinx-vip.h > +++ b/include/dt-bindings/media/xilinx-vip.h > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * Xilinx Video IP Core > * > @@ -6,10 +7,6 @@ > * > * Contacts: Hyun Kwon > * Laurent Pinchart > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > */ > > #ifndef __DT_BINDINGS_MEDIA_XILINX_VIP_H__ > Acked-by: Michal Simek Thanks, Michal

Re: [PATCH] [media] v4l: xilinx: fix typo in formats table

On 1.10.2018 15:36, Laurent Pinchart wrote: > Hi Michal, > > On Monday, 1 October 2018 16:28:32 EEST Michal Simek wrote: >> On 1.10.2018 15:26, Laurent Pinchart wrote: >>> On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote: >>>> On 28.9.2018 14:52, Lau

Re: [PATCH] [media] v4l: xilinx: fix typo in formats table

Hi Laurent, On 1.10.2018 15:26, Laurent Pinchart wrote: > Hi Michal, > > On Monday, 1 October 2018 15:45:49 EEST Michal Simek wrote: >> On 28.9.2018 14:52, Laurent Pinchart wrote: >>> On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: >>>> In for

Re: [PATCH] [media] v4l: xilinx: fix typo in formats table

Hi Laurent, On 28.9.2018 14:52, Laurent Pinchart wrote: > Hi Andrea, > > Thank you for the patch. > > On Friday, 28 September 2018 10:32:13 EEST Andrea Merello wrote: >> In formats table the entry for CFA pattern "rggb" has GRBG fourcc. >> This patch fixes it. >> >> Cc:

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

Hi Mauro, On 18.12.2017 08:32, Michal Simek wrote: > Hi guys, > > On 15.12.2017 10:27, Mauro Carvalho Chehab wrote: >> Em Fri, 15 Dec 2017 10:55:26 +0530 >> Dhaval Shah <dhaval23031...@gmail.com> escreveu: >> >>> Hi Laurent/Mauro/Greg, >>> &g

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

Hi Laurent, On 18.12.2017 09:32, Laurent Pinchart wrote: > Hi Michal, > > On Monday, 18 December 2017 09:32:12 EET Michal Simek wrote: >> On 15.12.2017 10:27, Mauro Carvalho Chehab wrote: >>> Em Fri, 15 Dec 2017 10:55:26 +0530 Dhaval Shah escreveu: >>>> On F

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

neral Public License version 2 as >>>>>> - * published by the Free Software Foundation. >>>>>> >>>>>> in all .c and .h files of the Xilinx V4L2 driver >>>>>> (drivers/media/platform/ >>>>>> xilinx). I have reviewed the patch and acked it. Mauro then rejected it, >>>>>> stating that he can't accept a change to license text without an >>>>>> explicit ack from the official driver's maintainers. My position is >>>>>> that such a change doesn't change the license and thus doesn't need to >>>>>> track all copyright holders, and can be merged without an explicit ack >>>>>> from the respective maintainers. >>>>> >>>>> Yes, I agree with you, no license is being changed here, and no >>>>> copyright is either. >>>>> >>>>> BUT, I know that most major companies are reviewing this process right >>>>> now. We have gotten approval from almost all of the major kernel >>>>> developer companies to do this, which is great, and supports this work >>>>> as being acceptable. >>>>> >>>>> So it's nice to ask Xilinx if they object to this happening, which I >>>>> guess Mauro is trying to say here (in not so many words...) To at least >>>>> give them the heads-up that this is what is going to be going on >>>>> throughout the kernel tree soon, and if they object, it would be good to >>>>> speak up as to why (and if they do, I can put their lawyers in contact >>>>> with some lawyers to explain it all to them.) >>>> >>>> Yes, that's basically what I'm saying. >>>> >>>> I don't feel comfortable on signing a patch changing the license text >>>> without giving the copyright owners an opportunity and enough time >>>> to review it and approve, or otherwise comment about such changes. >>> >>> If I understand you and Greg correctly, you would like to get a general >>> approval from Xilinx for SPDX-related changes, but that would be a blanket >>> approval that would cover this and all subsequent similar patches. Is that >>> correct ? That is reasonable for me. >>> >>> In that case, could the fact that commit >>> >>> commit 5fd54ace4721fc5ce2bb5aef6318fcf17f421460 >>> Author: Greg Kroah-Hartman <gre...@linuxfoundation.org> >>> Date: Fri Nov 3 11:28:30 2017 +0100 >>> >>> USB: add SPDX identifiers to all remaining files in drivers/usb/ >>> >>> add SPDX headers to several Xilinx-authored source files constitute such a >>> blanket approval ? >>> >> I have to do anything here or Once, we get approval from the Michal >> Simek(michal.si...@xilinx.com) and hyun.k...@xilinx.com ACK this patch >> then it will go into mainline? > > I would wait for their feedback. Please do not apply this patch till I get approval from legal. I have already discussed things about SPDX some weeks ago. Thanks, Michal

Re: [PATCH] [media] xilinx: Reflect dma header file move

On 04/24/2015 09:24 PM, Guenter Roeck wrote: Commit 937abe88aea3 (dmaengine: xilinx-dma: move header file to common location) moved xilinx_dma.h to a common location but neglected to reflect this move in all its users. This causes compile errors for several builds.